RE: [Vote] Tools Release Sep 17th

2015-09-18 Thread Vladimir Kotikov (Akvelon)
Confirm, the executables are broken on OS X. The vote thread is now closed. - Best regards, Vladimir -Original Message- From: dvpdin...@gmail.com [mailto:dvpdin...@gmail.com] On Behalf Of Darryl Pogue Sent: Thursday, September 17, 2015 8:11 PM To: dev@cordova.apache.org Subject: Re:

[GitHub] cordova-docs pull request: Add Keyword Index back to the table of ...

2015-09-18 Thread riknoll
Github user riknoll closed the pull request at: https://github.com/apache/cordova-docs/pull/354 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: Add Keyword Index back to the table of ...

2015-09-18 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/354#issuecomment-141606085 Yep, LGTM. There is no user input, so there shouldn't be any security issues. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-docs pull request: Add Keyword Index back to the table of ...

2015-09-18 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/354#issuecomment-141606098 Feel free to close. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-lib pull request: CB-9598 Introduces `cordova-common` modu...

2015-09-18 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-lib/pull/309#issuecomment-141607056 sounds great, @vladimir-kotikov - I plan to complete this on weekend --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-lib pull request: CB-8198 Unified console output logic for...

2015-09-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/306 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-dialogs pull request: On iOS8+ allow this dialog to...

2015-09-18 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/57#issuecomment-141407647 If you are in a hurry you can use my fork installing from the git url --- If your project is set up for it, you can reply to this email and have

[Vote] Tools Release Sep 17th (Take 2)

2015-09-18 Thread Vladimir Kotikov (Akvelon)
Please review and vote on this Tools Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-9678 Tools have been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-9678 The packages were

RE: [DISCUSS] Tools Release

2015-09-18 Thread Vladimir Kotikov (Akvelon)
The new thread has started. I had to bump patch versions for tools, so they now are: cordova-lib: 5.3.3 (932ad57858) cordova-plugman: 1.0.4 (0de514b4b1) cordova-cli: 5.3.3 (e647fe4382) Also, packages, broken when published from Windows seems to be known problem:

[GitHub] cordova-ios pull request: Fix Q include in check_reqs.js

2015-09-18 Thread mschwartz
Github user mschwartz commented on the pull request: https://github.com/apache/cordova-ios/pull/132#issuecomment-141518970 Whichever iOS platform is installed by cordova 4.3.0 has the wrong "Q" case in the file. On Fri, Sep 18, 2015 at 10:43 AM, Julio César

[GitHub] cordova-ios pull request: Fix Q include in check_reqs.js

2015-09-18 Thread mschwartz
Github user mschwartz commented on the pull request: https://github.com/apache/cordova-ios/pull/132#issuecomment-141525374 Fix it in the earlier tag for iOS platform :) That's my suggestion. On Fri, Sep 18, 2015 at 11:20 AM, Shazron Abdullah

[GitHub] cordova-plugin-camera pull request: [android] allowedit: fix not C...

2015-09-18 Thread hgehlhausen
Github user hgehlhausen commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/103#issuecomment-141544464 Hey Did this get merged in yet? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-ios pull request: Fix Q include in check_reqs.js

2015-09-18 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-ios/pull/132#issuecomment-141524412 The problem is fixed, you have to update, you should read about cordova cli and platform versions, cordova iOS 3.9.1 shouldn't break any plugin, cordova iOS

[GitHub] cordova-lib pull request: CB-9521 Do not pass removed platform to ...

2015-09-18 Thread vladimir-kotikov
Github user vladimir-kotikov closed the pull request at: https://github.com/apache/cordova-lib/pull/308 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-lib pull request: CB-9521 Do not pass removed platform to ...

2015-09-18 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/308#issuecomment-141555326 Closing this as there is some uncertainty in hook parameters specification. --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-plugin-splashscreen pull request: fixed "WARNING: The spla...

2015-09-18 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/23#issuecomment-141560624 Hopelessly stale pull request. Please close and resubmit if still relevant. --- If your project is set up for it, you can reply to this

[GitHub] cordova-ios pull request: Fix Q include in check_reqs.js

2015-09-18 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/132#issuecomment-141524921 Not sure what else we can do, it is fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-ios pull request: Fix Q include in check_reqs.js

2015-09-18 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/132#issuecomment-141538218 Nice of you to end the debate. And our answer is, update your platform, it is fixed in a newer update. --- If your project is set up for it, you can reply to

[GitHub] cordova-plugin-statusbar pull request: add nice smooth fadein/fade...

2015-09-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-ios pull request: Fix Q include in check_reqs.js

2015-09-18 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/132#issuecomment-141525802 Not sure how you do software dev -- that's not how our releases work, mschartz - if a bug goes in, it goes in a new release with a new version. We don't alter a

[GitHub] cordova-ios pull request: Fix Q include in check_reqs.js

2015-09-18 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/132#issuecomment-141519174 Update your cordova to get the latest pinned cordova-ios platform 3.9.1 or you can add it explicitly ios@3.9.1 --- If your project is set up for it, you can reply

[GitHub] cordova-docs pull request: Fixes main page's layout overlapping on...

2015-09-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/353 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-ios pull request: Fix Q include in check_reqs.js

2015-09-18 Thread mschwartz
Github user mschwartz commented on the pull request: https://github.com/apache/cordova-ios/pull/132#issuecomment-141528062 I reported the bug. You deal with it how you want. Anyone who uses 4.3.0 and follows instructions on numerous WWW sites are going to run into this.

[GitHub] cordova-plugin-statusbar pull request: add JIRA issue tracker link

2015-09-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/34 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-docs pull request: Add Keyword Index back to the table of ...

2015-09-18 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-docs/pull/354 Add Keyword Index back to the table of contents Adds a translated keyword index page for each version of the docs that lists all the pages for that language/version. Page titles are scraped

[GitHub] cordova-docs pull request: Add Keyword Index back to the table of ...

2015-09-18 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/354#issuecomment-141582319 and the docs_index.html _include as well --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[Android] Marshmallow Geolocation Update

2015-09-18 Thread Joe Bowser
Hey So, I have good news and bad news. The Bad News: We have to have a Geolocation Plugin, and for this to work seamlessly, we have to modify the WebViews to support the plugin. The Good News: We can write a wrapper so that it works just like Geolocation used to. I have a version that works.

[GitHub] cordova-docs pull request: Add Keyword Index back to the table of ...

2015-09-18 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/354#issuecomment-141581959 @dblotsky can you review docs-keyword-index.js to make sure there aren't any security issues with how the page is taken from the Jekyll generated JSON and built?

[GitHub] cordova-lib pull request: CB-9407 Fixes incorrect applying of plug...

2015-09-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/296 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-medic pull request: CB-9660 Kill emulator/app process at t...

2015-09-18 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-medic/pull/63#issuecomment-141589722 Why do this at both start and end? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-medic pull request: CB-8936 Gather 15 minutes of logs on W...

2015-09-18 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/62#discussion_r39910252 --- Diff: medic/medic-log.js --- @@ -66,7 +66,7 @@ function logIOS() { function logWindows() { var logScriptPath =

[GitHub] cordova-docs pull request: Minor layout fixes for home and docs

2015-09-18 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-docs/pull/355 Minor layout fixes for home and docs Adds padding to the not latest version text in docs Also fixes the "+4 more..." text on the front page so that it doesn't wrap awkwardly on small

[GitHub] cordova-lib pull request: CB-9598 Introduces `cordova-common` modu...

2015-09-18 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/309#issuecomment-141443929 @sgrebnov, this is ready to merge, please take a look. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-lib pull request: CB-9598 Introduces `cordova-common` modu...

2015-09-18 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/309#issuecomment-141443458 @nikhilkh, regarding your concern about iOS specific dependencies (`xcode`, `plist` and `bplist-parser`) for this - the reason is that `ConfigChanges`

[GitHub] cordova-plugin-dialogs pull request: On iOS8+ allow this dialog to...

2015-09-18 Thread androdel
Github user androdel commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/57#issuecomment-141406068 When will this fix be released? Because this issue is blocking the release of my app. --- If your project is set up for it, you can reply to this

[GitHub] cordova-plugin-camera pull request: added allowEdit support for an...

2015-09-18 Thread fguerin
Github user fguerin commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/12#issuecomment-141453855 Same as @roysG, I'm not able to edit the captured image. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-docs pull request: Fixes main page's layout overlapping on...

2015-09-18 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-docs/pull/353 Fixes main page's layout overlapping on mobile devices in landscape Limits the size of the Cordova-bot and adds a better min-height for the hero. Also fixes a problem where the

[GitHub] cordova-ios pull request: Fix Q include in check_reqs.js

2015-09-18 Thread mschwartz
Github user mschwartz commented on the pull request: https://github.com/apache/cordova-ios/pull/132#issuecomment-141507304 The issue exists with cordova 4.3.0 Any time you do cordova platform add ios, you get a check_reqs.js with the wrong case Q in it.

[GitHub] cordova-ios pull request: Fix Q include in check_reqs.js

2015-09-18 Thread mschwartz
Github user mschwartz commented on the pull request: https://github.com/apache/cordova-ios/pull/132#issuecomment-141519811 Doesn't Cordova 5 have breaking API changes? I found a number of plugins I was using on a project started crashing or failing to make callbacks to

[GitHub] cordova-plugin-statusbar pull request: fix warning on IOS8

2015-09-18 Thread dangnelson
Github user dangnelson commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/26#issuecomment-141490685 This really needs to be fixed. We're on iOS9 now... --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-ios pull request: Fix Q include in check_reqs.js

2015-09-18 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-ios/pull/132#issuecomment-141517225 Latest cordova (lib) version is 5.3.1, there is no cordova ios 4.3.0, latest is 3.9.1 --- If your project is set up for it, you can reply to this email and