[GitHub] cordova-cli pull request: CB-9784 Remove CLI logger levels prefixe...

2015-10-15 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-cli/pull/224#issuecomment-148376439 @nikhilkh, updated, please take a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-ios pull request: CB-9500 Added no sign argument to iOS bu...

2015-10-15 Thread njtman
Github user njtman commented on the pull request: https://github.com/apache/cordova-ios/pull/152#issuecomment-148380772 @shazron I have signed and submitted my icla to secret...@apache.org. Thanks! --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-plugin-camera pull request: Fix Android images opening in ...

2015-10-15 Thread dortzur
Github user dortzur commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/85#issuecomment-148356598 Nah, I'll probably just wait it out until I can move to React Native. Thanks anyway. On Thu, Oct 15, 2015, 13:43 Vladimir Kotikov

[GitHub] cordova-ubuntu pull request: add defaut icon parameter to config.x...

2015-10-15 Thread david-barth-canonical
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-ubuntu/pull/16 add defaut icon parameter to config.xml You can merge this pull request into a Git repository by running: $ git pull https://github.com/cordova-ubuntu/cordova-ubuntu

[GitHub] cordova-docs pull request: Added a block for Cocoon tool

2015-10-15 Thread keianhzo
Github user keianhzo closed the pull request at: https://github.com/apache/cordova-docs/pull/372 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-file-transfer pull request: CB-9673 Fixed test spec...

2015-10-15 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/102#issuecomment-148334079 Tested, works well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-lib pull request: CB-9407 Fixes incorrect applying of plug...

2015-10-15 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/296#issuecomment-148325630 @zalun, just tried create a new blank app with file-transfer and geolocation plugins, and it seems to fork for me: _config.xml_: ```xml

RE: cordova-vm.apache.org http server issue

2015-10-15 Thread Alexander Sorokin (Akvelon)
Yes, tests are green again. Thanks Steven! -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Wednesday, October 14, 2015 11:11 PM To: dev@cordova.apache.org Subject: Re: cordova-vm.apache.org http server issue Should be passing now On Wed, Oct 14, 2015 at

[GitHub] cordova-plugin-camera pull request: [Android] plugin now returns a...

2015-10-15 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/91#issuecomment-148328169 Okay, double-checked, the issue is fixed in master. @fu-raz, please close this PR. --- If your project is set up for it, you can reply to this

[GitHub] cordova-lib pull request: CB-9407 Fixes incorrect applying of plug...

2015-10-15 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/296#issuecomment-148442647 @zalun - this fix will be in the next minor/major release (whichever comes first) - the only change included in 5.3.3 was a patch to support node 4. --- If your

[GitHub] cordova-plugin-file-transfer pull request: CB-9790 Align FileUploa...

2015-10-15 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/98#issuecomment-148428651 Looks like `mimeType` default in JS will break the Windows case:

[GitHub] cordova-plugin-file-transfer pull request: CB-9790 Align FileUploa...

2015-10-15 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/98#issuecomment-148422624 @jason-ong, thanks! I've looked into the PR once more - I believe it will be better to default these values on JS side:

[GitHub] cordova-cli pull request: CB-9784 Remove CLI logger levels prefixe...

2015-10-15 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-cli/pull/224#issuecomment-148435203 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Buildbot: buildslave cordova-windows-slave was lost

2015-10-15 Thread buildbot
The Buildbot working for 'ASF Buildbot' has noticed that the buildslave named cordova-windows-slave went away It last disconnected at Thu Oct 15 14:26:08 2015 (buildmaster-local time) The admin on record (as reported by BUILDSLAVE:info/admin) was 'Dmitry Blotsky '.

RE: Buildbot: buildslave cordova-windows-slave was lost

2015-10-15 Thread Alexander Sorokin (Akvelon)
Just rebooting the machine to install updates. Regards, Alexander Sorokin -Original Message- From: build...@apache.org [mailto:build...@apache.org] Sent: Thursday, October 15, 2015 5:31 PM To: dev@cordova.apache.org Subject: Buildbot: buildslave cordova-windows-slave was lost The

[GitHub] cordova-lib pull request: CB-9407 Fixes incorrect applying of plug...

2015-10-15 Thread zalun
Github user zalun commented on the pull request: https://github.com/apache/cordova-lib/pull/296#issuecomment-148409135 master is fine, it's the Cordova 5.3.3 which still doesn't have this fix ... --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-lib pull request: Keep module-to-plugin mapping at hand.

2015-10-15 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/322#issuecomment-148547272 LGTM, @busykai. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-lib pull request: Keep module-to-plugin mapping at hand.

2015-10-15 Thread tony--
Github user tony-- commented on the pull request: https://github.com/apache/cordova-lib/pull/322#issuecomment-148547339 [JIRA issue CB-9813](https://issues.apache.org/jira/browse/CB-9813) --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-plugin-camera pull request: added allowEdit support for an...

2015-10-15 Thread jsappme
Github user jsappme commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/12#issuecomment-148548916 Same as @roysG, I'm not able to edit the captured image. I have a Nexus 4. --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-plugin-media pull request: CB-9741 Updated Android AudioPl...

2015-10-15 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/72#issuecomment-148553796 Sure, no problem --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-lib pull request: Keep module-to-plugin mapping at hand.

2015-10-15 Thread busykai
Github user busykai commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/322#discussion_r42191928 --- Diff: cordova-lib/src/platforms/PlatformApiPoly.js --- @@ -566,7 +566,8 @@ PlatformApiPoly.prototype._addModulesInfo = function(plugin, targetDir) {

[GitHub] cordova-lib pull request: CB-9813 Keep module-to-plugin mapping at...

2015-10-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/322 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: Keep module-to-plugin mapping at hand.

2015-10-15 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/322#discussion_r42191593 --- Diff: cordova-lib/src/platforms/PlatformApiPoly.js --- @@ -566,7 +566,8 @@ PlatformApiPoly.prototype._addModulesInfo = function(plugin, targetDir)

[GitHub] cordova-lib pull request: Keep module-to-plugin mapping at hand.

2015-10-15 Thread busykai
Github user busykai commented on the pull request: https://github.com/apache/cordova-lib/pull/322#issuecomment-148547532 Thanks, Tony! Updated the commit message. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-lib pull request: Keep module-to-plugin mapping at hand.

2015-10-15 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/322#issuecomment-148547652 Thanks @tony-- - @busykai, could you update the PR title to include the JIRA issue? --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-plugin-file-transfer pull request: Added note about iOS9 a...

2015-10-15 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/103#issuecomment-148506079 @shazron, friendly ping... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-lib pull request: Keep module-to-plugin mapping at hand.

2015-10-15 Thread busykai
GitHub user busykai opened a pull request: https://github.com/apache/cordova-lib/pull/322 Keep module-to-plugin mapping at hand. This information is handy for various use-cases. E.g. for preview application to provide only the plugins which are used by the application (instead

[GitHub] cordova-plugin-file-transfer pull request: CB-9790 Align FileUploa...

2015-10-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/98 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-android pull request: Move CordovaWebView to CordovaWebInt...

2015-10-15 Thread macdonst
GitHub user macdonst opened a pull request: https://github.com/apache/cordova-android/pull/227 Move CordovaWebView to CordovaWebInterface As discussed on at the face to face we should rename this interface. You can merge this pull request into a Git repository by running: $

[GitHub] cordova-docs pull request: Add BurracoON app to showcase

2015-10-15 Thread Rickgbw
GitHub user Rickgbw opened a pull request: https://github.com/apache/cordova-docs/pull/392 Add BurracoON app to showcase You can merge this pull request into a Git repository by running: $ git pull https://github.com/Rickgbw/cordova-docs cordova-website Alternatively you can

[GitHub] cordova-lib pull request: CB-9590 - Ubuntu support for the new plu...

2015-10-15 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/294#issuecomment-148444797 @david-barth-canonical - I think @stevengill's point is that the intent of your change is to strip the `cordova-plugin` from the start of the plugin name to

[GitHub] cordova-plugin-file-transfer pull request: CB-9385 Return FILE_NOT...

2015-10-15 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/95#issuecomment-148444138 @Ganster41, thanks! Merged in c0b3122e744df0274d17f7cd26a93e4f3b163d3f Added a test case for this in

[GitHub] cordova-android pull request: CB-9782 Implements PlatformApi contr...

2015-10-15 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/226#discussion_r42155780 --- Diff: bin/create --- @@ -1,49 +1,56 @@ -#!/usr/bin/env node - -/* - Licensed to the Apache Software Foundation (ASF)

[GitHub] cordova-android pull request: CB-9782 Implements PlatformApi contr...

2015-10-15 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/226#discussion_r42167999 --- Diff: bin/create --- @@ -1,49 +1,56 @@ -#!/usr/bin/env node - -/* - Licensed to the Apache Software Foundation