[GitHub] cordova-plugin-file-transfer pull request: uploadResponse encoding...

2015-10-24 Thread codable
Github user codable commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/71#discussion_r42941404 --- Diff: src/ios/CDVFileTransfer.m --- @@ -552,6 +552,8 @@ - (void)connectionDidFinishLoading:(NSURLConnection*)connection

[GitHub] cordova-windows pull request: CB-9565: Build failure for Windows 1...

2015-10-24 Thread SomaticIT
Github user SomaticIT commented on the pull request: https://github.com/apache/cordova-windows/pull/123#issuecomment-150876679 @robpaveza @nikhilkh @rakatyal Any news on this, it's a really painful error. The error in tests is an issue in @robpaveza fix [here](https://git

[GitHub] cordova-ios pull request: CB-9685 A fix for the magnifying glass p...

2015-10-24 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-ios/pull/164#issuecomment-150869787 I've tried on iPad 4, iPod touch 5 and iPhone 6 and the bug is gone on 9.1. On the iPad and iPod tested the same app before updating (magnifying glass appeared

[GitHub] cordova-plugin-device pull request: add isSimulator for iOS & Andr...

2015-10-24 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/35#issuecomment-150849472 Haha we were just chatting about this yesterday. Makes most sense to add the dependency to tests/plugin.xml --- If your project is set up for it, you

[GitHub] cordova-plugin-device pull request: add isSimulator for iOS & Andr...

2015-10-24 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/35#issuecomment-150835775 Love it! Shockingly, @stevengill and I had this idea also. --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] cordova-windows pull request: adding default cordova backbutton ha...

2015-10-24 Thread Viras-
GitHub user Viras- opened a pull request: https://github.com/apache/cordova-windows/pull/129 adding default cordova backbutton handling default cordova backbutton handling see issue: https://issues.apache.org/jira/browse/CB-8481 if its fine, I can merge it into cord

[GitHub] cordova-plugin-device pull request: add isSimulator for iOS & Andr...

2015-10-24 Thread alsorokin
Github user alsorokin commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/35#issuecomment-150781035 @purplecabbage what if we add device dependency not to accelerometer plugin itself but to tests/plugin.xml ? --- If your project is set up for it, you