Re: [DISCUSS] Removing blog posts repo

Many thanks, Steve! We shall all remember that repo fondly, with nothing remaining but a memory… and a full new copy now residing in cordova-docs. Kindly, Dmitry > On Oct 29, 2015, at 4:08 PM, Steven Gill wrote: > > IT HAS BEEN TERMINATED > > On Thu, Oct 29, 2015 at

[GitHub] cordova-lib pull request: CB-9834 Introduce cordova modules compat...

Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-lib/pull/329#issuecomment-152446226 lgtm :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-dialogs pull request: set cancelable to false by de...

Github user Heshyo commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/56#issuecomment-152465106 ++ It's easy to tap outside of the box unintentionally. Also you may wonder what happens if you tap outside instead of clicking OK/Cancel (did I just

[GitHub] cordova-plugin-file pull request: Fix CB-9752: FileEntry.getDirect...

Github user jasongin commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/144#issuecomment-152657405 @infil00p or @riknoll can you review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-plugin-file pull request: Fix CB-9752: FileEntry.getDirect...

Github user jasongin commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/144#issuecomment-152661034 Oh, yeah "unit test" was probably not the right term. --- If your project is set up for it, you can reply to this email and have your reply appear on

Re: CB-9901 cordova plugin search opens in a browser

I think is a nice thing to have for those users starting to use the CLI and running by hand. Similar to the "ionic docs" cli command On Fri, Oct 30, 2015 at 3:11 PM Tim Barham wrote: > I have no opinion regarding removing or not, but WTFPL is fine ( >

[GitHub] cordova-plugin-file pull request: CB-7253: requestFileSystem fails...

Github user jasongin commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/145#issuecomment-152657217 @infil00p or @riknoll can you review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-plugin-file pull request: CB-7253: requestFileSystem fails...

GitHub user jasongin opened a pull request: https://github.com/apache/cordova-plugin-file/pull/145 CB-7253: requestFileSystem fails when no external storage is present There were 2 issues behind this bug: 1) DirectoryManager.getFreeDiskSpace() used an incorrect way of

Re: Partnership with Google on App Indexing

+1 - it should be a plugin. On Fri, Oct 30, 2015 at 1:03 PM, julio cesar sanchez wrote: > Hi, > > I'm don't remember this being discussed on this mailing list, but my > opinion is, as it only supports iOS and android, it should be a 3rd party > plugin. Maybe others don't

[GitHub] cordova-lib pull request: CB-9834 Introduce cordova modules compat...

Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/329#issuecomment-152495853 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-android pull request: Update CordovaWebViewEngine.java

Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/234 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-android pull request: Update CordovaWebViewEngine.java

Github user omefire commented on the pull request: https://github.com/apache/cordova-android/pull/234#issuecomment-152507194 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-lib pull request: CB-9834 Introduce cordova modules compat...

Github user vladimir-kotikov closed the pull request at: https://github.com/apache/cordova-lib/pull/329 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-lib pull request: CB-9834 Introduce cordova modules compat...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/329#issuecomment-152467126 Merged in https://github.com/apache/cordova-lib/commit/b52c257fcde22e982aea7b2287b3d0b943b16df2 --- If your project is set up for it, you can reply to

[GitHub] cordova-ios pull request: Prepare cordova-ios 3.9.2 release

Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/175 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: Fix create argument prerequisite check

Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/337#issuecomment-152500036 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-android pull request: CB-9909 Shouldn't escape spaces in p...

Github user omefire commented on the pull request: https://github.com/apache/cordova-android/pull/237#issuecomment-152505807 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-android pull request: CB-9909 Shouldn't escape spaces in p...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/237 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-lib pull request: Fix create argument prerequisite check

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/337 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-dialogs pull request: set cancelable to false by de...

Github user Heshyo commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/56#issuecomment-152468218 I just saw https://github.com/apache/cordova-plugin-dialogs/pull/60 that actually added a ```setCanceledOnTouchOutside```. I don't know if both

[DISCUSS] Cordova-ios 3.9.2 release

Created this thread to separate discussions for 3.9.2 and 4.0.0 releases I'm going to start 3.9.2 release today if no one have any objections. - Best regards, Vladimir - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org

Re: [DISCUSS] Cordova-ios 3.9.2 release

One issue: https://issues.apache.org/jira/browse/CB-9917 I voted +1 in the [VOTE] thread because I didn't want to delay a vote for a change that didn't affect the release: When you do a `cordova platform add http://github.com/apache/cordova-ios.git#3.9.2` it first downloads master then checks the

Re: [VOTE] Tools Release

Am I the only one seeing the vote thread being merged into the discuss thread? I am 100% sure the subject was sent out as [VOTE] Tools release On Fri, Oct 30, 2015 at 5:34 PM, Steven Gill wrote: > Please review and vote on this Tools Release > by replying to this email

[GitHub] cordova-plugin-file pull request: CB-7253: requestFileSystem fails...

Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/145#discussion_r43565677 --- Diff: src/android/DirectoryManager.java --- @@ -56,45 +56,46 @@ public static boolean testFileExists(String name) { }

[GitHub] cordova-plugin-geolocation pull request: CB-9907 Handle ios tests ...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-geolocation/pull/56 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

Re: [DISCUSS] Tools Release

Oops, that vote was supposed to be its own thread. Ignore the vote in here. On Fri, Oct 30, 2015 at 5:33 PM, Steven Gill wrote: > Updated release notes: > Lib@5.4.0: > https://github.com/apache/cordova-lib/blob/master/cordova-lib/RELEASENOTES.md > CLI@5.4.0: >

[VOTE] Tools Release

Please review and vote on this Tools Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-9903 Tools have been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-9903/ The packages were

Re: [VOTE] iOS 3.9.2 release

+1 On Fri, Oct 30, 2015 at 1:09 PM, Vladimir Kotikov (Akvelon) wrote: > Please review and vote on this 3.9.2 iOS Release by replying to this email > (and keep discussion on the DISCUSS thread) > > > > Release issue: https://issues.apache.org/jira/browse/CB-9912 > > > >

[GitHub] cordova-plugin-geolocation pull request: CB-9907 Handle ios tests ...

GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-plugin-geolocation/pull/56 CB-9907 Handle ios tests that fail when run on ios simulator If the user has not specified how the simulator deals with location values, it will fail. with

[Vote] Tools Release

Please review and vote on this Tools Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-9903 Tools have been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-9903/ The packages were

[GitHub] cordova-coho pull request: CB-9220 remove check that enforces comm...

GitHub user stevengill opened a pull request: https://github.com/apache/cordova-coho/pull/100 CB-9220 remove check that enforces common to be linked in lib Take a look @vladimir-kotikov. Not sure if you were using create-verify for CI or something. You can merge this pull request

Re: [DISCUSS] Tools Release

Updated release notes: Lib@5.4.0: https://github.com/apache/cordova-lib/blob/master/cordova-lib/RELEASENOTES.md CLI@5.4.0: https://github.com/apache/cordova-cli/blob/master/RELEASENOTES.md Plugman@1.0.5: https://github.com/apache/cordova-plugman/blob/master/RELEASENOTES.md JS@4.1.2:

[GitHub] cordova-plugin-file pull request: CB-7253: requestFileSystem fails...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/145#discussion_r43565104 --- Diff: src/android/DirectoryManager.java --- @@ -56,45 +56,46 @@ public static boolean testFileExists(String name) { }

[GitHub] cordova-plugin-camera pull request: iOS: new resizable cropping re...

GitHub user convey-mane opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/131 iOS: new resizable cropping rectangle instead of Apple's standard square The title and comment of commit

Re: [Android] Possible solution to Camera/Media

Hi Joe, hot from my inbox I thought it was worth sharing, since I don't have a strong background on Android native dev, I didn't know about "*Don't Keep Activities*" Developer Option The setting could be useful to reproduce, debug problems, and unit testing around this area. *"* *XXX was

[GitHub] cordova-lib pull request: CB-9901 cordova plugin search opens in a...

Github user csantanapr commented on the pull request: https://github.com/apache/cordova-lib/pull/334#issuecomment-152646051 I think is a nice feature to open the browser to a good spot on the wen to search for plugins applicable for cli use cases where people are running by hand

[GitHub] cordova-plugin-camera pull request: CB-7668 Adding a sterner warni...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/130 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-lib pull request: CB-9901 cordova plugin search opens in a...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-lib/pull/334#issuecomment-152566519 LGTM this is a good one to fix. There is a jshint failure though that you might want to fix. --- If your project is set up for it, you can reply to this email

RE: [DISCUSS] Tools Release

Great. Good quick fix. Let's get this out soon. Node.js 5.0 just got released and it uses npm@3+ by default. Currently, cordova create fails with npm@3. Let's release soon to address that. -Nikhil -Original Message- From: Shazron [mailto:shaz...@gmail.com] Sent: Thursday, October 29,

RE: CB-9901 cordova plugin search opens in a browser

I have no opinion regarding removing or not, but WTFPL is fine (http://www.apache.org/legal/resolved.html#category-a). Tim -Original Message- From: Jesse [mailto:purplecabb...@gmail.com] Sent: Friday, October 30, 2015 12:00 PM To: dev@cordova.apache.org Subject: Re: CB-9901 cordova

[GitHub] cordova-lib pull request: CB-9901 cordova plugin search opens in a...

Github user eymorale commented on the pull request: https://github.com/apache/cordova-lib/pull/334#issuecomment-152596207 Thanks @nikhilkh! I'll take a look at the jshint failure and fix it --- If your project is set up for it, you can reply to this email and have your reply appear

Re: [DISCUSS] Cordova-ios 3.9.2 release

+1 On Fri, Oct 30, 2015 at 4:40 AM, Vladimir Kotikov (Akvelon) wrote: > Created this thread to separate discussions for 3.9.2 and 4.0.0 releases > I'm going to start 3.9.2 release today if no one have any objections. > > - > Best regards, Vladimir > >

[GitHub] cordova-plugin-file pull request: Fix CB-9752: FileEntry.getDirect...

GitHub user jasongin opened a pull request: https://github.com/apache/cordova-plugin-file/pull/144 Fix CB-9752: FileEntry.getDirectory fails with assets filesystem Calls to FileEntry.getDirectory() on an asset entry would internally call the AssetFileSystem.listAssets() method

Partnership with Google on App Indexing

Hello, My name is Emeric and I am working on Google App Indexing . Many developers have problems with discoverability and re-engagement in their apps. We have addressed those issues and came up with an idea called App Indexing. App Indexing allows

[GitHub] cordova-plugin-file pull request: Fix CB-9752: FileEntry.getDirect...

Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/144#issuecomment-152660125 Where are you adding the unit test? We currently don't have a way to unit test plugins. --- If your project is set up for it, you can reply to this

[GitHub] cordova-plugin-device-motion pull request: Pended tests that use a...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device-motion/pull/37 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-device-motion pull request: CB-9369 Return error wh...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device-motion/pull/38 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-docs pull request: Adding support for /docs/XX/latest

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/405 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: CB-9901 cordova plugin search opens in a browser

I would MUCH rather just remove search functionality from the cli. One less hook to worry about, one less feature to support, and we don't need to add a dependency to do it. Opener is nice because it has zero dependencies, I'm just not sure how compatible we are with the WTFPL license.

Re: Partnership with Google on App Indexing

Hi, I'm don't remember this being discussed on this mailing list, but my opinion is, as it only supports iOS and android, it should be a 3rd party plugin. Maybe others don't agree, so we should discuss it. It would be cool if somebody from google can create the plugins and share them.

[GitHub] cordova-plugin-geolocation pull request: Creation of the Geolocati...

Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/53#issuecomment-152604278 Rebased this code in, closing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-plugin-geolocation pull request: Creation of the Geolocati...

Github user infil00p closed the pull request at: https://github.com/apache/cordova-plugin-geolocation/pull/53 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-media pull request: Cordova-Android 5.0/Marshmallow...

Github user infil00p closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/71 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-contacts pull request: Changes for Cordova Android ...

Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/78#issuecomment-152604483 Rebased into master, closing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-contacts pull request: Changes for Cordova Android ...

Github user infil00p closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/78 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-file pull request: Adding permissions, giving read ...

Github user infil00p closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/135 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-media pull request: Cordova-Android 5.0/Marshmallow...

Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/71#issuecomment-152604611 Rebased, Closing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-lib pull request: CB-9901 cordova plugin search opens in a...

Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/334#issuecomment-152610676 What about people who use Cordova-lib from gulp instead of the cli ? Does it make sense to pop open a browser window ? --- If your project is set up for it,

CB-9901 cordova plugin search opens in a browser

Hi all, I have made a change to have the cordova plugin search command open the browser to 'http://cordova.apache.org/plugins/?q='. Nikhil has reviewed the changes already and they look good. But I just wanted to make sure the community is good with this change before I merge it in. Thanks,

Re: CB-9901 cordova plugin search opens in a browser

Sounds good to me. I don't think search is used much anyways in its current form. On Fri, Oct 30, 2015 at 11:31 AM, Edna Y Morales wrote: > > > Hi all, > > I have made a change to have the cordova plugin search command open the > browser to

[GitHub] cordova-lib pull request: CB-9901 cordova plugin search opens in a...

Github user eymorale commented on the pull request: https://github.com/apache/cordova-lib/pull/334#issuecomment-152611628 @omefire I've started a discussion thread for this on the dev list --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-lib pull request: CB-9901 cordova plugin search opens in a...

Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/334#issuecomment-152612090 Are people likely to be doing a plugin search from a gulp script? --- If your project is set up for it, you can reply to this email and have your reply appear on

[VOTE] iOS 3.9.2 release

Please review and vote on this 3.9.2 iOS Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-9912 The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-9912 The