[GitHub] cordova-windows pull request: Add support for back button on win10

Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/120#issuecomment-154014598 I plan to test and merge it. @EionRobb is there associated Jira issue available? Also, is there a special reason we use user agent instead of feature

[GitHub] cordova-windows pull request: CB-9836 Add .gitattributes to preven...

Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/126#issuecomment-153984003 lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-windows pull request: CB-9836 Add .gitattributes to preven...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/126 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-windows pull request: CB-9836 Add .gitattributes to preven...

Github user daserge commented on the pull request: https://github.com/apache/cordova-windows/pull/126#issuecomment-153990376 Done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-windows pull request: CB-9836 Add .gitattributes to preven...

Github user daserge commented on the pull request: https://github.com/apache/cordova-windows/pull/126#issuecomment-153986893 Will rebase and update it with [common web project template now](https://github.com/apache/cordova-ios/commit/7682bfeecc7a7adaa866ee2b946dcbe3a2696922). ---

RE: [VOTE] Tools Release (attempt 3)

I vote +1. * Verified tags * Ability to install/uninstall Cordova * Ability to update Cordova * Ability to create blank app for Windows, WP8, Android * Ability to build/run apps * Reviewed release notes * Verified versions * Verified line breaks * Verified 'cordova serve' * Verified that

[GitHub] cordova-windows pull request: Add support for back button on win10

Github user EionRobb commented on the pull request: https://github.com/apache/cordova-windows/pull/120#issuecomment-154017263 To clarify, the method defines itself as existing, but any attempts to use it will crash the container. There isn't a Jira issue for it, that would

RE: [DISCUSS] Cordova-Windows Release

I've tested mobilespec build artefacts (uap, win81) using Windows App Cert Kit and all tests pass. I see that we've just merged back button fix for WP8.1 so I plan to test and merge related fix[1] for Windows10 to have full back button support and proceed w/ release. [1]

[GitHub] cordova-firefoxos pull request: CB-9836 Add .gitattributes to prev...

GitHub user daserge opened a pull request: https://github.com/apache/cordova-firefoxos/pull/25 CB-9836 Add .gitattributes to prevent CRLF line endings in repos [Jira issue](https://issues.apache.org/jira/browse/CB-9836) You can merge this pull request into a Git repository by

[GitHub] cordova-windows pull request: Add support for back button on win10

Github user EionRobb commented on the pull request: https://github.com/apache/cordova-windows/pull/120#issuecomment-154016649 Feature detection is broken. It causes the ieframe.dll to crash outside of js and is uncatchable. --- If your project is set up for it, you can reply to

[GitHub] cordova-docs pull request: Set proper name in iOS config documenta...

GitHub user asc0de opened a pull request: https://github.com/apache/cordova-docs/pull/414 Set proper name in iOS config documentation Correct property name in example is wrong You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-plugin-camera pull request: Browser - Camera on top of all...

GitHub user aliokan opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/134 Browser - Camera on top of all! add CSS style {position: 'relative', z-index: 9} on DOM appended element You can merge this pull request into a Git repository by running: $

[GitHub] cordova-lib pull request: CB-9033 : fix WatchKit support

Github user shazron commented on the pull request: https://github.com/apache/cordova-lib/pull/219#issuecomment-154149943 Thanks. An update on this. I still want to get this in, but I will have to postpone it unless someone else wants to take this up right now. With the merge/rebase

[GitHub] cordova-docs pull request: CB-9903 added 5.4.0 tools release blog

Github user stevengill commented on the pull request: https://github.com/apache/cordova-docs/pull/411#issuecomment-154164542 oo good point about the cordova-app-hello-world update. I'll add it now --- If your project is set up for it, you can reply to this email and have your reply

Re: [Vote] 5.0.0 Android Release (attempt 2)

The vote has now closed. The results are: Positive Binding Votes: 3 Steve Gill Sergey Grebnov Joe Bowser The vote has passed. I wil now publish to dist and npm. @Frederico, please take the question to the [discuss] android release thread. We still need to do plugin + a new tools release for

Re: [DISCUSS] Removal of unused iOS bridges

I will integrate this later today. On Wed, Nov 4, 2015 at 2:18 PM, Carlos Santana wrote: > LGTM left a question. > > On Tue, Nov 3, 2015 at 6:36 PM Shazron wrote: > >> Sent a PR https://github.com/apache/cordova-ios/pull/178 please >> review/comment etc

Re: [Vote] 5.0.0 Android Release (attempt 2)

(This is kinda of a +1) Before anything else, I wanna make it clear that it is **not my intention to rush or demand anything at all**. Is anything else holding this release back? I have some urgent new project to go on about and it'd be crazy awesome if I could have 5.0 from the start so I don't

[GitHub] cordova-docs pull request: CB-9903 added 5.4.0 tools release blog

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/411#discussion_r44054631 --- Diff: www/_posts/2015-11-04-tools-release.md --- @@ -0,0 +1,121 @@ +--- +layout: post +author: +name: Steve Gill +

[GitHub] cordova-docs pull request: CB-9903 added 5.4.0 tools release blog

Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/411#discussion_r44055345 --- Diff: www/_posts/2015-11-04-tools-release.md --- @@ -0,0 +1,121 @@ +--- +layout: post +author: +name: Steve Gill +url:

Re: [DISCUSS] Cordova-Android 5.0.x

Please review the doc changes + release blog post at https://github.com/apache/cordova-docs/pull/409. Provide feedback on the PR. On Fri, Oct 23, 2015 at 11:20 AM, Jesse wrote: > +! > > > My team is hiring! > @purplecabbage > risingj.com > > On Fri, Oct 23, 2015 at 3:46

[GitHub] cordova-docs pull request: Update to plugin.md regarding Cordova-A...

Github user stevengill commented on the pull request: https://github.com/apache/cordova-docs/pull/409#issuecomment-154222843 Agreed, maybe we should say soon and then mention they can install plugins via giturl. Then provide an example: `cordova plugin add

[GitHub] cordova-docs pull request: Set proper name in iOS config documenta...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/414 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-file pull request: Fixed NullPointer Exception in A...

Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/119#discussion_r44084198 --- Diff: src/android/ContentFilesystem.java --- @@ -18,22 +18,19 @@ Licensed to the Apache Software Foundation (ASF) under one */

[GitHub] cordova-plugin-file pull request: Fixed NullPointer Exception in A...

Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/119#issuecomment-154187370 Can you create a JIRA issue for this, so I know what I'm testing? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-lib pull request:

Github user CatinhoCR commented on the pull request: https://github.com/apache/cordova-lib/commit/1b55e26bc5b234aa5c988291eee010607dba7c00#commitcomment-14223450 I'm still having this issue, tried to install node v 4.2.2 as suggested by @mgtorrea but didnt work. --- If your

[GitHub] cordova-docs pull request: Update to plugin.md regarding Cordova-A...

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/409#discussion_r44080144 --- Diff: www/_posts/2015-11-05-cordova-android-5.0.0.md --- @@ -0,0 +1,57 @@ +--- +layout: post +author: +name:Joe Bowser +

[GitHub] cordova-docs pull request: Update to plugin.md regarding Cordova-A...

Github user stevengill commented on the pull request: https://github.com/apache/cordova-docs/pull/409#issuecomment-154218614 Once I merge in the blog, I'm going to add `s to a bunch of code words in the commits section. --- If your project is set up for it, you can reply to this

[GitHub] cordova-docs pull request: Update to plugin.md regarding Cordova-A...

Github user stevengill commented on the pull request: https://github.com/apache/cordova-docs/pull/409#issuecomment-154222063 Might be worth it to add a point about which core plugins require the new permission model and mention that we plan on releasing updated versions of plugins

[DISCUSS] Plugins release

I plan on starting a plugins release on Monday. It is going to be a big one. Please review and close as many PRs as you can before than. If you have PR that is ready and needs someone to look at + merge, please share it in this thread and we will try to get to it before the release. You could

[GitHub] cordova-docs pull request: Set proper name in iOS config documenta...

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/414#issuecomment-154225170 Thanks for the PR @asc0de! I merged it in and followed up with a change to all the other languages. --- If your project is set up for it, you can reply to this

[GitHub] cordova-plugin-file pull request: Fixed NullPointer Exception in A...

Github user jasongin commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/119#issuecomment-154226660 Looks good to me other than the minor style issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-lib pull request: Cb 9964

GitHub user dubeejw opened a pull request: https://github.com/apache/cordova-lib/pull/339 Cb 9964 When providing a --template argument during project creation, users can use templates apps from a local directory, GitHub, or NPM. This makes sharing templates, and example apps

[GitHub] cordova-plugin-file pull request: Fixed NullPointer Exception in A...

Github user cjpearson commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/119#issuecomment-154190076 https://issues.apache.org/jira/browse/CB-9965 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-cli pull request: Cb 9964

GitHub user dubeejw opened a pull request: https://github.com/apache/cordova-cli/pull/226 Cb 9964 When providing a --template argument during project creation, users can use templates apps from a local directory, GitHub, or NPM. This makes sharing templates, and example apps much

[GitHub] cordova-docs pull request: CB-9959: Makes plugins search case inse...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/412 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-file pull request: Fixed NullPointer Exception in A...

Github user didlich commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/119#issuecomment-154184039 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-docs pull request: CB-9959: Makes plugins search case inse...

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/412#issuecomment-154212220 Tested. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-file pull request: Fixed NullPointer Exception in A...

Github user cjpearson commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/119#issuecomment-154181249 @infil00p, could you take a look at this PR? I'm running into this issue when I try to open a file that was taken from the camera plugin on Android

Re: [VOTE] Tools Release (attempt 3)

I vote +1. * Verified tags * Ability to install/uninstall Cordova * Ability to update Cordova * Ability to create blank app for Windows, WP8, Android * Ability to build/run apps * Reviewed release notes * Verified versions * Verified line breaks * Verified 'cordova serve' * Verified that

[GitHub] cordova-plugin-file pull request: Fixed NullPointer Exception in A...

Github user infil00p commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/119#discussion_r44106504 --- Diff: src/android/ContentFilesystem.java --- @@ -18,22 +18,19 @@ Licensed to the Apache Software Foundation (ASF) under one */

RE: [VOTE] Tools Release (attempt 3)

+1 * Verified ability to install/uninstall Cordova on Windows * Verified blank app could be created * Verified iOS, Android, Windows platforms could be added and built (iOS prepare only ) * Reviewed release notes * Verified cordova run --list -Sergey Grebnov -Original Message- From:

RE: [DISCUSS] Plugins release

I think this PR should get in the release: https://github.com/apache/cordova-plugin-file/pull/146 It might be considered a blocker, because it is a regression that could cause loss of data when upgrading apps which relied on the default AndroidPersistentFileLocation value. This would be a good

[GitHub] cordova-plugin-camera pull request: CB-9960 android: Fixed FileNot...

Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/135#discussion_r44093297 --- Diff: src/android/CameraLauncher.java --- @@ -547,7 +547,7 @@ private String ouputModifiedBitmap(Bitmap bitmap, Uri uri) throws

[GitHub] cordova-plugin-camera pull request: CB-9960 android: Fixed FileNot...

Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/135#discussion_r44093710 --- Diff: src/android/CameraLauncher.java --- @@ -547,7 +547,7 @@ private String ouputModifiedBitmap(Bitmap bitmap, Uri uri) throws

[GitHub] cordova-ios pull request: CB-9883 - Remove unused iOS bridges

Github user csantanapr commented on the pull request: https://github.com/apache/cordova-ios/pull/178#issuecomment-154265526 @shazron is this a lesson learned that certain experimental things should be kept in experimental branches and not in master :+1: --- If your project is set

Re: [GitHub] cordova-ios pull request: CB-9883 - Remove unused iOS bridges

And that we need to watch what others commit. More review would have stopped this in the first place. > On Nov 5, 2015, at 6:33 PM, csantanapr wrote: > > Github user csantanapr commented on the pull request: > >

[GitHub] cordova-plugin-camera pull request: CB-9960 android: Fixed FileNot...

GitHub user riknoll opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/135 CB-9960 android: Fixed FileNotFoundException for some gallery images Certain gallery applications (such as Google Photos) return `content://` URIs that our method of getting a file

[GitHub] cordova-ios pull request: CB-9883 - Remove unused iOS bridges

Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/178 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-coho pull request: CB-9962 Fixed CI builds

GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-coho/pull/103 CB-9962 Fixed CI builds https://issues.apache.org/jira/browse/CB-9962 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-coho pull request: CB-9962 Fixed CI builds

Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-coho/pull/103#issuecomment-154065880 lgtm :ship: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this