[GitHub] cordova-wp8 pull request: CB-9836 Add .gitattributes to prevent CR...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-wp8/pull/89 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: Partnership with Google on App Indexing

Thanks for that. A plugin would indeed be a good way to add this to Cordova. What would be the best way to get this plugin from the community? Thanks, Emeric On Thu, Nov 12, 2015 at 7:18 PM, julio cesar sanchez wrote: > Sorry, we have been answering but the mails went

[GitHub] cordova-blackberry pull request: CB-9836 Add .gitattributes to pre...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-blackberry/pull/193 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-firefoxos pull request: CB-9836 Add .gitattributes to prev...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-firefoxos/pull/25 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-ubuntu pull request: Cb 9694 - Add support for HTTP urls

Github user david-barth-canonical closed the pull request at: https://github.com/apache/cordova-ubuntu/pull/18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-camera pull request: iOS: new resizable cropping re...

Github user convey-mane commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/131#issuecomment-156374999 Yes, of course I did read that, too – but (excerpt from the excerpt :wink:): > … to cover any of their contributions which are not owned by

[GitHub] cordova-plugin-camera pull request: iOS: new resizable cropping re...

Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/131#issuecomment-156375961 Yeah, that's a legal thing so it could be interpreted differently. I'm not a lawyer so not sure, probably someone from the community could help to

[GitHub] cordova-plugin-camera pull request: iOS: new resizable cropping re...

Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/131#issuecomment-156369410 Not sure if only CCLA is needed: > For a corporation that has assigned employees to work on an Apache project, a Corporate CLA (CCLA) is

[GitHub] cordova-browser pull request: CB-9836 Add .gitattributes to preven...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-browser/pull/22 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-ubuntu pull request: add defaut icon parameter to config.x...

Github user david-barth-canonical closed the pull request at: https://github.com/apache/cordova-ubuntu/pull/16 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-camera pull request: iOS: new resizable cropping re...

Github user convey-mane commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/131#issuecomment-156366234 Yesterday my boss obviously sent a CCLA, 'cause he forwarded to me a mail from Craig L Russel, which acknowledges it's receipt. As there's just a

[GitHub] cordova-plugin-camera pull request: iOS: new resizable cropping re...

Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/131#issuecomment-156454285 @convey-mane, I believe you should do the following with the PR: - Send a message to the [dev-list](http://cordova.apache.org/contact/) with the

Re: [DISCUSS] CLI Templates

alias, deprecate and later remove On Fri, Nov 13, 2015 at 1:49 PM Carlos Santana wrote: > I agree, --template is the new --copy-from :-) > > > On Fri, Nov 13, 2015 at 1:48 PM Shazron wrote: > >> Well, we could deprecate --copy-from, and alias --template

Re: [DISCUSS] CLI Templates

I agree, --template is the new --copy-from :-) On Fri, Nov 13, 2015 at 1:48 PM Shazron wrote: > Well, we could deprecate --copy-from, and alias --template to it. But > we shouldn't have both, it should just be one implementation. > > On Fri, Nov 13, 2015 at 10:45 AM, Carlos

[GitHub] cordova-docs pull request: Added page describing how to create iss...

Github user rakatyal commented on the pull request: https://github.com/apache/cordova-docs/pull/418#issuecomment-156534098 Yeah. Let's skip it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-docs pull request: Added page describing how to create iss...

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/418#discussion_r44825857 --- Diff: www/contribute/contribute_guidelines.md --- @@ -0,0 +1,77 @@ +--- +layout: contribute-help +title: Apache Cordova Contribute

[GitHub] cordova-docs pull request: Added page describing how to create iss...

Github user csantanapr commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/418#discussion_r44826426 --- Diff: www/contribute/contribute_guidelines.md --- @@ -0,0 +1,77 @@ +--- +layout: contribute-help +title: Apache Cordova Contribute

[GitHub] cordova-docs pull request: Added page describing how to create iss...

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/418#discussion_r44821378 --- Diff: www/contribute/issues.md --- @@ -0,0 +1,32 @@ +--- +layout: contribute-help +title: Apache Cordova Reporting Issues --- End

Re: Plugin Audit 2015

Okay. I'll back down then. I thought it was a 'must have' which to me dictates that we 'must have' a fork. > On Nov 13, 2015, at 10:46 AM, Shazron wrote: > > I don't agree with keyboard being in core. It's not "required" on ios, > it's just a cosmetic change, and its

Re: Contributor and Issue guidelines

Thanks Richard ! Hopefully will migrate everything useful out from the old Wiki On Fri, Nov 13, 2015 at 2:41 PM Richard Knoll wrote: > Hey all, > > I have submitted a PR to the docs repo< > https://github.com/apache/cordova-docs/pull/418> with some updated > contributor

[GitHub] cordova-plugin-file pull request: CB-8497: Fix handling of file pa...

Github user jasongin commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/147#issuecomment-156501822 Closing this because I've decided to take a different approach now that I understand file plugin URI encoding issues better. I'll submit a new PR soon.

[GitHub] cordova-plugin-file pull request: CB-8497: Fix handling of file pa...

Github user jasongin closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/147 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: Plugin Audit 2015

I don't agree with keyboard being in core. It's not "required" on ios, it's just a cosmetic change, and its pretty hacky to get right. With iPad and iPad Pro's new enhanced keyboards, this will be a bigger nightmare to maintain thus I am strongly against this. With iOS 7 and greater's flat UI,

Re: [DISCUSS] CLI Templates

In some way we we are enhancing --copy-from I'm OK to the copy blindly even plugins and platforms, I was trying to avoid people creating templates when is not need it if they already have platforms and plugins But I'm OK if we want to allow it, but I would not documented :-) it just happens to

Contributor and Issue guidelines

Hey all, I have submitted a PR to the docs repo with some updated contributor guidelines and instructions for submitting issues to JIRA. They are mostly taken from the old wiki pages, but I updated the information based on Nikhil's JIRA triage

[GitHub] cordova-plugin-file pull request: CB-8497 Fix handling of file pat...

GitHub user jasongin opened a pull request: https://github.com/apache/cordova-plugin-file/pull/149 CB-8497 Fix handling of file paths with # character Because # is a valid filename character, it must be encoded whenever it is in a path that is part of a URI, to prevent part of

[GitHub] cordova-docs pull request: Added page describing how to create iss...

Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/418#discussion_r44818344 --- Diff: www/contribute/issues.md --- @@ -0,0 +1,32 @@ +--- +layout: contribute-help +title: Apache Cordova Reporting Issues --- End

[GitHub] cordova-plugin-file pull request: CB-8497 Fix handling of file pat...

Github user jasongin commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/149#issuecomment-156509216 @riknoll please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-docs pull request: Added page describing how to create iss...

Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/418#discussion_r44820997 --- Diff: www/contribute/issues.md --- @@ -0,0 +1,32 @@ +--- +layout: contribute-help +title: Apache Cordova Reporting Issues --- End

[GitHub] cordova-docs pull request: Added page describing how to create iss...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/418#issuecomment-156532357 I'm not sure, we do have the "feature" issue type in JIRA --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

Re: [DISCUSS] CLI Templates

Well, we could deprecate --copy-from, and alias --template to it. But we shouldn't have both, it should just be one implementation. On Fri, Nov 13, 2015 at 10:45 AM, Carlos Santana wrote: > In some way we we are enhancing --copy-from > > I'm OK to the copy blindly even

[GitHub] cordova-docs pull request: Added page describing how to create iss...

Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/418#discussion_r44818361 --- Diff: www/contribute/issues.md --- @@ -0,0 +1,32 @@ +--- +layout: contribute-help +title: Apache Cordova Reporting Issues +---

[GitHub] cordova-docs pull request: Added page describing how to create iss...

Github user rakatyal commented on the pull request: https://github.com/apache/cordova-docs/pull/418#issuecomment-156530510 Looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-docs pull request: Added page describing how to create iss...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/418#issuecomment-156536822 I've added a page of contributor guidelines as well. It's mostly based off the old [issue workflow wiki page](http://wiki.apache.org/cordova/IssueWorkflow) but

[GitHub] cordova-docs pull request: Added page describing how to create iss...

Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/418#discussion_r44825174 --- Diff: www/contribute/contribute_guidelines.md --- @@ -0,0 +1,77 @@ +--- +layout: contribute-help +title: Apache Cordova Contribute

Re: [DISCUSS] CLI Templates

What dynamic nature you want ? I think using yeoman is bad idea, we tried at work at is a huge dependency in terms of foot print and number of dependencies. We then learned that just using the inquirer npm package gave us what we wanted to create an interactive experience in the CLI At least the

Re: [DISCUSS] CLI Templates

Not liking the idea to add another dependency like yeoman, definitely not :/ Cordova should be lean... Stepping back, since this is clearly an enhancement to --copy-from -- why not just update --copy-from's implementation? The proposal says "it copies everything from the template including

[GitHub] cordova-docs pull request: Added page describing how to create iss...

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/418#discussion_r44828736 --- Diff: www/contribute/contribute_guidelines.md --- @@ -0,0 +1,77 @@ +--- +layout: contribute-help +title: Apache Cordova Contribute

Re: Plugin Audit 2015

It's not a "must have". I have yet to use it in any of my projects. It can be very handy, and I am glad someone is maintaining it, but it's not required. > On 14 Nov 2015, at 06:29, Jesse wrote: > > Okay. I'll back down then. I thought it was a 'must have' which to

[GitHub] cordova-docs pull request: Added page describing how to create iss...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/418#discussion_r44845293 --- Diff: www/_includes/head.html --- @@ -23,7 +23,12 @@ + +{% if page.no_code_highlight %} --- End diff --

RE: Native vs. File URIs

I completely agree with this. Would definitely be a breaking change, though, and require us to add the File plugin as a dependency. The file plugin dependency would be a good move too, I think, because then we might be able to strip out all of the content URI stuff we are doing in Android and

[GitHub] cordova-ios pull request: CB-9827 Implement and expose PlatformApi...

Github user omefire commented on the pull request: https://github.com/apache/cordova-ios/pull/176#issuecomment-156571123 I'll take a stab at reviewing this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-docs pull request: Added page describing how to create iss...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/418#discussion_r44845538 --- Diff: www/_layouts/contribute-help.html --- @@ -0,0 +1,10 @@ +--- +layout: cordova +no_code_highlight: true --- End diff --

[GitHub] cordova-docs pull request: Added page describing how to create iss...

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/418#discussion_r44845517 --- Diff: www/_includes/head.html --- @@ -23,7 +23,12 @@ + +{% if page.no_code_highlight %} --- End diff --

[GitHub] cordova-windows pull request: CB-9828 Implements PlatformApi contr...

Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/132#discussion_r44842471 --- Diff: bin/lib/check_reqs.js --- @@ -209,7 +209,7 @@ function getInstalledPhoneSdks () { } }) .then(function () {

[GitHub] cordova-windows pull request: CB-9828 Implements PlatformApi contr...

Github user jasongin commented on the pull request: https://github.com/apache/cordova-windows/pull/132#issuecomment-156579165 I looked through all of the PR and didn't find anything concerning other than the one thing I commented on. But it's a lot of code in an area I'm not at all

[GitHub] cordova-plugin-camera pull request: CB-5479 android: changed saveT...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/137#issuecomment-156579930 I think this should also fix CB-6640 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[DISCUSS] cordova-wp8 patch release 3.8.2

I have pushed 2 cherry-picked commits to the 3.8.x [1] branch of cordova-wp8 wp8 is currently not available as a platform to cordova platform add wp8 on some unix based machines because to case-sensitivity issues with the use of the 'Q' module instead of the 'q' module This should be a quick and

[GitHub] cordova-docs pull request: Added page describing how to create iss...

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/418#discussion_r44845912 --- Diff: www/_includes/head.html --- @@ -23,7 +23,12 @@ + +{% if page.no_code_highlight %} --- End diff --

Re: [DISCUSS] cordova-wp8 patch release 3.8.2

+1. On 11/13/15, 5:19 PM, "Jesse" wrote: >I have pushed 2 cherry-picked commits to the 3.8.x [1] branch of cordova-wp8 >wp8 is currently not available as a platform to cordova platform add wp8 on >some unix based machines because to case-sensitivity issues with the

Re: [DISCUSS] cordova-wp8 patch release 3.8.2

+1 On Fri, Nov 13, 2015 at 5:23 PM, Parashuram N wrote: > +1. > > > > > On 11/13/15, 5:19 PM, "Jesse" wrote: > > >I have pushed 2 cherry-picked commits to the 3.8.x [1] branch of > cordova-wp8 > >wp8 is currently not available as a platform to

Buildbot: buildslave cordova-osx-slave was lost

The Buildbot working for 'ASF Buildbot' has noticed that the buildslave named cordova-osx-slave went away It last disconnected at Sat Nov 14 01:57:57 2015 (buildmaster-local time) The admin on record (as reported by BUILDSLAVE:info/admin) was 'Dmitry Blotsky '.

[GitHub] cordova-docs pull request: Added page describing how to create iss...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/418#discussion_r44845704 --- Diff: www/_includes/head.html --- @@ -23,7 +23,12 @@ + +{% if page.no_code_highlight %} --- End diff --

Buildbot: buildslave cordova-windows-slave was lost

The Buildbot working for 'ASF Buildbot' has noticed that the buildslave named cordova-windows-slave went away It last disconnected at Sat Nov 14 02:36:25 2015 (buildmaster-local time) The admin on record (as reported by BUILDSLAVE:info/admin) was 'Dmitry Blotsky '.

[ANNOUNCE] cordova-windows@4.2.0 released!

blog: http://cordova.apache.org/announcements/2015/11/11/cordova-windows-4.2.0.html tweet: https://twitter.com/apachecordova/status/665325977011023873

[GitHub] cordova-android pull request: CB-9836 Add .gitattributes to preven...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/231 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-webos pull request: CB-9836 Add .gitattributes to prevent ...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-webos/pull/6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-ubuntu pull request: CB-9836 Add .gitattributes to prevent...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-ubuntu/pull/17 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-camera pull request: iOS: new resizable cropping re...

Github user convey-mane commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/131#issuecomment-156442350 @daserge: today the admin of our GitHub enterprise account was here, he looked at my posting from yesterday concerning `rebase` (you remember?); his

Re: Partnership with Google on App Indexing

Hey Emeric, The greatest thing about Cordova is it's openness. You don't need permission to create a new plugin. The core functionality (like geolocation) is written as a plugin and maintained by this group but third parties whether they be large companies Google or the independent software can