[GitHub] cordova-labs pull request: CB-51 API: FileTransfer - Support PUT M...

2015-11-17 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-labs/pull/8#issuecomment-157361428 Thank you guys! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-inappbrowser pull request: Fixed zIndex issue on Wi...

2015-11-17 Thread icaro56
Github user icaro56 commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/102#issuecomment-157405904 Do the test on windows 10 device. It seems the emulator is broken. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-plugin-camera pull request: [Browser] Give video and butto...

2015-11-17 Thread Clementp57
GitHub user Clementp57 opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/138 [Browser] Give video and button tag an id Allows developer to style both video and button tags in Browser. You can merge this pull request into a Git repository by running: $

[GitHub] cordova-plugin-inappbrowser pull request: Fixed zIndex issue on Wi...

2015-11-17 Thread napcat
Github user napcat commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/102#issuecomment-157380781 Is this fixed? How can I fixe it? I have the exact same problem described in the image above:

Re: [DISCUSS] Cordova CLI & LIB 5.4.1 Release

2015-11-17 Thread David Barth
Yeah, +1 for https://issues.apache.org/jira/browse/CB-9987 to help manage the transition of platforms to the 5.x world On Tue, Nov 17, 2015 at 3:24 AM, Steven Gill wrote: > Need to do a patch release for Lib & CLI. > > Fixing these 3 issues: >

Re: [DISCUSS] Cordova CLI & LIB 5.4.1 Release

2015-11-17 Thread David Barth
And if there is a release, there are 2 fixes i'd love to get in for Ubuntu: https://github.com/cordova-ubuntu/cordova-lib/commits/CB-9590 - to be compaitble with the new registry at last https://github.com/cordova-ubuntu/cordova-lib/commits/CB-9618 - fix the www non-sense in icon paths I can

[DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

2015-11-17 Thread David Barth
Hey, I would like to update the 4.x series of cordova-ubuntu with a couple of fixes, and make it the last in the series supporting the cordova-cli 4.3.1 branch as well - Cb 9868 - Should propose to install missing Ubuntu dependencies on platform add

[GitHub] cordova-plugin-camera pull request: CB-5479 android: changed saveT...

2015-11-17 Thread StopSine
Github user StopSine commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/137#issuecomment-157457257 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-camera pull request: CB-5479 android: changed saveT...

2015-11-17 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/137#issuecomment-157471037 @infil00p, if you have no objections, I'm going to merge this in. I don't think it'll break too many people and it fixes several quirks. --- If your

[GitHub] cordova-docs pull request: CB-10028: Made docs toc links relative ...

2015-11-17 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/425#issuecomment-157534721 @dblotsky please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-docs pull request: CB-10028: Made docs toc links relative ...

2015-11-17 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-docs/pull/425 CB-10028: Made docs toc links relative to URL You can merge this pull request into a Git repository by running: $ git pull https://github.com/riknoll/cordova-docs relative-toc-links

[GitHub] cordova-plugin-inappbrowser pull request: Fixed zIndex issue on Wi...

2015-11-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/102 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-inappbrowser pull request: Inappbrowser always on t...

2015-11-17 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/85#issuecomment-157546865 Handled in #102 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-inappbrowser pull request: Inappbrowser always on t...

2015-11-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/85 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-camera pull request: CB-5479 android: changed saveT...

2015-11-17 Thread infil00p
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/137#issuecomment-157475233 Sounds good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

Re: [DISCUSS] Cordova CLI & LIB 5.4.1 Release

2015-11-17 Thread Frederico Galvão
+1 please. 2015-11-17 15:36 GMT-02:00 David Barth : > And if there is a release, there are 2 fixes i'd love to get in for Ubuntu: > > https://github.com/cordova-ubuntu/cordova-lib/commits/CB-9590 - to be > compaitble with the new registry at last >

[GitHub] cordova-plugin-camera pull request: CB-5479 android: changed saveT...

2015-11-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/137 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-inappbrowser pull request: CB-8863 fix async self u...

2015-11-17 Thread purplecabbage
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/123 CB-8863 fix async self usage You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-plugin-inappbrowser pull request: CB-8863 fix async self u...

2015-11-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/123 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-camera pull request: update video and button style ...

2015-11-17 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/127#issuecomment-157496539 I'm not familiar with the ionic side menu layout, but I think that #138 might be a more general solution. @raykin does that sound alright? --- If your

[GitHub] cordova-plugin-camera pull request: [Browser] Give video and butto...

2015-11-17 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/138#issuecomment-157495682 Does this have a corresponding [JIRA](https://issues.apache.org/jira/secure/Dashboard.jspa) issue? Also, I don't see your name in the [ICLA

[GitHub] cordova-docs pull request: CB-10013: Removed line wrapping of code...

2015-11-17 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/420#issuecomment-157570116 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-docs pull request: CB-10015: Fixed the browse online link ...

2015-11-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/421 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: CB-10013: Removed line wrapping of code...

2015-11-17 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/420#issuecomment-157570180 Tested in latest Chrome, Firefox, and Safari. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-plugin-camera pull request: CB-8863 correct block usage fo...

2015-11-17 Thread purplecabbage
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/139 CB-8863 correct block usage for async calls You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-docs pull request: CB-10013: Removed line wrapping of code...

2015-11-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/420 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: CB-10017: Restored broken image in amaz...

2015-11-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/422 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-camera pull request: CB-8863 correct block usage fo...

2015-11-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/139 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-lib pull request: CB-9976 Reinstall plugins for platform i...

2015-11-17 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/344#issuecomment-157569576 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-docs pull request: CB-10017: Restored broken image in amaz...

2015-11-17 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/422#issuecomment-157572598 LGTM. I'll create a JIRA for the test script so that we can address it in the future. --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-docs pull request: Refactored the title prefix into a glob...

2015-11-17 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/423#issuecomment-157606026 One note: do you think it might be better to have `title_prefix` set to nothing on blog posts? Or maybe to change the prefix logic somehow to make titles visibly

[GitHub] cordova-docs pull request: CB-10020: Indicated the latest version ...

2015-11-17 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/424#issuecomment-157607051 Upon shrinking the screen size, I noticed that the `(Latest)` string makes the dropdown go outside the bounds of the screen. I was thinking of doing something

[GitHub] cordova-docs pull request: Ajout de popvox.png

2015-11-17 Thread juspriet
Github user juspriet commented on the pull request: https://github.com/apache/cordova-docs/pull/386#issuecomment-157308325 The app description : https://github.com/juspriet/cordova-docs/commit/0861d4c8a11c53aec5247de7647038671cadc477 --- If your project is set up for it, you can

[GitHub] cordova-lib pull request: CB-9976 Reinstall plugins for platform i...

2015-11-17 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/344#issuecomment-157312145 Thanks, @TimBarham. The commit itself also had a wrong JIRA prefix. Updated. --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-plugin-inappbrowser pull request: fixed a bug where status...

2015-11-17 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/91#issuecomment-157627565 This was fixed in #72 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-inappbrowser pull request: fixed a bug where status...

2015-11-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/91 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or