Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/426#issuecomment-158266198
LGTM. Rebasing first actually made this surprisingly easy,
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/427#issuecomment-158266219
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/426
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/427
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/140
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Alright, 5.4.1 vote thread is out.
Release notes:
https://github.com/apache/cordova-lib/blob/master/cordova-lib/RELEASENOTES.md#541-nov-19-2015
Mainly, these three issues have been resolved:
* https://issues.apache.org/jira/browse/CB-9975
* https://issues.apache.org/jira/browse/CB-9976
* https://
Please review and vote on this Tools Release
by replying to this email (and keep discussion on the DISCUSS thread)
Release issue: https://issues.apache.org/jira/browse/CB-10049
Both tools have been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-10049/
The packages were p
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-android/pull/240#issuecomment-158246192
Can't we still use superspawn and just add something like the
`stderr.on('data')` filter to catch and discard the undesired line? Superspawn
can return a promi
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/140#issuecomment-158245865
Agree with above. Otherwise, LGTM. Tested on an 8.1 device (and by tested I
mean I took a picture, not really sure what else to do here). I don't really
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/140#issuecomment-158243766
Good suggestion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/140#issuecomment-158243037
You could place the value into a constant named `HIGHEST_POSSIBLE_Z_INDEX`,
and then it would be both documented and easier to maintain.
---
If your pr
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/49
CB-8863 Fix block usage of self
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/purplecabbage/cordova-plugin-media-ca
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ubuntu/pull/19
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ubuntu/pull/15
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/76
CB-8863 Fix block usage of self
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/purplecabbage/cordova-plugin-media CB-8863
A
Github user maortega commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/116#issuecomment-158229415
Sure, test added.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-android/pull/239#issuecomment-158229277
@Bnaya @riknoll Unless you're getting a result back from an Activity, the
plugin processes belong to the activity that was put in the background, and the
plugi
Thanks Joe!
P.S. The "r" prefixed tags messed up my coho commands to create the tgz and
print the corresponding tags. I have now fixed that problem by not
stripping the "r" for plugin tags so those tags fail the semver check.
Attempt 2 for plugins vote is now out.
On Thu, Nov 19, 2015 at 11:03
Please review and vote on the release of this plugins release
by replying to this email (and keep discussion on the DISCUSS thread)
Release issue: https://issues.apache.org/jira/browse/CB-10035
The plugins have been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-10035/
T
Github user Bnaya commented on the pull request:
https://github.com/apache/cordova-android/pull/239#issuecomment-158226691
I will extend the scope of that issue.
This change can/should also help the apps developers to recover from
situations that the app sent to the background
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-android/pull/239#issuecomment-158225021
Also, I don't think you can get into a situation where you have two
Activity results pending (correct me if I'm wrong on that one).
---
If your project is set
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-android/pull/239#issuecomment-158224722
@Bnaya That is correct and it was intentional. Is there a need for
extending this to all plugin callbacks currently pending? The way I see it, the
burden is on
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/26#issuecomment-158222576
Oh, sorry, I'm talking about iOS 7 deprecated warnings, not iOS 8 warnings
Anyway, I already told that [[UIDevice currentDevice] orientatio
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/26#issuecomment-158220443
you updated from the github url? or just with a cordova plugin add
cordova-plugin-statusbar?
I suppose you did the latest, because the warnings
Github user Bnaya commented on the pull request:
https://github.com/apache/cordova-android/pull/239#issuecomment-158220594
@riknoll, after going over the docs (which looks great btw) its seems it
supports only single plugin result
What if you wait for two or more plugins responses?
Sorry these tags seem to be wrong. I have to cancel this vote and restart
once I get the write output for tags.
On Thu, Nov 19, 2015 at 12:43 PM, Joe Bowser wrote:
> I vote +1
>
> * Ran coho audit-license-headers over the relevant repos
> * Ran mobilespec on android and ios
>
> On Thu, Nov 19, 2
Github user Titoine commented on the pull request:
https://github.com/apache/cordova-android/pull/239#issuecomment-158219586
@infil00p Before the patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jordancardwell commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/26#issuecomment-158219287
Hey folks.. will this one get some love any time soon?
Just checking.. I updated to latest plugin version and thought it didn't
actually
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-android/pull/239#issuecomment-158217697
@Titoine Are you having problems after the patch or before? I'm not sure.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-android/pull/239#issuecomment-158217175
Hey all, I've added a PR to the docs repo that documents the result
callback part of this change as well as general Android lifecycle
considerations: https://gi
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-docs/pull/428
CB-8917: adding docs for Android lifecycle considerations
***Don't Merge! Dependent on [CB-8917
PR](https://github.com/apache/cordova-android/pull/239) in cordova-android!***
@infil00
Welcome Marco!
If you need any assistance, feel free to ask us on the list or on slack (
slack.cordova.io)
Cheers,
-Steve
On Thu, Nov 19, 2015 at 12:07 PM, Marco Antonio Ortega Moulin <
ma...@marksoftsolutions.com> wrote:
> Hello, I want to contribute to the cordova project since we are trying
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/116#issuecomment-158201106
Could you add a test for this new usecase?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-docs/pull/427
CB-10045: Made table elements in docs extend bootstrap table classes
I'm adding a docs page and need table styles. This affects the platform
support table FYI. @dblotsky please review.
You ca
I vote +1
* Ran coho audit-license-headers over the relevant repos
* Ran mobilespec on android and ios
On Thu, Nov 19, 2015 at 12:11 PM, Steven Gill
wrote:
> Please review and vote on the release of this plugins release
> by replying to this email (and keep discussion on the DISCUSS thread)
>
>
GitHub user maortega opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/116
CB-10044 FileTransfer plug in can upload parts of a file to implement
resumablejs
By sending the startByte and endByte to the FileTransfer plugin we are able
to upload parts
Please review and vote on the release of this plugins release
by replying to this email (and keep discussion on the DISCUSS thread)
Release issue: https://issues.apache.org/jira/browse/CB-10035
The plugins have been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-10035/
T
Hello, I want to contribute to the cordova project since we are trying to
implement a resumable feature for file uploading. I already did a fork of the
FileTransfer plugin and want to send a pull request.
I already joined the mailing list, signed the ICLA, created an account in
Apache Jira and
Github user luofan189 commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/137#issuecomment-158174054
I have added options to that JIRA issue, @riknoll
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/240#discussion_r45386856
--- Diff: bin/templates/cordova/lib/builders/GradleBuilder.js ---
@@ -211,3 +212,54 @@ module.exports = GradleBuilder;
function isAutoGenerated(
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/240#discussion_r45386261
--- Diff: bin/templates/cordova/lib/builders/GradleBuilder.js ---
@@ -211,3 +209,46 @@ module.exports = GradleBuilder;
function isAutoGenerated(
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/240#discussion_r45385875
--- Diff: bin/templates/cordova/lib/builders/GradleBuilder.js ---
@@ -211,3 +212,54 @@ module.exports = GradleBuilder;
function isAutoGenerated(
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/240#discussion_r45385577
--- Diff: bin/templates/cordova/lib/builders/GradleBuilder.js ---
@@ -211,3 +212,54 @@ module.exports = GradleBuilder;
function isAutoGenerated(
I just did the test again on this end, and the only test failures I got
were the ones where I was expected to approve permissions. It seems that
these tests will keep running and that the permission dialog won't block
the UI. This is the correct behaviour, but it does mean that we have to
make su
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/137#issuecomment-158134364
@luofan189 I would also appreciate it if you could post the camera options
you are passing to the plugin and the versions of iOS and the plugin you're
us
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/137#issuecomment-158133797
@luofan189 I'll try and reproduce this. If you don't mind, let's move this
conversation to the JIRA issue:
https://issues.apache.org/jira/browse/
Github user luofan189 commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/137#issuecomment-158132005
@riknoll only the low resolution image is saved on iOS device as well. I
set the targetWidth and targetHeight to 1024x768
---
If your project is set u
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/137#issuecomment-158127870
@luofan189 What issue are you seeing? I can take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user david-barth-canonical opened a pull request:
https://github.com/apache/cordova-ubuntu/pull/19
Cordova-Ubuntu Platform Release 4.3.1
From the RELEASENOTES.md
* default icon name www/img/logo.png
* add defaut icon parameter to config.xml
* use QUrl::fromLo
Github user luofan189 commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/137#issuecomment-158082173
Is this issue only fixed on Android side? I am seeing the same issue on iOS
with the latest release as well.
---
If your project is set up for it, you
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-contacts/pull/83
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/124
CB-7696 Document target=_self behavior for Windows
Documenting Windows behavior as per
https://issues.apache.org/jira/browse/CB-7696
You can merge this pull request into a Git
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/83#issuecomment-158055883
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/83#issuecomment-158054090
@daserge, updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/83#discussion_r45337850
--- Diff: tests/tests.js ---
@@ -525,6 +525,28 @@ exports.defineManualTests = function(contentEl,
createActionButton) {
}, obj);
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-plugin-contacts/pull/83
CB-7021 Adds manual test for pickContact
See [CB-7021](https://issues.apache.org/jira/browse/CB-7021) for details
You can merge this pull request into a Git repository by ru
For existing tags I think it doesn't hurt to have both the r and without the r
to avoid braking someone on the same commit/release
For new releases then do not have the r
- Carlos
@csantanapr
> On Nov 19, 2015, at 1:20 AM, Steven Gill wrote:
>
> Hey everyone
>
> I made new tags for all of ou
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/115
CB-9969 Filetransfer upload error deletes original file
Adds a corresponding test and fixes for Android, iOS and Windows.
[Jira issue](https://issues.apache.org/jira/br
Github user vincipop commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/77#issuecomment-158021220
Hi @vladimir-kotikov ,
Apache CLA signed
Issue filed on JRA : https://issues.apache.org/jira/browse/CB-10039
Thanks
---
If your project is
Github user Titoine commented on the pull request:
https://github.com/apache/cordova-android/pull/239#issuecomment-158017890
Hi,
First of all, thanks from the great work!
But I'm getting a lot of crash from this problem.
Do you have any idea when this will be merge ?
Github user aliokan commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/134#issuecomment-158002551
I have signed Apache Individual Contributor License Agreement :)
https://people.apache.org/committer-index.html#unlistedclas Laurent
Deketelaere
--
I vote +1
* Verified archives via 'coho verify-archive'
* Verified tags
* Verified platform version
* Verified that blank app creates correctly with platform
* Verified that blank app can be successfully ran and built
* Verified update scenario
* Verified compatibility with core plugins (released
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/114
CB-10037 Add progress indicator to file-transfer manual tests
[Jira issue](https://issues.apache.org/jira/browse/CB-10037)
You can merge this pull request into a Git repository
63 matches
Mail list logo
