RE: [VOTE] 3.8.2 WP8 Release (Attempt 2)

+1 * Manually verified platform could be added, built and run (blank app) * Run mobilespec auto tests * Reviewed release notes and package version Thx! Sergey -Original Message- From: Alexander Sorokin (Akvelon) [mailto:v-als...@microsoft.com] Sent: Thursday, November 19, 2015 12:30 PM

[GitHub] cordova-ios pull request: CB-9827 Implement and expose PlatformApi...

Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-ios/pull/176#issuecomment-158425264 TODO: @sgrebnov to rebase on top of master, fetch latest changes from cordova-lib (preferences handling change, may be more), address Mefire notes --- If your

[GitHub] cordova-plugin-statusbar pull request: fix warning on IOS8

Github user jordancardwell commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/26#issuecomment-158415705 @jcesarmobile awesome, thanks for the update... and yeah I didn't notice this was for previous deprecations. But yeah I had updated

[GitHub] cordova-android pull request: CB-9971 Redirect gradlew stderr to c...

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-android/pull/240#issuecomment-158336605 Doesn't superspawn already return a promise whose output can be processed? Superspawn doesn't need to be modified. --- If your project is set up for it, you

[GitHub] cordova-plugin-inappbrowser pull request: CB-7696 Document target=...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/124 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-inappbrowser pull request: Fixed issues causing spi...

Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/121#issuecomment-158437372 Hey Ben, thank you for your patch - it looks good. I've just merged similar fix that was here before (#89) so please take a look whether spinner

[GitHub] cordova-plugin-inappbrowser pull request: CB-3750: Add loading spi...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/89 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-inappbrowser pull request: CB-3750: Add loading spi...

Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/89#issuecomment-158436013 Tested and merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugin-inappbrowser pull request: Update CDVInAppBrowser.m

Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/90#issuecomment-158438647 Thank you for your patch, I've just merged similar fix since it was here before (#89), please see if spinner now works fine and consider closing

[GitHub] cordova-plugin-inappbrowser pull request: CB-8534: Add support for...

Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/82#issuecomment-158460236 Verified and merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-inappbrowser pull request: CB-8534: Add support for...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/82 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-android pull request: CB-9971 Redirect gradlew stderr to c...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-android/pull/240#issuecomment-158453018 .It does, right, but there is two problems: 1. Superspawn returns output only _after_ the underlying process exits - if the build lasts long

Re: [DISCUSS] Cordova CLI & LIB 5.4.1 Release

On Fri, Nov 20, 2015 at 2:31 AM, Steven Gill wrote: > [...] > @David, I can review those changes. Can you send it as PRs and send me the > links. They can go out in the next tools release (soon)! > Sure, Pull-requests, re-opened here:

RE: [DISCUSS] Plugins release

Hi guys, Currently we have Android ~4.1.0 pinned in CLI but the file plugin (and all plugins that depend on file plugin) depends on Android@5.0.0 or higher, so after this release, this will fail: cordova platform add android cordova plugin add cordova-plugin-file The output would be:

[GitHub] cordova-plugin-inappbrowser pull request: Allow for navigateTo met...

GitHub user byrning opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/126 Allow for navigateTo method Adding this method allows for one to navigate to another URL while the inappbrowser is already open. You can merge this pull request into a Git

[GitHub] cordova-android pull request: CB-8917: Added pending plugin callba...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-android/pull/239#issuecomment-158471787 I will submit a PR that updates the camera plugin to use the save-restore API as well, which should fix CB-9189. I'll also take a look at the contacts plugin,

[GitHub] cordova-plugin-inappbrowser pull request: Allow for navigateTo met...

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/126#issuecomment-158486504 This will not work. There would need to be a native implementation to back this, and it would need to exist in all platforms. Try

[GitHub] cordova-android pull request: CB-8917: Added pending plugin callba...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-android/pull/239#issuecomment-158469875 Alright, I plan on merging this in soon. I want to do some more testing and write some plugin-side docs before I do, but since this PR's been open a while and

CVE-2015-5256: Apache Cordova vulnerable to improper application of whitelist restrictions

== CVE-2015-5256: Apache Cordova vulnerable to improper application of whitelist restrictions Severity: Medium Vendor: The Apache Software Foundation Versions Affected: Cordova Android 3.7.2 and earlier Description: Android

[GitHub] cordova-plugin-media-capture pull request: CB-8863 Fix block usage...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media-capture/pull/49 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

RE: [DISCUSS] cordova-wp8 patch release 3.8.2

Yeah, not a big deal. Just fix it on master On Nov 20, 2015 5:14 AM, "Sergey Grebnov (Akvelon)" wrote: > Hi guys, one thing I noticed is that Release notes incorrectly claims we > release 3.9.2 instead of 3.8.2, otherwise looks good. How critical is this? > - As for me I

[GitHub] cordova-plugin-statusbar pull request: CB-10047 fix iOS 8 deprecat...

GitHub user jcesarmobile opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/39 CB-10047 fix iOS 8 deprecated warnings Removed all references to self.viewController.interfaceOrientation, they weren’t really used on invertFrameIfNeeded and are

[GitHub] cordova-docs pull request: CB-8917: adding docs for Android lifecy...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/428#issuecomment-158500525 Added docs for the new plugin API --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-android pull request: CB-9971 Redirect gradlew stderr to c...

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-android/pull/240#issuecomment-158513479 I'm pretty sure we can modify this line: https://github.com/MarcDiethelm/superspawn/blob/master/lib/index.js#L166 to return both the stdout and stderr. To me

[GitHub] cordova-plugin-statusbar pull request: CB-10047 fix iOS 8 deprecat...

Github user jcesarmobile closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/39 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-plugin-statusbar pull request: CB-10047 fix iOS 8 deprecat...

GitHub user jcesarmobile opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/40 CB-10047 fix iOS 8 deprecated warnings Removed all references to self.viewController.interfaceOrientation, they weren’t really used on invertFrameIfNeeded and are

CVE-2015-5257 - Weak Randomization of BridgeSecret for Apache Cordova Android

=== CVE-2015-5257: Weak Randomization of BridgeSecret for Apache Cordova Android Severity: Low Vendor: The Apache Software Foundation Versions Affected: Cordova Android versions up to and including 3.6.4 Description: Cordova uses

[GitHub] cordova-plugin-statusbar pull request: fix warning on IOS8

Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/26#issuecomment-158506196 I've sent the new pull request https://github.com/apache/cordova-plugin-statusbar/pull/40 In fact, in the latest version on github,

[GitHub] cordova-plugin-media pull request: CB-8863 Fix block usage of self

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/76 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

RE: [DISCUSS] Plugins release

Manually update until we released tools with android 5 pinned. The failure is expected. Users will have to manually update to android 5 or use an older version of file. This was discussed before. Steps: * android 5 release * plugins release * tools release On Nov 20, 2015 8:26 AM, "Alexander

[GitHub] cordova-android pull request: CB-9971 Redirect gradlew stderr to c...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-android/pull/240#issuecomment-158328421 @dblotsky, i propose to proceed with current approach for now, otherwise we'll have to release 'cordova-common' with updated superspawn before this

[GitHub] cordova-plugin-file-transfer pull request: CB-10044 FileTransfer p...

Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/116#issuecomment-158329499 Hi @maortega, thanks for the contribution! A few notes on this: * I believe it is better to move new parameters to

[GitHub] cordova-plugin-file-transfer pull request: CB-10044 FileTransfer p...

Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/116#discussion_r45447454 --- Diff: src/ios/CDVFileTransfer.m --- @@ -259,13 +259,35 @@ - (NSURLRequest*)requestForUploadCommand:(CDVInvokedUrlCommand*)command

[GitHub] cordova-plugin-file-transfer pull request: CB-10044 FileTransfer p...

Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/116#issuecomment-158332458 Also the test should be extended to verify the data received by [the

[GitHub] cordova-plugin-inappbrowser pull request: CB-9445 Improves execute...

Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/125#issuecomment-158564977 tested and working fine --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-plugin-file pull request: CB-8863 [ios] Fix block usage of...

GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-plugin-file/pull/150 CB-8863 [ios] Fix block usage of self You can merge this pull request into a Git repository by running: $ git pull https://github.com/purplecabbage/cordova-plugin-file

[GitHub] cordova-plugin-file pull request: CB-8863 [ios] Fix block usage of...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/150 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-docs pull request: CB-8917: adding docs for Android lifecy...

Github user jasongin commented on the pull request: https://github.com/apache/cordova-docs/pull/428#issuecomment-158571671 Looks good. Very well-written! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-docs pull request: Website fixes

GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-docs/pull/429 Website fixes Each commit is a separate improvement. In general, this is what changed: - version dropdown now says "(Latest)" in a translated manner - some pages now have weights and

[GitHub] cordova-docs pull request: Website fixes

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/429#issuecomment-158571723 @riknoll please review when you have a moment! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-docs pull request: Fixing some styling issues and simplify...

GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-docs/pull/430 Fixing some styling issues and simplifying content on Contribute page. Went from this:

[GitHub] cordova-docs pull request: Website fixes

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/429 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature