Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/119
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/119
CB-10086 There are two spec.31 tests for file-transfer tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/co
Github user mbektchiev commented on the pull request:
https://github.com/apache/cordova-lib/pull/289#issuecomment-159824863
@stevengill do you think this can be merged now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user johncblandii commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-159810270
For real. This is a long running PR and should go through sooner than later.
---
If your project is set up for it, you can reply to this email and hav
These 5 plugins have been reverted:
- cordova-plugin-camera
- cordova-plugin-geolocation
- cordova-plugin-contacts
- cordova-plugin-file
- cordova-plugin-media
On Wed, Nov 25, 2015 at 2:45 PM, Steven Gill wrote:
> haha of course. Well this will give build a chance to add cordov
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-159777975
@purplecabbage conflicts resolved was just the version bump I put in
plugin.xml conflicting with the new version 2.0.0 bump in master, so completely
trivi
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-159767819
@ghenry22 Absolutely!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-159765780
@dduwab @snstarosciak - glad I was able to help you guys out a bit. Good
luck with your projects!
---
If your project is set up for it, you can reply to
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/74#issuecomment-159765701
These are really simple small fixes that do not change any default
behaviour but fix fairly critical use cases, like being able to play sounds
from a url
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-osx/pull/26
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-159765464
@purplecabbage - if I fix the conflicts with the latest updates in master
can this finally get merged? I can't see any reason for this to be held back?
GitHub user tripodsan opened a pull request:
https://github.com/apache/cordova-osx/pull/26
CB-9584 OSX: add config to enable webview debug menu
- not setting the debug menu, this can be done via `defaults`
- disabling the console override when WebKitDeveloperExtras is set.
You c
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/115#issuecomment-159752162
Other than the small comment above, this LGTM. DId you try it with
mobilespec? Did the new test fail with the old code and does it pass now?
---
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/115#discussion_r45929691
--- Diff: tests/tests.js ---
@@ -450,7 +450,7 @@ exports.defineAutoTests = function () {
expect(transfer.o
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/118#discussion_r45928789
--- Diff: tests/tests.js ---
@@ -450,7 +450,7 @@ exports.defineAutoTests = function () {
expect(transfer.o
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/118#discussion_r45928589
--- Diff: tests/tests.js ---
@@ -468,6 +468,8 @@ exports.defineAutoTests = function () {
it("filetransfer.spec.10
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/118#discussion_r45928488
--- Diff: src/windows/FileTransferProxy.js ---
@@ -152,6 +158,18 @@ exec(win, fail, 'FileTransfer', 'upload',
try {
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/118#discussion_r45928408
--- Diff: src/windows/FileTransferProxy.js ---
@@ -116,9 +118,13 @@ exec(win, fail, 'FileTransfer', 'upload',
//
haha of course. Well this will give build a chance to add cordova-android 5
support too then :)
On Wed, Nov 25, 2015 at 2:41 PM, julio cesar sanchez wrote:
> "the user is expected to pin the plugin version", yeah, it's expected, but
> I've seen at least 3 questions on the phonegap build forum an
"the user is expected to pin the plugin version", yeah, it's expected, but
I've seen at least 3 questions on the phonegap build forum and one on
stackoverflow related to this, and there are a ton like "My app is failing
now, I built it x time ago and it worked, I didn't change anything, so you
brok
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/117#discussion_r45927170
--- Diff: src/windows/FileTransferProxy.js ---
@@ -81,6 +81,8 @@ exec(win, fail, 'FileTransfer', 'upload',
var uploadId =
having trouble rolling latest back currently. npm seems to be having issues
with dist-tag. https://github.com/npm/npm/issues/10548
I'll revert as soon as I can. I've already pinged people at npm.
On Wed, Nov 25, 2015 at 2:26 PM, Parashuram N
wrote:
> +1 to having a way for pinning too.
>
>
+1 to having a way for pinning too.
-Original Message-
From: Shazron [mailto:shaz...@gmail.com]
Sent: Wednesday, November 25, 2015 2:23 PM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Revert Cordova plugins to work with default pinned
versions
+1 what Steve said. Let's make sure a
+1 what Steve said. Let's make sure all stakeholders take note of the
discuss threads for plugins, not just platforms, in the future so we
can nip this in the bud.
"Cordova should not be backtracking releases due to downstreams" ->
Steve's cli pinning proposal would solve the VS scenario in the
fu
With build, the user is expected to pin the plugin version when they add it
to their config.xml. Build is in the process of adding cordova-android@5
too.
Anyways, doing the revert now.
On Wed, Nov 25, 2015 at 2:06 PM, julio cesar sanchez wrote:
> This has hit phonegap build users too as cordova
This has hit phonegap build users too as cordova android 5 isn't released
there yet and people doesn't pin the plugin version
2015-11-25 22:38 GMT+01:00 Parashuram N :
> I agree that we should have brought this up during the DISCUSS phase.
>
> VS is preparing for a fix in the week of Dec 7 when w
I agree that we should have brought this up during the DISCUSS phase.
VS is preparing for a fix in the week of Dec 7 when we are anticipating Cordova
6 with ios9 and marshmallow support.
-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com]
Sent: Wednesday, November 25,
I think it is more reasonable to get users to explicitly update their
cordova-android to 5 than it is to get people who are using
cordova-android@5 now to be explicit about adding plugins versions which
are higher than what npm shows (assuming we set latest back to previous
release).
Most people w
Hi,
The latest Cordova plugin release [1] has some plugins like camera, contacts,
files, geolocation, etc. that require mailto:cordova-android@5.0.0 to work. The
latest released version of Cordova-cli does not pin
mailto:cordova-android@5.0.0, but instead pins cordova-android@4.1.1.
Scenario
Github user Justin-Credible commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/94#issuecomment-159703609
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user Justin-Credible commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/95#issuecomment-159703588
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/102#issuecomment-159687509
The 80px border is by design. I am planning a pr to make this customizable
via css.
Back button is an error, I believe there is a jira is
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/114
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Community growth starts by talking with those interested in your
project. ApacheCon North America is coming, are you?
We are delighted to announce that the Call For Presentations (CFP) is
now open for ApacheCon North America. You can submit your proposed
sessions at
http://events.linuxfoundation.o
Github user daserge commented on the pull request:
https://github.com/apache/cordova-labs/pull/9#issuecomment-159676223
Created https://issues.apache.org/jira/browse/CB-10080 for the disk-cache
issue.
---
If your project is set up for it, you can reply to this email and have your
rep
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-labs/pull/9
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/117
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user dduwab commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-159663127
@ghenry22 Thanks for the great example, I got it working. I was using
toURL() but changed it to toInternalURL() like your example. Now it plays the
sounds.
Github user napcat commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/102#issuecomment-159620500
Yes... that worked! =) The inappbrowser windows is now fully scaled, but
there's a border, with about 70/80px around the page. Is that supposed to
h
GitHub user alexbuijs opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/127
Fix syntax error when browserifying
When browserifying this plugin, aliasify throws an error:
```
events.js:141
throw er; // Unhandled 'error' event
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-plugin-contacts/pull/87
CB-5308 Return rawId instead of id when modifying existing contact
This fixes issue with updating existing contact, described in
[CB-5308](https://issues.apache.org/jira/bro
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/86#issuecomment-159562030
Merged in
https://github.com/apache/cordova-plugin-contacts/commit/617fb764bf1c7047cfe02cf346771dd7fa38ed40
Thanks, @purplecabbage
---
If yo
Github user vladimir-kotikov closed the pull request at:
https://github.com/apache/cordova-plugin-contacts/pull/86
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/117#issuecomment-159554231
LGTM :ship: at will
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/117#discussion_r45847057
--- Diff: src/windows/FileTransferProxy.js ---
@@ -81,6 +81,8 @@ exec(win, fail, 'FileTransfer', 'upload',
var upl
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/117#discussion_r45846690
--- Diff: src/android/FileTransfer.java ---
@@ -528,14 +528,18 @@ public void run() {
}
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/117#discussion_r45845885
--- Diff: src/android/FileTransfer.java ---
@@ -528,14 +528,18 @@ public void run() {
}
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/117#discussion_r45845760
--- Diff: src/android/FileTransfer.java ---
@@ -528,14 +528,18 @@ public void run() {
}
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/117#issuecomment-159550548
@daserge, don't forget to update plugin docs regarding this new behaviour
for Windows platform
---
If your project is set up for it, you
49 matches
Mail list logo
