Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/87#discussion_r46023669
--- Diff: tests/tests.js ---
@@ -37,23 +37,34 @@ exports.defineAutoTests = function() {
var MEDIUM_TIMEOUT = 3;
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/87#discussion_r46023545
--- Diff: src/android/ContactAccessorSdk5.java ---
@@ -1027,7 +1027,7 @@ else if (accounts.length > 1) {
private String modi
Please file an issue at:
http://issues.apache.org/jira/browse/CB
... so it can be tracked and evaluated by the devs, and you can be notified.
Sign up here:
https://issues.apache.org/jira/secure/Signup!default.jspa
Thanks!
On Thu, Nov 26, 2015 at 12:29 PM, Maxime Alexandre
wrote:
> Sorry, to
Sorry, to be more precise, it's so it will
include all the files inside the "myfolder". So i need to move the
"myfolder" into the root folder of my plugin because it's the "src", so it
could be found and copied with this exact same name in the "Ressources"
folder, so it will precisely create a "Re
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/115
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Ok... well because there is a "*shell.cp('-R', srcFile,
project.resources_dir);*" i managed to get my folder into XCode with the
correct name.
So i had to name the "src" folder with the name I want it to appear in the
"Ressources" folder (which is not so obvious because it's not working like
this
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/115#issuecomment-159983208
@dblotsky, thanks for reviewing!
Looks like the Android code does not need any changes - I confused
targetFile with source, which was not bein
Hello everyone,
I want to copy a resource file into a specific folder, not just into the
"Resources" folder (like "Resources/myfolder") but this is not working when
i define a ** into
my plugin.xml.
I checked the source code and the target attribute is not used in the
*cordova-lib/src/plugman/pla
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/115#issuecomment-15997
Yes, I've tested it with test-framework plugin.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/115#discussion_r46001338
--- Diff: tests/tests.js ---
@@ -450,7 +450,7 @@ exports.defineAutoTests = function () {
expect(transfer.on
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/87#discussion_r45991178
--- Diff: src/android/ContactAccessorSdk5.java ---
@@ -1027,7 +1027,7 @@ else if (accounts.length > 1) {
private String modifyContact
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/87#discussion_r45990446
--- Diff: tests/tests.js ---
@@ -358,44 +380,68 @@ exports.defineAutoTests = function() {
pending();
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/87#discussion_r45989334
--- Diff: tests/tests.js ---
@@ -37,23 +37,34 @@ exports.defineAutoTests = function() {
var MEDIUM_TIMEOUT = 3;
-
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/89#discussion_r45988996
--- Diff: src/ios/CDVContact.m ---
@@ -1324,6 +1324,7 @@ - (NSObject*)extractPhotos
NSMutableArray* photos = nil;
if (
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/90#issuecomment-159933019
LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/90#discussion_r45985736
--- Diff: src/ios/CDVContact.m ---
@@ -750,7 +750,9 @@ +
(CFStringRef)convertContactTypeToPropertyLabel:(NSString*)label
} else if (
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/90#discussion_r45985746
--- Diff: src/ios/CDVContact.m ---
@@ -787,7 +789,9 @@ +
(NSString*)convertPropertyLabelToContactType:(NSString*)label
} else if
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-plugin-contacts/pull/90
CB-3950 Do not replace custom labels with "Other" on contact save
https://issues.apache.org/jira/browse/CB-3950
You can merge this pull request into a Git repository by runn
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-plugin-contacts/pull/89
CB-6979 Don't create duplicates for extracted contacts photos
Fix for [CB-6979](https://issues.apache.org/jira/browse/CB-6979)
You can merge this pull request into a Git rep
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-plugin-contacts/pull/88
CB-9348 Fetch phoneNumbers and emails from linked contacts too
This fixes [CB-9348](https://issues.apache.org/jira/browse/CB-9348).
The idea here is to fetch `phoneN
GitHub user theju opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/64
Use the SplashScreenDelay on iOS
Refs https://issues.apache.org/jira/browse/CB-10079
You can merge this pull request into a Git repository by running:
$ git pull https://githu
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/102#issuecomment-159866283
I believe we have special option (documented) for this case
(fullscreen=yes) and two classes you can use to customize IAB popup look and
feel (`
Github user napcat commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/102#issuecomment-159858236
Hello, purplecabbage. Thank you for the information.
I changed the css to remove the border, but I'm assuming the border serves
as a way to
23 matches
Mail list logo
