[GitHub] cordova-plugin-file-transfer pull request: CB-9837 Add data URI su...

2015-12-09 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/122#issuecomment-163520007 Updated the docs, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-file-transfer pull request: CB-9837 Add data URI su...

2015-12-09 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/122#discussion_r47194431 --- Diff: src/windows/FileTransferProxy.js --- @@ -89,19 +179,141 @@ exec(win, fail, 'FileTransfer', 'upload', var isMultip

Re: [DISCUSS] cordova-plugin-inappbrowser release

2015-12-09 Thread Shazron
I will start the release process tomorrow. On Wed, Dec 9, 2015 at 4:31 PM, Shazron wrote: > There is a change in master that is needed so it doesn't break on > cordova-ios-4.0.0 > > https://issues.apache.org/jira/browse/CB-10173 ---

Re: [REVIEW] Draft of Apache Cordova Board Report Dec 2015

2015-12-09 Thread Shazron
Submitted. On Wed, Dec 9, 2015 at 6:07 PM, Shazron wrote: > Now that's an intriguing idea. I'll ask, I think the project is called > "whimsy" on Apache... > > On Wed, Dec 9, 2015 at 6:02 PM, Steven Gill wrote: >> Any chance we can get an api to use reporter? I would probably use it more >> if I

[GitHub] cordova-docs pull request: 'ccordova' is a typo

2015-12-09 Thread fanfare
GitHub user fanfare opened a pull request: https://github.com/apache/cordova-docs/pull/438 'ccordova' is a typo changed ccordova to cordova You can merge this pull request into a Git repository by running: $ git pull https://github.com/fanfare/cordova-docs patch-1 Alternativel

Re: [DISCUSS] Deprecate cordova-wp8

2015-12-09 Thread Sergio Nader
Thanks, Julio. I really have missed the answer. Regards! Sérgio Nader Skype: sergio.nader.br Tel: 55 11 9 9101 4590 ​www.brasilisdigital.com.br Tecnologia & Inovação​ On Thu, Dec 10, 2015 at 1:29 AM, Tommy Williams wrote: > +1 > > > > > > On 9 Dec 2015, at 9:45 AM, Jesse wrote: > > > >

Re: [DISCUSS] Deprecate cordova-wp8

2015-12-09 Thread Tommy Williams
+1 > On 9 Dec 2015, at 9:45 AM, Jesse wrote: > > Deprecation is not the end, just the beginning of it.

[GitHub] cordova-ios pull request: CB-10162 correct the paths for iOS icon ...

2015-12-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/182 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-plugin-file-transfer pull request: CB-9837 Add data URI su...

2015-12-09 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/122#issuecomment-163464535 Are base64-encoded files documented as supported by the file transfer API? --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-plugin-file-transfer pull request: CB-9837 Add data URI su...

2015-12-09 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/122#discussion_r47181683 --- Diff: src/windows/FileTransferProxy.js --- @@ -89,19 +179,141 @@ exec(win, fail, 'FileTransfer', 'upload', var isMulti

Re: [REVIEW] Draft of Apache Cordova Board Report Dec 2015

2015-12-09 Thread Shazron
Now that's an intriguing idea. I'll ask, I think the project is called "whimsy" on Apache... On Wed, Dec 9, 2015 at 6:02 PM, Steven Gill wrote: > Any chance we can get an api to use reporter? I would probably use it more > if I it was a simple command from coho as part of the release process :P >

Re: [REVIEW] Draft of Apache Cordova Board Report Dec 2015

2015-12-09 Thread Steven Gill
Any chance we can get an api to use reporter? I would probably use it more if I it was a simple command from coho as part of the release process :P Thanks for your hard work Shaz! On Wed, Dec 9, 2015 at 5:53 PM, Carlos Santana wrote: > You raised the bar :-) > > - Carlos > @csantanapr > > > On

Re: [REVIEW] Draft of Apache Cordova Board Report Dec 2015

2015-12-09 Thread Carlos Santana
You raised the bar :-) - Carlos @csantanapr > On Dec 9, 2015, at 8:18 PM, Shazron wrote: > > Haha thanks everyone but I've got a great community behind it -- also > I have reporter.apache.org on my side these few times :D > > I used to gather this manually, but the Apache ppl have decided to

Re: [REVIEW] Draft of Apache Cordova Board Report Dec 2015

2015-12-09 Thread Shazron
Haha thanks everyone but I've got a great community behind it -- also I have reporter.apache.org on my side these few times :D I used to gather this manually, but the Apache ppl have decided to create this tool to help all the reporters (probably based on my input/report, most like, but who knows.

Re: [REVIEW] Draft of Apache Cordova Board Report Dec 2015

2015-12-09 Thread Jesse
Even knowing his tricks, I feel the same way! Looks good. +1 @purplecabbage risingj.com On Wed, Dec 9, 2015 at 4:54 PM, Carlos Santana wrote: > Looks Good +1 > > I don't get tired of saying it, Shaz I'm amazed how are you able to > collect and organize this info. Great job > > - Carlos > @csan

Re: [REVIEW] Draft of Apache Cordova Board Report Dec 2015

2015-12-09 Thread Carlos Santana
Looks Good +1 I don't get tired of saying it, Shaz I'm amazed how are you able to collect and organize this info. Great job - Carlos @csantanapr > On Dec 9, 2015, at 7:34 PM, Joe Bowser wrote: > > LGTM > >> On Wed, Dec 9, 2015 at 4:23 PM, Anis KADRI wrote: >> >> LGTM >> >>> On Wed, Dec 9,

Re: [REVIEW] Draft of Apache Cordova Board Report Dec 2015

2015-12-09 Thread Joe Bowser
LGTM On Wed, Dec 9, 2015 at 4:23 PM, Anis KADRI wrote: > LGTM > > On Wed, Dec 9, 2015 at 2:29 PM Shazron wrote: > > > Let me know if you have any comments, if there is anything I missed. I > > will send this out tomorrow morning. > > > > > https://github.com/cordova/apache-board-reports/blob/ma

[DISCUSS] cordova-plugin-inappbrowser release

2015-12-09 Thread Shazron
There is a change in master that is needed so it doesn't break on cordova-ios-4.0.0 https://issues.apache.org/jira/browse/CB-10173 - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-

Re: Purpose of pre_package hook for windows

2015-12-09 Thread So, Byoungro
I am not 100% sure, but as I looked at the code, it seems the original intention of pre_package hook is to allow users to make any necessary changes before we do windows-specific changes (for example adding BOM \ufeff in the source codes for windows store certification). Byoungro So SSG / DPD /

Re: [REVIEW] Draft of Apache Cordova Board Report Dec 2015

2015-12-09 Thread Anis KADRI
LGTM On Wed, Dec 9, 2015 at 2:29 PM Shazron wrote: > Let me know if you have any comments, if there is anything I missed. I > will send this out tomorrow morning. > > https://github.com/cordova/apache-board-reports/blob/master/2015/2015-12.md > > -

[REVIEW] Draft of Apache Cordova Board Report Dec 2015

2015-12-09 Thread Shazron
Let me know if you have any comments, if there is anything I missed. I will send this out tomorrow morning. https://github.com/cordova/apache-board-reports/blob/master/2015/2015-12.md - To unsubscribe, e-mail: dev-unsubscr...@cor

[GitHub] cordova-ios pull request: CB-10162 correct the paths for iOS icon ...

2015-12-09 Thread eymorale
Github user eymorale commented on the pull request: https://github.com/apache/cordova-ios/pull/182#issuecomment-163419109 Can do @tony-- . I'll add it in and merge it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

Re: Purpose of pre_package hook for windows

2015-12-09 Thread Jesse
I can't find any info on why we needed it ... it seems to be fired right before the files are added to the csproj, though I am not sure why. The only other person I think may know anything about it would be @sgrebnov The earliest JIRA ticket I could find on the issue [1] although the issue is jus

[GitHub] cordova-android pull request: Update theme to Theme.DeviceDefault....

2015-12-09 Thread dpogue
GitHub user dpogue opened a pull request: https://github.com/apache/cordova-android/pull/245 Update theme to Theme.DeviceDefault.NoActionBar This uses the device system theme instead of the old Gingerbread-era theme for dialogs and alerts. Available as of API 14, which is n

[GitHub] cordova-lib pull request: CB-9311 Add support for 87x87 icon, fix ...

2015-12-09 Thread tony--
Github user tony-- commented on the pull request: https://github.com/apache/cordova-lib/pull/354#issuecomment-163404133 Ok, thanks. Closing this as an incorrect fix and CB-9311 is being addressed by [apache/cordova-ios#182](https://github.com/apache/cordova-ios/pull/182). --- If yo

[GitHub] cordova-lib pull request: CB-9311 Add support for 87x87 icon, fix ...

2015-12-09 Thread tony--
Github user tony-- closed the pull request at: https://github.com/apache/cordova-lib/pull/354 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-plugin-file pull request: Allow setting data protection me...

2015-12-09 Thread spheroid-
GitHub user spheroid- opened a pull request: https://github.com/apache/cordova-plugin-file/pull/153 Allow setting data protection metadata on iOS This patch enables rudimentary support to set the NSFileProtectionKey property with FileEntry.setMetadata() on iOS. It passes the propert

[GitHub] cordova-lib pull request: CB-9311 Add support for 87x87 icon, fix ...

2015-12-09 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-lib/pull/354#issuecomment-163401759 no, never dumb it confused me as well at first -- yeah it was for the older platforms. We're trying to clean testing up so its less confusing esp with Platform API

[GitHub] cordova-lib pull request: CB-9311 Add support for 87x87 icon, fix ...

2015-12-09 Thread tony--
Github user tony-- commented on the pull request: https://github.com/apache/cordova-lib/pull/354#issuecomment-163396804 Right, I wasn't thinking about that - thanks @shazron. So... is this code here for backwards compatibility? Or it just hasn't been removed yet? Sorry for the dumb

[GitHub] cordova-ios pull request: CB-10162 correct the paths for iOS icon ...

2015-12-09 Thread tony--
Github user tony-- commented on the pull request: https://github.com/apache/cordova-ios/pull/182#issuecomment-163395756 If it's not too late, consider updating the URL to: https://developer.apple.com/library/ios/documentation/UserExperience/Conceptual/MobileHIG/IconMatrix.html

Purpose of pre_package hook for windows

2015-12-09 Thread Vladimir Kotikov (Akvelon)
Hi, guys. Could anyone please shed some light on the subject? Looking into PR for 'nohooks' option [1] I realized that we have a logic in Windows/wp8 parsers that fires a hooks, specific for these particular platforms. I see 2 problems with this: 1. This doesn't fits well into the concep

[GitHub] cordova-ios pull request: CB-10162 correct the paths for iOS icon ...

2015-12-09 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/182#issuecomment-163363203 Thanks everyone. Can you merge to master and also cherry-pick to branch 4.0.x --- If your project is set up for it, you can reply to this email and have your repl

Re: [DISCUSS] cordova-ios-4.x release (for real)

2015-12-09 Thread Shazron
Please label issues "cordova-ios-4.0.1" for the upcoming patch release like so: https://issues.apache.org/jira/browse/CB-10162 On Tue, Dec 8, 2015 at 5:19 AM, Shazron wrote: > I removed the root node_modules in cordova-ios, and re-created the > archive. They are re-published at: > https://dist.ap

[GitHub] cordova-windows pull request: CB-9828 Implements PlatformApi contr...

2015-12-09 Thread jasongin
Github user jasongin commented on the pull request: https://github.com/apache/cordova-windows/pull/132#issuecomment-163355408 Refactoring logging into common sounds good, but we shouldn't block this change on it. --- If your project is set up for it, you can reply to this email and h

[GitHub] cordova-ios pull request: CB-9311 CB-10162 fixes app icon 87x87 an...

2015-12-09 Thread csantanapr
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-ios/pull/183#issuecomment-163343873 closing this one since #182 fixed it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] cordova-ios pull request: CB-10162 correct the paths for iOS icon ...

2015-12-09 Thread csantanapr
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-ios/pull/182#issuecomment-163343647 @eymorale LGTM go ahead and merge it, I will close mine #183 --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] cordova-ios pull request: CB-9311 CB-10162 fixes app icon 87x87 an...

2015-12-09 Thread csantanapr
Github user csantanapr closed the pull request at: https://github.com/apache/cordova-ios/pull/183 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-docs pull request: Adding Search Button

2015-12-09 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/435#issuecomment-16417 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cordova-lib pull request: CB-8455 added --nohooks option

2015-12-09 Thread bso-intel
Github user bso-intel commented on the pull request: https://github.com/apache/cordova-lib/pull/353#issuecomment-163324816 Hi Vladmir, Exactly. The pre-package hooks on for the windows* platforms run when LIB prepares for the source. To suppress this hook, HookRunner n

[GitHub] cordova-plugin-contacts pull request: CB-10117 Added new tests

2015-12-09 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/99 CB-10117 Added new tests https://issues.apache.org/jira/browse/CB-10117 You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenT

[GitHub] cordova-labs pull request: CB-9837 Add data URI support to file-tr...

2015-12-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-labs/pull/11 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-ios pull request: CB-10162 correct the paths for iOS icon ...

2015-12-09 Thread eymorale
Github user eymorale commented on the pull request: https://github.com/apache/cordova-ios/pull/182#issuecomment-163319161 @csantanapr I have updated my pull request per your comments and suggestions --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-labs pull request: CB-9837 Add data URI support to file-tr...

2015-12-09 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-labs/pull/11 CB-9837 Add data URI support to file-transfer upload on iOS Increases direct upload limit to the test image size [Jira issue](https://issues.apache.org/jira/browse/CB-9837) You can mer

[GitHub] cordova-plugin-file-transfer pull request: CB-9837 Add data URI su...

2015-12-09 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/122 CB-9837 Add data URI support to file-transfer upload on iOS Adds iOS and Windows implementation Adds corresponding tests [Jira issue](https://issues.apache.org/jira

[GitHub] cordova-plugin-camera pull request: [iOS] Fixed how checks access ...

2015-12-09 Thread m-revetria
Github user m-revetria commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/146#issuecomment-163315077 @riknoll Hi, just to let you know that my signed ICLA has been filed in the Apache Software Foundation records. --- If your project is set up for it,

[GitHub] cordova-plugin-contacts pull request: CB-10131 Fixed null contact ...

2015-12-09 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/98#issuecomment-163284932 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] cordova-plugin-contacts pull request: CB-10131 Fixed null contact ...

2015-12-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/98 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-contacts pull request: CB-10131 Fixed null contact ...

2015-12-09 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/98 CB-10131 Fixed null contact creation You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-contacts CB-101

[GitHub] cordova-windows pull request: CB-9828 Implements PlatformApi contr...

2015-12-09 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-windows/pull/132#issuecomment-163206085 Addressed notes and fixed compatibility w/Node@0.12 Regarding logging, agree, we should move it common, but i propose to follow more general wa

[GitHub] cordova-lib pull request: CB-8455 added --nohooks option

2015-12-09 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/353#issuecomment-163182113 Isn't hooks is a CLI/LIB feature? As far as I remember, hooks fired by LIB except for `pre_package` hook for wp8/windows, so probably there is no need to p

[GitHub] cordova-android pull request: CB-10140 Use application id instead ...

2015-12-09 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-android/pull/244#issuecomment-163165235 @CookieCookson, LGTM, though I'm not sure about situations when this would be useful. However the problem here is that aapt might be not in the

[GitHub] cordova-android pull request: CB-10140 Use application id instead ...

2015-12-09 Thread CookieCookson
GitHub user CookieCookson opened a pull request: https://github.com/apache/cordova-android/pull/244 CB-10140 Use application id instead of package name when running You can merge this pull request into a Git repository by running: $ git pull https://github.com/CookieCookson/co

[GitHub] cordova-plugin-splashscreen pull request: Fixed installation instr...

2015-12-09 Thread gtczap
Github user gtczap closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/40 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if