GitHub user bso-intel opened a pull request:
https://github.com/apache/cordova-lib/pull/355
Cb 7183
CB-7183 security check for the scriptSrc property of the engine tag.
The other src and target-dir path escape checks are already implemented in
cordova-lib/src/plugman/pl
Github user gregavola commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-164110076
Does anyone have docs on how this works?
Greg
Sent from my iPhone
> On Dec 11, 2015, at 6:50 PM, Bnaya Peretz
wrote:
>
Your proposal about deprecating the 'pre_package' hook looks good to me.
People (or plugins) who have been using the 'pre_package' hooks will have time
to adjust their projects/plugins.
I think the undecided 'before_browserify' hook could be added in the LIB side
instead of the 'new' platform.
T
+1 Looks good!
@purplecabbage
risingj.com
On Fri, Dec 11, 2015 at 4:08 PM, Carlos Santana
wrote:
> LGTM
> On Fri, Dec 11, 2015 at 3:43 PM Shazron wrote:
>
> > Updated blog post:
> >
> >
> https://github.com/shazron/cordova-docs/blob/iab-1.1.1/www/_posts/2015-12-10-plugins-release.md
> >
> > I
LGTM
On Fri, Dec 11, 2015 at 3:43 PM Shazron wrote:
> Updated blog post:
>
> https://github.com/shazron/cordova-docs/blob/iab-1.1.1/www/_posts/2015-12-10-plugins-release.md
>
> In PR:
> https://github.com/apache/cordova-docs/pull/439
>
> On Fri, Dec 11, 2015 at 10:00 AM, Carlos Santana
> wrote:
Github user Bnaya commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-164083116
You can find more info here:
https://issues.apache.org/jira/browse/CB-8917
---
If your project is set up for it, you can reply to this email and have yo
Github user thehuijb commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-164077925
@Bnaya, thanks for the heads up. Don't know how I missed that, but great
that this issue is finally tackled
---
If your project is set up for it, you c
Github user Bnaya commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-164076417
@thehuijb this issue was solved in the platform level in
https://github.com/apache/cordova-android/commit/f5271431fbcda70188f485d9e91541bb596551fe
+
Github user thehuijb commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-164073745
@sebastianor, if you're asking if this pull request solves the issue, yes
it does.
just call the checkForSavedResult method in onDeviceReady to see if
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/122#issuecomment-164065701
Ah, gotcha. Thanks for the explanation. If the tests pass, then it LGTM!
---
If your project is set up for it, you can reply to this email and ha
Updated blog post:
https://github.com/shazron/cordova-docs/blob/iab-1.1.1/www/_posts/2015-12-10-plugins-release.md
In PR:
https://github.com/apache/cordova-docs/pull/439
On Fri, Dec 11, 2015 at 10:00 AM, Carlos Santana wrote:
> yep, it's better to release both together
>
>
> On Fri, Dec 11, 2015
I add comments on the docs structure to PR with notes why I think it that
way. This is based on my personal struggling with finding something on
docs, and other dumb questions which people asking on SO.
2015-12-11 20:40 GMT+06:00 Carlos Santana :
> yes I agree Reference your be top level at TOC,
+1
* tested in app
* ran coho verify-archive
On Fri, Dec 11, 2015 at 9:17 AM, Carlos Santana
wrote:
> +1
>
> Verify the fix for the compile error
> created app and tested inappbrowser
> Use coho verify-tags
> Recreated the archive and compare contents using coho create-archive
>
>
> On Thu, Dec
+1
* tested in app
* ran coho verify-archive
On Fri, Dec 11, 2015 at 10:29 AM, Carlos Santana
wrote:
> vote +1
>
> Use coho verify-archive
> Use coho create-archive and compare contents
> Use coho verify-tags
> tested app with inappbrowser 1.1.1 and cordova-ios@4 and wkwebview 1.0.1
>
>
> On Fr
Thanks Philipp,
We have looked at this in the past. Attempts to 'fix' this will likely
fail, and take us in the wrong direction.
The goal is browserify as the mainstream way of packaging js, in which case
everything is in one file.
If you have scientific evidence of an issue, please post it, other
vote +1
Use coho verify-archive
Use coho create-archive and compare contents
Use coho verify-tags
tested app with inappbrowser 1.1.1 and cordova-ios@4 and wkwebview 1.0.1
On Fri, Dec 11, 2015 at 1:10 PM Shazron wrote:
> Please review and vote on the release of this plugins release
> by replyin
Please review and vote on the release of this plugins release
by replying to this email (and keep discussion on the DISCUSS thread)
Release issue: https://issues.apache.org/jira/browse/CB-10191
The plugins have been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/CB-10191/
https://issues.apache.org/jira/browse/CB-10191
On Fri, Dec 11, 2015 at 9:22 AM, Shazron wrote:
> Because of this: https://issues.apache.org/jira/browse/CB-10190
>
> I will be putting out a patch release. This is related to the
> InAppBrowser release failing with WKWebView plugin (IAB is ok, it's
yep, it's better to release both together
On Fri, Dec 11, 2015 at 12:24 PM Shazron wrote:
> See [DISCUSS] for wkwebview-engine 1.0.1 release. I will amend the
> blog post to include the wkwebview-engine release, for simultaneous
> release.
>
> On Fri, Dec 11, 2015 at 9:04 AM, Carlos Santana
>
See [DISCUSS] for wkwebview-engine 1.0.1 release. I will amend the
blog post to include the wkwebview-engine release, for simultaneous
release.
On Fri, Dec 11, 2015 at 9:04 AM, Carlos Santana wrote:
> LGTM
>
> On Fri, Dec 11, 2015 at 8:13 AM Homer, Tony wrote:
>
>> LGTM
>>
>>
>>
>>
>> On 12/10/1
Because of this: https://issues.apache.org/jira/browse/CB-10190
I will be putting out a patch release. This is related to the
InAppBrowser release failing with WKWebView plugin (IAB is ok, it's
the WKWebView plugin's fault)
-
To
+1
Verify the fix for the compile error
created app and tested inappbrowser
Use coho verify-tags
Recreated the archive and compare contents using coho create-archive
On Thu, Dec 10, 2015 at 7:14 PM Shazron wrote:
> Please review and vote on the release of this plugins release
> by replying to
LGTM
On Fri, Dec 11, 2015 at 8:13 AM Homer, Tony wrote:
> LGTM
>
>
>
>
> On 12/10/15, 7:43 PM, "Shazron" wrote:
>
> >Please comment and review:
> >https://github.com/apache/cordova-docs/pull/439
> >
> >-
> >To unsubscribe, e-ma
OK it looks like Julio, Shaz, and me figure out what's going on.
The InAppBrowser is good to go.
On Fri, Dec 11, 2015 at 9:08 AM Carlos Santana wrote:
> Hi I'm working on verifying the vote.
>
> InAppBrowser doesn't load the web page when using wkwebview. What I'm
> doing wrong or is inappbrow
Github user sebastianor commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-163963386
So, there is any way to resolve this problem ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Oh I'm late on this thread.
Latest code is in master cordova-cli and cordova-lib
you have to link lib to cli to get it to show up.
if you are lazy like me you can do "npm install -g
csantanapr/cordova-cli-dev"
To see the help "cordova help create"
--template= ... use a custom template located
loc
yes I agree Reference your be top level at TOC, I left other comments in
the PR
On Thu, Dec 10, 2015 at 3:28 PM Dmitry Blotsky
wrote:
> Hey folks,
>
> Please take a look at the PR discussing this proposal:
> https://github.com/cordova/cordova-discuss/pull/31.
>
> Personally, I’d like to solicit
Can you open a JIRA and explain with more details what is taking most of
the time when loading?
Are the plugins taking time to load are core cordova plugins (i.e. camera,
device, etc..)?
We try to keep our scripts for clobbers/run/merge very light with no much
work.
You want to delay the injectio
Hi I'm working on verifying the vote.
InAppBrowser doesn't load the web page when using wkwebview. What I'm doing
wrong or is inappbrowser not supported in wekwebview, was not able to tell
from the limitations.
I remove the wkwebview plugin, and try InAppBrowser and it works.
Just doing this:
co
LGTM
On 12/10/15, 7:43 PM, "Shazron" wrote:
>Please comment and review:
>https://github.com/apache/cordova-docs/pull/439
>
>-
>To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>For additional commands, e-mail: dev-h
GitHub user pbakondy opened a pull request:
https://github.com/apache/cordova-docs/pull/440
fix typo
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pbakondy/cordova-docs master
Alternatively you can review and apply these chang
So, the only problem here is when plugin (or user) decides to modify www files,
they won't be BOMed by platform. This can be workarounded by moving 'add_bom'
logic from prepare to build in PlatformApi for Windows. This way BOM will still
be added _after_ 'pre_package'.
Regarding the fact that
>
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-windows/pull/132#issuecomment-163880842
This was merged in
[58047a3](https://git1-us-west.apache.org/repos/asf?p=cordova-windows.git;a=commit;h=58047a3daf21dbd046a6354bf748b83f3ae7b5b9)
---
Github user vladimir-kotikov closed the pull request at:
https://github.com/apache/cordova-windows/pull/132
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
34 matches
Mail list logo
