[GitHub] cordova-plugin-file-transfer pull request: CB-10208 Fix file-trans...

2015-12-17 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/123 CB-10208 Fix file-transfer multipart form data upload format on Windows [Jira issue](https://issues.apache.org/jira/browse/CB-10208) You can merge this pull request into a Git

[GitHub] cordova-plugin-file-transfer pull request: CB-10208 Fix file-trans...

2015-12-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/123 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-labs pull request: CB-10080 Rewrite file-transfer server n...

2015-12-17 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-labs/pull/12#issuecomment-165413593 @dblotsky, @jasongin, @stevengill, could you please take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on

Re: [DISCUSS] cordova-ios 4.0.1 release

2015-12-17 Thread Carlos Santana
Ignore the last two emails, I was talking to my self :-) I got it fix on my end with $ git fetch --tags not passing --tags didn't do it On Thu, Dec 17, 2015 at 8:18 AM Carlos Santana wrote: > false alarm, I think the problem is on my local repo tags not correct. > > On

Re: [DISCUSS] cordova-ios 4.0.1 release

2015-12-17 Thread Carlos Santana
Attempt has a problem. Hashes don't match! 4.0.1 tag needs to be move to commit 7890eae664 4.0.1 tag currently points to e40a776 at two commits behind 4.0.1/4.0.x  $ coho verify-tags -r ios --tag 4.0.1 Running from /Users/csantana23/Documents/dev/cordova Paste in print-tags output then hit

Re: [DISCUSS] cordova-ios 4.0.1 release

2015-12-17 Thread Shazron
Great :) I was just going to reply you were wrong :) On Thu, Dec 17, 2015 at 5:19 AM, Carlos Santana wrote: > Ignore the last two emails, I was talking to my self :-) > I got it fix on my end with $ git fetch --tags > not passing --tags didn't do it > > On Thu, Dec 17,

Re: [DISCUSS] cordova-ios 4.0.1 release

2015-12-17 Thread Carlos Santana
false alarm, I think the problem is on my local repo tags not correct. On Thu, Dec 17, 2015 at 8:14 AM Carlos Santana wrote: > Attempt has a problem. > > Hashes don't match! > > 4.0.1 tag needs to be move to commit 7890eae664 > 4.0.1 tag currently points to e40a776 at two

[GitHub] cordova-plugin-splashscreen pull request: fix link to splash and i...

2015-12-17 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/63#issuecomment-165475604 @JhonataRibeiro, probably it will be more correct to change the link to the latest released version?

[GitHub] cordova-plugin-inappbrowser pull request: CB-10009 Improve InAppBr...

2015-12-17 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/129 CB-10009 Improve InAppBrowser toolbar look and feel on Windows https://issues.apache.org/jira/browse/CB-10009 Solution is based on `Segoe UI Symbol` which is available

Re: [VOTE] 4.0.1 iOS Release (attempt 2)

2015-12-17 Thread Carlos Santana
I vote +1 Review code changes in commits Use coho verify-tags Use coho create-archive and compare contents Created app using uiwenview Created app using wkwebview Correct version 4.0.1 is reported using CLI and Runtime On Wed, Dec 16, 2015 at 5:48 PM Shazron wrote: > Please

[GitHub] cordova-ubuntu pull request: CB-10119 - Can't install click chroot...

2015-12-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ubuntu/pull/20 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-splashscreen pull request: Set scale type to CENTER...

2015-12-17 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/52#issuecomment-165483853 @trancee, if the image is smaller than the screen size it will not be scaled so there will be black area/stripes around it - I believe it is not the

[GitHub] cordova-ubuntu pull request: CB-10119 - Can't install click chroot...

2015-12-17 Thread david-barth-canonical
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-ubuntu/pull/20 CB-10119 - Can't install click chroot 14.10 Fix for CB-10119, switching the default framework to 15.04 Also a fix for check_reqs which was referencing a function that has

Re: [REVIEW] cordova-ios 4.0.1 blog post

2015-12-17 Thread Carlos Santana
+1 - Carlos @csantanapr > On Dec 17, 2015, at 1:30 PM, Shazron wrote: > > https://github.com/apache/cordova-docs/pull/441 > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional

[REVIEW] cordova-ios 4.0.1 blog post

2015-12-17 Thread Shazron
https://github.com/apache/cordova-docs/pull/441 - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Added Cordova iOS 4.0.1 blog post

2015-12-17 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-docs/pull/441 Added Cordova iOS 4.0.1 blog post You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-docs ios-4.0.1 Alternatively you can

[Vote] 4.3.2 Ubuntu Release

2015-12-17 Thread David Barth
Please review and vote on this 4.3.2 Ubuntu Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-10210 The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-10210/ The

Re: [DISCUSS] Cordova-Ubuntu Release

2015-12-17 Thread Shazron
Note that: cordova platform add https://github.com/apache/cordova-ubuntu#4.3.2 will not work yet, the tag hasn't been mirrored to Github. Do a: cordova platform add https://git-wip-us.apache.org/repos/asf/cordova-ubuntu.git#4.3.2 instead. --- On both OS X 10.11 and Ubuntu 15.10: I get an

Re: [REVIEW] cordova-ios 4.0.1 blog post

2015-12-17 Thread Jesse
+1 lgtm > On Dec 17, 2015, at 10:50 AM, Carlos Santana wrote: > > +1 > > - Carlos > @csantanapr > >> On Dec 17, 2015, at 1:30 PM, Shazron wrote: >> >> https://github.com/apache/cordova-docs/pull/441 >> >>

[GitHub] cordova-docs pull request: Fix typo : iOS -> Android

2015-12-17 Thread limhenry
GitHub user limhenry opened a pull request: https://github.com/apache/cordova-docs/pull/442 Fix typo : iOS -> Android You can merge this pull request into a Git repository by running: $ git pull https://github.com/limhenry/cordova-docs patch-1 Alternatively you can review

[GitHub] cordova-cli pull request: CB-8455 added --nohooks option

2015-12-17 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/230#discussion_r48002044 --- Diff: src/cli.js --- @@ -79,6 +79,7 @@ function cli(inputArgs) { , 'silent' : Boolean , 'experimental' : Boolean

[GitHub] cordova-lib pull request: CB-8455 added --nohooks option

2015-12-17 Thread bso-intel
Github user bso-intel commented on the pull request: https://github.com/apache/cordova-lib/pull/353#issuecomment-165619803 HI Jesse and Vladimir, If there is no more comment, could you pull my branch CB-8455 so the next Cordova release contains this feature? Thanks. --- If

[GitHub] cordova-lib pull request: Cb 7183

2015-12-17 Thread bso-intel
Github user bso-intel commented on the pull request: https://github.com/apache/cordova-lib/pull/355#issuecomment-165621005 Hi Shazron, Could you review this CB-7183? As we discussed we need some security check for plugins accessing outside the plugins directory. Please

[GitHub] cordova-cli pull request: CB-8455 added --nohooks option

2015-12-17 Thread bso-intel
Github user bso-intel commented on the pull request: https://github.com/apache/cordova-cli/pull/230#issuecomment-165622485 Hi Jesse and Vladimir, Could you review this together with my pull request in https://github.com/apache/cordova-lib/pull/353 for cordova-lib?

[DISCUSS] Cordova-Ubuntu Release

2015-12-17 Thread David Barth
Hi, I would like to do a quick interim release for cordova-ubuntu, in order to fix the default framework used. This bug is referenced here: https://issues.apache.org/jira/browse/CB-10119 I have created the release task here and am proceeding with

[GitHub] cordova-plugin-inappbrowser pull request: hack: very bad fix but j...

2015-12-17 Thread barryvdh
Github user barryvdh commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/71#issuecomment-165428808 Thanks, opening a popup twice (eg. on fast doubleclicking a button) will crash it. This prevents that :) --- If your project is set up for it,

[GitHub] cordova-plugin-splashscreen pull request: Set scale type to CENTER...

2015-12-17 Thread trancee
Github user trancee commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/52#issuecomment-165635319 @daserge, that is correct, but that is why you can set a background color to fill out the area around it. at least there should be an option if you