[GitHub] cordova-lib pull request: CB-8455 added --nohooks option

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/353#issuecomment-165732453 Looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-plugin-inappbrowser pull request: Open a new window on the...

GitHub user robario opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/130 Open a new window on the browser platform The URL is not supposed to change in the case of SPA. You can merge this pull request into a Git repository by running: $ git

[GitHub] cordova-plugin-splashscreen pull request: Set scale type to CENTER...

Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/52#issuecomment-165715932 Added a Jira issue: https://issues.apache.org/jira/browse/CB-10222 Add scaletype preference for Android splashscreen --- If your project is set up

[GitHub] cordova-cli pull request: CB-8455 added --nohooks option

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-cli/pull/230#issuecomment-165708524 @bso-intel, could you please update documentation as well --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-plugin-splashscreen pull request: Set scale type to CENTER...

Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/52#issuecomment-165710372 @trancee, the current implementation will also work if you have 'large margins (safe areas)' according to the docs: >

Re: [DISCUSS] Cordova-Ubuntu Release

Hmm, indeed... This is the same node_modules problem that affects other releases I think. I have used your recommendation to re-install the dependencies and re-uploaded an archive with the missing files : https://dist.apache.org/repos/dist/dev/cordova/CB-10210/ Then I verified on the list

Re: [Vote] 4.3.2 Ubuntu Release

I will ask for a re-vote on this, as I have pushed an updated archive with the missing node_modules. I also made a git commit (tag moved forward as well) with the missing directory as well. On Thu, Dec 17, 2015 at 11:12 PM, Shazron wrote: > -1 > See the exception I posted in

[GitHub] cordova-labs pull request: CB-10080 Rewrite file-transfer server n...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-labs/pull/12#discussion_r48029125 --- Diff: server.js --- @@ -11,6 +12,54 @@ var LATIN1_SYMBOLS = '¥§©ÆÖÑøøø¼'; var Iconv = require('iconv').Iconv; var iconv = new

[GitHub] cordova-labs pull request: CB-10080 Rewrite file-transfer server n...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-labs/pull/12#discussion_r48029078 --- Diff: server.js --- @@ -11,6 +12,54 @@ var LATIN1_SYMBOLS = '¥§©ÆÖÑøøø¼'; var Iconv = require('iconv').Iconv; var iconv = new

[GitHub] cordova-labs pull request: CB-10080 Rewrite file-transfer server n...

Github user daserge commented on the pull request: https://github.com/apache/cordova-labs/pull/12#issuecomment-165798576 @dblotsky, thanks for reviewing! [Addressed](https://github.com/daserge/cordova-labs/commit/091d64c57cb35ce3fe21042821abb30aad2bcb2a), please take a look.

[GitHub] cordova-labs pull request: CB-10080 Rewrite file-transfer server n...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-labs/pull/12#discussion_r48029256 --- Diff: server.js --- @@ -11,6 +12,54 @@ var LATIN1_SYMBOLS = '¥§©ÆÖÑøøø¼'; var Iconv = require('iconv').Iconv; var iconv = new

[GitHub] cordova-plugin-splashscreen pull request: Use the SplashScreenDela...

Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/64#issuecomment-165813016 @theju, thanks for this fix! A few notes on this: - Could you please add the fallback to default value for `splashDuration` (like the way it

Re: [VOTE] 4.0.1 iOS Release (attempt 2)

+1 Confirmed sigs & hashes with `coho verify-archive` Verified hash matches tag with `coho verify-tags` Re-created archive with `coho create-archive`, verified contents match release candidate Created app w/ `cordova platform add https://github.com/apache/cordova-ios#4.0.1` Ran on device and

[GitHub] cordova-plugin-splashscreen pull request: Get AutoHideSplashScreen...

GitHub user neo-clon opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/66 Get AutoHideSplashScreen from config.xml Get AutoHideSplashScreen from config.xml to manipulate when should be hide the splashscreen You can merge this pull request into a Git

Re: [Vote] 4.3.2 Ubuntu Release

David Close this vote and start a new a new thread with attempt 2 [VOTE] 4.3.2 Ubuntu release (attempt 2) On Fri, Dec 18, 2015 at 6:36 AM David Barth wrote: > I will ask for a re-vote on this, as I have pushed an updated archive with > the missing node_modules. I

[GitHub] cordova-js pull request: Fix CB-3785 - enable EventListener interf...

GitHub user rayshan opened a pull request: https://github.com/apache/cordova-js/pull/130 Fix CB-3785 - enable EventListener interface support This patch enables support for `EventListener` interface for `Channel.prototype.subscribe` / `unsubscribe`, based on the patch by @motorro

[GitHub] cordova-plugin-splashscreen pull request: CB-9977 iOS splashscreen...

GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/65 CB-9977 iOS splashscreen fading doesn't work anymore when autohide is… … set to false Fixes FadeSplashScreen to default to true [Jira

LVL integration

Hello, I'm in the final stages of development on my Cordova app and have been working my way through the Android pre-release to-do lists. I'm hung up on the bit about integrating Google Play Licensing. There is precious little information about this on the web. It seems that integrating the

[GitHub] cordova-labs pull request: CB-10080 Rewrite file-transfer server n...

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-labs/pull/12#issuecomment-165908889 LGTM. Thanks for addressing the comments! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-lib pull request: CB-8455 added --nohooks option

Github user bso-intel commented on the pull request: https://github.com/apache/cordova-lib/pull/353#issuecomment-165950086 Hi Vladimir, Thank you very much for reviewing. I addressed your feedback and added several unit tests in LIB and CLI. --- If your project is set up

[GitHub] cordova-cli pull request: CB-8455 added --nohooks option

Github user bso-intel commented on the pull request: https://github.com/apache/cordova-cli/pull/230#issuecomment-165950153 Hi Vladimir, Thank you for reviewing. I addressed your feedback, and updated the help doc, and created one unit test. --- If your project is set up