RE: [Vote] Windows 4.3.0 Release attempt 2

2016-01-13 Thread Sergey Grebnov (Akvelon)
The vote has failed. -Sergey -Original Message- From: Alexander Sorokin (Akvelon) [mailto:v-als...@microsoft.com] Sent: Wednesday, January 13, 2016 6:22 PM To: dev@cordova.apache.org Subject: RE: [Vote] Windows 4.3.0 Release attempt 2 There is a bug introduced in this release which preve

RE: [DISCUSS] Cordova-windows 4.3.0 release

2016-01-13 Thread Sergey Grebnov (Akvelon)
Vladimir is on sick leave, I will take a look on this as high priority thing today and restart the vote -Sergey -Original Message- From: Jesse [mailto:purplecabb...@gmail.com] Sent: Thursday, January 14, 2016 1:46 AM To: dev@cordova.apache.org Subject: Re: [DISCUSS] Cordova-windows 4.3.0

[GitHub] cordova-windows pull request: CB-10344 Fixed icons and splashscree...

2016-01-13 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/136#issuecomment-171542813 looks great, thank you a lot - will merge after fixing core windows install issue. PS. Can you also take a look if we can auto test this case please.

Re: Lisf to iPhone and iPad modelos

2016-01-13 Thread Carlos Santana
Looking forward to a pull request, I think it will be very helpful info to have I always end up using google when ever I need this info On Tue, Jan 5, 2016 at 1:58 PM Sergio Nader da Cunha Sardo < sergio.na...@gmail.com> wrote: > Thank you, Tony! Helped a lot. Definitely this info should somehow

Re: Introduction

2016-01-13 Thread Carlos Santana
Sean the steps for contribution look fine, jira, pull request, and tests Thanks for contributing On Wed, Jan 13, 2016 at 10:30 PM Carlos Santana wrote: > Welcome Sean > What's a pager? :-p > > On Wed, Jan 6, 2016 at 3:00 AM Sean Kelly wrote: > >> Thanks. I submitted a pull request for CB-7786,

Re: Introduction

2016-01-13 Thread Carlos Santana
Welcome Sean What's a pager? :-p On Wed, Jan 6, 2016 at 3:00 AM Sean Kelly wrote: > Thanks. I submitted a pull request for CB-7786, was there anything I > missed? > > SeanK > > > On Jan 4, 2016, at 11:48 AM, Shazron wrote: > > > > Welcome! Looking forward to contributions. Let us know if you ne

RE: [DISCUSS] Core Plugins and Android API 23

2016-01-13 Thread Richard Knoll
Hey all, This change has been merged into the file, camera, geolocation, and contacts plugins (media did not actually require any change). I was able to build and run mobilespec on cordova-android 4.0.0 and cordova-android's master. We should probably push for a plugins release soon, since ther

[GitHub] cordova-plugin-geolocation pull request: CB-10319 android: Adding ...

2016-01-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-geolocation/pull/66 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-geolocation pull request: CB-10319 android: Adding ...

2016-01-13 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/66#issuecomment-171495075 GPS randomly started working. I was able to test this properly after all on the device. --- If your project is set up for it, you can reply to this

[GitHub] cordova-plugin-geolocation pull request: CB-10319 android: Adding ...

2016-01-13 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/66#issuecomment-171492706 Okay, I feel confident that I've tested the code path. The above JIRA doesn't block the native code from executing, and I was able to step through th

[GitHub] cordova-plugin-contacts pull request: CB-10159 android: Adding res...

2016-01-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/97 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-contacts pull request: CB-10159 android: Adding res...

2016-01-13 Thread jasongin
Github user jasongin commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/97#issuecomment-171484812 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-inappbrowser pull request: Make WP respect location...

2016-01-13 Thread mvirkkunen
Github user mvirkkunen commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/134#issuecomment-171479628 As far as I could tell on Android at least it hides the bar with the back/next buttons. It would also be in line with how browsers such as Chrome

[GitHub] cordova-plugin-contacts pull request: CB-10159 android: Adding res...

2016-01-13 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/97#issuecomment-171471606 Rebased to master. Tested on Marshmallow device and Lollipop emulator. Also ran manual and auto mobilespec tests for both API levels with cordova-android

[GitHub] cordova-docs pull request: CB-10355: Add Python installation instr...

2016-01-13 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/454#issuecomment-171468547 Aside from the above comment, LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] cordova-docs pull request: CB-10355: Add Python installation instr...

2016-01-13 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/454#discussion_r49666289 --- Diff: README.md --- @@ -44,6 +44,37 @@ Run the commands from [this site][ruby_linux] that apply to your Linux distribut Verify the installatio

[GitHub] cordova-plugin-inappbrowser pull request: Make WP respect location...

2016-01-13 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/134#issuecomment-171465970 The WP version does not show a location bar, so this is irrelevant, hiding AppBar is not even close to the same thing. If you want to make WP

[GitHub] cordova-docs pull request: Cleaning up the 'plugin spec' documenta...

2016-01-13 Thread omefire
GitHub user omefire opened a pull request: https://github.com/apache/cordova-docs/pull/456 Cleaning up the 'plugin spec' documentation This is still in-flight. more commits to come before this PR can be pulled in. You can merge this pull request into a Git repository by running:

[GitHub] cordova-docs pull request: fix typo

2016-01-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/440 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-plugin-contacts pull request: CB-10159 android: Adding res...

2016-01-13 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/97#issuecomment-171463127 @jasongin please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-docs pull request: Updates to the install and uninstall do...

2016-01-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/444 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-plugin-geolocation pull request: CB-10319 android: Adding ...

2016-01-13 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/66#issuecomment-171461428 Looks like I'm seeing [this JIRA issue](https://issues.apache.org/jira/browse/CB-10338), which is preventing me from testing this. --- If your proj

Re: [DISCUSS] Cordova-windows 4.3.0 release

2016-01-13 Thread Jesse
Hi Vlad, There is something weird going on with the semver bundled, appveyor [1] is claiming that the build is failing since the addition of semver, and the same thing happened for me when I ran : `npm i` If however, I ran : `npm i semver` first, it works again. I think it is probably a permission

[GitHub] cordova-docs pull request: Update index.md

2016-01-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/445 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-docs pull request: Update index.md

2016-01-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/447 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-docs pull request: Update index.md

2016-01-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/448 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-docs pull request: Fixes a little typo.

2016-01-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/450 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-docs pull request: Update index.md

2016-01-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/451 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-docs pull request: CB-10355: Add Python installation instr...

2016-01-13 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/454#issuecomment-171458215 LGTM but I'll default to @dblotsky on this since he knows more about the docs dev environment than I do. --- If your project is set up for it, you can reply to th

[GitHub] cordova-docs pull request: Updating issues.md to add more details ...

2016-01-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/455 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-docs pull request: CB-10355: Add Python installation instr...

2016-01-13 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-docs/pull/454#issuecomment-171455108 @dblotsky @riknoll Can you please review these changes and accept the pull request? --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-docs pull request: Updating issues.md to add more details ...

2016-01-13 Thread nikhilkh
GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-docs/pull/455 Updating issues.md to add more details of --verbose flag You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-docs issues

[GitHub] cordova-docs pull request: CB-10355: Add Python installation instr...

2016-01-13 Thread sarangan12
GitHub user sarangan12 opened a pull request: https://github.com/apache/cordova-docs/pull/454 CB-10355: Add Python installation instructions to Readme.md file Modified the Readme.md file to include instructions for Python installation. This is done because Python is required for

Buildbot: buildslave cordova-osx-slave was lost

2016-01-13 Thread buildbot
The Buildbot working for 'ASF Buildbot' has noticed that the buildslave named cordova-osx-slave went away It last disconnected at Wed Jan 13 21:52:34 2016 (buildmaster-local time) The admin on record (as reported by BUILDSLAVE:info/admin) was 'Dmitry Blotsky '. Sincerely, The Buildbot http://

[GitHub] cordova-plugin-inappbrowser pull request: Make WP respect location...

2016-01-13 Thread mvirkkunen
GitHub user mvirkkunen opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/134 Make WP respect location=no The WP version reads the location parameter but seemingly never uses it. This would make it hide the "AppBar" with the back/next/exit buttons whic

[GitHub] cordova-plugin-camera pull request: CB-10319 android: Adding refle...

2016-01-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/151 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-camera pull request: CB-10319 android: Adding refle...

2016-01-13 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/151#issuecomment-171394616 Also tested mobilespec manual tests on a lollipop emulator with cordova-android's master and cordova-android 4.0.0. Again, only expected failures. I'm go

[GitHub] cordova-plugin-camera pull request: CB-10319 android: Adding refle...

2016-01-13 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/151#issuecomment-171382725 Tested with manual mobilespec tests on cordova-android's master and cordova-android 4.0.0 on a marshmallow device. The failures in those tests matched th

[GitHub] cordova-plugin-geolocation pull request: CB-10319 android: Adding ...

2016-01-13 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/66#issuecomment-171374468 @sgrebnov Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] cordova-plugin-contacts pull request: CB-10319 android: Adding ref...

2016-01-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/100 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

Re: Cordova CLI with Cordova iOS

2016-01-13 Thread julio cesar sanchez
Cordova ios 4 works with the 5.4.1 CLI The command is 'cordova build ios --device' Next release of the CLI will have ios 4.x.x as default El miércoles, 13 de enero de 2016, Dong, Jonathan escribió: > Hi folks, > > I’m a plugin developer who is working on implementing a Cordova iOS plugin > rec

Re: Cordova CLI with Cordova iOS

2016-01-13 Thread Simon MacDonald
Yes, there will be a new version of Cordova with updated versions of cordova ios and cordova android. However, I'm not sure if you problem is related to the cordova ios upgrade. Can you post a full build log somewhere? Simon Mac Donald http://hi.im/simonmacdonald On Wed, Jan 13, 2016 at 1:11 AM,

Cordova CLI with Cordova iOS

2016-01-13 Thread Dong, Jonathan
Hi folks, I’m a plugin developer who is working on implementing a Cordova iOS plugin recently. As Cordova iOS 4.0 has been tagged, I’m planning to write my plugin based on the newly upgraded iOS plugin interface. But unfortunately I found Cordova CLI latest version v5.4.1 does not support Cordo

[GitHub] cordova-windows pull request: CB-10344 Fixed icons and splashscree...

2016-01-13 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-windows/pull/136 CB-10344 Fixed icons and splashscreens parsing https://issues.apache.org/jira/browse/CB-10344 You can merge this pull request into a Git repository by running: $ git pull https://git

RE: [Vote] Windows 4.3.0 Release attempt 2

2016-01-13 Thread Alexander Sorokin (Akvelon)
There is a bug introduced in this release which prevents the user to add a custom icon to the app: https://issues.apache.org/jira/browse/CB-10344 I think we should fix it before releasing, I vote -1. -Original Message- From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com] Sen

[GitHub] cordova-plugin-inappbrowser pull request: Fix lint warnings

2016-01-13 Thread mbektchiev
Github user mbektchiev commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/120#issuecomment-171249916 Sorry for the delayed response. I reproduce it when I change the compileSdkVersion to 23 through the `target=android-23` line in `platf