[GitHub] cordova-plugin-inappbrowser pull request: Make WP respect location...

2016-01-14 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/134#issuecomment-171895107 That's what toolbar option makes on iOS toolbar: set to yes or no to turn the toolbar on or off for the InAppBrowser (defaults to yes)

[GitHub] cordova-plugin-inappbrowser pull request: Make WP respect location...

2016-01-14 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/134#issuecomment-171893568 You are correct, thanks for helping me to see it. The meaning of 'location' is somewhat vague. I will test this pr in the morning and me

[GitHub] cordova-plugin-splashscreen pull request: CB-9094: Smarter autohid...

2016-01-14 Thread dpolivy
Github user dpolivy commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/49#issuecomment-171885860 @daserge Unfortunately I don't believe AutoHideSplashScreen is implemented for Android. However, even if it were, I'm not sure it would address this

[GitHub] cordova-plugin-splashscreen pull request: CB-9094: Smarter autohid...

2016-01-14 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/49#issuecomment-171883205 @dpolivy, can we just use `` and `navigator.splashscreen.hide();` whenever the app is ready for achieving the same result? --- If your project is s

[GitHub] cordova-plugin-inappbrowser pull request: inappbrower plugin has b...

2016-01-14 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/131#issuecomment-171865288 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

Buildbot: buildslave cordova-windows-slave was lost

2016-01-14 Thread buildbot
The Buildbot working for 'ASF Buildbot' has noticed that the buildslave named cordova-windows-slave went away It last disconnected at Fri Jan 15 02:34:59 2016 (buildmaster-local time) The admin on record (as reported by BUILDSLAVE:info/admin) was 'Dmitry Blotsky '. Sincerely, The Buildbot htt

[GitHub] cordova-plugin-wkwebview-engine pull request: CB-10269: Replace co...

2016-01-14 Thread jamesandersen
GitHub user jamesandersen opened a pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/3 CB-10269: Replace cordova exec only when present in wkwebview You can merge this pull request into a Git repository by running: $ git pull https://github.com/james

Re: Late Response: Does Cordova make Developer happy

2016-01-14 Thread Shazron
Thanks for the data Joerg! Could you please file issues for items 2 and 3 at issues.cordova.io? I think issue 1 can be wrapped into 3. Issue 4 I'm not so sure since we don't want to play a game of "keeping up with the difference in distributions" but a general "Cordova is to [PhoneGap/Ionic/etc]

Buildbot: buildslave cordova-osx-slave was lost

2016-01-14 Thread buildbot
The Buildbot working for 'ASF Buildbot' has noticed that the buildslave named cordova-osx-slave went away It last disconnected at Fri Jan 15 01:22:25 2016 (buildmaster-local time) The admin on record (as reported by BUILDSLAVE:info/admin) was 'Dmitry Blotsky '. Sincerely, The Buildbot http://

[GitHub] cordova-plugin-inappbrowser pull request: inappbrower plugin has b...

2016-01-14 Thread ebaranov
Github user ebaranov commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/131#issuecomment-171822561 +1 for that PR, have the same issue --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-plugin-splashscreen pull request: CB-9094: Smarter autohid...

2016-01-14 Thread dpolivy
Github user dpolivy commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/49#issuecomment-171818850 @infil00p @stevengill Any possibility of getting a review on this? Thanks. --- If your project is set up for it, you can reply to this email and ha

RE: [DISCUSS] New Information Architecture for Cordova Website

2016-01-14 Thread Raghav Katyal
Hi everyone! Thanks for all the comments and inputs. I have incorporated them in the proposal and created Jira tasks to go ahead with the changes. You can find them here: https://issues.apache.org/jira/browse/CB-10354?jql=labels%20%3D%20Docs-6.x If anyone wants to help out, please feel free to

[DISCUSS] Plugin version fetching improvements

2016-01-14 Thread Richard Knoll
Hey all, I wanted to draw some attention to the proposal I have up on cordova-discuss for improving the way we fetch plugins from npm. The aim is to provide a robust way for plugins to specify their project requirements so that the CLI can fetch the correct version of a plugin based on the loca

Re: [DISCUSS] CocoaPods dependencies for iOS plugins

2016-01-14 Thread Carlos Santana
correct, at least from me I have had bandwidth to look into this again. but is something I think is valuable to have On Thu, Jan 14, 2016 at 5:14 PM Simon MacDonald wrote: > Looking at the JIRA there doesn't seem to have been any movement on > CocoaPod support for iOS, is my assumption correct?

[GitHub] cordova-docs pull request: CB-10363: Cleaning up the 'plugin spec'...

2016-01-14 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-docs/pull/456#issuecomment-171804282 @rakatyal can you please review these changes ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

RE: Buildbot: buildslave cordova-osx-slave was lost

2016-01-14 Thread Dmitry Blotsky
Sorry, folks. I was updating the Android SDK on both machines. -Original Message- From: build...@apache.org [mailto:build...@apache.org] Sent: Wednesday, January 13, 2016 1:58 PM To: dev@cordova.apache.org Subject: Buildbot: buildslave cordova-osx-slave was lost The Buildbot working for

[GitHub] cordova-plugin-camera pull request: [iOS] Fixed how checks access ...

2016-01-14 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/146#issuecomment-171801462 Thanks @m-revetria! @vladimir-kotikov when you get the chance, would you mind reviewing this? --- If your project is set up for it, you can reply to thi

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

2016-01-14 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-171800967 Awesome, thanks for doing that! Would you mind also incorporating the fix I commented on in the diff? --- If your project is set up for it, you can repl

[GitHub] cordova-docs pull request: CB-10355: Add Python installation instr...

2016-01-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/454 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-plugin-camera pull request: major bugs when user picture

2016-01-14 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/147#issuecomment-171800191 @nikhilkh is right; the issue you are referencing is [CB-9189](https://issues.apache.org/jira/browse/CB-9189). There was a fix for that merged recently a

Re: [DISCUSS] CocoaPods dependencies for iOS plugins

2016-01-14 Thread Simon MacDonald
Looking at the JIRA there doesn't seem to have been any movement on CocoaPod support for iOS, is my assumption correct? Simon Mac Donald http://hi.im/simonmacdonald On Mon, Oct 26, 2015 at 6:02 PM, Carlos Santana wrote: > Great ! > So in other words you are telling me RTFM :-p > On Mon, Oct 26

Re: [DISCUSS] Core Plugins and Android API 23

2016-01-14 Thread Carlos Santana
I agree with final compromise, I also had a discussion with Nikhil during holiday break offline and understood the situation, some 3rd party plugins are not open source and customers/devs don't move as fast as we wish, but having a CLI 6 with latest plugins being backwards compatible with lower And

Re: [DISCUSS] Cordova-windows 4.3.0 release

2016-01-14 Thread Carlos Santana
Vladimir get well soon. Sergey thanks for taking over +1 On Thu, Jan 14, 2016 at 10:15 AM Sergey Grebnov (Akvelon) < v-seg...@microsoft.com> wrote: > Cherry-picked the following two fixes and started new vote (attempt 3), > release notes and blogpost are not affected as those issues have been >

Re: Lisf to iPhone and iPad modelos

2016-01-14 Thread Carlos Santana
Hi Sergio To get started contributing check out this: http://cordova.apache.org/contribute/ If you are already familiar with github open a PR here: https://github.com/apache/cordova-plugin-device On Thu, Jan 14, 2016 at 9:44 AM Sergio Nader da Cunha Sardo < sergio.na...@gmail.com> wrote: > Hell

[GitHub] cordova-docs pull request: CB-10355: Add Python installation instr...

2016-01-14 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/454#issuecomment-171769710 I just setup my machine and these instructions are accurate for windows --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] cordova-plugin-camera pull request: major bugs when user picture

2016-01-14 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/147#issuecomment-171743036 This PR seems to be incorrect. We have a fix for this issue already committed and will release in the next cordova-android & camera plugin release. ---

[GitHub] cordova-windows pull request: CB-10234 Better error message when W...

2016-01-14 Thread rakatyal
Github user rakatyal commented on the pull request: https://github.com/apache/cordova-windows/pull/138#issuecomment-171738186 Looks good. Thanks Sergey. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-ios pull request: 4.0.x

2016-01-14 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/189#issuecomment-171737557 What is this pull request? Please close it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-docs pull request: CB-10355: Add Python installation instr...

2016-01-14 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-docs/pull/454#issuecomment-171732653 @dblotsky Can you check and merge when you have time? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[DISCUSS] Plugins Release

2016-01-14 Thread Steven Gill
Going to start a plugins release soon. Any blockers? Any high priority outstanding PRs you want us to look at before this release?

Re: [DISCUSS] Core Plugins and Android API 23

2016-01-14 Thread Steven Gill
Awesome! I'll kick up a discuss thread On Wed, Jan 13, 2016 at 5:42 PM, Richard Knoll wrote: > Hey all, > > This change has been merged into the file, camera, geolocation, and > contacts plugins (media did not actually require any change). I was able to > build and run mobilespec on cordova-andr

[GitHub] cordova-windows pull request: CB-10234 Better error message when W...

2016-01-14 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-windows/pull/138#issuecomment-171713713 @rakatyal FYI - LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

RE: [DISCUSS] Cordova-windows 4.3.0 release

2016-01-14 Thread Sergey Grebnov (Akvelon)
Cherry-picked the following two fixes and started new vote (attempt 3), release notes and blogpost are not affected as those issues have been recently introduced/fixed and don't affect previous versions. * CB-10344 Fixed icons and splashscreens parsing * CB-10356 "npm install" fails for cord

[Vote] Windwos 4.3.0 Release attempt 3

2016-01-14 Thread Sergey Grebnov (Akvelon)
Please review and vote on this 4.3.0 Windows Release (3nd attempt) by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-10299 The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/C

Re: Lisf to iPhone and iPad modelos

2016-01-14 Thread Sergio Nader da Cunha Sardo
Hello, Carlos. Never did a pull request. Where I can get some info to get started? Regards, ​​ Sérgio Nader Skype: sergio.nader.br Tel: 55 11 9 9101 4590 ​www.brasilisdigital.com.br Tecnologia & Inovação​ On Wed, Jan 13, 2016 at 10:56 PM, Carlos Santana wrote: > Looking forward to a p

[GitHub] cordova-windows pull request: CB-10234 Better error message when W...

2016-01-14 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-windows/pull/138 CB-10234 Better error message when Windows10 requires 'arch' flag This patch adds the following error message: ![image](https://cloud.githubusercontent.com/assets/981580/12324140/b9551

[GitHub] cordova-ios pull request: 4.0.x

2016-01-14 Thread wjpwu
GitHub user wjpwu opened a pull request: https://github.com/apache/cordova-ios/pull/189 4.0.x You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/cordova-ios 4.0.x Alternatively you can review and apply these changes as the p

[GitHub] cordova-windows pull request: CB-10344 Fixed icons and splashscree...

2016-01-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/136 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-windows pull request: CB-10356 "npm install" fails for cor...

2016-01-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/137 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-windows pull request: CB-10356 "npm install" fails for cor...

2016-01-14 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-windows/pull/137 CB-10356 "npm install" fails for cordova-windows https://issues.apache.org/jira/browse/CB-10356 You can merge this pull request into a Git repository by running: $ git pull https://gi