RE: [Vote] Windwos 4.3.0 Release attempt 3

I vote +1. * Verified archives via `coho verify-archive` * Verified tags manually * Verified that blank app creates correctly with platform * Verified that blank app can be successfully built and ran * Verified that platform can be updated from previous version * Verified compatibility with core

[GitHub] cordova-plugin-splashscreen pull request: CB-9516 Android SplashSc...

GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/75 CB-9516 Android SplashScreen - Spinner Does Not Display [Jira issue](https://issues.apache.org/jira/browse/CB-9516) Removes spinnerStop call from onMessage("spinner",

[GitHub] cordova-plugin-inappbrowser pull request: Fix for CB-8180 and CB-1...

GitHub user infil00p opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/135 Fix for CB-8180 and CB-10104, ids are required for layout We need to review the URIs before the page loads, not after. The custom URIs should work now. You can merge this

[GitHub] cordova-plugin-inappbrowser pull request: Fix lint warnings

Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/120#issuecomment-172064857 We can't remove the lines, because it screws up the layout of the native ui elements. We have to make sure that we cast these literals to

Re: [DISCUSS] Core Plugins and Android API 23

So, what does the timeline look like for a Plugins release. I just did a major change in the InAppBrowser to fix tel: and sms: URIs so they do stuff, and it'd be cool if this also made if this got looked over and landed before the next release.

[GitHub] cordova-plugin-inappbrowser pull request: Fix for CB-8180 and CB-1...

Github user infil00p closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/135 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-plugin-inappbrowser pull request: Fix lint warnings

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/120 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

Re: [Vote] Windwos 4.3.0 Release attempt 3

+1 * Verified archives via `coho verify-archive` * Verified that blank app creates correctly with platform * Verified that blank app can be successfully built and ran * Verified 'npm i' works @purplecabbage risingj.com On Fri, Jan 15, 2016 at 4:54 AM, Alexander Sorokin (Akvelon) <

[GitHub] cordova-plugin-inappbrowser pull request: CB-8180: Changing method...

GitHub user infil00p opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/136 CB-8180: Changing methods of interception in WebViewClient class You can merge this pull request into a Git repository by running: $ git pull

Re: [DISCUSS] Core Plugins and Android API 23

Sorry, wrong PR: https://github.com/apache/cordova-plugin-inappbrowser/pull/136 On Fri, Jan 15, 2016 at 11:42 AM, Joe Bowser wrote: > So, what does the timeline look like for a Plugins release. I just did a > major change in the InAppBrowser to fix tel: and sms: URIs so they

Re: [DISCUSS] Core Plugins and Android API 23

LGTM +1 Simon Mac Donald http://hi.im/simonmacdonald On Fri, Jan 15, 2016 at 4:32 PM, Joe Bowser wrote: > Sorry, wrong PR: > https://github.com/apache/cordova-plugin-inappbrowser/pull/136 > > On Fri, Jan 15, 2016 at 11:42 AM, Joe Bowser wrote: > > > So,

[GitHub] cordova-docs pull request: CB-10367 Add meaningful names to headin...

GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-docs/pull/457 CB-10367 Add meaningful names to heading anchors in Docs & show a link on hover

[GitHub] cordova-docs pull request: CB-10367 Add meaningful names to headin...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/457#issuecomment-172105070 @dblotsky to help review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-plugin-inappbrowser pull request: CB-8180: Changing method...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/136 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-inappbrowser pull request: CB-8180: Changing method...

Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/136#issuecomment-172109936 Neat, that actually worked! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[VOTE] Plugins Release! Jan 15, 2016

Please review and vote on the release of this plugins release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-10368 The plugins have been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-10368/

[GitHub] cordova-plugin-splashscreen pull request: CB-9094: Smarter autohid...

Github user dpolivy commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/49#issuecomment-172130564 @daserge That PR looks reasonable to me. I might be able to work around this bug by setting `AutoHideSplashScreen` to `false` when it is supported

[GitHub] cordova-coho pull request: Update plugins-release-process.md

GitHub user stevengill opened a pull request: https://github.com/apache/cordova-coho/pull/108 Update plugins-release-process.md You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-coho patch-45 Alternatively you

[GitHub] cordova-coho pull request: added step to push release branches to ...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/109 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-coho pull request: added step to push release branches to ...

GitHub user stevengill opened a pull request: https://github.com/apache/cordova-coho/pull/109 added step to push release branches to apache You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-coho patch-46

[GitHub] cordova-coho pull request: Update plugins-release-process.md

Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/108 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-windows pull request: CB-10234 Better error message when W...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/138 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-splashscreen pull request: CB-8396 Add AutoHideSpla...

GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/74 CB-8396 Add AutoHideSplashScreen logic to Android's Splashscreen [Jira issue](https://issues.apache.org/jira/browse/CB-8396) Also initializing the splashscreen image

[GitHub] cordova-plugin-splashscreen pull request: CB-9094: Smarter autohid...

Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/49#issuecomment-171906631 @dpolivy, yes you are right. Could you take a look at this implemented in #74 (based on #66)? --- If your project is set up for it, you can

[GitHub] cordova-plugin-splashscreen pull request: CB-8396 Add AutoHideSpla...

Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/74#issuecomment-171911919 :+1: lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-plugin-camera pull request: [iOS] Fixed how checks access ...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/146#issuecomment-171915964 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not