Github user alexbuijs closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/127
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, o
Github user alexbuijs commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/127#issuecomment-176042868
I understand, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/143
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/127#issuecomment-176041352
@alexbuijs thank you for proposed patch, but we can't remove this line as
it is required for InAppBrowser to work correct when app is emulated usin
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/463#discussion_r51076566
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -45,207 +45,356 @@ passively copied into various `platforms/`
subdirectories, for example:
Looks like there is some work going into a new release of this plugin. I'd
be nice to get this in there also.
On Fri, Jan 22, 2016 at 12:01 AM, Sean Kelly wrote:
> Is there a reason a committer has not merged this yet? If there is
> something else I need to do please let me know. as far as I can
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/144#issuecomment-175922592
I don't see much downside in keeping this always.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
I vote +1
Verify tags
coho verify-tags -r cordova-lib --tag 6.0.0
coho verify-tags -r cordova-js --tag 4.1.3
coho verify-tags -r cordova-plugman --tag 1.1.0
coho verify-tags -r cordova-cli --tag 6.0.0
Verify tgz
coho verify-archive vote-cli/cordova-6.0.0.tgz
coho verify-archive vote-cli/cordova-j
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-windows/pull/144#issuecomment-175915741
Looks good. Just a question, do we intend to revert this once the windows
team fix it on their side? Is there any harm in including the package name in
the URI
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-windows/pull/142#issuecomment-175909840
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/144#issuecomment-175909251
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/143#issuecomment-175908924
I'm OK if we want to fix this tactically right now and take a work item
shortly after to fix this correctly.
---
If your project is set up for it, you can re
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/463#issuecomment-175907262
Should the preferences be alphabetized?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/470#discussion_r51066513
--- Diff: www/_posts/2016-01-27-tools-release.md ---
@@ -0,0 +1,130 @@
+---
+layout: post
+author:
+name: Steve Gill
+url:
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/470#issuecomment-175906129
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/463#discussion_r51065837
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -45,207 +45,356 @@ passively copied into various `platforms/`
subdirectories, for example:
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/470#discussion_r51065845
--- Diff: www/_posts/2016-01-27-tools-release.md ---
@@ -0,0 +1,130 @@
+---
+layout: post
+author:
+name: Steve Gill
+url: h
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/463#discussion_r51065593
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -45,207 +45,356 @@ passively copied into various `platforms/`
subdirectories, for example:
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/463#discussion_r51065460
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -45,207 +45,356 @@ passively copied into various `platforms/`
subdirectories, for example:
GitHub user EddyVerbruggen opened a pull request:
https://github.com/apache/cordova-plugin-device/pull/47
Refactored deviceInfo on iOS for better readability
Hi, just a quick cleanup of dictionary creation on iOS.
No functional changes, but I like to write those dictionaries
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/463#issuecomment-175904149
General comment: should we change this file (and the styleguide) to just
use "_Required_" instead of "_Required: true_"? Same for using "**Platforms**"
instead of
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/463#discussion_r51065054
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -22,8 +22,8 @@ title: The config.xml File
# The config.xml File
-Many aspects
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/463#discussion_r51064971
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -22,8 +22,8 @@ title: The config.xml File
# The config.xml File
-Many aspects
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/470#discussion_r51064469
--- Diff: www/_posts/2016-01-27-tools-release.md ---
@@ -0,0 +1,130 @@
+---
+layout: post
+author:
+name: Steve Gill
+url:
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/470#discussion_r51064127
--- Diff: www/_posts/2016-01-27-tools-release.md ---
@@ -0,0 +1,130 @@
+---
+layout: post
+author:
+name: Steve Gill
+url:
Github user dpogue commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/470#discussion_r51063679
--- Diff: www/_posts/2016-01-27-tools-release.md ---
@@ -0,0 +1,130 @@
+---
+layout: post
+author:
+name: Steve Gill
+url: htt
Github user dpogue commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/470#discussion_r51063511
--- Diff: www/_posts/2016-01-27-tools-release.md ---
@@ -0,0 +1,130 @@
+---
+layout: post
+author:
+name: Steve Gill
+url: htt
Github user dpogue commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/470#discussion_r51063321
--- Diff: www/_posts/2016-01-27-tools-release.md ---
@@ -0,0 +1,130 @@
+---
+layout: post
+author:
+name: Steve Gill
+url: htt
Need one more vote!
Please review the blog post for the cordova 6 release!
https://github.com/apache/cordova-docs/pull/470
On Wed, Jan 27, 2016 at 7:16 AM, Steven Gill wrote:
> The ongoing vote has the fix in it.
>
> Need one more vote!
> On Jan 27, 2016 7:37 AM, "David Barth" wrote:
>
>> +1
>
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-docs/pull/470
Added cordova 6 tools release blog post
Please review this blog post for the cordova 6 release!
You can merge this pull request into a Git repository by running:
$ git pull https://gi
Github user stevengill closed the pull request at:
https://github.com/apache/cordova-docs/pull/462
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featu
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/144#issuecomment-175879953
@rakatyal to review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user sarangan12 commented on the pull request:
https://github.com/apache/cordova-docs/pull/465#issuecomment-175877188
@dblotsky Addressed the previous comments. I have shortened as much
possible and removed irrelevant information. Once the other docs such as the
Tutorial/guide
Github user omefire commented on the pull request:
https://github.com/apache/cordova-docs/pull/463#issuecomment-175868952
llk
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-windows/pull/144
CB-10446 Windows 10 Cordova Application restart instead of resume
[Jira issue](https://issues.apache.org/jira/browse/CB-10446)
You can merge this pull request into a Git repository by runni
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-docs/pull/469#issuecomment-175825801
Okay great. Thanks. And this looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user sarangan12 commented on the pull request:
https://github.com/apache/cordova-docs/pull/469#issuecomment-175821302
@rakatyal These broken links are found using the JIRA tickets created. At
this point, I did check the 'checklinks' task. It does not work with all cases.
I am p
Github user rayshan commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/2#issuecomment-175819620
Thanks for the confirmation! We'll try this as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user sarangan12 commented on the pull request:
https://github.com/apache/cordova-docs/pull/469#issuecomment-175819723
@riknoll Addressed the comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-docs/pull/469#issuecomment-175813525
Are you using 'checklinks' gulp task to find these broken links? I believe
we have [this] (https://issues.apache.org/jira/browse/CB-10058) Jira to fix the
broken
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/469#discussion_r51036871
--- Diff: www/docs/en/dev/cordova/storage/storage.md ---
@@ -64,6 +62,12 @@ The following platforms support IndexedDB:
## Plugin-Based Options
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/469#discussion_r51036646
--- Diff: www/docs/en/dev/cordova/storage/storage.md ---
@@ -64,6 +62,12 @@ The following platforms support IndexedDB:
## Plugin-Based Options
GitHub user sarangan12 opened a pull request:
https://github.com/apache/cordova-docs/pull/469
CB-10294: Wrong link in docs
Fixed one wrong link in docs and also changed the links to reference links.
@dblotsky @riknoll @nikhilkh @rakatyal Can you please review and merge this
Github user srgpqt commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/2#issuecomment-175787574
Yes, links are opening in Safari as a new tab when I use target="_blank" on
elements.
I'm not using the InAppBrowser plugin.
---
If you
Github user rayshan commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/2#issuecomment-175785833
Thanks. By "new window", do you mean links are opening in Safari as a new
tab when you use `target="_blank"`?
FYI We've been using https:
Github user srgpqt commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/2#issuecomment-175781426
target="_blank" worked for me in the iOS 9.2 simulator. I'll do some more
testing.
---
If your project is set up for it, you can reply to this em
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/462#issuecomment-175764899
@dhams you need to update your `cordova-android` platform to 5.1.0 and
`cordova-plugin-camera` plugin to 2.1.0 to get the fix. Version 5.4.1 sounds
like you are re
Github user rayshan commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/2#issuecomment-175756155
Hi @srgpqt, why is it no longer relevant? Seems like we still have to do
`window.open` instead of `target="_blank"`.
---
If your project is set
+1
On Jan 27, 2016 7:19 AM, Steven Gill wrote:
+1
On Jan 27, 2016 4:28 AM, "David Barth" wrote:
> Hi,
>
> I need to do another quick interim release of Cordova-Ubuntu to address a
> significant bug with the use of a deprecated Oxide API.
>
> This should become cordova-ubuntu@4.3.3
>
> Does anyo
Github user srgpqt closed the pull request at:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user srgpqt commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/2#issuecomment-175738375
No longer relevant.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user stipegrbic closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/140
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/77
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user daserge closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/78
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or i
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/78#issuecomment-175708006
Merged via 109c82b29b6cfda4fabcd0aa9a7660954b50e7d6
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/466#discussion_r51001854
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -167,6 +167,17 @@ all of them:
+ Applies to Windows.
+
+- C
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/466#discussion_r51000111
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -167,6 +167,17 @@ all of them:
+ Applies to Windows.
+
+- C
Github user daserge commented on the pull request:
https://github.com/apache/cordova-windows/pull/142#issuecomment-175691473
@nikhilkh, @dblotsky, thanks for review, I've addressed the notes.
---
If your project is set up for it, you can reply to this email and have your
reply appear
+1
On Jan 27, 2016 4:28 AM, "David Barth" wrote:
> Hi,
>
> I need to do another quick interim release of Cordova-Ubuntu to address a
> significant bug with the use of a deprecated Oxide API.
>
> This should become cordova-ubuntu@4.3.3
>
> Does anyone have any reason to delay a cordova-ubuntu plat
The ongoing vote has the fix in it.
Need one more vote!
On Jan 27, 2016 7:37 AM, "David Barth" wrote:
> +1
>
> On Fri, Jan 22, 2016 at 9:24 PM, Steven Gill
> wrote:
>
> > any objections or concerns? Some PRs or issues that need to get fixed
> > before I do this?
> >
> > I want to try to get the
On Mon, Jan 25, 2016 at 8:16 PM, Steven Gill wrote:
> Nikhil, sounds reasonable.
>
> I originally misunderstood Vlads message. He isn't proposing the
> PlatformAPI Polyfill for deprecation. This is the code which is used by
> platforms that haven't released a platform API implementation.
>
> He i
+1
On Fri, Jan 22, 2016 at 9:24 PM, Steven Gill wrote:
> any objections or concerns? Some PRs or issues that need to get fixed
> before I do this?
>
> I want to try to get the vote out either later today or Monday.
>
> -Steve
>
It definitely is interesting -- I haven't tried it out anywhere, but there
are tests for it that at least show how to use it:
https://android.googlesource.com/platform/cts/+/764c7c7/tests/tests/webkit/src/android/webkit/cts/PostMessageTest.java
It looks like it just works with strings on the Java
GitHub user JonSmart opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/159
Fix/file locations for Chrome
Corrected dataDirectory and cacheDirectory for accessing files when serving
the html locally. i.e. http://localhost not file::/
You can merge this pull r
I've implemented unit tests for plugin core functionality and events (see PR
[1]) and reported new bugs below. There is only one bad issue on Android which
leads to InAppBrowser window hang (CB-10456, CB-6702), a few issues on Windows;
iOS is doing well. I'm going to address them tomorrow so pro
Github user JonSmart closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/158
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Pretty exciting! Definitely seems like it would be cleaner.
Do you think this would be a new bridge mode?
I spent a couple minutes trying to find an example of how to use this, but
didn't come up with anything outside of the docs.
Looks like the relevant classes are WebMessage, WebMessagePort an
GitHub user JonSmart opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/158
Correct file location for served pages.
Corrected dataDirectory and cacheDirectory for accessing files when serving
the html locally. i.e. http://localhost not file::
You can merge th
Robert
Thanks for stepping up to help in this area, I think everyone agrees with
your recommendations so I see consensus that we should move forward on
having guides in place and process to maintain and apply them.
Some times the not so fun areas of the project are the important ones and
good docu
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-windows/pull/143#issuecomment-175617770
@nikhilkh, it seems there is another, more general way to resolve this. We
might reuse the same caching facility as used by `ConfigChanges` module. This
Looks like the regression is fix now, Steve are you going to resend a new
Vote?
On Mon, Jan 25, 2016 at 9:49 AM Alexander Sorokin (Akvelon) <
v-als...@microsoft.com> wrote:
> Hey guys,
>
> I think there is a regression in tools, but I'm not sure where it's
> located.
> In short, there is a build f
Github user dhams commented on the pull request:
https://github.com/apache/cordova-docs/pull/462#issuecomment-175609597
Sorry guys but that not comes with the fixes ... Same #/CB-9189 is still
there even after update 5.4.1
---
If your project is set up for it, you can reply to this e
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-android/pull/254
CB-10138 Adds missing plugin metadata to plugin_list module
This is a fix for [CB-10138](https://issues.apache.org/jira/browse/CB-10138)
You can merge this pull request into a Git
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-android/pull/254#issuecomment-175599710
@sgrebnov, PTAL
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-android/pull/248#issuecomment-175576742
@Mitko-Kerezov, my bad, i missed you name in CLA list
Regarding the
> the usage of -- basically suggests "I want to stop passing options and
Hi,
I need to do another quick interim release of Cordova-Ubuntu to address a
significant bug with the use of a deprecated Oxide API.
This should become cordova-ubuntu@4.3.3
Does anyone have any reason to delay a cordova-ubuntu platform release?
Any outstanding patches to land?
I am starting th
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/76#discussion_r50966450
--- Diff: README.md ---
@@ -123,13 +123,26 @@ window.setTimeout(function () {
}, splashDuration - fadeDuration);
```
-
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/366
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/142
CB-10441 Add auto tests for InAppBrowser plugin
https://issues.apache.org/jira/browse/CB-10441
Added the following unit tests:
1. `cordova.InAppBrowser.open` method
Github user SunboX commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/76#discussion_r50958608
--- Diff: README.md ---
@@ -123,13 +123,26 @@ window.setTimeout(function () {
}, splashDuration - fadeDuration);
```
-#
Github user Mitko-Kerezov commented on the pull request:
https://github.com/apache/cordova-android/pull/248#issuecomment-175496415
@nikhilkh I've already filed the ICLA some time in 2015 and have already
contributed to cordova. (Can't find the email though but I have merged pull
reque
Github user SunboX commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/76#issuecomment-175494339
That's great! Just was looking for a way how to set the background color
for UWP splash screen (Windows 10 Mobile). Thanks for your work! :+1: :heart:
Github user biasmv commented on the pull request:
https://github.com/apache/cordova-windows/pull/139#issuecomment-175489700
Cool, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
83 matches
Mail list logo
