Github user sarangan12 commented on the pull request:
https://github.com/apache/cordova-docs/pull/465#issuecomment-176604608
Closing the PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user sarangan12 closed the pull request at:
https://github.com/apache/cordova-docs/pull/465
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featu
Github user Balaji-Gopal closed the pull request at:
https://github.com/apache/cordova-plugin-vibration/pull/42
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/465#issuecomment-176550181
Merged with e7bfcca11b6e50368cd5ee4427e3d71131b99b10. Please close the PR.
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/155#issuecomment-176536128
See #135
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/465#issuecomment-176529249
LGTM - merging this one. @sarangan12 for future - please consider squashing
commits before we attempt to merge. I will do the squashing now.
---
If your project
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/158#issuecomment-176528759
Thanks for submitting a PR! The ALLMEDIA thing definitely sounds like a bug
and your change there looks good.
However, I'm not 100% sure about th
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-176512843
@imsingh That doesn't really have anything to do with this pull request.
I'm not sure what "MPESG Radio" is that is generating the error messages, never
Github user hkjorgensen commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/139#issuecomment-176511074
bump
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
I also think we should add tests for this. Carlos, do you have a setup for this
bug that you could share? It would be nice to have mobilespec tests for
save/restore in general, but that ends up being sort of tricky because it
requires enabling the "Don't Keep Activities" dev setting.
Thanks,
Ri
Github user mauron85 commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/51#issuecomment-176502264
Can I ask, why is this still not merged? Cordova 6 is out, declaring new
versions also of this plugin, but background locations are not working on iO
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/469
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/464#discussion_r51210760
--- Diff: www/_data/toc/de-dev-manual.yml ---
@@ -1,19 +1,70 @@
-- {name: "Reisef\xFChrer", url: !!python/unicode '/docs/de/dev/'}
-- {name: "\x
GitHub user sarangan12 opened a pull request:
https://github.com/apache/cordova-lib/pull/367
CB-10459: cordova platform list should mark amazon-fireos and wp8 as
deprecated
Added depracted information to wp8 and amazon-fireos
@nikhilkh Can you please review and merge this P
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/472#issuecomment-176493859
@riknoll @nikhilkh please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user dblotsky opened a pull request:
https://github.com/apache/cordova-docs/pull/472
Sitemap Improvements
- Implementing sitemap.xml manually instead of using a plugin.
- Adding /latest/ URIs to sitemap.xml. Moving some CSS from main.scss to
_docs.scss.
You can merge th
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/464#issuecomment-176489339
@nikhilkh I made articles not show up if they don't have a URL. As for
older versions, they were only updated to use relative links.
---
If your project is set u
LGTM, but we should have a unit test to cover this behaviour somehow.
On Thu, Jan 28, 2016 at 2:23 PM, Carlos Santana
wrote:
> It's being a while since I have done Android native dev,
> Can someone review the PR I sent
> https://github.com/apache/cordova-android/pull/255
>
> This hit us today at
It's being a while since I have done Android native dev,
Can someone review the PR I sent
https://github.com/apache/cordova-android/pull/255
This hit us today at work, we have a complex launch of multiple Cordova
Activities to deal with security aspects and crosswalk.
It's only in cordova-android
GitHub user csantanapr opened a pull request:
https://github.com/apache/cordova-android/pull/255
CB-10472 NullPointerException: org.apache.cordova.PluginManager.onSavâ¦
â¦eInstanceState
check if pluginManager is null before using it
You can merge this pull request into a
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/233#discussion_r51172093
--- Diff: doc/readme.md ---
@@ -0,0 +1,336 @@
+
+
+#Cordova Command-line-interface (CLI) Reference
+
+##Syntax
+
+cord
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/233#discussion_r51171898
--- Diff: doc/readme.md ---
@@ -0,0 +1,336 @@
+
+
+#Cordova Command-line-interface (CLI) Reference
+
+##Syntax
+
+cor
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/233#discussion_r51171853
--- Diff: doc/readme.md ---
@@ -0,0 +1,336 @@
+
+
+#Cordova Command-line-interface (CLI) Reference
+
+##Syntax
+
+cor
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/233#discussion_r51170442
--- Diff: doc/readme.md ---
@@ -0,0 +1,336 @@
+
+
+#Cordova Command-line-interface (CLI) Reference
+
+##Syntax
+
+cor
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/233#discussion_r51170388
--- Diff: doc/readme.md ---
@@ -0,0 +1,336 @@
+
+
+#Cordova Command-line-interface (CLI) Reference
+
+##Syntax
+
+cor
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/233#discussion_r51170136
--- Diff: doc/readme.md ---
@@ -0,0 +1,336 @@
+
+
+#Cordova Command-line-interface (CLI) Reference
+
+##Syntax
+
+cor
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/233#discussion_r51169743
--- Diff: doc/readme.md ---
@@ -0,0 +1,336 @@
+
+
+#Cordova Command-line-interface (CLI) Reference
+
+##Syntax
+
+cor
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/233#discussion_r51169212
--- Diff: doc/readme.md ---
@@ -0,0 +1,337 @@
+
+
+#Cordova Command-line-interface (CLI) Reference
+
+##Syntax
+
+cor
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/233#discussion_r51168235
--- Diff: doc/readme.md ---
@@ -0,0 +1,337 @@
+
+
+#Cordova Command-line-interface (CLI) Reference
+
+##Syntax
+
+cord
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-windows/pull/144#issuecomment-176334623
Thanks @daserge. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
GitHub user nikhilkh opened a pull request:
https://github.com/apache/cordova-cli/pull/233
Add cordova CLI readme docs
This is a checkpoint review as I'm not fully done with this. The goal of
this change to replace CLI guide in cordova-docs/ and the README.md in this
repo.
You can
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/145#issuecomment-176320293
setTimeout is required to support the following scenario. On ios, android
and other platforms functionality creates InAppBrowser on native side, so
Github user imsingh commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-176316488
@ghenry22 Hey, I am not able to use the .m3u stream on iOS. I am getting
following error.
2016-01-28 23:44:41.939 MPESG Radio[3073:44952] Failed to
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/76#issuecomment-176310415
@chrigi, thanks for your feedback.
> It does not respect the "ShowSplashScreenSpinner" preference from the
config.xml
That's strang
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-docs/pull/471
CB-10332 Android Guide Improvements
Lot's of changes, including:
* Fixing Markdown, links, grammar, etc.
* Removing outdated and duplicated content
* Removing content where we
Blog: http://cordova.apache.org/news/2016/01/28/tools-release.html
Tweet: https://twitter.com/apachecordova/status/692765260466429952
WO
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/145#issuecomment-176293276
Also, I would recommend using `setImmediate` as it has advantages over
`setTimeout(fn, 0)`.
https://msdn.microsoft.com/en-us/library/windows/apps/
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/145#issuecomment-176292095
I'm curious why those `setTimeout()` calls are required.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-coho/pull/112
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/112
Updated tools release process.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-coho patch-49
Alternatively you can
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/144#issuecomment-176290646
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/145#issuecomment-176290461
LGTM. Looks like these bugs have been there for a while and this is not a
recent regression that this change is addressing.
---
If your project i
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/470
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user daserge commented on the pull request:
https://github.com/apache/cordova-windows/pull/144#issuecomment-176284697
@nikhilkh, @rakatyal, thank you for the review.
Updated to use `Identity.Name` for 8.1 as well for consistency.
---
If your project is set up for it, you ca
The vote has now closed. The results are:
Positive Binding Votes: 3
Steve Gill
Alexander Sorokin
Carlos Santana
The vote has passed. I will now publish to dist, npm and post the blog post!
On Wed, Jan 27, 2016 at 5:07 PM, Carlos Santana
wrote:
> I vote +1
>
> Verify tags
> coho verify-tags -
Please review and vote on this 4.3.3 Ubuntu Release
by replying to this email (and keep discussion on the DISCUSS thread)
Release issue: https://issues.apache.org/jira/browse/CB-10453
The archive has been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/CB-10453/
The package
JFYI - I've addressed new issues found, could someone review PRs please.
CB-10456 InAppBrowser is not closed if I close it programmatically on Android
https://github.com/apache/cordova-plugin-inappbrowser/pull/143/files?w=1
CB-6702 InAppBrowser hangs when opening more than one instance on Andro
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/145#issuecomment-176253919
Use the following url to review proposed changes w/o whitespace:
https://github.com/apache/cordova-plugin-inappbrowser/pull/145/files?w=1
---
If
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/145
InAppBrowser bugfixing on Windows: CB-10451, CB-10452, CB-10454
CB-10451 InAppBrowser: loadstart event is not triggered on Windows
CB-10452 InAppBrowser: 'exit' event is not
Github user chrigi commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/76#issuecomment-176245101
Thanks for your work. I noticed the following:
- It does not respect the "ShowSplashScreenSpinner" preference from the
config.xml
- The s
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/144#issuecomment-176206237
This fix is similar to what @mysegfault proposed below. I've just
added logic to prevent the dialog for being dismissed twice.
https://
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/144
CB-6702 InAppBrowser hangs when opening more than one instance
https://issues.apache.org/jira/browse/CB-6702
You can merge this pull request into a Git repository by running:
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/466
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-vibration/pull/42#issuecomment-176161967
Please, close this, you created a pull request.
This is not the place to ask questions
---
If your project is set up for it, you can reply to
GitHub user Balaji-Gopal opened a pull request:
https://github.com/apache/cordova-plugin-vibration/pull/42
Vibrate is not working in IOS
I am getting an error saying that navigator is undefined for ios, but it
works fine in Android. Is there any workaround to be be done for ios plat
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/142
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-windows/pull/145#issuecomment-176142684
@nikhilkh, could you please take a look, when possible
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-windows/pull/145
CB-10303 Add tests to cover arguments parsing regression
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-wi
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-android/pull/248#issuecomment-176136907
Wohoo! Good to see this is getting committed!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user david-barth-canonical closed the pull request at:
https://github.com/apache/cordova-ubuntu/pull/21
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
GitHub user david-barth-canonical opened a pull request:
https://github.com/apache/cordova-ubuntu/pull/21
Set of fixes for Cordova-Ubuntu 4.3.3
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cordova-ubuntu/cordova-ubuntu master
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/254
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/143
CB-10456 InAppBrowser is not closed if I close it programmatically on
Android
https://issues.apache.org/jira/browse/CB-10456
This happens due to race condition: open/i
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-android/pull/254#issuecomment-176075769
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-android/pull/248#issuecomment-176068570
Verified and it seems to work fine now with all possible combinations of
`--` and other args (i tested with `--ant`, `--keystore` and `--alias` )
Th
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/248
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user FuzzyTree commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/99#issuecomment-176045492
Debugging shows that `FileHelper.getRealPath` returns an empty (non-null)
string, which causes the function to return a directory name instead of a file
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-windows/pull/143#issuecomment-176045173
I've created [CB-10463](https://issues.apache.org/jira/browse/CB-10463) for
appxmanifest improvements
---
If your project is set up for it, you can re
Github user Mitko-Kerezov commented on the pull request:
https://github.com/apache/cordova-android/pull/248#issuecomment-176044525
@vladimir-kotikov
I've restructured the fixes and have separated them in two commits.
Regarding the options I've considered your words and have tak
69 matches
Mail list logo
