[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-01-31 Thread rakatyal
Github user rakatyal commented on the pull request: https://github.com/apache/cordova-docs/pull/474#issuecomment-18561 Thanks for the detailed review. Addressed the issues. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-01-31 Thread rakatyal
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/474#discussion_r51380381 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -17,700 +17,489 @@ license: > specific language governing permissions and limitations

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-01-31 Thread rakatyal
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/474#discussion_r51380260 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -17,700 +17,489 @@ license: > specific language governing permissions and limitations

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-01-31 Thread rakatyal
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/474#discussion_r51380194 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -17,700 +17,489 @@ license: > specific language governing permissions and limitations

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-01-31 Thread rakatyal
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/474#discussion_r51380144 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -17,700 +17,489 @@ license: > specific language governing permissions and limitations

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-01-31 Thread rakatyal
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/474#discussion_r51379555 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -17,700 +17,489 @@ license: > specific language governing permissions and limitations

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-01-31 Thread rakatyal
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/474#discussion_r51379032 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -17,700 +17,489 @@ license: > specific language governing permissions and limitations

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-01-31 Thread rakatyal
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/474#discussion_r51378598 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -17,700 +17,489 @@ license: > specific language governing permissions and limitations

Re: Update Labels

2016-01-31 Thread Homer, Tony
Added. On 1/31/16, 7:43 PM, "seank@gmail.com on behalf of Sean Kelly" wrote: >I don't appear to have the permissions to update labels in JIRA > >could someone add the following labels to CB-7786? > >cordova inappbrowser android > >Thanks, > >Sean

[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...

2016-01-31 Thread ghenry22
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-177704439 Awesome! Glad I could contribute something back to the project! --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] cordova-windows pull request: CB-10487 WindowsStoreIdentityName sh...

2016-01-31 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-windows/pull/146#issuecomment-177677392 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Update Labels

2016-01-31 Thread Sean Kelly
I don't appear to have the permissions to update labels in JIRA could someone add the following labels to CB-7786? cordova inappbrowser android Thanks, Sean

[GitHub] cordova-browser pull request: Switch from adm-zip to archiver.

2016-01-31 Thread amikula
Github user amikula commented on the pull request: https://github.com/apache/cordova-browser/pull/10#issuecomment-177663442 Why was this closed? cordova-browser's zip file still corrupts files. As far as I can tell, it hasn't been fixed anywhere, including in adm-zip. --- If your pro

[GitHub] cordova-plugin-media-capture pull request: CB-10488 - MediaFile.ge...

2016-01-31 Thread TanaseButcaru
GitHub user TanaseButcaru opened a pull request: https://github.com/apache/cordova-plugin-media-capture/pull/50 CB-10488 - MediaFile.getFormatData does not work with localURL; changed with fullPath JIRA Issue [CB-10488](https://issues.apache.org/jira/browse/CB-10488) You can merge

Cordova iOS build how to enable DEBUG for #ifdef DEBUG in CDVDebug.h

2016-01-31 Thread Shane MacPhillamy
I'm developing a plugin for iOS Cordova. I've created an iOS Cordova application project using the Cordova CLI tools. I would like to enable the debug macros defined in CDVDebug.h with the -DDEBUG compiler flag. Is there a way I can do this from within Xcode when I have the Cordova project open

Can you help me test/review this commit? ( ios statusbar plugin iPad multitask )

2016-01-31 Thread julio cesar sanchez
I'm trying to fix https://issues.apache.org/jira/browse/CB-10288 I've tested on simulators and seems to work fine, but I don't have any real iPad with multitasking support to test. As cordova doesn't officially support multitasking yet, you have to follow these steps to add the support. On an em

[GitHub] cordova-plugin-statusbar pull request: CB-10047 fix iOS 8 deprecat...

2016-01-31 Thread jcesarmobile
Github user jcesarmobile closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/41 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or