Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/375
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user fmiboy commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/158#issuecomment-179682916
Hello guys,
Currently I have image orientation correct when I use PNG type and on
Android 4.4.4 but Android 5 orientation doesn't work at all.
Any
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/375#issuecomment-179682858
@purplecabbage, i'd say to CamelCase for classes and lowerCamelCase for the
rest
---
If your project is set up for it, you can reply to this email and hav
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/471#issuecomment-179666263
Should we add a section on "Diagnosing failures" - it could be part of a
subsequent PR - in particular, talking about adb logcat or referencing
appropriate Androi
Github user adamduren commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/257#discussion_r51833834
--- Diff: cordova-js-src/platform.js ---
@@ -58,6 +61,19 @@ module.exports = {
bindButtonChannel('volumeup');
bindButtonCh
Github user ozeranjo commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/89#issuecomment-179664403
The ability to pass options for overriding the spinnerColor and hiding the
spinner were not included as part of the commit above. Can this be consid
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/471#discussion_r51833532
--- Diff: www/docs/en/dev/guide/platforms/android/plugin.md ---
@@ -155,27 +158,24 @@ thread, but do not want to block the `WebCore` thread
either:
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/471#discussion_r51833427
--- Diff: www/docs/en/dev/guide/platforms/android/index.md ---
@@ -32,276 +32,152 @@ development. For a comparison of the two development
paths, see th
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/471#discussion_r51833065
--- Diff: www/docs/en/dev/guide/platforms/android/plugin.md ---
@@ -72,7 +72,7 @@ Otherwise, the plugin may compile but still be
unavailable to Cordova
Github user zhangkaizhao commented on the pull request:
https://github.com/apache/cordova-docs/pull/477#issuecomment-179662355
@dblotsky OK! Thanks for you suggestion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/471#discussion_r51832927
--- Diff: www/docs/en/dev/guide/platforms/android/plugin.md ---
@@ -31,12 +31,12 @@ platform and back. For another sample, see also the
comments in
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/477#issuecomment-179644356
@zhangkaizhao thanks for your contribution! If you are interested in
contributing more to Cordova or other Apache projects, I recommend for you to
sign the [Apach
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/477
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/484#issuecomment-179642588
Could you please split this into two commits: one for the content changes
and one for the build changes?
---
If your project is set up for it, you can reply to t
Just an FYI for us: we do already have coverage reports: "npm run cover". This
tool gives extra functionality on top of that. I like the coverage diffs, and
the GitHub reports. If this is automated and free, I'm all for it.
Kindly,
Dmitry
-Original Message-
From: Sergey Grebnov (Akvelo
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-medic/pull/73
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-docs/pull/484
added version 6.x
Deleted 6.0.0
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-docs master
Alternatively you can re
GitHub user cfjedimaster opened a pull request:
https://github.com/apache/cordova-docs/pull/483
Update tools.md
Fixes the JSON in the last example. There was a comma missing after "iPhone
Distribution".
You can merge this pull request into a Git repository by running:
$ git pu
Github user hassankhan commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/3#issuecomment-179556132
Is it possible for a new release to be tagged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user hassankhan commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/3#issuecomment-179555817
Ah my mistake, I assumed the error I was getting was related to this.
---
If your project is set up for it, you can reply to this email and ha
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/363#issuecomment-179554892
@stevengill just checking in now that Cordova 6.0.0 is released. Let me
know if you have any feedback.
---
If your project is set up for it, you can reply to this
Github user dpogue commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/3#issuecomment-179554784
It has already been merged in
https://github.com/apache/cordova-plugin-wkwebview-engine/commit/faa9d877045d8baf8afdfd0d8689389ec240e2e4
---
If yo
Github user hassankhan commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/3#issuecomment-179554625
+1 can this be merged soon please? :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-179553260
@Titoine @adamduren I've got a PR open in cordova-android that should fix
the `resume` event issues. It should let you subscribe to the `resume` event
aft
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/471#discussion_r51806333
--- Diff: www/docs/en/dev/guide/platforms/android/index.md ---
@@ -32,276 +32,152 @@ development. For a comparison of the two development
paths, see th
GitHub user omefire opened a pull request:
https://github.com/apache/cordova-docs/pull/482
CB-10526: Improve 'iOS Guide' documentation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/omefire/cordova-docs CB-10526
Alternatively y
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/471#discussion_r51805298
--- Diff: www/docs/en/dev/guide/platforms/android/tools.md ---
@@ -19,206 +19,218 @@ license: >
title: Android Shell Tool Guide
---
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/471#discussion_r51803655
--- Diff: www/docs/en/dev/guide/platforms/android/plugin.md ---
@@ -118,7 +118,8 @@ exception names as much as possible.
The plugin's JavaScript do
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/471#discussion_r51802949
--- Diff: www/docs/en/dev/guide/platforms/android/plugin.md ---
@@ -31,12 +31,12 @@ platform and back. For another sample, see also the
comments in
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/471#discussion_r51802869
--- Diff: www/docs/en/dev/guide/platforms/android/index.md ---
@@ -32,276 +32,152 @@ development. For a comparison of the two development
paths, see the
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-lib/pull/375#issuecomment-179518934
lgtm!
Seems we are slowly migrating from lowercase file names to CamelCase ..
---
If your project is set up for it, you can reply to this email and have
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/471#discussion_r51802704
--- Diff: www/docs/en/dev/guide/platforms/android/index.md ---
@@ -32,276 +32,152 @@ development. For a comparison of the two development
paths, see the
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/471#discussion_r51802634
--- Diff: www/docs/en/dev/guide/platforms/android/index.md ---
@@ -32,276 +32,152 @@ development. For a comparison of the two development
paths, see th
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/472
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/471#discussion_r51802258
--- Diff: www/docs/en/dev/guide/platforms/android/index.md ---
@@ -32,276 +32,152 @@ development. For a comparison of the two development
paths, see th
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-medic/pull/74
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/471#discussion_r51801961
--- Diff: www/docs/en/dev/guide/platforms/android/index.md ---
@@ -32,276 +32,152 @@ development. For a comparison of the two development
paths, see th
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/375#issuecomment-179513568
:+1: Thanks Vladimir.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/471#discussion_r51801334
--- Diff: www/docs/en/dev/guide/platforms/android/index.md ---
@@ -32,276 +32,152 @@ development. For a comparison of the two development
paths, see the
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-medic/pull/74#issuecomment-179512306
Alright, LGTM then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/376#issuecomment-179511413
Looks great! Just one comment: I think just a couple of spaces would look
better than a tab.
Also, looks like there is a test that is sensitive to the out
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/471#discussion_r51800700
--- Diff: www/docs/en/dev/guide/platforms/android/index.md ---
@@ -32,276 +32,152 @@ development. For a comparison of the two development
paths, see th
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-medic/pull/73#issuecomment-179507278
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user sarangan12 commented on the pull request:
https://github.com/apache/cordova-lib/pull/376#issuecomment-179505519
@TimBarham @nikhilkh Agreed. Added formatting changes. Now the display will
be like:
Installed platforms:
android 5.0.0
blackberry10 3
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/376#issuecomment-179503770
Yeah, and in fact, for consistency maybe "installed platforms" should also
be separated by line breaks rather than commas:
```
Installed platforms:
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-android/pull/257
CB-10498: Resume event should be sticky if it has a plugin result
Changes the resume event behavior as follows:
1. When the app starts and there is no plugin result to be delivered,
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/376#issuecomment-179500082
That's more like what we do for plugins (`cordova plugin ls`)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/376#issuecomment-179498720
I like the idea, but find the list is starting to get a bit confusing (to
see the actual platform names. We need to make sure the platform names a very
easy to se
Experiencing a rather critical issue since getting on Cordova 6.0.0 for
iOS. We have a scenario where we hide the Cordova splash screen manually
relatively shortly after app launch. The problem is that quite often
during launch the app just stays on the splash screen instead of
continuing after
2 ways to make the corners don't show up in simulator
1. rotate and rotate back while in split view
2. make the app that I bring from the right take the whole screen, and then
bring back cordova app from the right
[1]: https://www.evernote.com/l/ACJTXoqbhYFIn6mo-SThfghBkSEYsP7vTgk
[2]:
https://ww
Github user jimmont commented on the pull request:
https://github.com/apache/cordova-js/pull/118#issuecomment-179440047
[This
try-catch](https://github.com/apache/cordova-js/blob/master/src/cordova.js#L228)
for callbacks is a real pain. Having access to errors as they occur is highly
GitHub user edewit reopened a pull request:
https://github.com/apache/cordova-ios/pull/104
generates a workspace instead of subproject
Initial part of [CB-5921](https://issues.apache.org/jira/browse/CB-5921)
You can merge this pull request into a Git repository by running:
$ gi
Github user edewit commented on the pull request:
https://github.com/apache/cordova-ios/pull/104#issuecomment-179434508
The initial idea was to be able to support swift plugins. This is now fixed
by changing build.xconfig. For cocoapods this pr could still be relevant
---
If your pr
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/146
CB-7500 executeScript with callback kills/blurs inAppBrowser window
https://issues.apache.org/jira/browse/CB-7500
You can merge this pull request into a Git repository by runn
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/480#discussion_r51769377
--- Diff: www/docs/en/dev/cordova/events/events.md ---
@@ -22,29 +22,384 @@ title: Events
# Events
-> Cordova lifecycle events.
Github user sarangan12 commented on the pull request:
https://github.com/apache/cordova-lib/pull/376#issuecomment-179407654
@dblotsky @nikhilkh @riknoll, @vladimir-kotikov Can you please review and
merge this PR?
---
If your project is set up for it, you can reply to this email and h
GitHub user sarangan12 opened a pull request:
https://github.com/apache/cordova-lib/pull/376
CB-10461: 'cordova platform ls' should list the versions of platforms pinned
Added version information to available platforms list. The output will
be similar to:
E:\projects\MyApp3>
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/375#issuecomment-179387443
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/370#issuecomment-179384632
I understand that this approach is not an ideal pattern - Anyone has better
ideas?
We do need this to work to ensure that --verbose logs that we produce ha
I vote +1.
* Verified signatures and hashes
* Verified tag
* Verified that plugin can be added correctly to blank app
* Verified that blank app can be successfully built and ran
* Ran smoke testing of mobilespec app
* Verified release notes
-Original Message-
From: Sergey Grebnov (Akvelon
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-medic/pull/70#issuecomment-179332769
lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/370#issuecomment-179297923
No, this is not a part of API. However, this might be critical for some
external tools to get this information.
@nikhilkh, what do you think about
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/375
CB-10176 Adds CordovaLogger class, based on logger module from cordova-cli
This is an implementation for
[CB-10176](https://issues.apache.org/jira/browse/CB-10176)
This PR adds a s
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/374
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-lib/pull/374#issuecomment-179263903
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/374#issuecomment-179262628
@sgrebnov, PTAL
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/374
CB-10465 Pass correct options to prepare from compile
This fixes incorrect behaviour of `cordova emulate` command, which results
in restoring all saved platforms even when only particu
Github user hdsnet commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/78#issuecomment-179223182
Works like charm. Please merge asap.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user darinda opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/160
Fix IllegalArgumentException
outChannel.transferFrom will throw IllegalArgumentException when trying to
transfer files larger than Integer.MAX_VALUE. Use alternative copy method in
thi
Github user hdsnet commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/78#issuecomment-179215307
Hi,
It still doesn't seem to work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
This should be good now.
On Tue, Feb 2, 2016 at 1:47 AM, Steven Gill wrote:
> Hey David,
>
> I think you need to add your gpg key to dist/keys
>
> Can you run through
> https://github.com/apache/cordova-coho/blob/master/docs/setting-up-gpg.md
> up to the point of adding your key to dist/keys?
>
They shouldn't disappear, they don't disappear on my tests on the simulator.
Well, they disappear when there is another app on Slide Over because the
app on the Slide Over is over the app, and the cordova app is grayed out
and not usable, once I hit the white button to change to Split View the
webv
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/369
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/147
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/368#issuecomment-179092390
@sarangan12, LGTM, merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/368
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
76 matches
Mail list logo