Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/378#discussion_r51986491
--- Diff: cordova-lib/src/cordova/metadata/windows_parser.js ---
@@ -65,135 +53,13 @@ require('util').inherits(windows_parser, Parser);
modu
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/378#discussion_r51986428
--- Diff: cordova-lib/src/cordova/metadata/windows_parser.js ---
@@ -65,135 +53,13 @@ require('util').inherits(windows_parser, Parser);
modu
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/376
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/487#issuecomment-180224660
@nikhilkh @riknoll @sarangan12 Please review when you folks get a chance.
---
If your project is set up for it, you can reply to this email and have your
reply ap
GitHub user dblotsky opened a pull request:
https://github.com/apache/cordova-docs/pull/487
Doc Anchor Fixes
- Moving anchor creation out of ToC logic.
- Moving ID creation into JS because RedCarpet doesn't support Unicode
headings.
- Making permalink icons a bit smaller a
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/370#issuecomment-180179865
Yes, we could fix all callers of it - but ideally, 'log' messages from
`cordova-common` can be surfaced and reported.
---
If your project is set up for it, you c
Did I mentioned that I like how the train is moving forward :-), great work
getting releases out this fast
On Thu, Feb 4, 2016 at 10:10 PM Steven Gill wrote:
> Blog:
>
> http://cordova.apache.org/announcements/2016/02/04/cordova-windows-4.3.1.html
> Tweet: https://twitter.com/apachecordova/statu
Blog:
http://cordova.apache.org/announcements/2016/02/04/cordova-windows-4.3.1.html
Tweet: https://twitter.com/apachecordova/status/695444216357396480
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-android/pull/257#issuecomment-180171364
@riknoll I tested the pull request and it's working for me.
lastResume keeps the data, any new listener that get's attached get's the
data.
---
If you
I will take a look
On Thu, Feb 4, 2016 at 1:23 PM Richard Knoll wrote:
> I have a PR open in cordova-android that should probably be merged first.
> It addresses a bug in the save/restore API that a few people are hitting. I
> still have some updates/testing to do but I hope to merge it in soon.
Github user dpogue commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/3#issuecomment-180132192
This is part of an Apache Software Froundation project, so any release
needs to follow the ASF guidelines including a 48-hour voting period with 3
Github user hassankhan commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/3#issuecomment-180128975
True, but a new release is usually only an `npm publish` away, unless I'm
mistaken? :)
---
If your project is set up for it, you can reply to
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-android/pull/257#issuecomment-180126717
@infil00p I'd appreciate it if you could review this one
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
The committer, in this case sgrebnov, would close the issue, or if you
are the reporter of the issue, if the fix is satisfactory, you can
close it.
On Thu, Feb 4, 2016 at 4:07 PM, Joe Bowser wrote:
> Ideally either the person who pulled in the request, or you would confirm
> that it landed in mas
Ideally either the person who pulled in the request, or you would confirm
that it landed in master and that it works as you intended. You can test
it and indicate that it's closed if you want to move things forward a bit
faster.
On Thu, Feb 4, 2016 at 3:54 PM, Sean Kelly wrote:
> I see from the
I see from the mail below that pull request was closed and I see that
master now has my PR code. However, the JIRA issue is still open where I
would have expected it to be marked resolved. Is there more that I need to
do or?
Sean
-- Forwarded message --
From: asfgit
Date: Thu,
Sorry to be such a pain, I realize this is a thankless job and I want you
to know I appreciate all your work.
On Thu, Feb 4, 2016 at 5:26 AM, Sergey Grebnov (Akvelon) <
v-seg...@microsoft.com> wrote:
> The vote has now closed. The results are:
>
> Positive Binding Votes: 3
>
> Vladimir Kotikov
>
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/3#issuecomment-180077007
It's not on NPM yet, plugin releases take time.
Anybody using cordova can install from github, they don't have to wait for
the NPM releas
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/162#issuecomment-180072860
Alright. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/162#discussion_r51945467
--- Diff: src/windows/CameraProxy.js ---
@@ -710,7 +710,10 @@ function takePictureFromCameraWindows(successCallback,
errorCallback, args) {
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/162#issuecomment-180071998
@riknoll: Yes. I have created a separate Jira bug to tackle that. We are
waiting for the response from Windows team on the approach.
---
If your projec
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/162#discussion_r51945199
--- Diff: src/windows/CameraProxy.js ---
@@ -710,7 +710,10 @@ function takePictureFromCameraWindows(successCallback,
errorCallback, args) {
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/162#discussion_r51944877
--- Diff: src/windows/CameraProxy.js ---
@@ -710,7 +710,10 @@ function takePictureFromCameraWindows(successCallback,
errorCallback, args) {
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/162#issuecomment-180070027
So does this still leave us open to the possibility of having the plugin
crash when certain combinations of width and height are passed?
---
If your pro
Github user IvanKarpan commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/3#issuecomment-180050118
IMHO without a release to npm this whole WKWebView support of Cordova is
pretty not usable at all ATM...
---
If your project is set up for it
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-lib/pull/370#issuecomment-180043070
In this case, why not emit the event that you are calling spawn with
arguments a,b,c
```
function execSpawn(command, args, resultMsg, errorMsg) {
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/370#issuecomment-180036146
https://issues.apache.org/jira/browse/CB-10430 has details of one scenario
where verbose logs from the cordova-common do not show up. In particular, the
processes
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/485
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-lib/pull/370#issuecomment-180030165
I am still not seeing the value in this.
When is this an issue? Who does it affect?
---
If your project is set up for it, you can reply to this email and
GitHub user rakatyal opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/162
CB-10541: Changing default maxResoltion to be highestAvailable for Caâ¦
â¦meraCaptureUI
You can merge this pull request into a Git repository by running:
$ git pull https://gi
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/370#issuecomment-180028239
I like the idea of a global.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/471#discussion_r51930488
--- Diff: www/docs/en/dev/guide/platforms/android/plugin.md ---
@@ -31,12 +31,12 @@ platform and back. For another sample, see also the
comments in
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/377
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/471#discussion_r51930197
--- Diff: www/docs/en/dev/guide/platforms/android/plugin.md ---
@@ -72,7 +72,7 @@ Otherwise, the plugin may compile but still be
unavailable to Cordova.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/370#issuecomment-180026635
Guys, just a couple of ideas, based on discussion with Nikhil:
1, Instead of overwriting `events` instance in common, platform might set a
reference to
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/370#issuecomment-180023878
Guys, just a couple of ideas, based on discussion with Nikhil:
1. Instead of rewriting cordo
---
If your project is set up for it, you can reply to thi
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/471#issuecomment-180021130
@nikhilkh yes, I think the plan is to add a debugging section.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user wolframkriesing commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/147#issuecomment-180019684
hey cool that this is finding it's way.
Meanwhile we fixed the problem for older androids too, I updated the
comment in https://issues.
Gave you permission!
On Thu, Feb 4, 2016 at 5:40 AM, Sergey Grebnov (Akvelon) <
v-seg...@microsoft.com> wrote:
> Can someone give me npm permissions for the plugin please:
>
> npm owner add sgrebnov cordova-plugin-inappbrowser
>
> -Sergey
> -Original Message-
> From: Sergey Grebnov (A
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/257#discussion_r51923623
--- Diff: cordova-js-src/platform.js ---
@@ -58,6 +61,19 @@ module.exports = {
bindButtonChannel('volumeup');
bindButtonChan
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-docs/pull/484#issuecomment-180010429
@dblotsky how does that look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/480
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-cli/pull/234#issuecomment-180006307
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/378#issuecomment-180005902
@vladimir-kotikov to review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-lib/pull/378
CB-10482 Remove references to windows8 from cordova-lib/cli
[Jira issue](https://issues.apache.org/jira/browse/CB-10482)
`update_from_config method` tests are moved to [the
platform](h
I have a PR open in cordova-android that should probably be merged first. It
addresses a bug in the save/restore API that a few people are hitting. I still
have some updates/testing to do but I hope to merge it in soon. Would love some
feedback if anyone has a chance to review.
The PR is here:
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/377#issuecomment-179979668
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-cli/pull/234
CB-10482 Remove references to windows8 from cordova-lib/cli
[Jira issue](https://issues.apache.org/jira/browse/CB-10482)
You can merge this pull request into a Git repository by running:
$
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/485#issuecomment-179979278
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/257#discussion_r51911630
--- Diff: cordova-js-src/platform.js ---
@@ -58,6 +61,19 @@ module.exports = {
bindButtonChannel('volumeup');
bindButtonChan
Github user hassankhan commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/3#issuecomment-179944762
I believe it is merged just fine, but there hasn't been a new release of
the plugin on npm, so anybody trying to use the latest version won't g
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/137
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or i
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/137#issuecomment-179900260
I see, merging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/137#issuecomment-179898101
It fix 2 other things that affect iOS 8-9 too.
And don't we have to maintain support for 6 months after deprecating? (not
sure if that appl
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/137#issuecomment-179896028
Is it still actual? - Looks like we have dropped iOS 7.0 support - see
CB-9726 Update minimum Deployment Target to iOS 8.0
(https://issues.apache.
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/3#issuecomment-179891115
check the jira issue
https://issues.apache.org/jira/browse/CB-10269
Commit faa9d877045d8baf8afdfd0d8689389ec240e2e4 in
cordova-plugin
Github user andres-torres-marroquin commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/3#issuecomment-179887523
I also thought it wasn't merged, how can we know that? I'm unfamiliar on
how this is handled.
---
If your project is set up for
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-docs/pull/486#issuecomment-179853679
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Can someone give me npm permissions for the plugin please:
npm owner add sgrebnov cordova-plugin-inappbrowser
-Sergey
-Original Message-
From: Sergey Grebnov (Akvelon)
Sent: Monday, February 1, 2016 2:46 PM
To: 'dev@cordova.apache.org'
Subject: RE: [DISCUSS] inAppBrowser plugin rele
Left minor comment in PR
On Thu, Feb 4, 2016 at 8:17 AM Sergey Grebnov (Akvelon) <
v-seg...@microsoft.com> wrote:
> Please review and comment: https://github.com/apache/cordova-docs/pull/486
>
> -Sergey
>
> -
> To unsubscribe, e-m
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-docs/pull/486#issuecomment-179835728
Updated, @csantanapr thx for review!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
The vote has now closed. The results are:
Positive Binding Votes: 3
Vladimir Kotikov
Alexander Sorokin
Sergey Grebnov
Negative Binding Votes: 0
Other Votes:
-1 from Sean Kelly
The vote has passed.
-Sergey
-Original Message-
From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.c
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-docs/pull/486#issuecomment-179833612
Change the date on the file and to 2016-02-04
Other than that looks good
---
If your project is set up for it, you can reply to this email and have your
rep
Please review and comment: https://github.com/apache/cordova-docs/pull/486
-Sergey
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-docs/pull/486
CB-10505 Adds cordova-plugin-inappbrowser 1.2.1 release blog post
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-docs
Should we do a patch releaseand pick up a few bugs seating master?
Github user mysegfault closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/71
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, o
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-lib/pull/377#issuecomment-179812613
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
It looks like we don't need for INFRA here. The coverage reports is available
without any integration - see
https://codecov.io/github/apache/cordova-lib?ref=39793cf6b7aaaf05eb9cfa03930d936c1cbf1f16
for the report.
-
Best regards, Vladimir
-Original Message-
From: Vladimir Kotikov (Akve
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/377
CB-10531 Enable coverage reports for cordova-lib
This PR adds integration with codecov.io
There is also a few improvements for Travis and Appveyor configs and npm
tasks:
Please review and comment: https://github.com/apache/cordova-docs/pull/485
-
Best regards, Vladimir
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-docs/pull/485#issuecomment-179789660
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Please review and comment: https://github.com/apache/cordova-docs/pull/485
-
Best regards, Vladimir
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/147#issuecomment-179787521
@wolframkriesing please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/147
CB-10395 InAppBrowser's WebView not storing cookies reliable
https://issues.apache.org/jira/browse/CB-10395
You can merge this pull request into a Git repository by running:
Thank you, guys for the feedback.
This sounds like we now have a consensus, so I'm going to submit a ticket to
INFRA, asking to enable codecov.io <-> GitHub integration, and send a PR to
cordova-lib with coverage reports generation
-
Best regards, Vladimir
-Original Message-
From: Dmitr
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-docs/pull/485
CB-10495 Adds cordova-windows 4.3.1 release blog post
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-docs CB-
I vote +1.
* Verified signatures and hashes
* Ran coho audit-license-headers over the repo
* Ran plugin auto tests to ensure they are passing
-
Best regards, Vladimir
-Original Message-
From: Alexander Sorokin (Akvelon) [mailto:v-als...@microsoft.com]
Sent: Wednesday, February 3, 2016 7
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/71#issuecomment-179782033
@mysegfault Thank you for path - this has been fixed similar way w/ small
change by the following commit, pls close this PR.
https://github.co
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/131#issuecomment-179780091
@gaoyuan123 - thank you for the pach, I see that this change is already in
repo master, please close this PR
---
If your project is set up for it
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/132
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or i
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/146
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or i
The vote has now closed. The results are:
Positive Binding Votes: 3
Vladimir Kotikov
Alexander Sorokin
Jesse MacFadyen
The vote has passed.
-
Best regards, Vladimir
-Original Message-
From: Alexander Sorokin (Akvelon) [mailto:v-als...@microsoft.com]
Sent: Tuesday, February 2, 2016 3:
83 matches
Mail list logo
