[GitHub] cordova-plugin-device pull request: chore: edit package.json licen...

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/48#issuecomment-180569344 Sure, if you can! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugin-inappbrowser pull request: CB-10395 InAppBrowser's ...

Github user wolframkriesing commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/147#issuecomment-180591346 I think importing the `CookieSyncManager ` is missing --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-plugin-media pull request: CB-10476 - fix problem where ca...

Github user tony-- commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/78#issuecomment-180593938 +1 this fixed the tests for me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-docs pull request: CB-10353: Make Hooks guide a reference

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/489#discussion_r52080185 --- Diff: www/docs/en/dev/guide/appdev/hooks/index.md --- @@ -115,41 +247,38 @@ As a plugin developer you can define hook scripts using `` elements in

[GitHub] cordova-docs pull request: CB-10332 Android Guide Improvements

Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/471#issuecomment-180608678 Okay, I just forced pushed some major changes to this PR: * Addressed most of the code review * Deleted old pages and combined other pages into single

[GitHub] cordova-plugin-camera pull request: CB-10539: Commenting out the v...

GitHub user rakatyal opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/163 CB-10539: Commenting out the verySmallQvga maxResolution option You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-docs pull request: CB-10353: Make Hooks guide a reference

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/489#discussion_r52085523 --- Diff: www/docs/en/dev/guide/appdev/hooks/index.md --- @@ -20,63 +20,193 @@ license: > title: Hooks Guide --- -# Hooks Guide

[GitHub] cordova-lib pull request: CB-10482 Remove references to windows8 f...

Github user daserge commented on the pull request: https://github.com/apache/cordova-lib/pull/378#issuecomment-180407487 @vladimir-kotikov, added the tests for non-default plugman engines, PTAL --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-plugin-file-transfer pull request: CB-8407 Fix downloading...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/63#issuecomment-180444839 @Fuchur84, please file an issue on [our issue tracker](https://issues.apache.org/jira/browse/CB) so it could be seen by other devs,

Re: [Vote] 4.3.3 Ubuntu Release

Any feedback on the release? I need your votes ! :) On Thu, Jan 28, 2016 at 5:25 PM, David Barth wrote: > Please review and vote on this 4.3.3 Ubuntu Release > by replying to this email (and keep discussion on the DISCUSS thread) > > Release issue:

[GitHub] cordova-lib pull request: CB-10482 Remove references to windows8 f...

Github user daserge commented on the pull request: https://github.com/apache/cordova-lib/pull/378#issuecomment-180425340 @nikhilkh, @stevengill could you please take a look and confirm if

Re: [DISCUSS] Core Plugins and Android API 23

Yeah, that one. El viernes, 5 de febrero de 2016, Homer, Tony escribió: > It took me a while to find it, but I guess you mean CB-10455? > > > > On 2/5/16, 7:56 AM, "julio cesar sanchez" > wrote: > > >I think we just forgot, somebody

Re: [Vote] 4.3.3 Ubuntu Release

+1 ran coho verify archive added fine to a project. Can't build due to lack of environment. On Fri, Feb 5, 2016 at 8:15 AM, David Barth wrote: > Any feedback on the release? I need your votes ! :) > > On Thu, Jan 28, 2016 at 5:25 PM, David Barth

[GitHub] cordova-docs pull request: CB-10549: Fixing 6.0.0 manual TOC links

Github user rakatyal commented on the pull request: https://github.com/apache/cordova-docs/pull/488#issuecomment-180501457 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-docs pull request: CB-10549: Fixing 6.0.0 manual TOC links

Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/488#issuecomment-180501130 @dblotsky please review and push ASAP --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-docs pull request: CB-10549: Fixing 6.0.0 manual TOC links

GitHub user riknoll opened a pull request: https://github.com/apache/cordova-docs/pull/488 CB-10549: Fixing 6.0.0 manual TOC links I did not verify every language (used regex find and replace) You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-plugin-media pull request: CB-10476 - fix problem where ca...

Github user drbeermann commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/78#issuecomment-180462324 +1 Fixes a few issues for me as well. Still having problems with multiple audio files playing on marshmallow however. --- If your project is set up

[GitHub] cordova-plugin-media pull request: CB-10476 - fix problem where ca...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/78#issuecomment-180486950 This LGTM. Seems like our tests have been failing for a while with cordova-plugin-media, and this was the cause --- If your project is set up for it, you

[GitHub] cordova-plugin-media pull request: CB-10476 - fix problem where ca...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/78#issuecomment-180492977 I have tested this by running cordova-mobile-spec on a 6.0.1 device, 5.1.1 emulator, and 4.44 emulator. --- If your project is set up for it, you can

[GitHub] cordova-plugin-media pull request: CB-10455 android: Adding permis...

GitHub user riknoll opened a pull request: https://github.com/apache/cordova-plugin-media/pull/79 CB-10455 android: Adding permission helper to remove cordova-android 5.0.0 constraint Left out of the first round by mistake You can merge this pull request into a Git repository by

[GitHub] cordova-lib pull request: CB-10482 Remove references to windows8 f...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/378#issuecomment-180243971 Added a few comments, otherwise LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-lib pull request: CB-10482 Remove references to windows8 f...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/378#discussion_r51986870 --- Diff: cordova-lib/spec-cordova/metadata/windows_parser.spec.js --- @@ -115,31 +110,9 @@ describe('windows8 project parser', function() {

[GitHub] cordova-plugin-file-transfer pull request: CB-8407 Fix downloading...

Github user Fuchur84 commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/63#issuecomment-180414183 There seems to be a problem with this on Windows 10 / Windows 10 Mobile... I get an error on line 502, column 33 in

[GitHub] cordova-plugin-media pull request: CB-10455 android: Adding permis...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/79#issuecomment-180517843 Thanks. Also FYI I did the tests including #78 which I plan to merge shortly. Tests fail without it. --- If your project is set up for it, you can reply

[GitHub] cordova-docs pull request: CB-10353: Make Hooks guide a reference

Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/489#discussion_r52064153 --- Diff: www/docs/en/dev/guide/appdev/hooks/index.md --- @@ -22,61 +22,191 @@ title: Hooks Guide # Hooks Guide +## Introduction

[GitHub] cordova-plugin-media pull request: CB-10455 android: Adding permis...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/79 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: package discovery

Sorry I meant cordova:tool but I also like cordova:tooling better On Fri, Feb 5, 2016 at 12:34 PM, Jesse wrote: > +1 > Shouldn't cordova-tool be cordova:tool ? > I might like cordova:tooling better, not sure ... > > > @purplecabbage > risingj.com > > On Fri, Feb 5, 2016

[GitHub] cordova-docs pull request: CB-10353: Make Hooks guide a reference

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/489#discussion_r52080114 --- Diff: www/docs/en/dev/guide/appdev/hooks/index.md --- @@ -178,28 +307,51 @@ module.exports = function(context) { `context.opts.plugin` object

Remove deprecated platform guides?

Hi, We are doing some work on the platform guides. We are converting them to one page/platform and updating and modifying the content. Should we remove the deprecated platform guides from the website (wp8, fire OS and firefox OS) or let them be? -Raghav

[GitHub] cordova-lib pull request: CB-10235 Added clearer error message for...

Github user ktop closed the pull request at: https://github.com/apache/cordova-lib/pull/357 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request: CB-10235 Added clearer error message for...

Github user ktop commented on the pull request: https://github.com/apache/cordova-lib/pull/357#issuecomment-180583758 I will redo this pull request. I was having some repository problems so I'll just start over. --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-docs pull request: CB-10353: Make Hooks guide a reference

Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-docs/pull/489#issuecomment-180586418 @rakatyal Why do we want to remove Sample Usage? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-docs pull request: CB-10353: Make Hooks guide a reference

Github user rakatyal commented on the pull request: https://github.com/apache/cordova-docs/pull/489#issuecomment-180589385 No we shouldn't. I didn't see anything in the diff on that so was curious. Also do you think it's a good idea to add another sample usage for iOS/windows? ---

Re: Remove deprecated platform guides?

I think wp8 still has use, I would leave it and dump the others. @purplecabbage risingj.com On Fri, Feb 5, 2016 at 2:04 PM, Steven Gill wrote: > As long as they continue to live in the older version of docs, I'm fine > with removing them. > > On Fri, Feb 5, 2016 at

[GitHub] cordova-docs pull request: CB-10332 Android Guide Improvements

Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/471#issuecomment-180609791 @rakatyal @nikhilkh @vladimir-kotikov @infil00p please look this over. I have some more updates to content that are coming, like

[GitHub] cordova-docs pull request: CB-10353: Make Hooks guide a reference

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/489#discussion_r52085944 --- Diff: www/docs/en/dev/guide/appdev/hooks/index.md --- @@ -20,63 +20,193 @@ license: > title: Hooks Guide --- -# Hooks Guide

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/474#discussion_r52085975 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -17,700 +17,489 @@ license: > specific language governing permissions and limitations

[GitHub] cordova-docs pull request: CB-10353: Make Hooks guide a reference

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/489#discussion_r52085942 --- Diff: www/docs/en/dev/guide/appdev/hooks/index.md --- @@ -20,63 +20,193 @@ license: > title: Hooks Guide --- -# Hooks Guide

Re: Remove deprecated platform guides?

As long as they continue to live in the older version of docs, I'm fine with removing them. On Fri, Feb 5, 2016 at 2:00 PM, Raghav Katyal wrote: > Hi, > > We are doing some work on the platform guides. We are converting them to > one page/platform and updating and

[GitHub] cordova-docs pull request: CB-10353: Make Hooks guide a reference

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/489#discussion_r52079856 --- Diff: www/docs/en/dev/guide/appdev/hooks/index.md --- @@ -178,28 +307,51 @@ module.exports = function(context) { `context.opts.plugin` object

[GitHub] cordova-docs pull request: CB-10353: Make Hooks guide a reference

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/489#discussion_r52084953 --- Diff: www/docs/en/dev/guide/appdev/hooks/index.md --- @@ -20,63 +20,193 @@ license: > title: Hooks Guide --- -# Hooks Guide

[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...

Github user Titoine commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-180613895 @riknoll can't test it right now. I'm trying to do a camera/gallery plugin without having to use native and avoid this problem. --- If your project

[GitHub] cordova-docs pull request: CB-10353: Make Hooks guide a reference

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/489#discussion_r52085107 --- Diff: www/docs/en/dev/guide/appdev/hooks/index.md --- @@ -178,28 +307,51 @@ module.exports = function(context) { `context.opts.plugin` object

[GitHub] cordova-plugin-media pull request: CB-10455 android: Adding permis...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/79#issuecomment-180511951 @tony-- @infil00p @nikhilkh Please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-docs pull request: CB-10353: Make Hooks guide a reference

GitHub user sarangan12 opened a pull request: https://github.com/apache/cordova-docs/pull/489 CB-10353: Make Hooks guide a reference Making Hooks guide a reference @nikhilkh @axemclion @rakatyal Can you review this PR? You can merge this pull request into a Git repository

RE: [DISCUSS] Core Plugins and Android API 23

Yep, I left it out of the first round by mistake; I was looking at an out of date version of cordova-plugin-media at the time. I've got a PR open that adds the helper here: https://github.com/apache/cordova-plugin-media/pull/79 Thanks, Richard -Original Message- From: julio cesar

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/474#discussion_r52067383 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -17,700 +17,491 @@ license: > specific language governing permissions and limitations

[GitHub] cordova-android pull request: CB-10498: Resume event should be sti...

Github user csantanapr commented on the pull request: https://github.com/apache/cordova-android/pull/257#issuecomment-180554647 @riknoll you are going to merge this or there is more work to be done? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-docs pull request: CB-10353: Make Hooks guide a reference

Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/489#discussion_r52063845 --- Diff: www/docs/en/dev/guide/appdev/hooks/index.md --- @@ -22,61 +22,191 @@ title: Hooks Guide # Hooks Guide +## Introduction

[GitHub] cordova-docs pull request: CB-10549: Fixing 6.0.0 manual TOC links

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/488#issuecomment-180545937 Whoops, I made the change just now before I noticed the PR. Sorry! Deploying now. --- If your project is set up for it, you can reply to this email and have

Re: package discovery

+1 Shouldn't cordova-tool be cordova:tool ? I might like cordova:tooling better, not sure ... @purplecabbage risingj.com On Fri, Feb 5, 2016 at 12:26 PM, Tommy-Carlos Williams wrote: > +1 > > > > On 6 Feb 2016, at 6:51 AM, Steven Gill wrote: > > >

[GitHub] cordova-docs pull request: CB-10549: Fixing 6.0.0 manual TOC links

Github user riknoll closed the pull request at: https://github.com/apache/cordova-docs/pull/488 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-camera pull request: CB-10541: Changing default max...

Github user XiMnet commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/162#issuecomment-180514539 Hi, We are away for the Chinese New Year celebration from 8 February 2016 to 12 February 2016. We will be back on 15th February

[GitHub] cordova-plugin-media pull request: CB-10476 - fix problem where ca...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/78#issuecomment-180528497 @infil00p to review. I think this should fix most of the errors we are seeing in [the

[GitHub] cordova-docs pull request: CB-10353: Make Hooks guide a reference

Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/489#discussion_r52066234 --- Diff: www/docs/en/dev/guide/appdev/hooks/index.md --- @@ -178,28 +307,51 @@ module.exports = function(context) { `context.opts.plugin` object

Re: [DISCUSS] Plugin patch release

+1 cordova-plugin-media has also had commits related to background streaming on iOS Also : cordova-plugin-splashscreen: CB-10422 Splashscreen displays black screen with no image on Android CB-10412 AutoHideSplashScreen "false" isn't taken in account on iOS CB-9516 Android SplashScreen - Spinner

[GitHub] cordova-android pull request: CB-10498: Resume event should be sti...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-android/pull/257#issuecomment-180556020 Sorry @csantanapr, I was dealing with some plugin fixes. I will merge this by the end of today; I need to test on a device. --- If your project is set up for

Re: package discovery

+1 !! On Fri, Feb 5, 2016 at 4:01 PM Steven Gill wrote: > Sorry I meant cordova:tool but I also like cordova:tooling better > > On Fri, Feb 5, 2016 at 12:34 PM, Jesse wrote: > > > +1 > > Shouldn't cordova-tool be cordova:tool ? > > I might like

[GitHub] cordova-plugin-camera pull request: CB-10541: Changing default max...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/162 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-media pull request: CB-10455 android: Adding permis...

Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/79#issuecomment-180514813 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-docs pull request: CB-10353: Make Hooks guide a reference

Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/489#discussion_r52063505 --- Diff: www/docs/en/dev/guide/appdev/hooks/index.md --- @@ -22,61 +22,191 @@ title: Hooks Guide # Hooks Guide --- End diff --

package discovery

Hey everyone! With templates out now, I wanted to propose a few keywords for improving discoverability. Firstly, every package should contain 'ecosystem:cordova'. I suggest we add these new keywords. 'cordova:platform' 'cordova:plugin' 'cordova:template' 'cordova-tool' (don't really need this

[GitHub] cordova-docs pull request: CB-10353: Make Hooks guide a reference

Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/489#discussion_r52065065 --- Diff: www/docs/en/dev/guide/appdev/hooks/index.md --- @@ -158,7 +287,7 @@ module.exports = function(context) { "opts": {

[GitHub] cordova-plugin-contacts pull request: Try catch finally cursors

Github user nicoabie commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/71#issuecomment-180537827 Hi @manugb, is this the reason of why I'm getting > android.database.CursorWindowAllocationException: Cursor window could not be created from

[GitHub] cordova-plugin-media pull request: CB-10455 android: Adding permis...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/79#issuecomment-180512541 Tested on Marshmallow device and KitKat emulator using mobilespec media auto tests. Did tests using cordova-android's master and cordova-android 4.0.0

[DISCUSS] Plugin patch release

Looks like we might need another plugins release. I have been triaging JIRAs after the latest set of releases and these look like high priority enough to get a release out for them. There are number of regressions/bug fixes that we want to get released. These changes are simple and probably

RE: package discovery

I like the idea. However, currently plugins are being identified with "ecosystem:cordova" keyword. We might have to maintain that for all plugins that do not switch to these new keyword below. For "tool" there is at least one example of a tool which currently shows up in plugin search:

[GitHub] cordova-docs pull request: CB-10353: Make Hooks guide a reference

Github user rakatyal commented on the pull request: https://github.com/apache/cordova-docs/pull/489#issuecomment-180541475 Are we getting rid of the 'Sample usage' section? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/474#discussion_r52068338 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -17,700 +17,491 @@ license: > specific language governing permissions and limitations

Re: package discovery

+1 > On 6 Feb 2016, at 6:51 AM, Steven Gill wrote: > > Hey everyone! > > With templates out now, I wanted to propose a few keywords for improving > discoverability. > > Firstly, every package should contain 'ecosystem:cordova'. > > I suggest we add these new

[GitHub] cordova-android pull request: CB-10498: Resume event should be sti...

Github user csantanapr commented on the pull request: https://github.com/apache/cordova-android/pull/257#issuecomment-180557444 @riknoll sure no problem, I was just curious if there was more you wanted me to look at. --- If your project is set up for it, you can reply to this email

RE: [Discuss] Process question

Yeap, I completely forgot to update associated JIRA issue, fixed. Sean, thank you for the patch! PS. This is covered in the PR processing documentation[1]: Step 7: Update JIRA [1] https://github.com/apache/cordova-coho/blob/master/docs/processing-pull-requests.md -Sergey -Original

RE: [DISCUSS] inAppBrowser plugin release

Thank you Steve - cordova-plugin-inappbrowser@1.2.1 has been published to npm. -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Thursday, February 4, 2016 10:33 PM To: dev@cordova.apache.org Subject: Re: [DISCUSS] inAppBrowser plugin release Gave you

[GitHub] cordova-docs pull request: CB-10505 Adds cordova-plugin-inappbrows...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/486 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: [DISCUSS] Core Plugins and Android API 23

Earlier in this thread, Richard stated: >> This change has been merged into the file, camera, geolocation, and contacts >> plugins (media did not actually require any change). Media was updated on 1/15 but it still has a "cordova-android >=5.0.0-dev" engine tag. I couldn't find any other

[GitHub] cordova-plugin-inappbrowser pull request: CB-10395 InAppBrowser's ...

Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/147#issuecomment-180319788 pls review updated version --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-lib pull request: CB-10482 Remove references to windows8 f...

Github user daserge commented on the pull request: https://github.com/apache/cordova-lib/pull/378#issuecomment-180348008 Vladimir, thanks for review! I've addressed the notes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

Re: [DISCUSS] Core Plugins and Android API 23

I think we just forgot, somebody mentioned this on slack and there is an issue open on JIRA. 2016-02-05 13:52 GMT+01:00 Homer, Tony : > Earlier in this thread, Richard stated: > >> This change has been merged into the file, camera, geolocation, and > contacts plugins (media

Re: [DISCUSS] Core Plugins and Android API 23

It took me a while to find it, but I guess you mean CB-10455? On 2/5/16, 7:56 AM, "julio cesar sanchez" wrote: >I think we just forgot, somebody mentioned this on slack and there is an >issue open on JIRA. > >2016-02-05 13:52 GMT+01:00 Homer, Tony

[GitHub] cordova-docs pull request: Doc Anchor Fixes

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/487#issuecomment-180636960 I'm assuming you grep'd for any `#link-` anchor links on our site that need to be changed now as we change the slugify scheme and prefix. --- If your project is

[GitHub] cordova-plugin-media pull request: CB-10476 - fix problem where ca...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/78#issuecomment-180658516 Actually it might have to wait until Monday before I can get to this. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-plugin-media pull request: CB-10476 - fix problem where ca...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/78#issuecomment-180658674 In the meantime, @jclalala can you [submit an ICLA](http://www.apache.org/licenses/#clas)? It's better for us to have one on file. --- If your project

[GitHub] cordova-plugin-media pull request: CB-10476 - fix problem where ca...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/78#issuecomment-180656412 Alright, I'm going to merge this in. It's small enough to not require an ICLA. --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-plugin-camera pull request: CB-10539: Commenting out the v...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/163#issuecomment-180633771 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-docs pull request: Doc Anchor Fixes

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/487#discussion_r52092001 --- Diff: www/static/js/docs.js --- @@ -17,49 +17,81 @@ $(document).ready(function () { -function getAnchorName(i, heading,

[GitHub] cordova-plugin-camera pull request: CB-10539: Commenting out the v...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/163 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-android pull request: CB-10498: Resume event should be sti...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/257 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-docs pull request: Doc Anchor Fixes

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/487#discussion_r52091918 --- Diff: www/static/js/docs.js --- @@ -17,49 +17,81 @@ $(document).ready(function () { -function getAnchorName(i, heading,

[GitHub] cordova-docs pull request: Doc Anchor Fixes

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/487#discussion_r52092095 --- Diff: www/static/js/docs.js --- @@ -17,49 +17,81 @@ $(document).ready(function () { -function getAnchorName(i, heading,

[GitHub] cordova-js pull request: CB-9366 Log error.stack as it helps with ...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-js/pull/118#issuecomment-180637928 @jimmont Why is the `try-catch` a pain? Is it because the stack gets reset here? You have a fair point about the callback not being deleted on exception scenarios.

[GitHub] cordova-docs pull request: CB-10206: Documenting uses-sdk attribut...

GitHub user riknoll opened a pull request: https://github.com/apache/cordova-docs/pull/490 CB-10206: Documenting uses-sdk attribute support in config.xml And stripped a lot of trailing whitespace. I recommend you append `?w=1` to the URL (lets you view diff without whitespace