[GitHub] cordova-plugin-splashscreen pull request: Fixed doccument issue

2016-02-09 Thread dhams
Github user dhams closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/80 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[PR] Plugin Docs in Main Docs

2016-02-09 Thread Dmitry Blotsky
Hey folks, I’m writing to draw your attention to this PR: https://github.com/apache/cordova-docs/pull/493, regarding showing plugin docs on the main Cordova docs website. I didn’t put up a live demo, but you can see what they look like with just a bit of setup and an invocation of “gulp serve”

[GitHub] cordova-plugin-vibration pull request: chore: edit package.json li...

2016-02-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-vibration/pull/43 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] cordova-plugin-splashscreen pull request: chore: edit package.json...

2016-02-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/79 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-network-information pull request: chore: edit packa...

2016-02-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-network-information/pull/37 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-media-capture pull request: chore: edit package.jso...

2016-02-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media-capture/pull/52 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] cordova-ios pull request: fixes for CB-10184 and CB-10493

2016-02-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/191 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-ios pull request: fixes for CB-10184 and CB-10493

2016-02-09 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/191#issuecomment-182166896 LGTM. In the future, let's fix all space formatting issues :) i'll merge this now --- If your project is set up for it, you can reply to this email and have yo

[GitHub] cordova-docs pull request: CB-10521 Add OS X platform to docs

2016-02-09 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-docs/pull/496 CB-10521 Add OS X platform to docs You can merge this pull request into a Git repository by running: $ git pull https://github.com/tripodsan/cordova-docs CB-10521 Alternatively you ca

[GitHub] cordova-plugin-media pull request: Appease iOS ATS issues by downl...

2016-02-09 Thread omefire
GitHub user omefire opened a pull request: https://github.com/apache/cordova-plugin-media/pull/81 Appease iOS ATS issues by downloading MP3 file from HTTPS instead of … …HTTP You can merge this pull request into a Git repository by running: $ git pull https://github.com/ome

Re: Introduction for apache corodva

2016-02-09 Thread Steven Gill
Welcome! Join us on slack and ask us any questions you have about contributing! slack.cordova.io On Tue, Feb 9, 2016 at 4:21 PM, Jesse wrote: > Welcome Dharmendra! Good to have you here. > Be sure to read http://cordova.apache.org/contribute/ > > > @purplecabbage > risingj.com > > On Fri, Feb 5

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-02-09 Thread rakatyal
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/474#discussion_r52400297 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -17,700 +17,498 @@ license: > specific language governing permissions and limitations

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-02-09 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/474#issuecomment-182149869 "CLI" should be "The CLI". Also, make sure that the platforms are consistently capitalized. Android and Windows are sometimes lowercase. Otherwise LGTM --- If yo

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-02-09 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/474#discussion_r52400040 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -17,700 +17,498 @@ license: > specific language governing permissions and limitations

[GitHub] cordova-osx pull request: CB-10582 Clean up code before release

2016-02-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-osx/pull/32 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-plugin-camera pull request: CB-10576: MobileSpec can't get...

2016-02-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/166 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: Introduction for apache corodva

2016-02-09 Thread Jesse
Welcome Dharmendra! Good to have you here. Be sure to read http://cordova.apache.org/contribute/ @purplecabbage risingj.com On Fri, Feb 5, 2016 at 2:58 AM, dharmendra sharma wrote: > Hi, > > My self Dharmendra sharma i am planning to commit the corodva for android > platform. > > I am having

[GitHub] cordova-plugin-camera pull request: CB-10576: MobileSpec can't get...

2016-02-09 Thread rakatyal
Github user rakatyal commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/166#issuecomment-182144797 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-camera pull request: CB-10576: MobileSpec can't get...

2016-02-09 Thread sarangan12
GitHub user sarangan12 opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/166 CB-10576: MobileSpec can't get results for Windows-Store 8.1 Builds Fixing a minor syntax issue @rakatyal @riknoll @nikhilkh Could you please review and merge this PR? You

[GitHub] cordova-osx pull request: CB-10582 Clean up code before release

2016-02-09 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-osx/pull/32 CB-10582 Clean up code before release You can merge this pull request into a Git repository by running: $ git pull https://github.com/tripodsan/cordova-osx CB-10582 Alternatively you ca

[GitHub] cordova-osx pull request: fix JavaScriptCore.h import case

2016-02-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-osx/pull/30 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-osx pull request: CB-10581 Remove deprecated methods

2016-02-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-osx/pull/31 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-02-09 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-docs/pull/474#issuecomment-182141339 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

Re: [mobilespec] bridge.test

2016-02-09 Thread Jesse
The test remains pending for all but android. I believe this test was added because there was an issue on android where iframes on the page could still access the bridge. @purplecabbage risingj.com On Tue, Feb 9, 2016 at 1:09 PM, Tobias Bocanegra wrote: > Hi, > > can someone explain what the b

[GitHub] cordova-osx pull request: CB-10581 Remove deprecated methods

2016-02-09 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-osx/pull/31 CB-10581 Remove deprecated methods You can merge this pull request into a Git repository by running: $ git pull https://github.com/tripodsan/cordova-osx CB-10581 Alternatively you can r

[GitHub] cordova-docs pull request: CB-10206: Documenting uses-sdk attribut...

2016-02-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/490 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-medic pull request: CB-10433: Removing the ETIMEDOUT error...

2016-02-09 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-medic/pull/76#issuecomment-182121613 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] cordova-medic pull request: CB-10433: Removing the ETIMEDOUT error...

2016-02-09 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/76#discussion_r52387149 --- Diff: medic/medic-run.js --- @@ -372,13 +372,13 @@ function main() { // timeout needs to be in milliseconds, but it's

[GitHub] cordova-mobile-spec pull request: CB-10572 Mobilespec tests not wo...

2016-02-09 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/137 CB-10572 Mobilespec tests not working for OSX You can merge this pull request into a Git repository by running: $ git pull https://github.com/tripodsan/cordova-mobile-spec CB-10

[GitHub] cordova-medic pull request: CB-10433: Removing the ETIMEDOUT error...

2016-02-09 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-medic/pull/76 CB-10433: Removing the ETIMEDOUT errors in medic-run Occasionally, requests to couchdb fail for mysterious reasons when medic-run does its polling for mobilespec results. These were being repo

[mobilespec] bridge.test

2016-02-09 Thread Tobias Bocanegra
Hi, can someone explain what the bridge.tests is supposed to do? especially, the pending() call [0]. the test remains pending on ios and osx. thanks. regards, toby [0] https://github.com/apache/cordova-mobile-spec/blob/master/cordova-plugin-mobilespec-tests/tests/bridge.tests.js#L31 --

[GitHub] cordova-plugin-inappbrowser pull request: Added Android cookie sha...

2016-02-09 Thread Sinistralis
Github user Sinistralis commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/122#issuecomment-182066306 I've been meaning to come back to this. I've been incredibly busying reforming the front-end process at my job. I'm trying to find the time but

[GitHub] cordova-plugin-file pull request: CB-10577 Check if URL points to ...

2016-02-09 Thread vldmrrr
GitHub user vldmrrr opened a pull request: https://github.com/apache/cordova-plugin-file/pull/162 CB-10577 Check if URL points to file or directory. You can merge this pull request into a Git repository by running: $ git pull https://github.com/vldmrrr/cordova-plugin-file CB-1

[GitHub] cordova-docs pull request: Doc Anchor Fixes

2016-02-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/487 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-plugin-splashscreen pull request: CB-10412 AutoHideSplashS...

2016-02-09 Thread bitflower
Github user bitflower commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/78#issuecomment-182047128 I picked the latest 3.2.1-dev because of this bug and now I get XCode memory errors when running an app in debug mode. If started normally on the

[GitHub] cordova-docs pull request: Added instructions for adding redirects...

2016-02-09 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/494#issuecomment-182046718 @riknoll Updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] cordova-docs pull request: CB-10206: Documenting uses-sdk attribut...

2016-02-09 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/490#issuecomment-182044901 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] cordova-medic pull request: CB-10561: Removing wp8 and windows-sto...

2016-02-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-medic/pull/75 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-android pull request: Makes CLI build play nice along with...

2016-02-09 Thread infil00p
Github user infil00p commented on the pull request: https://github.com/apache/cordova-android/pull/225#issuecomment-182036589 @saharshtibrewal I'm no longer having problems with Android Studio, so you should probably make sure the problem persists. --- If your project is set up for i

[GitHub] cordova-docs pull request: CB-10206: Documenting uses-sdk attribut...

2016-02-09 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/490#issuecomment-182036432 @dblotsky done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] cordova-docs pull request: CB-10481 Update the docs according to w...

2016-02-09 Thread rakatyal
Github user rakatyal commented on the pull request: https://github.com/apache/cordova-docs/pull/478#issuecomment-182035818 Sounds good. LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[CORDOVA CI Status] 2/8/2016

2016-02-09 Thread Mefire O .
Hi Community, Here's the latest status for our continuous integration (CI) machinery, broken down by platforms: No Build Current Status Reason for status 1 cordova-android-osx Warning InAppBrowser Timeout (CB-10542) - 31% Me

[GitHub] cordova-docs pull request: CB-10481 Update the docs according to w...

2016-02-09 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/478#issuecomment-182033601 @rakatyal I think we should do that as part of a single page guide that you will take up as it requires to setup 301 re-directs. --- If your project is set up f

[GitHub] cordova-docs pull request: CB-10481 Update the docs according to w...

2016-02-09 Thread rakatyal
Github user rakatyal commented on the pull request: https://github.com/apache/cordova-docs/pull/478#issuecomment-182031278 Can we change the folder name for guides from win8 to windows as well? www/docs/en/dev/guide/platforms/win8/index.md becomes www/docs/en/dev/guide/platforms/wind

[GitHub] cordova-docs pull request: CB-10560: Removing Amazon FireOS and Fi...

2016-02-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/492 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-docs pull request: Doc Anchor Fixes

2016-02-09 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/487#issuecomment-182023849 LGTM. Thanks, Dmitry for fixing this! I just tested it and it works very well! --- If your project is set up for it, you can reply to this email and have your re

[GitHub] cordova-mobile-spec pull request: CB-10569 Mobilespec doesn't use ...

2016-02-09 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/136#issuecomment-182021426 I opened a JIRA ([CB-10575](https://issues.apache.org/jira/browse/CB-10575)) --- If your project is set up for it, you can reply to this email and have you

[GitHub] cordova-mobile-spec pull request: CB-10569 Mobilespec doesn't use ...

2016-02-09 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/136#issuecomment-182015516 This LGTM and I tested it on my local machine. However, this also is just sort of masking a bug with `--searchpath`. I'm totally okay with doing that here

[GitHub] cordova-docs pull request: CB-10557 Adds plugins release blog post

2016-02-09 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/495#discussion_r52357723 --- Diff: www/_posts/2016-02-09-plugins-release.md --- @@ -0,0 +1,63 @@ +--- +layout: post +author: +name: Vladimir Kotikov

[VOTE] Plugins Release

2016-02-09 Thread Vladimir Kotikov (Akvelon)
Please review and vote on the release of this plugins release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-10557 The plugins have been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-10557 T

[GitHub] cordova-docs pull request: CB-10557 Adds plugins release blog post

2016-02-09 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-docs/pull/495#issuecomment-182008871 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-docs pull request: CB-10557 Adds plugins release blog post

2016-02-09 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/495#discussion_r52356712 --- Diff: www/_posts/2016-02-09-plugins-release.md --- @@ -0,0 +1,63 @@ +--- +layout: post +author: +name: Vladimir Kotikov +

[GitHub] cordova-plugin-inappbrowser pull request: Added Android cookie sha...

2016-02-09 Thread infil00p
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/122#issuecomment-182007524 Is there work being done on this? It'd probably be good to update the pull request so that it can be more easily tested against the current master.

[GitHub] cordova-docs pull request: Added instructions for adding redirects...

2016-02-09 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/494#issuecomment-182001874 LGTM, but I'd add more to the deprecated.html page. Just saying that the content is "deprecated" is sort of unclear. Instead, say something along the lines of "Thi

[GitHub] cordova-lib pull request: CB-10430 Adds forwardEvents method to ea...

2016-02-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/382 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-osx pull request: fix JavaScriptCore.h import case

2016-02-09 Thread tripodsan
Github user tripodsan commented on the pull request: https://github.com/apache/cordova-osx/pull/30#issuecomment-181997280 fixed via 63599eb61f862df94fa9d332c7dbe1df1680ed7a --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-lib pull request: CB-10482 Remove references to windows8 f...

2016-02-09 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/378#issuecomment-181997030 +1! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] cordova-plugin-camera pull request: CB-10270 android: Added back s...

2016-02-09 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/160#issuecomment-181996971 Alright, the real solution to this problem in my opinion is to get rid of the `getRealPath` function altogether. Not all URIs have real paths and there a

[GitHub] cordova-docs pull request: CB-10481 Update the docs according to w...

2016-02-09 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-docs/pull/478#issuecomment-181993842 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-docs pull request: CB-10481 Update the docs according to w...

2016-02-09 Thread sarangan12
Github user sarangan12 commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/478#discussion_r52350996 --- Diff: www/docs/en/dev/guide/platforms/win8/index.md --- @@ -49,37 +49,23 @@ on how to support IE along with comparable WebKit browsers.

[GitHub] cordova-lib pull request: CB-10567 Bubble up `cordova.raw.run()` e...

2016-02-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/381 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-docs pull request: CB-10206: Documenting uses-sdk attribut...

2016-02-09 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/490#discussion_r52349972 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -131,82 +131,85 @@ platform. See [Icons and Splash Screens](images.html) for more information.

[GitHub] cordova-docs pull request: CB-10206: Documenting uses-sdk attribut...

2016-02-09 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/490#discussion_r52347236 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -131,82 +131,85 @@ platform. See [Icons and Splash Screens](images.html) for more information.

[GitHub] cordova-lib pull request: CB-10482 Remove references to windows8 f...

2016-02-09 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-lib/pull/378#issuecomment-181980800 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cordova-docs pull request: CB-10481 Update the docs according to w...

2016-02-09 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/478#issuecomment-181978377 @rakatyal to review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-osx pull request: fix JavaScriptCore.h import case

2016-02-09 Thread tripodsan
Github user tripodsan commented on the pull request: https://github.com/apache/cordova-osx/pull/30#issuecomment-181971744 thanks. I created the respective bug in jira: CB-10570. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] cordova-osx pull request: Support for multi-dimensional js array/o...

2016-02-09 Thread spirylics
Github user spirylics commented on the pull request: https://github.com/apache/cordova-osx/pull/29#issuecomment-181967238 @tripodsan I've made a pullrequest : https://github.com/apache/cordova-osx/pull/30 Is it sufficient ? Since several weeks, I use case sensitive and I h

[GitHub] cordova-lib pull request: CB-10567 Bubble up `cordova.raw.run()` e...

2016-02-09 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-lib/pull/381#issuecomment-181961258 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cordova-lib pull request: CB-10430 Adds forwardEvents method to ea...

2016-02-09 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-lib/pull/382#issuecomment-181964075 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cordova-osx pull request: Support for multi-dimensional js array/o...

2016-02-09 Thread tripodsan
Github user tripodsan commented on the pull request: https://github.com/apache/cordova-osx/pull/29#issuecomment-181955368 thanks @spirylics for pointing this out. can you create a new issue in https://issues.apache.org/jira/browse/CB ? --- If your project is set up for it, you can re

RE: [DISCUSS] Plugin patch release

2016-02-09 Thread Steven Gill
Good to know. Quite the release. Some good fixes coming out. On Feb 9, 2016 5:57 AM, "Alexander Sorokin (Akvelon)" < v-als...@microsoft.com> wrote: > I thinks it is worth mentioning that inappbrowser, media and splashscreen > plugins got their minor version bumped. Since plugin versions are now >

[GitHub] cordova-lib pull request: CB-10430 Adds forwardEvents method to ea...

2016-02-09 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/382#issuecomment-181910107 @nikhilkh, could you please take a look --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-lib pull request: CB-10430 Adds forwardEvents method to ea...

2016-02-09 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/382 CB-10430 Adds forwardEvents method to easily connect two EventEmitters This fixes CB-10430. This change is needed to allow platform connect own `events` instance to another, p

[GitHub] cordova-mobile-spec pull request: CB-10569 Mobilespec doesn't use ...

2016-02-09 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/136 CB-10569 Mobilespec doesn't use edge versions of plugins https://issues.apache.org/jira/browse/CB-10569 You can merge this pull request into a Git repository by running: $ git pu

[GitHub] cordova-lib pull request: CB-10430 Allow to modify events source

2016-02-09 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/370#issuecomment-181906497 Closing this for now. I'll reopen another PR with updated implementation. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] cordova-lib pull request: CB-10430 Allow to modify events source

2016-02-09 Thread vladimir-kotikov
Github user vladimir-kotikov closed the pull request at: https://github.com/apache/cordova-lib/pull/370 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-dialogs pull request: CB-9347 - fix to allow to sta...

2016-02-09 Thread imaffett
Github user imaffett commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/54#issuecomment-181897670 @jcesarmobile - thanks for the prompt reply. This is the plugin https://github.com/phonegap/phonegap-plugin-barcodescanner.git --- If your project i

[GitHub] cordova-plugin-dialogs pull request: CB-9347 - fix to allow to sta...

2016-02-09 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/54#issuecomment-181897098 getTopPresentedViewController returns the view controller on the top, not necessarily the mainViewController, the dialog has to be presented over the

[GitHub] cordova-plugin-camera pull request: CB-10539 CaptureFileAsync does...

2016-02-09 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/165 CB-10539 CaptureFileAsync doesn't work when maxResolution is set to v… …erySmallQvga on Windows 10 [Jira issue](https://issues.apache.org/jira/browse/CB-10539) Fi

[GitHub] cordova-plugin-dialogs pull request: CB-9347 - fix to allow to sta...

2016-02-09 Thread imaffett
Github user imaffett commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/54#issuecomment-181886490 I'm running into a similar issue where showing an alert after using the phonegap-barcode-scanner plugin is failing. the getTopPresentedViewController m

[GitHub] cordova-plugin-splashscreen pull request: Fixed doccument issue

2016-02-09 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/80#discussion_r52312032 --- Diff: README.md --- @@ -123,6 +123,8 @@ window.setTimeout(function () { }, splashDuration - fadeDuration); ``` +##

[GitHub] cordova-plugin-splashscreen pull request: Fixed doccument issue

2016-02-09 Thread dhams
Github user dhams commented on a diff in the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/80#discussion_r52311417 --- Diff: README.md --- @@ -123,6 +123,8 @@ window.setTimeout(function () { }, splashDuration - fadeDuration); ``` +###

[GitHub] cordova-plugin-splashscreen pull request: Fixed doccument issue

2016-02-09 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/80#discussion_r52310332 --- Diff: README.md --- @@ -123,6 +123,8 @@ window.setTimeout(function () { }, splashDuration - fadeDuration); ``` +##

RE: [DISCUSS] Plugin patch release

2016-02-09 Thread Alexander Sorokin (Akvelon)
I thinks it is worth mentioning that inappbrowser, media and splashscreen plugins got their minor version bumped. Since plugin versions are now pinned, they will require their version to be specified manually on installation until next cordova tools release with pinned plugin versions. Thanks,

[GitHub] cordova-js pull request: CB-10558 Update cordova-js according to w...

2016-02-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-js/pull/131 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-plugin-splashscreen pull request: Fixed doccument issue

2016-02-09 Thread dhams
GitHub user dhams opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/80 Fixed doccument issue Changed miss leaded document. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accenture/cordova-plugin-sp

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

2016-02-09 Thread ianisted
Github user ianisted commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-181852903 @ochakov thanks, but I'm needing to perform QR code scanning. Seems you have a similar issue, though the phonegap-plugin-barcodescanner plugin uses Inte

[GitHub] cordova-lib pull request: CB-10567 Bubble up `cordova.raw.run()` e...

2016-02-09 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/381 CB-10567 Bubble up `cordova.raw.run()` error to the caller JIRA [CB-10567](https://issues.apache.org/jira/browse/CB-10567) You can merge this pull request into a Git repository by runn

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

2016-02-09 Thread ochakov
Github user ochakov commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-181845807 @ianisted Use my version of the plugin https://github.com/ochakov/cordova-plugin-camera --- If your project is set up for it, you can reply to t

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

2016-02-09 Thread ianisted
Github user ianisted commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-181845462 Any luck with a resolution to this issue? I'm using that Barcode plugin and I'm getting the following error "Sorry, the Android camera encountered a pro

[REVIEW] Plugins release blog post

2016-02-09 Thread Vladimir Kotikov (Akvelon)
Please review and comment: https://github.com/apache/cordova-docs/pull/495 - Best regards, Vladimir - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10557 Adds plugins release blog post

2016-02-09 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-docs/pull/495 CB-10557 Adds plugins release blog post Release issue: [CB-10557](https://issues.apache.org/jira/browse/CB-10557) You can merge this pull request into a Git repository by running:

[GitHub] cordova-plugin-camera pull request: CB-10270 android: Added back s...

2016-02-09 Thread olexme
Github user olexme commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/160#issuecomment-181818806 I had the same issue (empty string from getPicture() when trying to get the gallery picture) and I've just tried to use this PR by cordova plugin add

Re: [Vote] 4.3.3 Ubuntu Release

2016-02-09 Thread David Barth
The vote has now closed. The results are: Positive Binding Votes: 3 David Barth Steven Gill Jesse MacFadyen Negative Binding Votes: 0 The vote has passed. On Tue, Feb 9, 2016 at 10:04 AM, David Barth wrote: > \o/ Thank you Jesse. > > The warning is not a regression. We're fixing that in next

[GitHub] cordova-plugin-geolocation pull request: Update iOS geolocation pl...

2016-02-09 Thread guillaumedev
Github user guillaumedev commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/67#issuecomment-181782297 Just try my solution, and there is no problem anymore :D --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] cordova-cli pull request: CB-10482 Remove references to windows8 f...

2016-02-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/234 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-docs pull request: CB-10481 Update the docs according to w...

2016-02-09 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-docs/pull/478#issuecomment-181775667 @nikhilkh, @omefire, @sarangan12, could you please take a look if possible? --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] cordova-js pull request: CB-10558 Update cordova-js according to w...

2016-02-09 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-js/pull/131#issuecomment-181774989 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] cordova-plugin-camera pull request: CB-10270 android: Added back s...

2016-02-09 Thread shaoner
Github user shaoner commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/160#issuecomment-181769966 @riknoll yes, actually if you don't set correctOrientation to true, getRealPath is never called, it returns the uri instead (I don't see why) so this is

Re: [Vote] 4.3.3 Ubuntu Release

2016-02-09 Thread David Barth
\o/ Thank you Jesse. The warning is not a regression. We're fixing that in next release with the move to the new PlatformAPI. On Mon, Feb 8, 2016 at 8:56 PM, Jesse wrote: > +1 > > ran coho verify-archive > added to a project > > I did get a warning, although I don't think this blocks the vote.

  1   2   >