[GitHub] cordova-plugin-camera pull request: CB-10539 CaptureFileAsync does...

Github user daserge closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/165 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-lib pull request: CB-10519 Wrap all sync calls inside of `...

GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/384 CB-10519 Wrap all sync calls inside of `cordova.raw` methods into promises This is a fix for [CB-10519](https://issues.apache.org/jira/browse/CB-10519) This PR fixes the issue

RE: [VOTE] Plugins Release

I vote +1. * Verified signatures and hashes * Verified tags * Verified that plugins can be added correctly to blank app * Verified that blank app can be successfully built and ran * Verified that browserified app can be successfully built and ran (found 1 issue, see below) * Ran smoke testing of

[GitHub] cordova-plugin-splashscreen pull request: Cb 6498

Github user JoseWalker commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/81#issuecomment-182477242 Hi! I'm facing problems with the 3.1.0 splash plugin for iOS. I've seen that the 3.2.0 apparently have solved the issue. Now my problem is that

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

Github user rakatyal commented on the pull request: https://github.com/apache/cordova-docs/pull/474#issuecomment-182537864 Updated with suggestions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-docs pull request: CB-10481 Update the docs according to w...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/478 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-10584 Splashscreen plugin crashes the...

GitHub user daserge opened a pull request: https://github.com/apache/cordova-lib/pull/385 CB-10584 Splashscreen plugin crashes the app on windows 10 when built… … with browserify [Jira issue](https://issues.apache.org/jira/browse/CB-10584) You can merge this pull

[GitHub] cordova-docs pull request: CB-10481 Update the docs according to w...

Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-docs/pull/478#issuecomment-182516182 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

Github user rakatyal closed the pull request at: https://github.com/apache/cordova-docs/pull/474 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

Github user rakatyal commented on the pull request: https://github.com/apache/cordova-docs/pull/474#issuecomment-182567392 This has been merged as part of [this] (https://github.com/apache/cordova-docs/commit/d236276fb6c651b1a6d76e6dd3ea1c031b043c19) commit. --- If your project is

[GitHub] cordova-docs pull request: CB-10363: Cleaning up the 'plugin spec'...

Github user omefire closed the pull request at: https://github.com/apache/cordova-docs/pull/456 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-camera pull request: CB-10270 android: Added back s...

Github user shahin8r commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/160#issuecomment-182563046 This doesn't seem to fix empty string for videos (mediaType: 1) but is working fine on photos. --- If your project is set up for it, you can reply to

[GitHub] cordova-docs pull request: CB-10206: Documenting uses-sdk attribut...

Github user omefire commented on the pull request: https://github.com/apache/cordova-docs/pull/490#issuecomment-182577611 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-lib pull request: CB-10584 Splashscreen plugin crashes the...

Github user daserge commented on the pull request: https://github.com/apache/cordova-lib/pull/385#issuecomment-182552066 @vladimir-kotikov, could you please review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-lib pull request: CB-10584 Splashscreen plugin crashes the...

Github user daserge commented on the pull request: https://github.com/apache/cordova-lib/pull/385#issuecomment-182551514 It was taking the old version from `legacy_exec` so `base.js` was not found. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-docs pull request: CB-10363: Cleaning up the 'plugin spec'...

Github user rakatyal commented on the pull request: https://github.com/apache/cordova-docs/pull/456#issuecomment-182569279 @omefire: Can you close this PR? I took care of most of these changes in my commit. --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-docs pull request: CB-10481 Update the docs according to w...

Github user omefire commented on the pull request: https://github.com/apache/cordova-docs/pull/478#issuecomment-182576365 Should we not also remove Win8 from other languages ? i.e:

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/474#issuecomment-182553520 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Buildbot: buildslave cordova-windows-slave was lost

The Buildbot working for '' has noticed that the buildslave named cordova-windows-slave went away It last disconnected at Wed Feb 10 22:07:06 2016 (buildmaster-local time) The admin on record (as reported by BUILDSLAVE:info/admin) was 'Dmitry Blotsky '. Sincerely, The

[GitHub] cordova-plugin-media pull request: CB-10535: Circumvent iOS ATS is...

Github user omefire closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/81 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-media pull request: CB-10535: Fix Plugin Media cras...

GitHub user omefire opened a pull request: https://github.com/apache/cordova-plugin-media/pull/82 CB-10535: Fix Plugin Media crash due to seeking before buffering of file is completed You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-plugin-media pull request: CB-10535: Fix Plugin Media cras...

Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/82#issuecomment-182658276 Reviewing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

RE: [PR] Plugin Docs in Main Docs

Hey folks, I'm pinging y'all about this once again because this was a contentious issue at the F2F. This change displays plugin docs on the main docs site. Please voice your feedback if you have any. Kindly, Dmitry -Original Message- From: Dmitry Blotsky

[GitHub] cordova-docs pull request: CB-10552: Pull all the plugin docs to C...

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/493#issuecomment-182702522 @stevengill @purplecabbage @csantanapr please take a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-docs pull request: Added instructions for adding redirects...

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/494#issuecomment-182702147 @stevengill ping. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-docs pull request: CB-10481 Update the docs according to w...

Github user daserge commented on the pull request: https://github.com/apache/cordova-docs/pull/478#issuecomment-182746309 @omefire, I thought that translations are handled (semi)automatically using Crowdin, i.e. the `en/dev` version updates are translated and a snapshot then copied

[GitHub] cordova-lib pull request: CB-10584 Splashscreen plugin crashes the...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/385#discussion_r52569334 --- Diff: cordova-lib/src/plugman/browserify.js --- @@ -106,7 +106,7 @@ module.exports = function doBrowserify (project, platformApi,

[GitHub] cordova-lib pull request: CB-10518 Correct log level and error mes...

GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/383 CB-10518 Correct log level and error messages for some cordova errors Issue [CB-10518](https://issues.apache.org/jira/browse/CB-10518) You can merge this pull request into a Git

[GitHub] cordova-docs pull request: Add Cordova Ubuntu 4.3.3 blog post

GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-docs/pull/497 Add Cordova Ubuntu 4.3.3 blog post Blog post to announce cordova-ubuntu 4.3.3 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-mobile-spec pull request: CB-10569 Mobilespec doesn't use ...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-mobile-spec/pull/136 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-lib pull request: CB-10482 Remove references to windows8 f...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/378 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-windows pull request: don't copy resource-files at plugin ...

Github user biasmv commented on the pull request: https://github.com/apache/cordova-windows/pull/139#issuecomment-182249434 Hi, just to follow up on this. I've changed the code to use relative paths. We have been using this version for a while for testing our plugin and it

[GitHub] cordova-docs pull request: CB-10481 Update the docs according to w...

Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/478#discussion_r52428160 --- Diff: www/docs/en/dev/guide/platforms/win8/index.md --- @@ -49,37 +49,23 @@ on how to support IE along with comparable WebKit browsers.

[GitHub] cordova-docs pull request: CB-10481 Update the docs according to w...

Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/478#discussion_r52428377 --- Diff: www/docs/en/dev/guide/platforms/win8/index.md --- @@ -49,37 +49,23 @@ on how to support IE along with comparable WebKit browsers.

[GitHub] cordova-plugin-splashscreen pull request: Cb 6498

GitHub user dhams opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/81 Cb 6498 Fixed document issue for android You can merge this pull request into a Git repository by running: $ git pull

Re: [CORDOVA CI Status] 2/8/2016

Hi Community, I realize the formatting in the last email was broken. These are the issues found by our CI infrastructure:

[GitHub] cordova-docs pull request: CB-10481 Update the docs according to w...

Github user daserge commented on the pull request: https://github.com/apache/cordova-docs/pull/478#issuecomment-182348840 @sarangan12, updated the links, please take a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-plugin-media pull request: CB-10535: Fix Plugin Media cras...

Github user omefire commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/82#issuecomment-182635288 @shazron , could you please help review these changes ? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-plugin-media pull request: CB-10535: Fix Plugin Media cras...

Github user omefire commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/82#issuecomment-182649235 When dealing with remote files, we can get into a situation where we start playing before the native iOS components (AVPlayer & AVPlayerItem) have had the

[GitHub] cordova-plugin-media pull request: CB-10535: Fix Plugin Media cras...

Github user omefire commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/82#issuecomment-182671912 @ghenry22 , interesting. What mediaStatus event lets you know when it's ready ? --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-plugin-media pull request: CB-10535: Fix Plugin Media cras...

Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/82#issuecomment-182667452 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-media pull request: CB-10535: Fix Plugin Media cras...

Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/82#issuecomment-182668004 That should fix the test for rate change as it will allow the media to buffer before starting to count play time. In reality actually using the

[GitHub] cordova-plugin-media pull request: CB-10535: Fix Plugin Media cras...

Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/82#issuecomment-182673242 I have an audioplayer service which creates the media object with media.play().then statement. In the then statement I wait for mediaStatus to hit 2 and