[GitHub] cordova-plugin-media-capture pull request: add JIRA issue tracker ...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media-capture/pull/45 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-media-capture pull request: CB-10690 windows: fix c...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media-capture/pull/56 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-android pull request: CB-10660 fixed the exception when re...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/261 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-android pull request: CB-10660 fixed the exception when re...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-android/pull/261#issuecomment-189149877 LGTM, merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-lib pull request: CB-10314 avoid fetching plugins when old...

Github user bso-intel commented on the pull request: https://github.com/apache/cordova-lib/pull/396#issuecomment-189123404 @vladimir-kotikov Could you review this? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-plugin-inappbrowser pull request: Should the README design...

GitHub user josh-m-sharpe opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/152 Should the README designate where general discussions take place? You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-ios pull request: CB-9254 copy over templates/PROJECT_NAME...

Github user stevengill commented on the pull request: https://github.com/apache/cordova-ios/pull/198#issuecomment-189082380 Okay, updated the PR. Take a look @shazron --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-docs pull request: Docs Touch-Up

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/523#issuecomment-189076643 @nikhilkh @riknoll please review this when you have a moment. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-docs pull request: Docs Touch-Up

GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-docs/pull/523 Docs Touch-Up - Refactoring front matter merging - Moving some functionality into util.js - Reverting some unintended gulpfile changes - Removing Segoe UI from font-family -

RE: [DISCUSS] Cordova-iOS release

Since this is a bug we encountered previously as well - should we block on it? Also, looks like it will not be a patch release and we may need an accompanying tools release. Is that correct? -Nikhil -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Wednesday,

[GitHub] cordova-lib pull request: New plugin version selection implementat...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/363#discussion_r54193600 --- Diff: cordova-lib/src/cordova/plugin.js --- @@ -512,3 +535,175 @@ function versionString(version) { return null; } +

[GitHub] cordova-docs pull request: Minor changes to TOC styling

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/522 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: Renaming 6.0.0 to 6.x.

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/520 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: Minor changes to TOC styling

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/522#issuecomment-189059339 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-medic pull request: CB-10671 and CB-10699: Android Windows...

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-medic/pull/83#issuecomment-189059097 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-docs pull request: Minor changes to TOC styling

GitHub user rakatyal opened a pull request: https://github.com/apache/cordova-docs/pull/522 Minor changes to TOC styling @dblotsky , @riknoll : Please review. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-lib pull request: CB-10622 fix target attribute being igno...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-lib/pull/392#issuecomment-189058742 @vladimir-kotikov to review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-media-capture pull request: [CB-10554] Fix null ref...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-media-capture/pull/51#issuecomment-189025565 Thanks for doing this! LGTM, I just need to test it. Can you add a note to the README about this quirk? Something like

[GitHub] cordova-ios pull request: fix formating issues from pull request 1...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/192 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-media-capture pull request: [CB-10554] Fix null ref...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-media-capture/pull/51#issuecomment-189000686 @riknoll to review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-camera pull request: Rebased ochakov's branch to th...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/174#issuecomment-188971773 Rebased and updated in #179 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-camera pull request: CB-10120 android: Camera permi...

GitHub user riknoll opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/179 CB-10120 android: Camera permission must be requested when present in Manifest Because three PRs are better than one. This provides fixes for #142 and is based on top of the

[GitHub] cordova-plugin-media-capture pull request: [CB-10554] Fix null ref...

Github user adamduren commented on the pull request: https://github.com/apache/cordova-plugin-media-capture/pull/51#issuecomment-188962549 @stevengill What additional steps do I need to take to get this resolved? --- If your project is set up for it, you can reply to this email and

[Vote] 5.1.1 Android Release (attempt 2)

Please review and vote on this 5.1.1 Android Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-10687 The archive has been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-10687 The package

[GitHub] cordova-docs pull request: CB-10679: Adding docs for new plugin ve...

GitHub user riknoll opened a pull request: https://github.com/apache/cordova-docs/pull/521 CB-10679: Adding docs for new plugin version fetching implementation **DO NOT MERGE! This PR is documenting https://github.com/apache/cordova-lib/pull/363 which has yet to be merged** You

[GitHub] cordova-medic pull request: CB-10671 and CB-10699: Android Windows...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-medic/pull/83#issuecomment-188944883 Also, the Android emulator medic-run code really needs to be refactored, but I didn't want to add that to this PR --- If your project is set up for it, you can

[GitHub] cordova-medic pull request: CB-10671 and CB-10699: Android Windows...

GitHub user riknoll opened a pull request: https://github.com/apache/cordova-medic/pull/83 CB-10671 and CB-10699: Android Windows CI fixes for logging and run This addresses two JIRAs: [CB-10671](https://issues.apache.org/jira/browse/CB-10671) and

[GitHub] cordova-ios pull request: CB-9254 copy over templates/PROJECT_NAME...

Github user stevengill commented on the pull request: https://github.com/apache/cordova-ios/pull/198#issuecomment-188936225 Chatted with Shaz. Going to update this PR to do most of the steps create does during update. Safest way --- If your project is set up for it, you can reply to

[GitHub] cordova-docs pull request: Renaming 6.0.0 to 6.x.

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/520#issuecomment-188892886 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

Github user dieppe commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-188872652 You can also check this fork https://github.com/jnuine/cordova-plugin-camera It includes a major refactor of the iOS plugin which fixes some bugs,

[GitHub] cordova-plugin-console pull request: CB-10636 Add JSHint for plugi...

GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-console/pull/16 CB-10636 Add JSHint for plugins [Jira issue](https://issues.apache.org/jira/browse/CB-10636) You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-ios pull request: fix formating issues from pull request 1...

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/192#discussion_r54118663 --- Diff: bin/templates/project/__PROJECT_NAME__/Images.xcassets/AppIcon.appiconset/Contents.json --- @@ -121,6 +121,12 @@ "scale" : "2x"

Re: [Vote] 5.1.1 Android Release

This vote has failed. I'll send a new one today. On Feb 24, 2016 12:52 PM, "Steven Gill" wrote: > Please review and vote on this 5.1.1 Android Release > by replying to this email (and keep discussion on the DISCUSS thread) > > Release issue:

RE: [DISCUSS] Cordova-Android 5.2.0 Release

Ahh your right. Looks like since 5.1.x existed I needed to manually cherry-pick changes into it instead of relying on coho prepare-release command. I'll send a new vote today. On Feb 25, 2016 6:19 AM, "Alexander Sorokin (Akvelon)" < v-als...@microsoft.com> wrote: > I think there's something

[GitHub] cordova-lib pull request: CB-10583 Protect plugin preferences from...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/400 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

RE: [DISCUSS] Cordova-Android 5.2.0 Release

I think there's something wrong with the package: it doesn't contain any of the changes described in the release notes, only increased version. -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Thursday, February 25, 2016 5:59 AM To: dev@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10583 Protect plugin preferences from...

Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-lib/pull/400#issuecomment-188757069 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-plugin-battery-status pull request: CB-10636 Add JSHint fo...

GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-battery-status/pull/32 CB-10636 Add JSHint for plugins [Jira issue](https://issues.apache.org/jira/browse/CB-10636) You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-lib pull request: CB-10662 Use project's config.xml as a f...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/398 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-file-transfer pull request: CB-10636 Add JSHint for...

GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/127 CB-10636 Add JSHint for plugins [Jira issue](https://issues.apache.org/jira/browse/CB-10636) You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-lib pull request: CB-10662 Use project's config.xml as a f...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/398#discussion_r54081599 --- Diff: cordova-lib/src/plugman/platforms/browser.js --- @@ -31,25 +29,7 @@ module.exports = { return path.join(project_dir,

[GitHub] cordova-lib pull request: CB-10662 Use project's config.xml as a f...

Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/398#issuecomment-188730806 Thanks @vladimir-kotikov - looks good. Just a couple of suggestions. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-lib pull request: CB-10662 Use project's config.xml as a f...

Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/398#discussion_r54079687 --- Diff: cordova-lib/src/plugman/platforms/browser.js --- @@ -31,25 +29,7 @@ module.exports = { return path.join(project_dir, 'www');

[GitHub] cordova-lib pull request: CB-10662 Use project's config.xml as a f...

Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/398#discussion_r54079611 --- Diff: cordova-lib/src/plugman/platforms/common.js --- @@ -22,7 +22,39 @@ var shell = require('shelljs'), fs= require('fs'),

[GitHub] cordova-medic pull request: CB-10638 Appium runner: Fixed build co...

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-medic/pull/82#issuecomment-188721218 @alsorokin I'll test this locally tomorrow (i.e. in about 10 hours) and I'll give any remaining feedback, if there is any. Thanks again for the improvements!

[GitHub] cordova-medic pull request: CB-10652 Added the instruction on how ...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-medic/pull/81 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-10662 Apply project config to platfor...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/398#issuecomment-188710263 Thanks for advice, @TimBarham. Updated --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-plugin-wkwebview-engine pull request: CB-10636 Add JSHint ...

GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/6 CB-10636 Add JSHint for plugins [Jira issue](https://issues.apache.org/jira/browse/CB-10636) You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-lib pull request: CB-10583 Protect plugin preferences from...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/400#issuecomment-188674424 @sgrebnov, could you take a look please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-lib pull request: CB-10583 Protect plugin preferences from...

GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/400 CB-10583 Protect plugin preferences from adding extra Array properties JIRA [CB-10583](https://issues.apache.org/jira/browse/CB-10583) You can merge this pull request into a Git