Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-android/pull/267#issuecomment-191631596
> Is this supported in other platforms too? If not, should it be?
It sound like platform-agnostic Plugman's feature, so my thinking is that
it
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-windows/pull/155#issuecomment-191624625
> Is there also a PR for removing these from cordova-lib?
No, because the code these tests are testing is still in cordova-lib. I
think we
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-android/pull/264#issuecomment-191616111
Since now I created the --force-copying-src option, the current behavior of
throwing exception is preserved.
To get around this issue, the user can use
Welcome Jerroyd!
Make sure to join us on slack! Sign up at slack.cordova.io.
Let us know if you have any question!
-Steve
On Wed, Mar 2, 2016 at 9:53 PM, Nikhil Khandelwal
wrote:
> Welcome! Looking forward to your contributions!
>
> -Nikhil
>
> -Original
GitHub user bso-intel opened a pull request:
https://github.com/apache/cordova-lib/pull/404
CB-10673 added --force-copying-src option
This option is need to rescue some Cordova users who has trouble installing
two conflicting plugins that use the same source-file target.
You can
GitHub user bso-intel opened a pull request:
https://github.com/apache/cordova-cli/pull/236
CB-10673 added --force-copying-src option
This option is need to rescue some Cordova users who has trouble installing
two conflicting plugins that use the same source-file target.
You can
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/528
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Welcome! Looking forward to your contributions!
-Nikhil
-Original Message-
From: So, Byoungro [mailto:byoungro...@intel.com]
Sent: Wednesday, March 2, 2016 8:16 PM
To: dev@cordova.apache.org
Subject: Re: Personal Introduction: Jerroyd Moore
Welcome on board, Jerroyd.
Byoungro So
SSG /
Welcome on board, Jerroyd.
Byoungro So
SSG / DPD / Mobile Computing and Compilers
Intel Corporation
On 3/2/16, 2:03 PM, "Carlos Santana" wrote:
>Welcome Jerroyd !
>
>
>On Wed, Mar 2, 2016 at 4:56 PM Jerroyd Moore wrote:
>
>> Hello Apache
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54834210
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -512,3 +543,219 @@ function versionString(version) {
return null;
}
+
Github user okonon commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/179#issuecomment-191558538
@riknoll got it thanks a lot. Fingers crossed. hopefully he will do it soon
---
If your project is set up for it, you can reply to this email and have
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/528#discussion_r54830785
--- Diff: www/docs/en/dev/config_ref/images.md ---
@@ -42,79 +45,107 @@ density | *Optional* Specified icon
density (Android Specific)
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/526#discussion_r54830128
--- Diff: www/static/js/index.js ---
@@ -145,17 +145,46 @@ $(document).ready(function () {
// Smooth scroll to anchor links
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-battery-status/pull/33#discussion_r54829785
--- Diff: README.md ---
@@ -57,120 +60,81 @@ attach an event listener after the `deviceready` event
fires.
- BlackBerry 10
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/179#issuecomment-191549054
There were conflicts that he resolved, so yes I do need an ICLA
---
If your project is set up for it, you can reply to this email and have your
reply
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/532#discussion_r54829006
--- Diff: www/static/js/docs.js ---
@@ -17,19 +17,30 @@
$(document).ready(function () {
-function slugify(text) {
+
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/526#discussion_r54826548
--- Diff: www/static/js/index.js ---
@@ -145,17 +145,46 @@ $(document).ready(function () {
// Smooth scroll to anchor links
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/186#issuecomment-191537745
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-console/pull/17#issuecomment-191537055
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-lib/pull/402#issuecomment-191536082
@vladimir-kotikov
Could you review this pull request?
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-battery-status/pull/33#discussion_r54825729
--- Diff: README.md ---
@@ -57,120 +60,81 @@ attach an event listener after the `deviceready` event
fires.
- BlackBerry 10
-
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-battery-status/pull/33#discussion_r54825752
--- Diff: README.md ---
@@ -57,120 +60,81 @@ attach an event listener after the `deviceready` event
fires.
- BlackBerry 10
-
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-battery-status/pull/33#discussion_r54825731
--- Diff: README.md ---
@@ -57,120 +60,81 @@ attach an event listener after the `deviceready` event
fires.
- BlackBerry 10
-
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-android/pull/267#issuecomment-191535809
Are there tests for this? I don't know how to test this to verify that the
fix works.
---
If your project is set up for it, you can reply to this email and
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-android/pull/267#issuecomment-191534609
Is this supported in other platforms too?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/532#discussion_r54825004
--- Diff: www/static/js/docs.js ---
@@ -17,19 +17,30 @@
$(document).ready(function () {
-function slugify(text) {
+
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-network-information/pull/39#discussion_r54824539
--- Diff: README.md ---
@@ -27,7 +27,7 @@ This plugin provides an implementation of an old version
of the
It provides
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/528#issuecomment-191533128
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/89#discussion_r54824272
--- Diff: README.md ---
@@ -23,7 +23,7 @@
This plugin displays and hides a splash screen during application launch.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-media-capture/pull/58
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
GitHub user gaelenh opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/85
CB-10723: iOS audio should use audioFile player
avPlayer.play does not play the requested audio file. Use the player on the
audioFile object to play instead. I checked out stop and
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/528#discussion_r54822846
--- Diff: www/docs/en/dev/config_ref/images.md ---
@@ -42,79 +45,107 @@ density | *Optional* Specified icon
density (Android Specific)
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/89#issuecomment-191524399
The commit message has a typo
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/89#discussion_r54822518
--- Diff: README.md ---
@@ -23,7 +23,7 @@
This plugin displays and hides a splash screen during application launch.
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-network-information/pull/39#discussion_r54822492
--- Diff: README.md ---
@@ -27,7 +27,7 @@ This plugin provides an implementation of an old version
of the
It provides
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/533#issuecomment-191523696
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/527#discussion_r54822185
--- Diff: www/_posts/2016-02-29-docs-improvement.md ---
@@ -0,0 +1,39 @@
+---
+layout: post
+author:
+name: Raghav Katyal
+
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/527#discussion_r54822052
--- Diff: www/_posts/2016-02-29-docs-improvement.md ---
@@ -0,0 +1,39 @@
+---
+layout: post
+author:
+name: Raghav Katyal
+
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/527#issuecomment-191523360
Nitpick: please use reference-style links.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/527#discussion_r54821949
--- Diff: www/_posts/2016-02-29-docs-improvement.md ---
@@ -0,0 +1,39 @@
+---
+layout: post
+author:
+name: Raghav Katyal
+
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/84#issuecomment-191521724
Ell Gee Tee Emm.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-windows/pull/155#issuecomment-191521522
Is there also a PR for removing these from `cordova-lib`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Tweet: https://twitter.com/apachecordova/status/705195091959291906
Blog: http://cordova.apache.org/announcements/2016/03/02/ios-4.1.0.html
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54820983
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -512,3 +543,219 @@ function versionString(version) {
return null;
}
+
+/**
Tweet: https://twitter.com/apachecordova/status/705194344588783616
Blog:
http://cordova.apache.org/announcements/2016/03/02/cordova-android-5.1.1.html
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/155#discussion_r54820656
--- Diff: spec/unit/JsprojManager.spec.js ---
@@ -53,6 +54,13 @@ describe('JsprojManager', function () {
JsprojManager.__set__('proj',
GitHub user sarangan12 opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/89
CB-10764: Remove emoji in cordovo-plugin-splashscreen
Removing warning emoji
@dblotsky @riknoll @rakatyal Can you please review and merge this PR?
You can merge this
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54819210
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -512,3 +543,219 @@ function versionString(version) {
return null;
}
+
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-docs/pull/533#issuecomment-191507967
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user sarangan12 opened a pull request:
https://github.com/apache/cordova-docs/pull/533
CB-10762: Fix the link in Icons page
Fixing the splashscreen link in the icons page.
@dblotsky @riknoll @rakatyal Can you please review and merge this PR?
You can merge this pull
The Buildbot working for ''
has noticed that the buildslave named cordova-windows-slave went away
It last disconnected at Thu Mar 3 00:24:41 2016 (buildmaster-local time)
The admin on record (as reported by BUILDSLAVE:info/admin)
was 'Dmitry Blotsky
'.
Sincerely,
The
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/530#discussion_r54817953
--- Diff: www/_posts/2016-03-02-ios-4.1.0.md ---
@@ -0,0 +1,47 @@
+---
+layout: post
+author:
+name: Steve Gill
+url:
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-device-orientation/pull/26
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-dialogs/pull/67
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54817429
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -305,6 +289,49 @@ module.exports = function plugin(command, targets,
opts) {
});
};
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/166
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/363#issuecomment-191504890
Okay, I added a lot of verbose logging and responded to some of the
refactor stuff @TimBarham mentioned (except where noted). I plan to rebase this
down to one
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/58#issuecomment-191501509
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54814983
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -305,6 +289,49 @@ module.exports = function plugin(command, targets,
opts) {
});
};
GitHub user dblotsky opened a pull request:
https://github.com/apache/cordova-docs/pull/532
Reverse-engineering GitHub's slugifying function.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-docs CB-10739
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-docs/pull/528#issuecomment-191490969
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/528#discussion_r54811063
--- Diff: www/docs/en/dev/guide/overview/index.md ---
@@ -129,27 +125,20 @@ task, they each offer advantages:
this workflow if you need to
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/528#discussion_r54810855
--- Diff: www/docs/en/dev/guide/hybrid/plugins/index.md ---
@@ -93,30 +95,28 @@ the platform-specific `config.xml` file to make the
platform aware of
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/527#issuecomment-191489272
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54809830
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -512,3 +543,219 @@ function versionString(version) {
return null;
}
+
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/527#discussion_r54809742
--- Diff: www/_posts/2016-02-29-docs-improvement.md ---
@@ -0,0 +1,39 @@
+---
+layout: post
+author:
+name: Raghav Katyal
+
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/527#discussion_r54809498
--- Diff: www/_posts/2016-02-29-docs-improvement.md ---
@@ -0,0 +1,39 @@
+---
+layout: post
+author:
+name: Raghav Katyal
+
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/527#discussion_r54809280
--- Diff: www/_posts/2016-02-29-docs-improvement.md ---
@@ -0,0 +1,39 @@
+---
+layout: post
+author:
+name: Raghav Katyal
+
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/527#discussion_r54809135
--- Diff: www/_posts/2016-02-29-docs-improvement.md ---
@@ -0,0 +1,39 @@
+---
+layout: post
+author:
+name: Raghav Katyal
+
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/530
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/529
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
On Wed, Mar 2, 2016 at 2:34 PM, Carlos Santana wrote:
> What do you mean by a manual step to set the architecture?
>
> meaning that "cordova build" will build one apk by default
>
>
Yes, right now if I set the version code to 1 and do a crosswalk build, I
would get the
What do you mean by a manual step to set the architecture?
meaning that "cordova build" will build one apk by default
But if they want a specific architecture or multiple built they can do via
extra argument to "cordova build"
Like cordova build -- --x86 --arm
This is similar for windows
On Wed, Mar 2, 2016 at 2:02 PM, Carlos Santana wrote:
> Avoiding a large APK is kind of a good feature to have, to build small apk
> targeted to specific architecture.
>
> What's your proposal ? Maybe I missed it
>
>
Step 1. Remove the code that changes version codes but
GitHub user rakatyal opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/188
CB-10414: Adding focus handler to resume video when user comes back oâ¦
â¦n leaving the app while preview was running
You can merge this pull request into a Git repository by
Welcome Jerroyd !
On Wed, Mar 2, 2016 at 4:56 PM Jerroyd Moore wrote:
> Hello Apache Cordova!
>
> I am a member of the HTML5 Tools Team at Intel. My main responsibilities
> include managing the backend build system, including the tools that build
> cordova applications
Avoiding a large APK is kind of a good feature to have, to build small apk
targeted to specific architecture.
What's your proposal ? Maybe I missed it
You said to remove multiple apk generation or have multiple apk generation
being don in a different way to handle the versionCode per
The vote has now closed. The results are:
Positive Binding Votes: 4
Steve Gill
Sergey Grebnov
Omar Mefire
Carlos Santana
The vote has passed.
On Wed, Mar 2, 2016 at 1:08 PM, Carlos Santana wrote:
> +1
>
> coho verify-archive vote-ios/cordova-ios-4.1.0.tgz
>
> coho
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/153
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Hi everyone!,
Here's the latest status for our continuous integration (CI) machinery, broken
down by platforms:
Builders Status
Issues
Hello Apache Cordova!
I am a member of the HTML5 Tools Team at Intel. My main responsibilities
include managing the backend build system, including the tools that build
cordova applications for windows platforms. I used to dabble in HTML5 apps,
but am moving away from user application development
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/58#issuecomment-191447457
Can I merge this one? The quotes are just formatting that is used through
the rest of the file, so I'd rather not update it unless we are making
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-media/pull/84
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
On Wed, Mar 2, 2016 at 1:26 PM, Carlos Santana wrote:
> If it's not well documented how this multiple APKs suppose to work and use.
> then I would say the impact is low
>
I disagree, since people using Crosswalk are expecting that behaviour by
default right now. We don't
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/166#issuecomment-191442193
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/527#discussion_r54793831
--- Diff: www/_posts/2016-02-29-docs-improvement.md ---
@@ -0,0 +1,39 @@
+---
+layout: post
+author:
+name: Raghav Katyal
+
GitHub user omefire opened a pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/67
Remove 'warning' emoji, as it doesn't correctly display in the docs wâ¦
â¦ebsite:
http://cordova.apache.org/docs/en/dev/cordova-plugin-dialogs/index.html
You can merge this pull
+1
coho verify-archive vote-ios/cordova-ios-4.1.0.tgz
coho verify-tags -r ios --tag 4.1.0
coho create-archive -r ios --tag 4.1.0
(minor diffs in node_modules/ related to windows vs linux end of lines)
created hello app
On Tue, Mar 1, 2016 at 1:28 PM Mefire O. wrote:
OK, so, I'm dealing with this code, which pisses me off to no end:
if (Boolean.valueOf(cdvBuildMultipleApks)) {
productFlavors {
armv7 {
versionCode defaultConfig.versionCode + 2
ndk {
abiFilters "armeabi-v7a", ""
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54785237
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -512,3 +543,219 @@ function versionString(version) {
return null;
}
+
+/**
GitHub user omefire opened a pull request:
https://github.com/apache/cordova-plugin-device-orientation/pull/26
Remove 'warning' emoji, as it doesn't correctly display in the docs wâ¦
â¦ebsite:
http://cordova.apache.org/docs/en/dev/cordova-plugin-device-orientation/index.html
You
Github user omefire commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/166#issuecomment-191410281
@rakatyal
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user omefire opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/166
Remove 'warning' emoji, as it doesn't correctly display in the docs wâ¦
â¦ebsite: cordova.apache.org/docs/en/dev/cordova-plugin-file/index.html
You can merge this pull request into a
Github user okonon commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/179#issuecomment-191394465
@riknoll what in particular the ICLA for this PR? For the fact that
@MatthewBooth rebased someone else's commits? If yes, can someone more
responsive
Github user mix3d commented on the pull request:
https://github.com/apache/cordova-ios/pull/193#issuecomment-191390888
Thanks @stevengill - I've been checking it daily for almost the last week.
Eyes are well peeled.
---
If your project is set up for it, you can reply to this email
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54772365
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -512,3 +543,219 @@ function versionString(version) {
return null;
}
+
+/**
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54771328
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -512,3 +543,219 @@ function versionString(version) {
return null;
}
+
+/**
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54771522
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -512,3 +543,219 @@ function versionString(version) {
return null;
}
+
+/**
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/530#discussion_r54767182
--- Diff: www/_posts/2016-03-02-ios-4.1.0.md ---
@@ -0,0 +1,47 @@
+---
+layout: post
+author:
+name: Steve Gill
+url:
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-191358763
Hey @okonon, that has been done in #179, which will hopefully be merged in
soon. Just waiting on an ICLA.
---
If your project is set up for it, you can
1 - 100 of 137 matches
Mail list logo