[GitHub] cordova-lib pull request: CB-10314 avoid fetching plugins when old...

Github user bso-intel commented on the pull request: https://github.com/apache/cordova-lib/pull/396#issuecomment-192567709 @vladimir-kotikov , Just a friendly reminder. This is still not merged. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-lib pull request: CB-10328 set top-level property of plugi...

Github user bso-intel commented on the pull request: https://github.com/apache/cordova-lib/pull/402#issuecomment-19288 @vladimir-kotikov , I added an e2e test that is described in CB-10328. The test fails without my fix, and passes with my fix. Could you merge this pull

[GitHub] cordova-plugin-file pull request: CB-10577: Android resolveLocalFi...

Github user rakatyal commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/167#issuecomment-192543406 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-docs pull request: Moving dev to 6.x

Github user rakatyal commented on the pull request: https://github.com/apache/cordova-docs/pull/537#issuecomment-192542631 Yes. They were added as part of [this](https://github.com/apache/cordova-docs/pull/507/files) commit. We added landing pages for guides which we didn't make

[GitHub] cordova-plugin-file pull request: CB-10577: Android resolveLocalFi...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/167#issuecomment-192542492 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-docs pull request: Moving dev to 6.x

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/537#issuecomment-192540964 @rakatyal it looks like some pages were added to other languages than English. Was this intentional? --- If your project is set up for it, you can reply to this

[GitHub] cordova-docs pull request: Moving dev to 6.x

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/537#discussion_r55110503 --- Diff: www/docs/de/6.x/guide/platforms/blackberry10/home.md --- @@ -0,0 +1,29 @@ +--- +license: > +Licensed to the Apache Software

Re: Discuss: Moving current 'dev' documentation to 6.x

Hey folks, Just bringing up an important note: this change is only coming to English. Other languages will not get the change and they will still have older content that looks different even though the version is the same (6.x). Are we okay with this change in user experience? Kindly, Dmitry

[GitHub] cordova-docs pull request: CB-8976: Restoring documentation for an...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/540#issuecomment-192534567 @infil00p @nikhilkh please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-docs pull request: CB-8976: Restoring documentation for an...

GitHub user riknoll opened a pull request: https://github.com/apache/cordova-docs/pull/540 CB-8976: Restoring documentation for android version code The version code documentation was lost in the update to the config.xml reference. This restores that old information and moves it to

[GitHub] cordova-plugin-file pull request: CB-10577: Android resolveLocalFi...

GitHub user jasongin opened a pull request: https://github.com/apache/cordova-plugin-file/pull/167 CB-10577: Android resolveLocalFileSystemURL should detect directory @rakatyal or @riknoll please review There were two places in the Android file plugin code that didn't do

Re: Test Plugin on npm

Thanks Shaz for keeping us legit #2legit2quit [1] [1]: https://www.youtube.com/watch?v=wiyYozeOoKs On Fri, Mar 4, 2016 at 4:49 PM Richard Knoll wrote: > Great! I think I will actually put the source for the plugin into the > cordova-lib test folder to make it clear

RE: DISCUSS cordova-paramedic

Thanks, Jesse! -Nikhil -Original Message- From: Carlos Santana [mailto:csantan...@gmail.com] Sent: Friday, March 4, 2016 1:58 PM To: dev@cordova.apache.org Subject: Re: DISCUSS cordova-paramedic +1 Jesse for the contribution On Fri, Mar 4, 2016 at 4:01 PM Jesse

RE: Test Plugin on npm

Great! I think I will actually put the source for the plugin into the cordova-lib test folder to make it clear that it is only intended for testing. Thanks, Richard -Original Message- From: Shazron [mailto:shaz...@gmail.com] Sent: Friday, March 4, 2016 12:58 PM To:

[GitHub] cordova-plugin-globalization pull request: CB-10792 -Cannot instal...

Github user csantanapr commented on the pull request: https://github.com/apache/cordova-plugin-globalization/pull/47#issuecomment-192465550 @dubeejw I meant not the file itself but the path, I think you know what I meant :laughing: --- If your project is set up for it, you can

Re: DISCUSS cordova-paramedic

Repo created here: https://git-wip-us.apache.org/repos/asf?p=cordova-paramedic.git and github mirror here: https://github.com/apache/cordova-paramedic @purplecabbage risingj.com On Thu, Mar 3, 2016 at 3:59 PM, Jesse wrote: > Nikhil and team have expressed interest in

[GitHub] cordova-plugin-globalization pull request: CB-10792 -Cannot instal...

Github user csantanapr commented on the pull request: https://github.com/apache/cordova-plugin-globalization/pull/47#issuecomment-192465283 Hi @dubeejw it would be good to go over all the cordova plugins plugin.xml and check which one have this bug of not using lower case for source

Re: Test Plugin on npm

Here are the guidelines: http://www.apache.org/dev/release.html#what In short, what others have said is correct. Test packages do not require a vote as long as they follow the (bolded) guidelines in the link I cited above. On Fri, Mar 4, 2016 at 10:30 AM, Richard Knoll

Re: Test Plugin on npm

I vote that you don't need a vote :-) - Carlos @csantanapr > On Mar 4, 2016, at 2:18 PM, Nikhil Khandelwal wrote: > > I agree - this is for testing purposes only - no VOTE required. > > -Nikhil > > > > >> On 3/4/16, 11:08 AM, "Steven Gill"

[Vote] 4.0.1 OSX Release (attempt 2)

Please review and vote on this 4.0.1 OSX Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-10779 The archive has been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-10779 The package was

Re: [DISCUSS] OSX 4.0.1 release

fixed it. Updated coho so it will update that file for osx. On Fri, Mar 4, 2016 at 7:35 AM, Steven Gill wrote: > I'll resend it in a bit. Coho should have updated it. I'll investigate. > On Mar 4, 2016 4:16 AM, "Alexander Sorokin (Akvelon)" < > v-als...@microsoft.com>

Re: [Vote] 4.0.1 OSX Release

This vote has failed. Resending On Thu, Mar 3, 2016 at 4:01 PM, Steven Gill wrote: > Please review and vote on this 4.0.1 OSX Release > by replying to this email (and keep discussion on the DISCUSS thread) > > Release issue: https://issues.apache.org/jira/browse/CB-10779

Re: [DISCUSS] Plugins release

cordova-plugin-camera should be released too, right now picking images from the gallery doesn't work on android 4.4+ 2016-03-04 19:42 GMT+01:00 Edna Y Morales : > > Hi, > > There are some fixes we are wanting to get released for > cordova-plugin-globalization and

Re: Test Plugin on npm

I agree - this is for testing purposes only - no VOTE required. -Nikhil On 3/4/16, 11:08 AM, "Steven Gill" wrote: >The real question is do we vote on it before posting to npm. > >Since it isn't for general release distribution, but just for testing, I >would say you

Re: Test Plugin on npm

The real question is do we vote on it before posting to npm. Since it isn't for general release distribution, but just for testing, I would say you don't have to vote on it. Thoughts? -Steve On Fri, Mar 4, 2016 at 10:43 AM, Richard Knoll wrote: > Yep, I would like to

[DISCUSS] Plugins release

Hi, There are some fixes we are wanting to get released for cordova-plugin-globalization and cordova-plugin-splashscreen. Any thoughts on when we can do the next release for these? For cordova-plugin-globalization there are several deprecation warnings that we need to get rid of. Addressed by

Re: Test Plugin on npm

Hey Byoungro, We already test local plugins. I think the point of Richard asking is so we actually test our npm fetching and installing. Cheers, -Steve On Fri, Mar 4, 2016 at 10:37 AM, So, Byoungro wrote: > Hi Richard, > > Do you know you can add the plugin from your

Re: Test Plugin on npm

Hi Richard, Do you know you can add the plugin from your local disk path? “cordova plugin add ” might be easier for you than publishing your test plugin on the NPM registry and test using NPM. Byoungro So SSG / DPD / Mobile Computing and Compilers Intel Corporation From: Richard Knoll

Re: Test Plugin on npm

We all just your our own accounts to publish. Publish away On Fri, Mar 4, 2016 at 10:30 AM, Richard Knoll wrote: > Hey all, > > I'd like to have some better end-to-end tests for "cordova plugin add" in > cordova-lib, so I wanted to publish a test plugin to npm. The plugin

Test Plugin on npm

Hey all, I'd like to have some better end-to-end tests for "cordova plugin add" in cordova-lib, so I wanted to publish a test plugin to npm. The plugin itself will be empty besides a plugin.xml, I just need it to exist and have engine information I can test against. Do we have an official npm

[GitHub] cordova-windows pull request: CB-10673 fixed conflicting plugin in...

Github user bso-intel commented on the pull request: https://github.com/apache/cordova-windows/pull/154#issuecomment-192389824 @nikhilkh, Could you review this? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-lib pull request: CB-10673 added --force-copying-src optio...

Github user bso-intel commented on the pull request: https://github.com/apache/cordova-lib/pull/404#issuecomment-192389465 @nikhilkh, Could you review this? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-ios pull request: CB-10673 fixed conflicting plugin instal...

Github user bso-intel commented on the pull request: https://github.com/apache/cordova-ios/pull/199#issuecomment-192389706 @nikhilkh, Could you review this? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-android pull request: CB-8976: Removing the auto-version f...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/270 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-cli pull request: CB-10748 Use cordova-common.CordovaLogge...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-cli/pull/235#issuecomment-192373606 Are there still some test failures? @daserge Could you also add the travis badge for cordova-cli --- If your project is set up for it, you can reply to this

[GitHub] cordova-plugin-globalization pull request: CB-10792 -Cannot instal...

GitHub user dubeejw opened a pull request: https://github.com/apache/cordova-plugin-globalization/pull/47 CB-10792 -Cannot install cordova-plugin-globalization with cordova-windows on Ubuntu - Make Windows lower-case in plugin.xml You can merge this pull request into a Git

Re: [Vote] Cordova-browser 4.1.0 Release

I vote +1 coho verify-tags -r browser coho verify-archive --tag 4.1.0 -r browser vote-browser/cordova-browser-4.1.0.tgz coho create-archive -r browser --tag 4.1.0 --dest test-browser/ compare contents of archives tested with hello app On Fri, Mar 4, 2016 at 9:39 AM Vladimir Kotikov

[GitHub] cordova-android pull request: CB-8976: Removing the auto-version f...

Github user csantanapr commented on the pull request: https://github.com/apache/cordova-android/pull/270#issuecomment-192333002 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-docs pull request: CB-10788 Add blog post about browser@4....

GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-docs/pull/539 CB-10788 Add blog post about browser@4.1.0 release You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-docs

[Vote] Cordova-browser 4.1.0 Release

Please review and vote on this Cordova-browser 4.1.0 Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-10788 The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-10788

[GitHub] cordova-lib pull request: CB-10791 Add adjustLoggerLevel to cordov...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/405#discussion_r55035943 --- Diff: cordova-common/src/CordovaLogger.js --- @@ -153,6 +153,30 @@ CordovaLogger.prototype.setLevel = function (logLevel) { };

[GitHub] cordova-android pull request: CB-10749 Use cordova-common.CordovaL...

Github user daserge commented on the pull request: https://github.com/apache/cordova-android/pull/268#issuecomment-192302740 Thanks for the review! Added https://issues.apache.org/jira/browse/CB-10791 and https://github.com/apache/cordova-lib/pull/405 for the `adjustLoggerLevel`

[GitHub] cordova-android pull request: CB-10749 Use cordova-common.CordovaL...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-android/pull/268#issuecomment-192302388 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-lib pull request: CB-10791 Add adjustLoggerLevel to cordov...

GitHub user daserge opened a pull request: https://github.com/apache/cordova-lib/pull/405 CB-10791 Add adjustLoggerLevel to cordova-common.CordovaLogger [Jira issue](https://issues.apache.org/jira/browse/CB-10791) You can merge this pull request into a Git repository by running:

[GitHub] cordova-android pull request: CB-10749 Use cordova-common.CordovaL...

Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/268#discussion_r55032086 --- Diff: bin/templates/cordova/Api.js --- @@ -29,11 +29,23 @@ var AndroidProject = require('./lib/AndroidProject'); var PlatformMunger =

[GitHub] cordova-android pull request: CB-10749 Use cordova-common.CordovaL...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/268#discussion_r55029692 --- Diff: bin/templates/cordova/Api.js --- @@ -91,8 +102,11 @@ function Api(platform, platformRootDir, events) { * instance or

[GitHub] cordova-android pull request: CB-10749 Use cordova-common.CordovaL...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/268#discussion_r55029727 --- Diff: bin/templates/cordova/Api.js --- @@ -91,8 +102,11 @@ function Api(platform, platformRootDir, events) { * instance or

[GitHub] cordova-android pull request: CB-10749 Use cordova-common.CordovaL...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/268#discussion_r55029617 --- Diff: bin/templates/cordova/Api.js --- @@ -29,11 +29,23 @@ var AndroidProject = require('./lib/AndroidProject'); var PlatformMunger

[GitHub] cordova-android pull request: CB-10749 Use cordova-common.CordovaL...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/268#discussion_r55029308 --- Diff: bin/templates/cordova/loggingHelper.js --- @@ -0,0 +1,18 @@ +var CordovaLogger = require('cordova-common').CordovaLogger;

[GitHub] cordova-android pull request: CB-10768 Use cordova-common.superspa...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/269 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

RE: [DISCUSS] Cordova-browser release

Hey, guys. Here is a release notes for this release: ### 4.1.0 (Mar 04, 2016) * CB-10788 Updated checked in node_modules * CB-10650 Non-index content.src causes Splashscreen to be not displayed on browser * CB-9836 Add .gitattributes to prevent CRLF line endings in repos * CB-9669 Browser exec

RE: [DISCUSS] OSX 4.0.1 release

Hi Steven, There is a small issue with this release: The file 'bin/templates/scripts/cordova/version' doesn't seem to be updated by coho and contains the following line: var VERSION="4.0.0-dev"; I don't know if that's a blocker so I'm just reporting it here. What do you think? Thanks,

[GitHub] cordova-cli pull request: CB-10748 Use cordova-common.CordovaLogge...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/235 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-media pull request: CB-10723: iOS audio should use ...

Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/85#issuecomment-192183151 cool I'll test this out when I have a chance and see if it still behaves as expected in my app as it uses a mix of local and streaming content --- If