[GitHub] cordova-cli pull request: Remove invalid space from license in pac...

2016-03-07 Thread BBosman
GitHub user BBosman opened a pull request: https://github.com/apache/cordova-cli/pull/237 Remove invalid space from license in package.json Typo introduced in e2f3cf6d403a9f23fa130ddfdc5fc74c69365f6e Ping @nikhilkh You can merge this pull request into a Git repository by ru

[GitHub] cordova-docs pull request: Cleaned up plugin authoring guide

2016-03-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/542 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-android pull request: CB-10673 fixed conflicting plugin in...

2016-03-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/264 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-docs pull request: Cleaned up plugin authoring guide

2016-03-07 Thread rakatyal
Github user rakatyal commented on the pull request: https://github.com/apache/cordova-docs/pull/542#issuecomment-193633116 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] cordova-windows pull request: CB-10673 fixed conflicting plugin in...

2016-03-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/154 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-ios pull request: CB-10673 fixed conflicting plugin instal...

2016-03-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/199 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: Can we please kill the Battery Plugin on Android

2016-03-07 Thread Carlos Santana
+1 API for android can be remove from plugin with major bump version of the plugin. I would say that would start the clock for the six months support for the previous version. A patch release can be done to mark API deprecated for those picking only minor and patch to start getting the warning

[GitHub] cordova-lib pull request: CB-10673 added --force-copying-src optio...

2016-03-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/404 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-cli pull request: CB-10673 added --force-copying-src optio...

2016-03-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/236 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: Can we please kill the Battery Plugin on Android

2016-03-07 Thread Joe Bowser
Actually, we already document this as clear as possible in the README.md for the plugin. I think this is a very serious understatement. https://github.com/apache/cordova-plugin-battery-status On Mon, Mar 7, 2016 at 10:09 PM, Joe Bowser wrote: > > > On Mon, Mar 7, 2016 at 10:00 PM, Nikhil Khan

Re: Can we please kill the Battery Plugin on Android

2016-03-07 Thread Joe Bowser
On Mon, Mar 7, 2016 at 10:00 PM, Nikhil Khandelwal wrote: > What's our deprecation policy? Should we log a deprecation message before > remove this support. What alternatives do Cordova developers have - are > there other plugins which provide the equivalent functionality - perhaps > with a bette

RE: Can we please kill the Battery Plugin on Android

2016-03-07 Thread Nikhil Khandelwal
What's our deprecation policy? Should we log a deprecation message before remove this support. What alternatives do Cordova developers have - are there other plugins which provide the equivalent functionality - perhaps with a better API - as opposed to polling events every 1% battery drop. -Nik

[GitHub] cordova-weinre pull request: `func` sometimes is undefined

2016-03-07 Thread wuchangming
Github user wuchangming commented on the pull request: https://github.com/apache/cordova-weinre/pull/13#issuecomment-193593096 I fixed this issue with trick in my program: ``` const weinre = require('weinre'); var temPrepareStackTrace = Error.prepareStackTrace; Error.pre

[GitHub] cordova-cli pull request: CB-10673 added --force-copying-src optio...

2016-03-07 Thread bso-intel
Github user bso-intel commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/236#discussion_r55312985 --- Diff: doc/readme.md --- @@ -315,6 +315,7 @@ cordova {plugin | plugins} [ | |--link | When installing from a local path,

[GitHub] cordova-weinre pull request: `func` sometimes is undefined

2016-03-07 Thread pmuellr
Github user pmuellr commented on the pull request: https://github.com/apache/cordova-weinre/pull/13#issuecomment-193584214 Weinre isn't really built to be integrated into another program, directly. It's really meant to be used stand-alone. What are you trying to do?

[GitHub] cordova-cli pull request: CB-10673 added --force-copying-src optio...

2016-03-07 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/236#discussion_r55310491 --- Diff: doc/readme.md --- @@ -315,6 +315,7 @@ cordova {plugin | plugins} [ | |--link | When installing from a local path,

[GitHub] cordova-weinre pull request: `func` sometimes is undefined

2016-03-07 Thread wuchangming
Github user wuchangming commented on the pull request: https://github.com/apache/cordova-weinre/pull/13#issuecomment-193567171 @pmuellr , It's because `Error.prepareStackTrace` is global scope. when I integrate `weinre` in my project, some awful happens in my OWN program and cause

Re: [DISCUSS] another problem with in-call status bar on iOS (inAppBrowser)

2016-03-07 Thread Shazron
We should leave this be, we can fix and think about it when its actually a problem. Ideally, it should listen to (UIApplicationDelegate): application:willChangeStatusBarFrame: application:didChangeStatusBarFrame: ... for the actual status bar frame changes. On Mon, Mar 7, 2016 at 1:42 AM,

Re: [iOS][statusbar plugin] How is StatusBarOverlaysWebView supposed to work?

2016-03-07 Thread Shazron
The Apple HIG has some guidelines, but essentially say "handle it properly" so that's no help. I would look at how the stock iOS apps handle it. The native ones do move down the UI, but Safari is different. Check out CB-10796, I added some screenshots. In short -- Safari, does *not* resize the web

Re: Can we please kill the Battery Plugin on Android

2016-03-07 Thread Shazron
+1 If no one has concerns by the end of the week, I'd say we would have lazy consensus and you can delete the Android part of the plugin (maybe prep the PR now) On Mon, Mar 7, 2016 at 12:12 PM, Joe Bowser wrote: > Hey > > Once again, I ran into someone using the Battery Plugin that actively kills

[GitHub] cordova-docs pull request: Moving dev to 6.x

2016-03-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/537 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-plugin-media pull request: iOS: Add support for playing no...

2016-03-07 Thread winstef
Github user winstef commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/39#issuecomment-193512333 any news to add this in? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[DISCUSS] Android InAppBrowser circular loop with deep links

2016-03-07 Thread Dan Polivy
Hi folks, I've been working on adding deep linking/Universal links to my app, and ran into an issue with the InAppBrowser on Android that I'd appreciate some feedback on. For those not familiar, deep linking allows the app to handle standard HTTP/HTTPS urls for a given website within the app it

[GitHub] cordova-docs pull request: CB-8976: Restoring documentation for an...

2016-03-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/540 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-weinre pull request: `func` sometimes is undefined

2016-03-07 Thread pmuellr
Github user pmuellr commented on the pull request: https://github.com/apache/cordova-weinre/pull/13#issuecomment-193485755 Thanks for the PR! Same comment as I left in #11 ... Is there an issue open for this at Jira? You can open one [here](https://issues.apache.org/

[GitHub] cordova-docs pull request: CB-8976: Restoring documentation for an...

2016-03-07 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/540#issuecomment-193485168 Updated --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-plugin-file pull request: Fix for CB-9753 : index out of b...

2016-03-07 Thread rakatyal
Github user rakatyal commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/164#issuecomment-19340 Merged [here](https://github.com/apache/cordova-plugin-file/commit/68e40437f48aa648e15653d74e007f5dbf5741ec). --- If your project is set up for it, you c

[GitHub] cordova-docs pull request: CB-8976: Restoring documentation for an...

2016-03-07 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/540#issuecomment-193474356 Minor comments. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-docs pull request: Cleaned up plugin authoring guide

2016-03-07 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/542#issuecomment-193474447 @rakatyal to help review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-docs pull request: CB-8976: Restoring documentation for an...

2016-03-07 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/540#discussion_r55280038 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -57,7 +57,7 @@ platform. See [Customize icons topic](images.html) for more information. --

[GitHub] cordova-docs pull request: CB-8976: Restoring documentation for an...

2016-03-07 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/540#discussion_r55279789 --- Diff: www/docs/en/dev/guide/platforms/android/index.md --- @@ -252,6 +252,34 @@ Note that plugins can also include `build-extras.gradle` files via:

[GitHub] cordova-lib pull request: New plugin version selection implementat...

2016-03-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/363 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-docs pull request: Cleaned up plugin authoring guide

2016-03-07 Thread nikhilkh
GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-docs/pull/542 Cleaned up plugin authoring guide You can merge this pull request into a Git repository by running: $ git pull https://github.com/nikhilkh/cordova-docs patch-1 Alternatively you can re

[GitHub] cordova-docs pull request: Moving dev to 6.x

2016-03-07 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/537#issuecomment-193445777 Cool. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] cordova-docs pull request: Moving dev to 6.x

2016-03-07 Thread rakatyal
Github user rakatyal commented on the pull request: https://github.com/apache/cordova-docs/pull/537#issuecomment-193443047 Yup this will make them access the platform guides for other languages as well. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-docs pull request: Moving dev to 6.x

2016-03-07 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/537#issuecomment-193442788 Ohh, I see. That makes sense now. Thanks for explaining. So then this change is technically for all languages, yes? --- If your project is set up for it, you can

[GitHub] cordova-plugin-contacts pull request: CB-10399 Added Appium tests

2016-03-07 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/101#issuecomment-193442451 @dblotsky @riknoll to review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-docs pull request: Moving dev to 6.x

2016-03-07 Thread rakatyal
Github user rakatyal commented on the pull request: https://github.com/apache/cordova-docs/pull/537#issuecomment-193441996 They were added to dev and now they are being added to 6.x --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-docs pull request: Moving dev to 6.x

2016-03-07 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/537#issuecomment-193441267 @rakatyal if they were part of a previous commit then please rebase this branch on top of master so that they don't show up in this PR. --- If your project is se

Can we please kill the Battery Plugin on Android

2016-03-07 Thread Joe Bowser
Hey Once again, I ran into someone using the Battery Plugin that actively kills the Battery on Android, and can we please discourage people from using this very broken plugin that we have no ability or intention of fixing? The reason I don't want to fix it because the browser already supports it

Re: [DISCUSS] Plugins release

2016-03-07 Thread julio cesar sanchez
I add cordova-plugin-statusbar to the list 2016-03-07 20:52 GMT+01:00 Edna Y Morales : > bump > > Thanks, > *Edna Morales* > > [image: Inactive hide details for julio cesar sanchez ---03/04/2016 > 02:52:54 PM---cordova-plugin-camera should be released too, right n]julio > cesar sanchez ---03/04/2

Re: [DISCUSS] Plugins release

2016-03-07 Thread Edna Y Morales
bump Thanks, Edna Morales From: julio cesar sanchez To: "dev@cordova.apache.org" Date: 03/04/2016 02:52 PM Subject:Re: [DISCUSS] Plugins release cordova-plugin-camera should be released too, right now picking images from the gallery doesn't work on android 4.4+ 2016-03-

CI Build Status 3-7-2015

2016-03-07 Thread Richard Knoll
Hey everyone, Status of the CI was pretty good last week! We are seeing occasional build failures in the Android builder on Windows that are the result of the Android emulator failing to start up correctly, but those failures are not common and the Android OS X builder is working consistently.

Re: [DISCUSS] OSX 4.0.1 release

2016-03-07 Thread Tobias Bocanegra
I don't think we need this file. I copied it from ios and adjusted it: https://github.com/apache/cordova-ios/blob/master/component.json apparently it was added for: https://issues.apache.org/jira/browse/CB-7775 and a fix for coho is pending: https://issues.apache.org/jira/browse/CB-7776 as it wa

[GitHub] cordova-plugin-file pull request: Fix for CB-9753 : index out of b...

2016-03-07 Thread rakatyal
Github user rakatyal commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/164#issuecomment-193391342 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] cordova-weinre pull request: `func` sometimes is undefined

2016-03-07 Thread pmuellr
Github user pmuellr commented on the pull request: https://github.com/apache/cordova-weinre/pull/11#issuecomment-193387358 Is there an issue open for this at Jira? You can open one [here](https://issues.apache.org/jira/secure/CreateIssueDetails!init.jspa?pid=12312420&components=123166

Re: [DISCUSS] OSX 4.0.1 release

2016-03-07 Thread Steven Gill
I'll ask toby what that file does. Hopefully not a blocker. coho will need to add support to update that file. On Mon, Mar 7, 2016 at 8:29 AM, Alexander Sorokin (Akvelon) < v-als...@microsoft.com> wrote: > Sorry I didn't mention it earlier but I just stumbled upon this > component.json file: > h

[GitHub] cordova-plugin-media-capture pull request: [CB-10554] Fix null ref...

2016-03-07 Thread adamduren
Github user adamduren commented on the pull request: https://github.com/apache/cordova-plugin-media-capture/pull/51#issuecomment-193344477 @riknoll Sorry for the delay. I pulled the note from the cordova camera plugin. They should be the same. --- If your project is set up for it,

RE: [DISCUSS] OSX 4.0.1 release

2016-03-07 Thread Alexander Sorokin (Akvelon)
Sorry I didn't mention it earlier but I just stumbled upon this component.json file: https://github.com/apache/cordova-osx/blob/4.0.x/component.json I'm not sure what's it's exact purpose so I'm not sure if it's a blocker. If it's not, I'm ready to vote +1. -Original Message- From: Stev

[GitHub] cordova-plugin-media pull request: CB-10723: iOS audio should use ...

2016-03-07 Thread MikelArnaiz
Github user MikelArnaiz commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/85#issuecomment-193184301 I changed those two lines and now it works, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

2016-03-07 Thread SergiiS
Github user SergiiS commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-193183285 Hello guys, was it merged? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[DISCUSS] another problem with in-call status bar on iOS (inAppBrowser)

2016-03-07 Thread julio cesar sanchez
I've been looking into this issue https://issues.apache.org/jira/browse/CB-10799 The problem is that the inAppBrowser creates a "fake" statusbar using a toolbar so the statusbar seems opaque. That toolbar is created with the size of the statusbar, and when the in-call statusbar is present it's 40

RE: [Vote] Cordova-browser 4.1.0 Release

2016-03-07 Thread Alexander Sorokin (Akvelon)
I vote +1: * Verified archives via `coho verify-archive` * Verified tags manually * Verified that blank app creates correctly with platform * Verified that blank app can be successfully ran and built * Verified that platform can be updated from previous version * Went through release notes * Check