Re: [DRAFT] [REPORT] Cordova - March 2016

LGTM 2016-03-11 3:28 GMT+01:00 Carlos Santana : > LGTM > > - Carlos > @csantanapr > > > On Mar 10, 2016, at 8:28 PM, Shazron wrote: > > > > Please read and review. I'm sending this out later tonight. > > > > >

[GitHub] cordova-ios pull request: CB-10769 Move plugin handlers tests into...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/200 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-windows pull request: CB-10838 Use logger from cordova-com...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/158 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-ios pull request: CB-10769 Move plugin handlers tests into...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-ios/pull/200#issuecomment-195226834 @dblotsky, updated/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-camera pull request: Adding DATA_URL warnings to RE...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/193#issuecomment-195220562 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-android pull request: [CB-10600] 'cordova run --release' u...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-android/pull/273#issuecomment-195215718 @daserge Can you please review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-docs pull request: Fix syntax highlighting within the Andr...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/549#issuecomment-195213880 Merged with 49710a0026137da0da6a7bcab91304bebe7528f2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-docs pull request: Fix syntax highlighting within the Andr...

Github user nikhilkh closed the pull request at: https://github.com/apache/cordova-docs/pull/549 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-paramedic pull request: Real time logging and other improv...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/1#discussion_r55791682 --- Diff: sample-config/.paramedic-core-plugins.config.js --- @@ -0,0 +1,51 @@ +module.exports = { +//"externalServerUrl":

[GitHub] cordova-docs pull request: CB-10829 Fixing reference links.

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/554#issuecomment-195164298 @riknoll please review when you have a moment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-docs pull request: CB-10829 Fixing reference links.

GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-docs/pull/554 CB-10829 Fixing reference links. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-docs CB-10829 Alternatively you can

Re: Simplifying cordova-cli README

Might want to add the --template stuff? > On 11 Mar 2016, at 1:31 PM, Carlos Santana wrote: > > Thanks Nikhil this looks very clean now > > +1 > > - Carlos > @csantanapr > >> On Mar 10, 2016, at 8:22 PM, Nikhil Khandelwal >> wrote: >> >>

Re: Simplifying cordova-cli README

Thanks Nikhil this looks very clean now +1 - Carlos @csantanapr > On Mar 10, 2016, at 8:22 PM, Nikhil Khandelwal wrote: > > Our cordova-cli readme has become super long & not been maintained over the > years. It repeats a lot of content from the docs. I have

Re: [DISCUSS] Removing plugin pinning

+1 - Carlos @csantanapr > On Mar 10, 2016, at 8:36 PM, Shazron wrote: > > +1 > >> On Thu, Mar 10, 2016 at 1:16 PM, Richard Knoll wrote: >> Hey everyone, >> >> With the new plugin version selection code merged into cordova-lib, are >> there any

Re: [DRAFT] [REPORT] Cordova - March 2016

LGTM - Carlos @csantanapr > On Mar 10, 2016, at 8:28 PM, Shazron wrote: > > Please read and review. I'm sending this out later tonight. > > https://github.com/cordova/apache-board-reports/blob/master/2016/2016-03.md > >

[GitHub] cordova-paramedic pull request: Real time logging and other improv...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/1#discussion_r55781222 --- Diff: lib/Tunnel.js --- @@ -0,0 +1,19 @@ + var exec = require('./utils').exec; + var path = require('path'); + var Q = require('Q');

[GitHub] cordova-plugin-contacts pull request: CB-10399 Added Appium tests

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55781014 --- Diff: appium-tests/helpers/wdHelper.js --- @@ -0,0 +1,68 @@ +/* jshint node: true */ +/* + * + * Licensed to the Apache

[GitHub] cordova-plugin-contacts pull request: CB-10399 Added Appium tests

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55780934 --- Diff: appium-tests/helpers/contactsHelper.js --- @@ -0,0 +1,222 @@ +/* jshint node: true */ +/* + * + * Licensed to the

[GitHub] cordova-plugin-contacts pull request: CB-10399 Added Appium tests

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55780861 --- Diff: appium-tests/helpers/contactsHelper.js --- @@ -0,0 +1,222 @@ +/* jshint node: true */ +/* + * + * Licensed to the

[GitHub] cordova-plugin-contacts pull request: CB-10399 Added Appium tests

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55780842 --- Diff: appium-tests/android/android.spec.js --- @@ -0,0 +1,338 @@ +/*jshint node: true, jasmine: true */ +/* + * + *

[GitHub] cordova-plugin-contacts pull request: CB-10399 Added Appium tests

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55780731 --- Diff: appium-tests/android/android.spec.js --- @@ -0,0 +1,338 @@ +/*jshint node: true, jasmine: true */ +/* + * + *

[GitHub] cordova-plugin-contacts pull request: CB-10399 Added Appium tests

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55780654 --- Diff: appium-tests/android/android.spec.js --- @@ -0,0 +1,338 @@ +/*jshint node: true, jasmine: true */ +/* + * + *

[GitHub] cordova-plugin-contacts pull request: CB-10399 Added Appium tests

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55780482 --- Diff: appium-tests/android/android.spec.js --- @@ -0,0 +1,338 @@ +/*jshint node: true, jasmine: true */ +/* + * + *

[GitHub] cordova-plugin-contacts pull request: CB-10399 Added Appium tests

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55780306 --- Diff: appium-tests/ios/ios.spec.js --- @@ -0,0 +1,352 @@ +/*jshint node: true, jasmine: true */ +/* + * + * Licensed to

[GitHub] cordova-plugin-contacts pull request: CB-10399 Added Appium tests

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55780286 --- Diff: appium-tests/ios/ios.spec.js --- @@ -0,0 +1,352 @@ +/*jshint node: true, jasmine: true */ +/* + * + * Licensed to

Re: [DISCUSS] Removing plugin pinning

+1 On Thu, Mar 10, 2016 at 1:16 PM, Richard Knoll wrote: > Hey everyone, > > With the new plugin version selection code merged into cordova-lib, are there > any objections to removing plugin pinning? I plan to open PRs soon on the > core plugins to move engine info into

[GitHub] cordova-docs pull request: CB-10819 Adding snapshotting and improv...

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/553#issuecomment-195134620 @riknoll @rakatyal please review when you have a moment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-plugin-camera pull request: [iOS] Fixed authorization erro...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/144#issuecomment-195134078 Hey @nleclerc, mind closing this PR? #146 was merged --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-docs pull request: CB-10819 Adding snapshotting and improv...

GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-docs/pull/553 CB-10819 Adding snapshotting and improving build system - Added 'snap' command to Makefile and gulpfile. - Fixed 'newversion' command. - Made fetched files live under /reference/.

[DRAFT] [REPORT] Cordova - March 2016

Please read and review. I'm sending this out later tonight. https://github.com/cordova/apache-board-reports/blob/master/2016/2016-03.md - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands,

Simplifying cordova-cli README

Our cordova-cli readme has become super long & not been maintained over the years. It repeats a lot of content from the docs. I have simplified it significantly by linking to relevant getting started, filing issues, contribution etc. sections that are part of our website. This should help

[GitHub] cordova-docs pull request: Clean up plugin publishing guide

Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/548#issuecomment-195129017 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-docs pull request: Clean up plugin publishing guide

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/548#issuecomment-195125079 @riknoll can you take a quick look as well? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

Re: [Android] New Bridge: evaluateJavascript

On Thu, Mar 10, 2016 at 3:54 PM, Darryl Pogue wrote: > If it's an addition to one of the public interfaces, doesn't that require a > major bump because every existing implementation of the interface would now > cause errors due to missing methods? > > Yeah, I hate semver.

Re: [Android] New Bridge: evaluateJavascript

If it's an addition to one of the public interfaces, doesn't that require a major bump because every existing implementation of the interface would now cause errors due to missing methods? Semver aside, this change sounds good to me. I've definitely encountered some bizarre issues with the

Re: [Android] New Bridge: evaluateJavascript

I didn't say it was a private API what I meant is that based on what you shared that this Will be a new public API another bridge people can use with the current API not broken. So a minor bump on the version is OK - Carlos @csantanapr > On Mar 10, 2016, at 4:03 PM, Joe Bowser

Re: Edit to Edit on Github for Docs

I agree Robert This points out that [1] Contribute page is missing the Edit button :-). If it was there you could've submitted the change Add to the list another way to help the project by clicking that Edit link and help out Advertise the "Edit Source on Github" link with some info how

[GitHub] cordova-docs pull request: Fix typo for orientation property portr...

GitHub user insane210 opened a pull request: https://github.com/apache/cordova-docs/pull/552 Fix typo for orientation property portrait. You can merge this pull request into a Git repository by running: $ git pull https://github.com/insane210/cordova-docs patch-1

[GitHub] cordova-cli pull request: CB-10679: Documenting how the CLI choose...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/241#discussion_r55768334 --- Diff: doc/readme.md --- @@ -337,6 +337,18 @@ There are a number of ways to specify a plugin: | commit-ish | Commit/tag/branch reference. If

[GitHub] cordova-cli pull request: CB-10679: Documenting how the CLI choose...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/241#discussion_r55767811 --- Diff: doc/readme.md --- @@ -337,6 +337,18 @@ There are a number of ways to specify a plugin: | commit-ish | Commit/tag/branch reference. If

[GitHub] cordova-cli pull request: CB-10679: Documenting how the CLI choose...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/241#discussion_r55766818 --- Diff: doc/readme.md --- @@ -337,6 +337,18 @@ There are a number of ways to specify a plugin: | commit-ish | Commit/tag/branch reference. If

Re: [DISCUSS] Removing plugin pinning

No objection here On Mar 10, 2016 1:17 PM, "Richard Knoll" wrote: > Hey everyone, > > With the new plugin version selection code merged into cordova-lib, are > there any objections to removing plugin pinning? I plan to open PRs soon on > the core plugins to move engine

[GitHub] cordova-plugin-camera pull request: Android FileHelper modificatio...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/149#issuecomment-195093360 I just got a Jellybean device, so I'm going to verify that there is no issue there first --- If your project is set up for it, you can reply to this

[GitHub] cordova-plugin-camera pull request: Android FileHelper modificatio...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/149#issuecomment-195092845 Shall we close this PR now? :boom: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

Re: Edit to Edit on Github for Docs

In my confused mode (as documented in my last e-mail) when I was wondering what does this "Edit" button do? I went looking for an answer on different Cordova documentation and contributor web pages. No answer was found. I would have thought it should be explained under "Contributing" somewhere

[GitHub] cordova-plugin-camera pull request: CB-10270 android: Added back s...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/160#issuecomment-195084460 @jcesarmobile I don't even know if this is an issue in Jelly Bean. Do you have a device to test with? --- If your project is set up for it, you can

[GitHub] cordova-ios pull request: CB-10769 Move plugin handlers tests into...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/200#discussion_r55762230 --- Diff: .jshintignore --- @@ -1,2 +1,3 @@ bin/node_modules/* bin/templates/project/* +tests/spec/unit/fixtures/* --- End diff --

[GitHub] cordova-ios pull request: CB-10769 Move plugin handlers tests into...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/200#discussion_r55762207 --- Diff: .gitignore --- @@ -7,3 +7,4 @@ tmp xcuserdata console.log node_modules/ +npm-debug.log --- End diff -- Please

[GitHub] cordova-plugin-camera pull request: CB-10270 android: Added back s...

Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/160#issuecomment-195082019 #175 only fixes it on API 19 and greater, maybe it should be moved outside. --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-plugin-camera pull request: Android FileHelper modificatio...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/149#issuecomment-195080403 I can confirm this is no longer an issue on Marshmallow. I tested all of the permutations of camera options with both the stock gallery app and Google

[GitHub] cordova-plugin-camera pull request: CB-9960 android: Fixed FileNot...

Github user riknoll closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/135 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-camera pull request: CB-10270 android: Added back s...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/160#issuecomment-195077141 Seems to have been fixed by #175, so I'm closing this --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-plugin-camera pull request: CB-10270 android: Added back s...

Github user riknoll closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/160 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-docs pull request: CB-10760: Document plugin element

Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/536#issuecomment-195072875 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-docs pull request: CB-10760: Document plugin element

Github user omefire commented on the pull request: https://github.com/apache/cordova-docs/pull/536#issuecomment-195072354 @riknoll :+1: handled. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-docs pull request: Documenting some missing prefs: Windows...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/534 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: CB-10836 Improving "Edit" links

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/551#issuecomment-195061572 @nikhilkh @rakatyal @stevengill please review when you have a moment. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-cli pull request: CB-10679: Documenting how the CLI choose...

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-cli/pull/241#issuecomment-195060242 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-docs pull request: CB-10760: Document plugin element

Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/536#issuecomment-195059738 I know this was merged, but there was another part to the JIRA. The example config.xml at the bottom of the file uses the plugin tag incorrectly (`version` should

[GitHub] cordova-docs pull request: CB-10760: Document plugin element

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/536 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-camera pull request: [iOS] Major refactor

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/185#discussion_r55750647 --- Diff: src/ios/CDVCamera.m --- @@ -398,10 +437,82 @@ - (NSString*)tempFilePath:(NSString*)extension do { filePath =

Re: [Android] New Bridge: evaluateJavascript

Well, If they add the method, the latest version of their plugin should still work with older versions of Cordova. So, is this really the same thing? On Thu, Mar 10, 2016 at 12:18 PM, Simon MacDonald wrote: > I think we are okay bumping the minor for this change not

[GitHub] cordova-plugin-camera pull request: [iOS] Major refactor

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/185#discussion_r55746231 --- Diff: src/ios/CDVCamera.m --- @@ -145,9 +198,38 @@ - (void)takePicture:(CDVInvokedUrlCommand*)command [self.commandDelegate

[GitHub] cordova-plugin-camera pull request: [iOS] Major refactor

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/185#discussion_r55746150 --- Diff: src/ios/CDVCamera.m --- @@ -145,9 +198,38 @@ - (void)takePicture:(CDVInvokedUrlCommand*)command [self.commandDelegate

[GitHub] cordova-plugin-camera pull request: [iOS] Major refactor

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/185#discussion_r55746051 --- Diff: src/ios/CDVCamera.m --- @@ -145,9 +198,38 @@ - (void)takePicture:(CDVInvokedUrlCommand*)command [self.commandDelegate

[GitHub] cordova-plugin-camera pull request: [iOS] Major refactor

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/185#discussion_r55745359 --- Diff: src/ios/CDVCamera.m --- @@ -145,9 +198,38 @@ - (void)takePicture:(CDVInvokedUrlCommand*)command [self.commandDelegate

Re: [Android] New Bridge: evaluateJavascript

I think we are okay bumping the minor for this change not the major. I'm in favour of this bridge as long as we don't need to guard all the code with reflection. Using reflection to call evaluateJavascript would negate any performance bonus. So if we can use evaluateJavascript on Android 4.4 and

FYI: new Apache Help Wanted site

https://helpwanted.apache.org/ We could populate some tasks there and put the widget on our homepage somewhere. - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail:

[GitHub] cordova-plugin-camera pull request: Adding DATA_URL warnings to RE...

GitHub user riknoll opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/193 Adding DATA_URL warnings to README Adding clearer warning messages to the README about DATA_URL, because that option provides us with a steady stream of JIRAs. @nikhilkh

Re: [DISCUSS] another problem with in-call status bar on iOS (inAppBrowser)

Apache mailserver has stripped your post of images, so we can't see anything. My point in listening for that delegate function is so we don't rely on the hardcoded 20. On Thu, Mar 10, 2016 at 7:40 AM, julio cesar sanchez wrote: > But the problem here is not when the

Re: [Android] New Bridge: evaluateJavascript

I don't think we need to bump major number, there is no public API brake we are just added a feature, old stuff will still work. On Thu, Mar 10, 2016 at 2:41 PM Joe Bowser wrote: > Well, since the problem is with ONLINE_EVENT having a race condition, > earlier versions of

Re: [Android] New Bridge: evaluateJavascript

Well, since the problem is with ONLINE_EVENT having a race condition, earlier versions of Android would have to use the slower LOAD_URL with known issues related to the input fields. There's more testing that needs to be done, obviously, but it's worth adding the third bridge in the next major

Re: [Android] New Bridge: evaluateJavascript

But what about 4.3 and lower versions of Android? How do we support them? Do we use ONLINE_EVENT if we detect were are running on those versions of Android? On Thu, Mar 10, 2016 at 1:36 PM Joe Bowser wrote: > So, apparently some people are reporting that the ONLINE_EVENT

[GitHub] cordova-plugin-file pull request: CB-10577: Windows resolveLocalFi...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/169 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-file pull request: CB-10577: Windows resolveLocalFi...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/169#issuecomment-195004006 LGTM. Tested on windows phone 8.1 emulator and Windows 10 --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-plugin-file pull request: CB-7862: FileReader reads large ...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/168 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-camera pull request: Prevent edited image to replac...

GitHub user t-nonque opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/192 Prevent edited image to replace the previous one You can merge this pull request into a Git repository by running: $ git pull https://github.com/t-nonque/cordova-plugin-camera

[GitHub] cordova-docs pull request: Fix syntax highlighting within the Andr...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/549#discussion_r55727012 --- Diff: www/docs/en/dev/guide/platforms/android/plugin.md --- @@ -284,72 +302,87 @@ documentation [here][permissions-guide]. As far as a

[GitHub] cordova-cli pull request: CB-10679: Documenting how the CLI choose...

GitHub user riknoll opened a pull request: https://github.com/apache/cordova-cli/pull/241 CB-10679: Documenting how the CLI chooses plugin versions Now in the README! Note that this relies on the documentation in https://github.com/apache/cordova-docs/pull/521 being merged.

[Android] New Bridge: evaluateJavascript

So, apparently some people are reporting that the ONLINE_EVENT bridge that we currently use by default in Android has a race condition when you start using more than one WebView in an application. Even though we decided to not support the case of having multiple webviews in an Application, it's

[GitHub] cordova-docs pull request: Fix syntax highlighting within the Andr...

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/549#discussion_r55724956 --- Diff: www/docs/en/dev/guide/platforms/android/plugin.md --- @@ -284,72 +302,87 @@ documentation [here][permissions-guide]. As far as a

[GitHub] cordova-android pull request: [CB-10600] 'cordova run --release' u...

GitHub user dpolivy opened a pull request: https://github.com/apache/cordova-android/pull/273 [CB-10600] 'cordova run --release' uses wrong apk When doing `cordova run android --release`, the CLI attempts to use the android-release-unsigned.apk, which naturally fails to install

[GitHub] cordova-windows pull request: CB-10838 Use logger from cordova-com...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-windows/pull/158#issuecomment-194969878 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-android pull request: fix issue with app_name containing a...

Github user revolunet commented on the pull request: https://github.com/apache/cordova-android/pull/272#issuecomment-194966222 tried to add a unit test for this but i need guidance --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-android pull request: fix issue with app_name containing a...

GitHub user revolunet opened a pull request: https://github.com/apache/cordova-android/pull/272 fix issue with app_name containing apostrophes When the app name has an apostrophe defined in config.xml, this cause an issue on Android when building cordova build android

[GitHub] cordova-plugin-splashscreen pull request: CB-10562 hide() not work...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/91#issuecomment-194966042 Can we add test cases for this area? Looks like we regressed behavior here. --- If your project is set up for it, you can reply to this email and

RE: [VOTE] Plugins Release camera@2.1.1 globalization@1.0.3 splashscreen@3.2.1 statusbar@2.1.2

+1 * Ran mobilespec plugin tests (ios) * Verified that hello world app be can built and run with plugins (ios) * Verified tags with 'coho verify-tags' Thanks, Edna Morales From: "Alexander Sorokin (Akvelon)" To: "dev@cordova.apache.org"

[GitHub] cordova-docs pull request: Blog post for Plugin release 03 12

Github user csantanapr commented on the pull request: https://github.com/apache/cordova-docs/pull/550#issuecomment-194888965 @dpogue weird I didn't catch this I was using VSCode preview and they looked fine, it could a difference in markdown with Github, I fixed, thanks for the

[GitHub] cordova-docs pull request: Blog post for Plugin release 03 12

Github user csantanapr commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/550#discussion_r55690550 --- Diff: www/_posts/2016-03-12-plugin-release.md --- @@ -0,0 +1,74 @@ +--- +layout: post +author: +name: Carlos Santana +

[GitHub] cordova-lib pull request: CB-10679: Improving version choosing log...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/406 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-10791 Add adjustLoggerLevel to cordov...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/405 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-splashscreen pull request: CB-10562 hide() not work...

GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/91 CB-10562 hide() not working in latest splashscreen plug in 3.1.0 in iOS [Jira issue](https://issues.apache.org/jira/browse/CB-10562) You can merge this pull request into a Git

[GitHub] cordova-windows pull request: CB-10838 Use logger from cordova-com...

GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-windows/pull/158 CB-10838 Use logger from cordova-common This implements https://issues.apache.org/jira/browse/CB-10838 You can merge this pull request into a Git repository by running: $ git

Re: Edit to Edit on Github for Docs

Hey Robert, What do you mean by the “Edit” button being documented? Also folks: here is a PR with a change addressing this discussion and a bit more: https://github.com/apache/cordova-docs/pull/551/files. Kindly, Dmitry On Mar 9, 2016, at 2:19 PM, Robert Posener

[GitHub] cordova-docs pull request: CB-10836 Improving "Edit" links

GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-docs/pull/551 CB-10836 Improving "Edit" links # Changes - Added links to Crowdin translation on appropriate pages - Changed "Edit" links for translated content to point to English sources

[GitHub] cordova-lib pull request: CB-10822 Manage plugins/modules metadata...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/408#issuecomment-194806460 The related changes for cordova android can be found here: https://github.com/apache/cordova-android/compare/master...MSOpenTech:CB-10822?expand=1 --- If

[GitHub] cordova-lib pull request: CB-10822 Manage plugins/modules metadata...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/408#issuecomment-194804304 https://github.com/apache/cordova-lib/commit/317cfdb374b9dfa215de77c617db0c373dc098c6 is seen here due to ASF git and Github is out of sync. --- If your

[GitHub] cordova-lib pull request: CB-10822 Manage plugins/modules metadata...

GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/408 CB-10822 Manage plugins/modules metadata using PlatformJson JIRA https://issues.apache.org/jira/browse/CB-10822 This PR adds brings logic for storing and generating plugin

[GitHub] cordova-plugin-statusbar pull request: New feature 'styleAndroidTr...

GitHub user aegliv opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/51 New feature 'styleAndroidTranslucent' Replaces the need for following plugin: ekuwang / cordova-plugin-statusbar You can merge this pull request into a Git repository by running:

RE: [VOTE] Plugins Release camera@2.1.1 globalization@1.0.3 splashscreen@3.2.1 statusbar@2.1.2

I vote +1. * Verified signatures and hashes * Verified tags * Verified that plugins can be added correctly to blank app * Verified that blank app can be successfully built and ran (windows and android) * Verified that browserified app can be successfully built and ran (windows and android) *

  1   2   >