[GitHub] cordova-android pull request: add JIRA issue tracker link

2016-03-11 Thread revolunet
Github user revolunet commented on the pull request: https://github.com/apache/cordova-android/pull/213#issuecomment-195246564 bump :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] cordova-android pull request: add JIRA issue tracker link

2016-03-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/213 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-plugin-contacts pull request: CB-10399 Added Appium tests

2016-03-11 Thread alsorokin
Github user alsorokin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55803047 --- Diff: appium-tests/ios/ios.spec.js --- @@ -0,0 +1,352 @@ +/*jshint node: true, jasmine: true */ +/* + * + * Licensed to

[GitHub] cordova-plugin-contacts pull request: CB-10399 Added Appium tests

2016-03-11 Thread alsorokin
Github user alsorokin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55803473 --- Diff: appium-tests/android/android.spec.js --- @@ -0,0 +1,338 @@ +/*jshint node: true, jasmine: true */ +/* + * + * Lic

[GitHub] cordova-plugin-contacts pull request: CB-10399 Added Appium tests

2016-03-11 Thread alsorokin
Github user alsorokin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55803572 --- Diff: appium-tests/android/android.spec.js --- @@ -0,0 +1,338 @@ +/*jshint node: true, jasmine: true */ +/* + * + * Lic

[GitHub] cordova-plugin-contacts pull request: CB-10399 Added Appium tests

2016-03-11 Thread alsorokin
Github user alsorokin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55803719 --- Diff: appium-tests/android/android.spec.js --- @@ -0,0 +1,338 @@ +/*jshint node: true, jasmine: true */ +/* + * + * Lic

[GitHub] cordova-plugin-contacts pull request: CB-10399 Added Appium tests

2016-03-11 Thread alsorokin
Github user alsorokin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55803966 --- Diff: appium-tests/helpers/contactsHelper.js --- @@ -0,0 +1,222 @@ +/* jshint node: true */ +/* + * + * Licensed to the

Re: [DRAFT] [REPORT] Cordova - March 2016

2016-03-11 Thread Shazron
Sent. On Thu, Mar 10, 2016 at 5:28 PM, Shazron wrote: > Please read and review. I'm sending this out later tonight. > > https://github.com/cordova/apache-board-reports/blob/master/2016/2016-03.md - To unsubscribe, e-mail: dev-un

[GitHub] cordova-android pull request: CB-10846 Add AppVeyor configuration

2016-03-11 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-android/pull/274 CB-10846 Add AppVeyor configuration You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-android CB-10846 Alter

[GitHub] cordova-ios pull request: CB-10846 Add AppVeyor configuration

2016-03-11 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-ios/pull/202 CB-10846 Add AppVeyor configuration You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-ios CB-10846 Alternatively

[GitHub] cordova-android pull request: CB-10846 Add AppVeyor configuration

2016-03-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/274 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-ios pull request: CB-10846 Add AppVeyor configuration

2016-03-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/202 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-plugin-camera pull request: Rebased ochakov's branch to th...

2016-03-11 Thread MatthewBooth
Github user MatthewBooth commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/174#issuecomment-195320677 @riknoll Cheers, I've done that. Sent the ICLA signed with my GPG keys to the secretary, and signed up to JIRA. I only rebased @ochakov's wo

[GitHub] cordova-plugin-camera pull request: Android FileHelper modificatio...

2016-03-11 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/149#issuecomment-195335571 I'm working on a PR that will remove the whole API11to18 part, so I think we can close this --- If your project is set up for it, you can reply to

[GitHub] cordova-plugin-camera pull request: CB-10270 android: Added back s...

2016-03-11 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/160#issuecomment-195337221 I'm going to send a PR that will use the API 19 method on android 11 and greater and will handle file urls --- If your project is set up for it, yo

[GitHub] cordova-plugin-camera pull request: Android FileHelper modificatio...

2016-03-11 Thread dlogo
Github user dlogo commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/149#issuecomment-195345471 @riknoll thanks for your work!! Don't hesitate to close this PR if a new one is coming to solve it. --- If your project is set up for it, you can reply to

[GitHub] cordova-plugin-contacts pull request: CB-10399 Added Appium tests

2016-03-11 Thread alsorokin
Github user alsorokin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55824201 --- Diff: appium-tests/android/android.spec.js --- @@ -0,0 +1,338 @@ +/*jshint node: true, jasmine: true */ +/* + * + * Lic

[GitHub] cordova-plugin-media pull request: cordova-plugin-media-with-compr...

2016-03-11 Thread ayyazzafar
GitHub user ayyazzafar opened a pull request: https://github.com/apache/cordova-plugin-media/pull/86 cordova-plugin-media-with-compression is not working with phonegap build I really need this plugin but this plugin is not working with build.phonegap.com I always get follow

Android N

2016-03-11 Thread Carlos Santana
Have someone evaluated Cordova with API 24/Android N [1]? Multi-Windows sounds like good if we can support. Wondering if the Data Saver thing how will affect File Transfer Scoped directory access plugin accessing IO, camera, file, etc.. [1]: http://developer.android.com/preview/index.html

Re: [Android] New Bridge: evaluateJavascript

2016-03-11 Thread Carlos Santana
Maybe we can do a Cordova Android 6.0 and sync it with Android N support when it comes out and this new bridge. On Thu, Mar 10, 2016 at 7:29 PM Joe Bowser wrote: > On Thu, Mar 10, 2016 at 3:54 PM, Darryl Pogue wrote: > > > If it's an addition to one of the public interfaces, doesn't that > re

[GitHub] cordova-docs pull request: CB-10836 Improving "Edit" links

2016-03-11 Thread csantanapr
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-docs/pull/551#issuecomment-195385864 @dblotsky Love the option to help with translations to get them to the right spot in Crowding. Still I think the label for the button should be changed

Re: Android N

2016-03-11 Thread Simon MacDonald
I flashed one of my phones with Android N and did some basic testing yesterday and Cordova-Android apps still work :) I believe Joe was going to look into multi-window support. We should probably create JIRA items for all the new Android N features so we can track them. Simon Mac Donald http://h

Re: Android N

2016-03-11 Thread Carlos Santana
I agree creating a JIRA Kaban board, don't know if that's the terminology. I know Shaz used that for Cordova iOS 4.0 and it was useful to see what the tasks included in one place. On Fri, Mar 11, 2016 at 10:25 AM Simon MacDonald wrote: > I flashed one of my phones with Android N and did some ba

Re: Android N

2016-03-11 Thread Simon MacDonald
That is a great idea. The board worked quite well for Cordova iOS 4.0. Simon Mac Donald http://hi.im/simonmacdonald On Fri, Mar 11, 2016 at 10:44 AM, Carlos Santana wrote: > I agree creating a JIRA Kaban board, don't know if that's the terminology. > I know Shaz used that for Cordova iOS 4.0 an

Re: [DISCUSS] Plugins release

2016-03-11 Thread Carlos Santana
If everything goes well with the VOTE I should be able to close it this weekend. Can someone give me access to npm to publish? I was reading the slides of a talk by the CTO on the many uses of npm [1], and I notice they talk about organizations and teams to manage access. Is creating a team/orga

Re: Android N

2016-03-11 Thread Carlos Santana
Can you create the board and add the initial tasks, then Joe can follow up and keep adding as more things get discover. Karen from the IBM team will also give it a try and she can create tasks/issues and add to the board on what ever she founds On Fri, Mar 11, 2016 at 10:46 AM Simon MacDonald w

Re: Android N

2016-03-11 Thread Joe Bowser
1. I don't want to use a Kanban board. 2. I did some initial investigation and the WebView on N isn't ready to be used. There's crashes the moment you try and resize a cordova application, and it's clear that we should probably wait until the next Developer Preview before we do anything. As far

Re: [DISCUSS] Plugins release

2016-03-11 Thread Steven Gill
Gave you npm publish access to all of the plugins! I looked into npm orgs when they first released them. They don't offer a free tier for open source yet. -Steve On Fri, Mar 11, 2016 at 7:49 AM, Carlos Santana wrote: > If everything goes well with the VOTE I should be able to close it this > w

Re: Android N

2016-03-11 Thread Carlos Santana
1. I don't have personal experience creating and managing a board, just talked about what I saw Steve and Shaz using it 2. 100% carefully evaluate and try to push new features to user land/ third party, I agree Joe with pushing to third-party, I was just pointing the obvious of plugin should not b

Re: [DISCUSS] Plugins release

2016-03-11 Thread Carlos Santana
Thanks Steve ! I will ask Laurie, maybe we get a golden ticket :-) On Fri, Mar 11, 2016 at 11:34 AM Steven Gill wrote: > Gave you npm publish access to all of the plugins! > > I looked into npm orgs when they first released them. They don't offer a > free tier for open source yet. > > -Steve >

[GitHub] cordova-plugin-contacts pull request: Dismiss permissions request ...

2016-03-11 Thread omefire
GitHub user omefire opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/108 Dismiss permissions request during automated testing You can merge this pull request into a Git repository by running: $ git pull https://github.com/omefire/cordova-plugin-con

[GitHub] cordova-plugin-camera pull request: CB-10460 getRealPath return nu...

2016-03-11 Thread jcesarmobile
GitHub user jcesarmobile opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/194 CB-10460 getRealPath return null in some cases Now there is only a function to get the real path on API 11 and above. You can merge this pull request into a Git repository by run

[GitHub] cordova-docs pull request: CB-10836 Improving "Edit" links

2016-03-11 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-docs/pull/551#issuecomment-195494647 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-plugin-file pull request: CB-10798, CB-10384: Fixing permi...

2016-03-11 Thread rakatyal
GitHub user rakatyal opened a pull request: https://github.com/apache/cordova-plugin-file/pull/170 CB-10798, CB-10384: Fixing permissions for Marshmallow The present code used to ask for permissions on Marshmallow while even trying to read/write from the application's own locations.

[GitHub] cordova-docs pull request: Making dropdowns preserve /latest/ in t...

2016-03-11 Thread rakatyal
Github user rakatyal commented on the pull request: https://github.com/apache/cordova-docs/pull/545#issuecomment-195516165 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

Re: [DISCUSS] Plugins release

2016-03-11 Thread Shazron
Ouch, at 80 cordova committers, it will cost us $560/month for an npm org :^O On Fri, Mar 11, 2016 at 8:41 AM, Carlos Santana wrote: > Thanks Steve ! > > I will ask Laurie, maybe we get a golden ticket :-) > > > On Fri, Mar 11, 2016 at 11:34 AM Steven Gill wrote: > >> Gave you npm publish access

Re: [DISCUSS] Plugins release

2016-03-11 Thread Carlos Santana
My bad, I had the impression that that open source package don't need to pay, that an organization was able to be created and only when creating the first package to be private then that required payment. sorry for the confusion On Fri, Mar 11, 2016 at 3:14 PM Shazron wrote: > Ouch, at 80 cor

[GitHub] cordova-ios pull request: Expose supportedOrientations method

2016-03-11 Thread purplecabbage
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-ios/pull/203 Expose supportedOrientations method Expose supportedOrientations getter/setter so native code can override the current behavior. I think this would require a minor version bump only,

[GitHub] cordova-plugin-contacts pull request: CB-10399 Added Appium tests

2016-03-11 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55895708 --- Diff: appium-tests/helpers/contactsHelper.js --- @@ -0,0 +1,222 @@ +/* jshint node: true */ +/* + * + * Licensed to the

[GitHub] cordova-plugin-contacts pull request: Dismiss permissions request ...

2016-03-11 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/108#issuecomment-195573683 @sgrebnov to review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-docs pull request: CB-10829 Fixing reference links.

2016-03-11 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/554#issuecomment-195579073 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] cordova-plugin-file pull request: CB-10798, CB-10384: Fixing permi...

2016-03-11 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/170#discussion_r55899536 --- Diff: src/android/FileUtils.java --- @@ -75,6 +75,7 @@ Licensed to the Apache Software Foundation (ASF) under one public stati

[GitHub] cordova-plugin-file pull request: CB-10798, CB-10384: Fixing permi...

2016-03-11 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/170#discussion_r55899953 --- Diff: src/android/FileUtils.java --- @@ -347,18 +348,25 @@ else if (action.equals("write")) { threadhelper( new FileOp( ){

[GitHub] cordova-plugin-file pull request: CB-10798, CB-10384: Fixing permi...

2016-03-11 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/170#discussion_r55900124 --- Diff: src/android/FileUtils.java --- @@ -435,8 +443,23 @@ else if (action.equals("getDirectory")) { public void run(JSON

RE: Simplifying cordova-cli README

2016-03-11 Thread Nikhil Khandelwal
I don't fully follow what about --template I should add? Could you elaborate? Feel free to comment on the PR and we can have more follow up conversations on github. -Nikhil -Original Message- From: Tommy Williams [mailto:to...@devgeeks.org] Sent: Thursday, March 10, 2016 7:33 PM To: de

[GitHub] cordova-lib pull request: Fall back to platform's default orientat...

2016-03-11 Thread mmrko
Github user mmrko closed the pull request at: https://github.com/apache/cordova-lib/pull/188 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-plugin-file pull request: CB-10798, CB-10384: Fixing permi...

2016-03-11 Thread jasongin
Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/170#discussion_r55904187 --- Diff: src/android/FileUtils.java --- @@ -75,6 +75,7 @@ Licensed to the Apache Software Foundation (ASF) under one public stati

[GitHub] cordova-plugin-file pull request: CB-10798, CB-10384: Fixing permi...

2016-03-11 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/170#discussion_r55904424 --- Diff: src/android/FileUtils.java --- @@ -75,6 +75,7 @@ Licensed to the Apache Software Foundation (ASF) under one public stati

[GitHub] cordova-plugin-file pull request: CB-10798, CB-10384: Fixing permi...

2016-03-11 Thread rakatyal
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/170#discussion_r55904524 --- Diff: src/android/FileUtils.java --- @@ -347,18 +348,25 @@ else if (action.equals("write")) { threadhelper( new FileOp( ){

[GitHub] cordova-plugin-media pull request: cordova-plugin-media-with-compr...

2016-03-11 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/86#issuecomment-195602518 I saw you already got a solution for your problem. Can you please close this pull request you created? Pull request aren't for asking for help

[GitHub] cordova-plugin-media pull request: cordova-plugin-media-with-compr...

2016-03-11 Thread ayyazzafar
Github user ayyazzafar commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/86#issuecomment-195602984 Ok sure. but how can we post any issue or request any help in this plugin? Further I am facing issue that recording with compression does not res

[GitHub] cordova-docs pull request: CB-10836 Improving "Edit" links

2016-03-11 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/551#issuecomment-195602694 @csantanapr the links don't fit on mobile screens, which is why I went for a dropdown. --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-ios pull request: Expose supportedOrientations method

2016-03-11 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-ios/pull/203#issuecomment-195603847 This pull-request is somewhat less important now that I have found a way to do this with the existing code. This can still be added to a future minor relea

[GitHub] cordova-plugin-file pull request: CB-10798, CB-10384: Fixing permi...

2016-03-11 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/170#discussion_r55908300 --- Diff: src/android/FileUtils.java --- @@ -347,18 +348,25 @@ else if (action.equals("write")) { threadhelper( new FileOp( ){

[GitHub] cordova-plugin-contacts pull request: Disable 'calendar permission...

2016-03-11 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/108#issuecomment-195613820 I've tested this, and it did not work for me. Modal still appeared when I ran the mobilespec tests --- If your project is set up for it, you can reply

RE: Edit to Edit on Github for Docs

2016-03-11 Thread Dmitry Blotsky
Once JIRA comes back up, please feel free to create a task for adding the "Edit" button to non-docs pages. As for the wording, I went for "Edit" on the dropdown because there are two different things to edit: translation and content. The link to edit content says that it's on GitHub, and the tr

[GitHub] cordova-plugin-file pull request: Fix file plugin test failure on ...

2016-03-11 Thread jasongin
GitHub user jasongin opened a pull request: https://github.com/apache/cordova-plugin-file/pull/171 Fix file plugin test failure on WP 8.1 @riknoll please review I dislike JavaScript number objects... You can merge this pull request into a Git repository by running: $ g

[GitHub] cordova-plugin-contacts pull request: Disable 'calendar permission...

2016-03-11 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/108#issuecomment-195623104 Thanks for testing. Behavior was sporadic for me. Even without this patch, it sometimes does not prompt, even though it should. I don't understand why y

[GitHub] cordova-plugin-file pull request: Fix file plugin test failure on ...

2016-03-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/171 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

Re: [Android] New Bridge: evaluateJavascript

2016-03-11 Thread Darryl Pogue
On 10 March 2016 at 16:29, Joe Bowser wrote: > On Thu, Mar 10, 2016 at 3:54 PM, Darryl Pogue wrote: > Semver aside, this change sounds good to me. I've definitely encountered >> some bizarre issues with the online/offline events being used for bridge >> communication (like navigator.online gettin

[GitHub] cordova-lib pull request: Remove plugin pinning

2016-03-11 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-lib/pull/409 Remove plugin pinning As discussed on the dev list You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib remove-pinning Al

[GitHub] cordova-lib pull request: Remove plugin pinning

2016-03-11 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-lib/pull/409#issuecomment-195631599 I'll create a JIRA later (Apache JIRA seems to be down right now). @stevengill please review when you have a moment. --- If your project is set up for it, you can

[GitHub] cordova-cli pull request: CB-10679: Documenting how the CLI choose...

2016-03-11 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-cli/pull/241#issuecomment-195646034 @nikhilkh responded to your review. I removed the bit about plugin pinning, but do we need to explain that Cordova version 6.0.0 had it? --- If your project is set

[GitHub] cordova-docs pull request: CB-10829 Fixing reference links.

2016-03-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/554 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

RE: Edit to Edit on Github for Docs

2016-03-11 Thread Dmitry Blotsky
Here is an alternative implementation: https://github.com/apache/cordova-docs/pull/555. Kindly, Dmitry -Original Message- From: Dmitry Blotsky [mailto:dblot...@microsoft.com] Sent: Friday, March 11, 2016 4:25 PM To: dev@cordova.apache.org Subject: RE: Edit to Edit on Github for Docs On

[GitHub] cordova-docs pull request: CB-10836 Improving "Edit" links (Altern...

2016-03-11 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-docs/pull/555 CB-10836 Improving "Edit" links (Alternative) Alternative implementation to #551. # Examples French ![1](https://cloud.githubusercontent.com/assets/405489/13721029/

[GitHub] cordova-docs pull request: Update index.md

2016-03-11 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/434#issuecomment-195662861 @h2ospace really sorry for the delay in getting back on this PR! I've merged in your change and I've also applied it for [this page Crowdin][page], so that it wil

[GitHub] cordova-docs pull request: Update index.md

2016-03-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/434 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-docs pull request: 'ccordova' is a typo

2016-03-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/438 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-docs pull request: 'ccordova' is a typo

2016-03-11 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/438#issuecomment-195665626 @fanfare sorry for the delay in responding to you! Thank you very much for your pull request. This change had already been applied between the time you opened the

[GitHub] cordova-docs pull request: Update index.md

2016-03-11 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/443#issuecomment-195668154 Извините что так много времени потребовалось чтобы дойти до этого PR. :/ @daserge вы правы: попÑ

[GitHub] cordova-docs pull request: Update index.md

2016-03-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/446 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-docs pull request: Update index.md

2016-03-11 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/446#issuecomment-195669697 @r3nya thank you for your PR! Sorry that it took us so long to get to merging it. I've merged your change. You may also contribute translations for Cordova in the

[GitHub] cordova-plugin-camera pull request: CB-10460 getRealPath return nu...

2016-03-11 Thread sassy
Github user sassy commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/194#issuecomment-195669631 I check the this patch the following device. (try to run https://github.com/sassy/cordovaCameraPluginFailSample ) * Motorola Xoom (Android 4.0.3) O

[GitHub] cordova-plugin-camera pull request: CB-10460 getRealPath return nu...

2016-03-11 Thread sassy
Github user sassy commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/194#issuecomment-195669909 I checked it used cordova-plugin-camera-tests. Xperia Z2 Tablet (Android 4.4.2) is no problem. --- If your project is set up for it, you can reply to

[GitHub] cordova-docs pull request: Fix invalid dash sign (`Too many parame...

2016-03-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/459 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-docs pull request: Fix invalid dash sign (`Too many parame...

2016-03-11 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/459#issuecomment-195671806 Thank you, @SunboX for your contribution! Sorry that it took us so long to merge your change. --- If your project is set up for it, you can reply to this email a

[GitHub] cordova-docs pull request: Add "Linux" to "blackberry10"

2016-03-11 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/475#issuecomment-195672780 @purplecabbage could you please confirm if we can build Blackberry 10 Cordova apps on Linux? --- If your project is set up for it, you can reply to this email an

[GitHub] cordova-docs pull request: Do not escape markdown code for relativ...

2016-03-11 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/476#issuecomment-195676290 @mikrobi thank you for your PR! Sorry that it took us so long to get to merging it. We've also made note of this type of link in our source code, and we'll make a

[GitHub] cordova-docs pull request: Do not escape markdown code for relativ...

2016-03-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/476 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-docs pull request: Update tools.md

2016-03-11 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/483#issuecomment-195678572 @cfjedimaster @jcesarmobile @nikhilkh I've fixed this retroactively in old docs and closed the PR. Thanks for the contribution, @cfjedimaster! --- If your projec

[GitHub] cordova-docs pull request: Update tools.md

2016-03-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/483 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-docs pull request: Update config.md

2016-03-11 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/491#issuecomment-195681354 @sonus thank you for your PR! Sorry that it took us so long to get to merging it, that the docs changed in that time. The good news are that the [latest config.xm

[GitHub] cordova-docs pull request: Renamed 6.0.0 to 6.x

2016-03-11 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/499#issuecomment-195681406 @stevengill please close this PR when you have a moment. :) The changes have been applied. --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-docs pull request: Fixed Typo: ccordova to cordova

2016-03-11 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/515#issuecomment-195681504 @Samshal thank you for your PR! Sorry that it took us so long to get to it. I've just merged a PR from a while ago that fixed this issue, so it's actually already

[GitHub] cordova-docs pull request: Update tools.md

2016-03-11 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-docs/pull/483#issuecomment-195682424 Can you change codeSignIdentitiy to codeSignIdentity? --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] cordova-docs pull request: Fix typo for orientation property portr...

2016-03-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/552 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-docs pull request: Fix typo for orientation property portr...

2016-03-11 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/552#issuecomment-195685755 @insane210 thank you for the PR! :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] cordova-docs pull request: Update tools.md

2016-03-11 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/483#issuecomment-195686116 @jcesarmobile done in a1b3b74. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] cordova-docs pull request: Remove misleading reference to "publish...

2016-03-11 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/402#issuecomment-195686924 @nikhilkh ping; please give this a look when you have a moment. --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] cordova-docs pull request: Cb 10637

2016-03-11 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/504#issuecomment-195687896 @dhams please close this PR when you have a moment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well