[GitHub] cordova-docs pull request: CB-11021 Changing docs styling

2016-04-05 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/567#issuecomment-206091474 @riknoll Please give this another look. I added an attributions page. @rakatyal I fixed the footer to be slightly different for the docs and for the rest of the

[GitHub] cordova-paramedic pull request: Paramedic improvements

2016-04-05 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r58642061 --- Diff: paramedic-plugin/paramedic.js --- @@ -0,0 +1,74 @@ +var io = cordova.require('cordova-plugin-paramedic.socket.io'); --- End diff

RE: [DISCUSS] cordova-ios release

2016-04-05 Thread Nikhil Khandelwal
I noticed there is an issue with ios-deploy/cordova-ios & Xcode 7.3. This seems fairly high priority: CB-10962. If the fix/workaround happens to be in cordova-ios - we might have to do another release or add it to this release. -Nikhil -Original Message- From: Shazron

Re: Cordova plugin help

2016-04-05 Thread Jesse
You can also reach out on the cordova slack channel as many developers are lurking there. https://cordova.slack.com/ join: http://slack.cordova.io/ @purplecabbage risingj.com On Tue, Apr 5, 2016 at 1:23 PM, Raymond Camden wrote: > Hello Thomas, > > This list is for

[GitHub] cordova-plugin-contacts pull request: Remove logging

2016-04-05 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/117#issuecomment-206034479 @omefire I am ok with removing the logging. Please check the travis erros. --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-docs pull request: Changing docs styling.

2016-04-05 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/567#discussion_r58628814 --- Diff: www/_includes/footer.html --- @@ -1,6 +1,6 @@ - --- End diff -- Great catch! It makes the footer look a bit

[GitHub] cordova-docs pull request: Changing docs styling.

2016-04-05 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/567#issuecomment-206025768 @riknoll thanks for pointing that out! I've created a JIRA: https://issues.apache.org/jira/browse/CB-11021. I'll also add the font attribution to the footer and

Re: Plugin Dev Issues

2016-04-05 Thread Michael Tomasz Lapinski
Hello, Please reply to all as I am not subscribed to the list. Yes that link is to the post that I made on StackOverflow. I would be happy to provide further detail in order to help debug or explain the build environment. -thank you -mtl Subject: Re: Plugin Dev Issues From:

Re: [Android] Need a solution to config.xml and AndroidManifest.xml feature requests

2016-04-05 Thread Simon MacDonald
I would love to but I have a few other things to handle first. If someone else picks it up before I get to it then that's cool with me. Simon Mac Donald http://hi.im/simonmacdonald On Tue, Apr 5, 2016 at 6:51 PM, Carlos Santana wrote: > Oh so it means you don't want to

Re: [Android] Need a solution to config.xml and AndroidManifest.xml feature requests

2016-04-05 Thread Alexis Kofman
Haha, so you can merge all the waiting PR !! On Wed, Apr 6, 2016 at 12:51 AM, Carlos Santana wrote: > Oh so it means you don't want to work on the code :-p > > > On Tue, Apr 5, 2016 at 6:50 PM Simon MacDonald > wrote: > > > Thanks, I put a watch

Re: [Android] Need a solution to config.xml and AndroidManifest.xml feature requests

2016-04-05 Thread Carlos Santana
Oh so it means you don't want to work on the code :-p On Tue, Apr 5, 2016 at 6:50 PM Simon MacDonald wrote: > Thanks, I put a watch on that. > > > Simon Mac Donald > http://hi.im/simonmacdonald > > On Tue, Apr 5, 2016 at 6:48 PM, Carlos Santana

Re: [Android] Need a solution to config.xml and AndroidManifest.xml feature requests

2016-04-05 Thread Simon MacDonald
Thanks, I put a watch on that. Simon Mac Donald http://hi.im/simonmacdonald On Tue, Apr 5, 2016 at 6:48 PM, Carlos Santana wrote: > Simon, I was not able to find a JIRA, I created a new JIRA [1] to enhance > plugin.xml to allow to add attributes > > [1]:

Re: [Android] Need a solution to config.xml and AndroidManifest.xml feature requests

2016-04-05 Thread Carlos Santana
Simon, I was not able to find a JIRA, I created a new JIRA [1] to enhance plugin.xml to allow to add attributes [1]: https://issues.apache.org/jira/browse/CB-11023 On Wed, Mar 23, 2016 at 11:30 AM Simon MacDonald wrote: > Seems like editing attributes in a

[GitHub] cordova-lib pull request: CB-8627: Only update fetch.json when plu...

2016-04-05 Thread omefire
Github user omefire closed the pull request at: https://github.com/apache/cordova-lib/pull/228 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-8627: Only update fetch.json when plu...

2016-04-05 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/228#issuecomment-206015614 Closing this as not relevant anymore. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-contacts pull request: Remove logging

2016-04-05 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/117#issuecomment-206015404 @omefire why are you removing this? This was actually pretty useful in debugging --- If your project is set up for it, you can reply to this email

[GitHub] cordova-plugin-contacts pull request: Remove logging

2016-04-05 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/117#issuecomment-206014203 @sarangan12 could you please review this ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-plugin-contacts pull request: Remove logging

2016-04-05 Thread omefire
GitHub user omefire opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/117 Remove logging You can merge this pull request into a Git repository by running: $ git pull https://github.com/omefire/cordova-plugin-contacts RemoveLogging Alternatively

[GitHub] cordova-ios pull request: CB-10962 CB-10945 removes justlaunch fla...

2016-04-05 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-ios/pull/212#issuecomment-205981561 OK, sounds good. I'm running some investigations as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

Re: Cordova plugin help

2016-04-05 Thread Raymond Camden
Hello Thomas, This list is for discussing Cordova as a whole, not for technical support. For technical support, please see StackOverflow or the Phonegap Google Group (https://groups.google.com/forum/#!forum/phonegap). On Tue, Apr 5, 2016 at 9:38 AM, Thomas Dik - MendriX wrote:

[GitHub] cordova-plugin-statusbar pull request: CB-11018 Fix statusbar with...

2016-04-05 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/54#issuecomment-205975023 Tested on iOS 8 and iOS 9 devices and iOS 7 simulator. Seems ok on all of them. I can test on a real iOS 7 device tomorrow.

[GitHub] cordova-plugin-contacts pull request: CB-10985 Android sets type t...

2016-04-05 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/116 CB-10985 Android sets type to -1 for ims Added a corresponding test [Jira issue](https://issues.apache.org/jira/browse/CB-10985) You can merge this pull request into a Git

[GitHub] cordova-plugin-file-transfer pull request: Removing flaky test ass...

2016-04-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/137 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

Re: [DISCUSS] cordova-ios release

2016-04-05 Thread Shazron
When I do a "cordova run --device" and I don't have ios-deploy installed, I don't get the warning anymore to install it, just a "Error: spawn ios-deploy ENOENT". Not sure when this behaviour changed. Don't think it should stall the release though. On Tue, Apr 5, 2016 at 9:33 AM, Edna Y Morales

[GitHub] cordova-windows pull request: CB-8056 Implement splashscreen for W...

2016-04-05 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/141#issuecomment-205929216 This now has conflicts, can we get a rebase and a merge? lgtm! --- If your project is set up for it, you can reply to this email and have your reply

Re: [DISCUSS] Core Plugins and Android API 23

2016-04-05 Thread Jesse
5) add new plugin repo to coho managed plugins list @purplecabbage risingj.com On Tue, Apr 5, 2016 at 8:20 AM, Simon MacDonald wrote: > Just an update: > > Task list: > > 1) create cordova-plugin-compat repo, populate with code. COMPLETE > Apache Repo: >

[GitHub] cordova-lib pull request: CB-10921 Emit warning in case of plugin ...

2016-04-05 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/420#issuecomment-205924214 @vladimir-kotikov taking a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-ios pull request: CB-10962 CB-10945 removes justlaunch fla...

2016-04-05 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/212#issuecomment-205923253 This change will modify expected behaviour if someone is scripting this, since the run call will not terminate. That is, however, a lower priority consequence

[DISCUSS] Plugins release

2016-04-05 Thread Simon MacDonald
Hey all, I'd like to start the ball rolling for a new plugin release. I've done the necessary changes to remove the need to copy PermissionHelper.java into every new Cordova Android Plugin. Now these plugins depend on cordova-plugin-compat to provide that class. It would mean new minor versions

[VOTE] 4.1.1 iOS Release - Take 2

2016-04-05 Thread Edna Y Morales
Please review and vote on this 4.1.1 iOS Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-11006 The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-11006/ The package

Cordova plugin help

2016-04-05 Thread Thomas Dik - MendriX
Dear Sir or Madam, I've been trying to develop a cordova plugin for android but I've had no success so far. So I tried to create a simple Hello World plugin to check if the java exec method is called but still with no success. I've attached the simple Hello World plugin to this mail and I was

[GitHub] cordova-docs pull request: Changing docs styling.

2016-04-05 Thread rakatyal
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/567#discussion_r58583885 --- Diff: www/_includes/footer.html --- @@ -1,6 +1,6 @@ - --- End diff -- Why this change? Will it effect non-docs

[GitHub] cordova-docs pull request: Changing docs styling.

2016-04-05 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/567#issuecomment-205914843 Also, create a JIRA! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

RE: [Vote] 4.1.1 iOS Release

2016-04-05 Thread Edna Y Morales
The vote has failed. I will start a new vote thread in a few mins. Thanks, Edna Morales From: "Alexander Sorokin (Akvelon)" To: "dev@cordova.apache.org" Date: 04/05/2016 11:39 AM Subject:RE: [Vote] 4.1.1 iOS Release Adding a

[GitHub] cordova-docs pull request: Changing docs styling.

2016-04-05 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/567#issuecomment-205912526 Otherwise, LGTM. The TOC logic is unchanged, right? Kind of hard to read through the diff on that. Tested it in Chrome and Edge and everything looks great.

[GitHub] cordova-docs pull request: Changing docs styling.

2016-04-05 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/567#issuecomment-205908700 Alright, on the font front Google provides the appropriate attribution notice here: https://www.google.com/fonts/attribution The question is where should

[GitHub] cordova-ios pull request: CB-10962 CB-10945 removes justlaunch fla...

2016-04-05 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-ios/pull/212#issuecomment-205899455 I think we should pull this in, while waiting for a fix for the XCode 7.3 issue. What do you think @shazron ? --- If your project is set up for it, you can reply

[GitHub] cordova-plugin-camera pull request: CB-10857 android : Camera.getP...

2016-04-05 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/198#issuecomment-205895064 That sounds good to me. We can probably just put the images into a directory like `cache/cordova-plugin-camera` and routinely wipe it as part of

RE: [DISCUSS] cordova-ios release

2016-04-05 Thread Edna Y Morales
Thanks, Mefire! So there is an issue with the archive that I published on dist/dev. I don't see the issue when I install from git so it must be something in the packaging that I'll need to investigate. I'll close the vote as Failed, republish and restart the vote. Thanks, Edna Morales From:

RE: [Vote] 4.1.1 iOS Release

2016-04-05 Thread Alexander Sorokin (Akvelon)
Adding a platform from the archive fails with message "Cannot find module 'underscore'". It looks like something Is missing from the archive. So, -1. Thanks, Alexander Sorokin -Original Message- From: Edna Y Morales [mailto:eymor...@us.ibm.com] Sent: Monday, April 4, 2016 8:45 PM To:

RE: [VOTE] Cordova-windows 4.3.2 release

2016-04-05 Thread Alexander Sorokin (Akvelon)
I vote +1. * Verified archives via `coho verify-archive` * Verified tags manually * Verified that blank app creates correctly with platform * Verified that blank app can be successfully built and ran * Verified that platform can be updated from previous version * Verified compatibility with core

Re: [DISCUSS] Core Plugins and Android API 23

2016-04-05 Thread Simon MacDonald
Just an update: Task list: 1) create cordova-plugin-compat repo, populate with code. COMPLETE Apache Repo: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-compat.git Github Mirror: https://github.com/apache/cordova-plugin-compat NPM:

[GitHub] cordova-plugin-statusbar pull request: CB-11018 Fix statusbar with...

2016-04-05 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/54#issuecomment-205843380 I'm on my way home, will try to test it tonight. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-plugin-statusbar pull request: CB-11018 Fix statusbar with...

2016-04-05 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/54#issuecomment-205840096 @jcesarmobile, could you please take a look? Tested on iPhone iOS7.1.1, iPad iOS8.1, 9.2 simulators. --- If your project is set up for it, you can

[GitHub] cordova-plugin-statusbar pull request: CB-11018 Fix statusbar with...

2016-04-05 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/54 CB-11018 Fix statusbar with inappbrowser causing incorrect orientatio… …n on iOS8 [Jira issue](https://issues.apache.org/jira/browse/CB-11018) You can merge this pull

[GitHub] cordova-docs pull request: CB-10999 Adds windows@4.3.2 release blo...

2016-04-05 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-docs/pull/572#issuecomment-205768133 @csantanapr, updated --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

Re: [DISCUSS] cordova-windows patch release

2016-04-05 Thread Carlos Santana
Update blog with CLI 6.1.1 instead of 6.1.0 - Carlos @csantanapr > On Apr 5, 2016, at 4:31 AM, Vladimir Kotikov (Akvelon) > wrote: > > Please review the blog post: https://github.com/apache/cordova-docs/pull/572 > - > Best regards, Vladimir > > -Original

Re: [ANNOUNCE] Tools release

2016-04-05 Thread Carlos Santana
Great !, Thanks a lot Vladimir - Carlos @csantanapr > On Apr 5, 2016, at 2:23 AM, Vladimir Kotikov (Akvelon) > wrote: > > Blog: http://cordova.apache.org/news/2016/04/04/tools-release.html > Tweet: https://twitter.com/apachecordova/status/71718881055602 > > - >

[GitHub] cordova-cli pull request: CB-10062 Error: EACCES: permission denie...

2016-04-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/242 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-contacts pull request: CB-8115 incorrect birthday s...

2016-04-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/113 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-geolocation pull request: Update iOS geolocation pl...

2016-04-05 Thread guillaumedev
Github user guillaumedev commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/67#issuecomment-205721024 Please test it with my fork https://github.com/guillaumedev/cordova-plugin-geolocation It's been some weeks since i played with it so i

Plugin Development on Android with view modification.

2016-04-05 Thread Matthieu Renard
Hello Cordova Dev Team, I need some advise about plugin creation. I'm developing an android player plugin who need to add an Android "SurfaceView". I decide to modify the view when the pluginInitialize : - create the SurfaceView and add it into the layout - set the CordovaWebview

RE: [DISCUSS] cordova-windows patch release

2016-04-05 Thread Vladimir Kotikov (Akvelon)
Please review the blog post: https://github.com/apache/cordova-docs/pull/572 - Best regards, Vladimir -Original Message- From: Carlos Santana [mailto:csantan...@gmail.com] Sent: Monday, April 4, 2016 10:23 PM To: dev@cordova.apache.org Subject: Re: [DISCUSS] cordova-windows patch release

[GitHub] cordova-docs pull request: CB-10999 Adds windows@4.3.2 release blo...

2016-04-05 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-docs/pull/572 CB-10999 Adds windows@4.3.2 release blog post You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-docs CB-10999

[VOTE] Cordova-windows 4.3.2 release

2016-04-05 Thread Vladimir Kotikov (Akvelon)
Please review and vote on this Cordova-windows 4.3.2 release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-10999 The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-10999

[GitHub] cordova-plugin-camera pull request: CB-10857 android : Camera.getP...

2016-04-05 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/198#issuecomment-205672785 I like the idea, if we can get the real name, then the new image should be realname-modified-timestap, if we can't get the real name, then just use

RE: [ANNOUNCE] Tools release

2016-04-05 Thread Vladimir Kotikov (Akvelon)
Blog: http://cordova.apache.org/news/2016/04/04/tools-release.html Tweet: https://twitter.com/apachecordova/status/71718881055602 - Best regards, Vladimir -Original Message- From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com] Sent: Monday, April 4, 2016 12:05 PM To: