Re: [DISCUSS] Plugins release

2016-04-06 Thread julio cesar sanchez
At least this 3 have changes: cordova-plugin-inappbrowser cordova-plugin-statusbar cordova-plugin-dialogs If this can wait, I want to add a small change on dialogs plugin this afternoon. I have another change almost ready for the inappbrowser, but might take a while, so I can add it for the next

[GitHub] cordova-docs pull request: Adding both Chinese versions.

2016-04-06 Thread dblotsky
Github user dblotsky closed the pull request at: https://github.com/apache/cordova-docs/pull/569 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-contacts pull request: CB-10985 Android sets type t...

2016-04-06 Thread tobiasmuecksch
Github user tobiasmuecksch commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/116#issuecomment-206258396 Well that might fix the -1 issue. But the android version of this plugin behaves very differently from the ios Version. The iOS Version

[GitHub] cordova-plugin-contacts pull request: CB-10985 Android sets type t...

2016-04-06 Thread tobiasmuecksch
Github user tobiasmuecksch commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/116#issuecomment-206265136 I've openend an Issue on that: https://issues.apache.org/jira/browse/CB-11028 --- If your project is set up for it, you can reply to this email

[GitHub] cordova-ios pull request: CB-11019 Handle app name change more acc...

2016-04-06 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-ios/pull/213 CB-11019 Handle app name change more accurately This PR fixes potential bug in 'prepare' functionality, when changing application name (which assumes renaming of some folders inside of

[GitHub] cordova-paramedic pull request: Paramedic improvements

2016-04-06 Thread sgrebnov
Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r58688217 --- Diff: paramedic-plugin/paramedic.js --- @@ -0,0 +1,74 @@ +var io = cordova.require('cordova-plugin-paramedic.socket.io'); --- End diff --

[GitHub] cordova-paramedic pull request: Paramedic improvements

2016-04-06 Thread sgrebnov
Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r58692216 --- Diff: lib/LocalServer.js --- @@ -0,0 +1,122 @@ +var Q = require('q'), --- End diff -- Done --- If your project is set up for i

[GitHub] cordova-paramedic pull request: Paramedic improvements

2016-04-06 Thread sgrebnov
Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r58692210 --- Diff: lib/paramedic.js --- @@ -0,0 +1,205 @@ +#!/usr/bin/env node + +var exec = require('./utils').exec, +shell = require('sh

[GitHub] cordova-lib pull request: CB-10975 Allow plugin path to be relativ...

2016-04-06 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/421 CB-10975 Allow plugin path to be relative to current directory JIRA: [CB-10975](https://issues.apache.org/jira/browse/CB-10975) You can merge this pull request into a Git repository by

[GitHub] cordova-android pull request: CB-10964 build.js script under "plat...

2016-04-06 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-android/pull/286 CB-10964 build.js script under "platforms\android\cordova\lib" can no… …t handle build.json file starting with a BOM [Jira issue](https://issues.apache.org/jira/browse/CB-10964)

[GitHub] cordova-android pull request: CB-10862 Cannot set minsdkversion

2016-04-06 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-android/pull/284#issuecomment-206418145 Another scenario where we need a test case - perhaps an end-to-end one - thoughts? --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-plugin-camera pull request: trigger file upload dialog aut...

2016-04-06 Thread robertarnesson
GitHub user robertarnesson opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/200 trigger file upload dialog automatically on browser platform When using getPicture with source Camera.PictureSourceType.PHOTOLIBRARY on browser platform, a file upload input fi

[GitHub] cordova-plugin-contacts pull request: CB-10399 Added Appium tests

2016-04-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/101 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

Re: [DISCUSS] Plugins release

2016-04-06 Thread Simon MacDonald
Yeah, it can wait. It's just something I would like to get in to reduce code duplication. I'm also working on CB-10776 as well. Simon Mac Donald http://hi.im/simonmacdonald On Wed, Apr 6, 2016 at 4:11 AM, julio cesar sanchez wrote: > At least this 3 have changes: > > cordova-plugin-inappbrowser

[GitHub] cordova-docs pull request: CB-11021 Changing docs styling

2016-04-06 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/567#issuecomment-206459071 @dblotsky Is there a reason this suddenly has 1,634 changed files? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-lib pull request: CB-9434: Adding a ToDO. 'cordova run' sh...

2016-04-06 Thread omefire
Github user omefire closed the pull request at: https://github.com/apache/cordova-lib/pull/280 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-plugin-contacts pull request: Remove logging

2016-04-06 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/117#issuecomment-206471960 @sarangan12 errors fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] cordova-android pull request: Revert "CB-10881: Logging to further...

2016-04-06 Thread omefire
GitHub user omefire opened a pull request: https://github.com/apache/cordova-android/pull/287 Revert "CB-10881: Logging to further investigations" This reverts commit 1b43bc99a1c50e5ab30347ec9ca5af8cf22d3e85. You can merge this pull request into a Git repository by running: $ g

[GitHub] cordova-android pull request: Revert "CB-10881: Logging to further...

2016-04-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/287 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-plugin-contacts pull request: Remove logging

2016-04-06 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/117#issuecomment-206509564 Lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] cordova-plugin-contacts pull request: Remove logging

2016-04-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/117 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] cordova-paramedic pull request: Paramedic improvements

2016-04-06 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r58771547 --- Diff: lib/LocalServer.js --- @@ -0,0 +1,141 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more cont

[GitHub] cordova-paramedic pull request: Paramedic improvements

2016-04-06 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r58771505 --- Diff: lib/LocalServer.js --- @@ -0,0 +1,141 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more cont

[GitHub] cordova-paramedic pull request: Paramedic improvements

2016-04-06 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r58771737 --- Diff: lib/LocalServer.js --- @@ -0,0 +1,141 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more cont

[GitHub] cordova-plugin-dialogs pull request: CB-10097 dialog doesn't show ...

2016-04-06 Thread jcesarmobile
GitHub user jcesarmobile opened a pull request: https://github.com/apache/cordova-plugin-dialogs/pull/70 CB-10097 dialog doesn't show on iOS when called from a select list onChange event Changed getTopPresentedViewController to not set the presentingViewController to a ViewContr

[GitHub] cordova-plugin-dialogs pull request: CB-10097 dialog doesn't show ...

2016-04-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-dialogs/pull/70 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-dialogs pull request: On iOS8+ allow this dialog to...

2016-04-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-dialogs/pull/57 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-paramedic pull request: Paramedic improvements

2016-04-06 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r58785033 --- Diff: lib/paramedic.js --- @@ -0,0 +1,232 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more contri

[GitHub] cordova-paramedic pull request: Paramedic improvements

2016-04-06 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r58785263 --- Diff: lib/utils/execWrapper.js --- @@ -0,0 +1,39 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] cordova-paramedic pull request: Paramedic improvements

2016-04-06 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r58785401 --- Diff: paramedic-plugin/paramedic.js --- @@ -0,0 +1,93 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or

[GitHub] cordova-paramedic pull request: Paramedic improvements

2016-04-06 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r58785566 --- Diff: paramedic-plugin/paramedic.js --- @@ -0,0 +1,93 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or

[GitHub] cordova-paramedic pull request: Paramedic improvements

2016-04-06 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r58786335 --- Diff: lib/LocalServer.js --- @@ -0,0 +1,141 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more cont

[GitHub] cordova-paramedic pull request: Paramedic improvements

2016-04-06 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r58786905 --- Diff: lib/LocalServer.js --- @@ -0,0 +1,141 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more cont

[GitHub] cordova-paramedic pull request: Paramedic improvements

2016-04-06 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r58787128 --- Diff: lib/LocalServer.js --- @@ -0,0 +1,141 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more cont

RE: [VOTE] Cordova-windows 4.3.2 release

2016-04-06 Thread Raghav Katyal
+1 * Tested blank app * Tested compatibility with core plugins * Ran mobilespec * Ran coho verify-tags * Verified builds are passing * Verified platform updates from previous version * Reviewed release notes -Raghav -Original Message- From: Alexander Sorokin (Akvelon) [mailto:v-als...@mi

[Android] Library Project/AAR alternatives to current plugin situation

2016-04-06 Thread Joe Bowser
Hey I recently looked at how native Android developers could use the current Cordova code with their projects, and I've noticed that there's some major problems with our current approach of just copying the Java classes into a project, such as resources getting merged together, and other related i

[GitHub] cordova-ios pull request: CB-10962 CB-10945 removes justlaunch fla...

2016-04-06 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/212#issuecomment-20663 Update (good news?): https://github.com/phonegap/ios-deploy/pull/218#issuecomment-206597622 --- If your project is set up for it, you can reply to this email and h

[GitHub] cordova-docs pull request: CB-11021 Changing docs styling

2016-04-06 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/567#issuecomment-206601373 @riknoll yeah. The latest merge to the ASF Git master hasn't reflected in the GitHub master yet because it was a large commit. Sorry, the best way to see the diff

Re: [Android] Library Project/AAR alternatives to current plugin situation

2016-04-06 Thread Carlos Santana
Does this aligns in a similar way as how phonegap is recommending for iOS on using Cocoapods [1] to embed the Cordova WebView into an existing iOS App? Looking only from a Native Android developer eyes this will be the approach I would like if I have a pure native android app and for some reason I

[GitHub] cordova-docs pull request: CB-11021 Changing docs styling

2016-04-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/567 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

Re: [VOTE] Cordova-windows 4.3.2 release

2016-04-06 Thread Jesse
+1 * Ran coho verify-archive * Ran coho audit-license-headers * Ran coho check-license * Created and ran blank app via cli @purplecabbage risingj.com On Wed, Apr 6, 2016 at 2:52 PM, Raghav Katyal wrote: > +1 > > * Tested blank app > * Tested compatibility with core plugins > * Ran mobilespec

Re: [Android] Library Project/AAR alternatives to current plugin situation

2016-04-06 Thread Joe Bowser
On Wed, Apr 6, 2016 at 4:08 PM, Carlos Santana wrote: > Does this aligns in a similar way as how phonegap is recommending for iOS > on using Cocoapods [1] to embed the Cordova WebView into an existing iOS > App? > Yes, except that I don't think it will be nearly as complex as the iOS approach is

New Docs Look

2016-04-06 Thread Dmitry Blotsky
Check it out! http://cordova.apache.org/docs/

Re: [VOTE] 4.1.1 iOS Release - Take 2

2016-04-06 Thread Jesse
+1 - Ran coho audit-license-headers - Ran coho check-license - Ran coho verify archive - Ran iOS native tests > Good signature from "Edna Morales" - Created and ran hello world iOS app with CLI @purplecabbage risingj.com On Tue, Apr 5, 2016 at 10:51 AM, Edna Y Morales wrote: > > > Please rev

RE: [VOTE] Cordova-windows 4.3.2 release

2016-04-06 Thread Vladimir Kotikov (Akvelon)
The vote has now closed. The results are: Positive Binding Votes: 4 Vladimir Kotikov Alexander Sorokin Raghav Katyal Jesse MacFadyen The vote has passed. - Best regards, Vladimir -Original Message- From: Jesse [mailto:purplecabb...@gmail.com] Sent: Thursday, April 7, 2016 3:08 AM To:

[GitHub] cordova-docs pull request: CB-10999 Adds windows@4.3.2 release blo...

2016-04-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/572 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i