Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/177#discussion_r58983833
--- Diff: www/FileWriter.js ---
@@ -107,8 +108,29 @@ FileWriter.prototype.write = function(data) {
var fileReader = new FileReader();
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/177#discussion_r58983822
--- Diff: www/FileWriter.js ---
@@ -107,8 +108,29 @@ FileWriter.prototype.write = function(data) {
var fileReader = new FileReader();
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/177#issuecomment-207234305
Thank you for the review!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/42
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
cordova-ios@4.1.1 is on NPM now: https://www.npmjs.com/package/cordova-ios
Check out blog post at
https://cordova.apache.org/announcements/2016/04/04/ios-4.1.1.html and
retweet https://twitter.com/apachecordova/status/718229585758986241
Thanks,
Edna Morales
1. Browser platform... the one under discussion.
2. I understood everything you say in your response paragraphs 2 and 3.
3. My points still remain... your statement "many of these APIs..." is
confusing.
4. Your words in paragraphs 2 and 3 of your response should be included as
clarification.
5. Rep
GitHub user robario opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/138
Fix cordova-plugin-file dependency
In plugin.xml
>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robario/cordo
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/77#issuecomment-207159923
@purplecabbage there are 2 single line changes on this PR, one of which is
already incorporated into master from another commit. If the second one liner
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-207159395
@purplecabbage comments on this PR could not possibly go further off topic
:) Seems to have become defacto media plugin support for a while there.
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/119#discussion_r58964379
--- Diff: README.md ---
@@ -354,6 +354,35 @@ for details.
// remove the contact from the device
contact.remove(onSuccess
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/119#discussion_r58964196
--- Diff: README.md ---
@@ -354,6 +354,35 @@ for details.
// remove the contact from the device
contact.remove(onSuccess
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/119#discussion_r58963991
--- Diff: README.md ---
@@ -354,6 +354,35 @@ for details.
// remove the contact from the device
contact.remove(onSuccess,on
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/119#discussion_r58963814
--- Diff: README.md ---
@@ -354,6 +354,35 @@ for details.
// remove the contact from the device
contact.remove(onSuccess,on
GitHub user sarangan12 opened a pull request:
https://github.com/apache/cordova-plugin-contacts/pull/119
CB-11041: cordova-plugin-contacts readme must be updated to include
instructions on removing phone number from a contact
Refer
[Link](https://issues.apache.org/jira/browse/CB-10
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-docs/pull/573#issuecomment-207138716
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/573#discussion_r58962639
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -348,6 +349,7 @@ platform. See [Customize icons topic](images.html) for
more information.
Github user tripodsan commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/42#issuecomment-207138136
please close. we got osx support in the meantime added.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user omefire commented on the pull request:
https://github.com/apache/cordova-ios/pull/214#issuecomment-207134914
Thanks @shazron, will recheck it and make appropriate changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/214#issuecomment-207134051
This PR removes crucial functionality, namely the inheritance of build
settings from the .xcconfig files:
![screen shot 2016-04-07 at 4 13 33
pm](https://cloud.
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/176#issuecomment-207123605
Rob, what platform are you looking at?
The W3C FileSystems spec for web browsers is deprecated; what that
effectively means is no other browsers w
GitHub user omefire opened a pull request:
https://github.com/apache/cordova-ios/pull/214
CB-10957 Remove build-*.xcconfig files from build output
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/omefire/cordova-ios CB-10957
Alte
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/42#issuecomment-207121298
This pr is hopelessly out of date. If it is still relevant, please rebase
it, otherwise I will be closing it shortly.
---
If your project is set up fo
Github user RobPosener commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/176#issuecomment-207120687
I am able to get all of the File System APIs that I require to work
correctly. I can create directories and sub-directories. I can create files
and re
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-207117910
We are further and further off topic, but
Why are you using `sudo` to install plugins @Taewa ?
---
If your project is set up for it, you can rep
Nicely done!!
On Thu, Apr 7, 2016 at 5:20 PM Jesse wrote:
> Yeah, looks great on an iPhone 6!
>
>
> @purplecabbage
> risingj.com
>
> On Thu, Apr 7, 2016 at 10:52 AM, Shazron wrote:
>
> > Nice! Thank you!
> >
> > On Wed, Apr 6, 2016 at 6:32 PM, Dmitry Blotsky
> > wrote:
> > > Check it out! http
Yeah, looks great on an iPhone 6!
@purplecabbage
risingj.com
On Thu, Apr 7, 2016 at 10:52 AM, Shazron wrote:
> Nice! Thank you!
>
> On Wed, Apr 6, 2016 at 6:32 PM, Dmitry Blotsky
> wrote:
> > Check it out! http://cordova.apache.org/docs/
>
> ---
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-android/pull/286#issuecomment-207108814
This needs to be handled for other platforms too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
GitHub user rakatyal opened a pull request:
https://github.com/apache/cordova-docs/pull/573
CB-11020, CB-11040 Documenting event firing details in VS and the uapâ¦
â¦-target-min-version preference
You can merge this pull request into a Git repository by running:
$ git pull ht
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-docs/pull/573#issuecomment-207100260
@jasongin, @riknoll : Please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
GitHub user nikhilkh opened a pull request:
https://github.com/apache/cordova-lib/pull/422
CB-10770 Remove cache-min when adding platforms
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-lib cache-min
Alternat
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/571
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/176#issuecomment-207076949
Looks good, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
The vote has now closed. The results are:
Positive Binding Votes: 3
Edna Morales
Jesse MacFadyen
Alexander Sorokin
The vote has passed.
Thanks,
Edna Morales
From: "Alexander Sorokin (Akvelon)"
To: "dev@cordova.apache.org"
Date: 04/07/2016 12:28 PM
Subject:RE: [VOTE] 4.1.1
Github user JPustkuchen commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/99#issuecomment-207061483
I can confirm that this is really an important feature request. For example
we want to use skype:// and whatsapp:// links within the webview. The
Github user JPustkuchen commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/122#issuecomment-207060533
+1 for this merge. A really useful feature! :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-windows/pull/165#issuecomment-207058473
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user rakatyal opened a pull request:
https://github.com/apache/cordova-windows/pull/165
CB-11024: Add preference to set the min UAP target version in the JSPâ¦
â¦roj File
The current preferences allow the user to set the target and min versions
in the appxmanifest
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58929077
--- Diff: README.md ---
@@ -538,3 +540,298 @@ Android also supports a special filesystem named
"documents", which represents a
* `root`: Th
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58928914
--- Diff: README.md ---
@@ -36,7 +36,9 @@ Although most of the plugin code was written when an
earlier spec was current:
It also implements
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58927585
--- Diff: README.md ---
@@ -36,9 +36,9 @@ Although most of the plugin code was written when an
earlier spec was current:
It also implements
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58928337
--- Diff: README.md ---
@@ -671,89 +718,111 @@ window.requestFileSystem(window.TEMPORARY, 5 * 1024
* 1024, function (fs) {
}, onErrorLoadFs
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58928048
--- Diff: README.md ---
@@ -671,89 +718,111 @@ window.requestFileSystem(window.TEMPORARY, 5 * 1024
* 1024, function (fs) {
}, onErrorLoadFs
Hey folks,
Last month, we sent out a list of things that the team at Microsoft was working
on, for the Apache Cordova project. You can find that list here -
http://apache.markmail.org/thread/lqvfduev3ib2ob62
We made a lot of progress, and I wanted to keep up the cadence, telling people
what we
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/177#issuecomment-207044636
LGTM as well aside from Jason's feedback.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/177#discussion_r58923252
--- Diff: www/FileWriter.js ---
@@ -107,8 +108,29 @@ FileWriter.prototype.write = function(data) {
var fileReader = new FileReader()
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/202#discussion_r58923139
--- Diff: appium-tests/android/android.spec.js ---
@@ -450,143 +306,110 @@ describe('Camera tests Android.', function () {
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/177#issuecomment-207042297
LGTM aside from the minor issues I commented on.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/202#issuecomment-207042099
I'm not sure if this is a limitation of the way appium injects functions,
but since the promise-related callbacks seem to be the same for iOS and
Android
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/177#discussion_r58922573
--- Diff: www/FileWriter.js ---
@@ -107,8 +108,29 @@ FileWriter.prototype.write = function(data) {
var fileReader = new FileReader()
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/177#discussion_r58919879
--- Diff: www/FileWriter.js ---
@@ -107,8 +108,29 @@ FileWriter.prototype.write = function(data) {
var fileReader = new FileReader()
GitHub user GitRubb opened a pull request:
https://github.com/apache/cordova-android/pull/288
CB-8383 Handle pause event when keeprunning=false
I added this pull request to hopefully get some attention to this bug
https://issues.apache.org/jira/browse/CB-8383. When keeprunning = fal
Nice! Thank you!
On Wed, Apr 6, 2016 at 6:32 PM, Dmitry Blotsky wrote:
> Check it out! http://cordova.apache.org/docs/
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordov
Update: looks like it looks like an ios-deploy thing
https://github.com/phonegap/ios-deploy/pull/218#issuecomment-206895124
On Tue, Apr 5, 2016 at 4:47 PM, Nikhil Khandelwal
wrote:
> I noticed there is an issue with ios-deploy/cordova-ios & Xcode 7.3. This
> seems fairly high priority: CB-10962.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/177#issuecomment-207004588
Please find the issue details in the
[Jira](https://issues.apache.org/jira/browse/CB-10960).
---
If your project is set up for it, you can reply to this e
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/177#issuecomment-207000261
@rakatyal @jasongin Can you please review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
BTW: The library project is in the Android directory of this plugin. I
want to be able to have our plugins use Library Projects and AARs so that
we can get much improved test coverage.
https://github.com/infil00p/cordova-plugin-inappbrowser/tree/aar_poc
On Thu, Apr 7, 2016 at 8:52 AM, Joe Bowser
I vote +1:
* Verified archives via `coho verify-archive`
* Verified tags manually
* Verified that blank app creates correctly with platform
* Verified that blank app can be successfully ran and built
* Verified that platform can be updated from previous version
* Verified compatibility with core p
Will do. Thanks for the pointer.
On Thu, Apr 7, 2016 at 11:13 AM, Shazron wrote:
> Hi,
> Check out the official plugins, they have a package.json which is the npm
> package format for publishing to their registry. Most plugins would publish
> to that so users can just install a plugin by name.
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/202
Appium tests stability improvements
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-plugin-camera ui-tests
Hi,
Check out the official plugins, they have a package.json which is the npm
package format for publishing to their registry. Most plugins would publish
to that so users can just install a plugin by name.
On Thursday, April 7, 2016, Brad Reynolds wrote:
> If there's an official way to release a
BTW: You can use this to install plugins in an Android Studio project.
It's a proof-of-concept, but it's a good stop-gap until we get our plugin
story figured out.
https://github.com/infil00p/cordova-android-studio
On Thu, Apr 7, 2016 at 5:31 AM, julio cesar sanchez
wrote:
> I think it's a good
I didn't publish it anywhere yet because I can't officially publish things
as Cordova without things being voted on. I could probably call this all
PhoneGap and publish it, but I really want to make sure that I have the is
dotted and the ts crossed before doing that, since I don't want the Apache
If there's an official way to release a plugin let me know but I just
pushed a plugin we developed to github. It allows for a cordova app to
inject cordova into a remote site. This allows us to have a cordova app
with native integration and a mobile app for older devices and platforms we
don't su
Github user goshakkk commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/55#issuecomment-206938010
So, we should add a check if it's hidden and then the PR is good?
---
If your project is set up for it, you can reply to this email and have your
repl
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/55#issuecomment-206936756
If the statusbar is the in-call statusbar, then 40-20 = 20. Your code is ok
for this case.
If the statusbar is the regular statusbar, then 20-2
Github user goshakkk commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/55#issuecomment-206934148
https://issues.apache.org/jira/browse/CB-10796
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user goshakkk commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/55#issuecomment-206932594
The problem is with just overlay set to true, when the status bar extends,
it partially slides onto the web view.
Reducing the web view's fram
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/55#issuecomment-206930561
With that code, if statusbar is hidden(height = 0), you'll set webview y to
-20.
What is the problem you are trying to fix? right now the
GitHub user elsewhat opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/201
CB-11034: Camera.getPicture -Handle of OutOfMemoryError gracefull
Catch OutOfMemoryError for memory intensive operations and handle them
gracefully.
Tested on a Samsung S
Github user goshakkk commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/55#discussion_r58876986
--- Diff: src/ios/CDVStatusBar.m ---
@@ -457,6 +457,14 @@ -(void)resizeWebView
frame.origin.y = statusBarFrame.size.height;
GitHub user goshakkk opened a pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/55
Handle extended status bar on iOS
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hellyeahllc/cordova-plugin-statusbar
tall-i
GitHub user vladimirnani opened a pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/19
Update README.md
Install docs updated
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vladimirnani/cordova-plugin-whitelist
I think it's a good idea as right now you can't install plugins on the
cordova embedded webview use case, not even with plugman.
Did you publish it on jcenter or mavencentral? or can you publish on github
the plugin as library project (I mean the plugin with the changes you
made, but without the
Github user mariol3 commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/112#issuecomment-206808003
+1 for this fix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/177
CB-10960 Uncaught # in write() when readyState != WRITING ?
[Jira issue](https://issues.apache.org/jira/browse/CB-10960)
You can merge this pull request into a Git repository by running
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-contacts/pull/118
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if th
Cordova-windows@4.3.2 is on NPM now:
https://www.npmjs.com/package/cordova-windows
Check out blog post at
http://cordova.apache.org/announcements/2016/04/05/cordova-windows-4.3.2.html
and retweet https://twitter.com/apachecordova?ref_src=twsrc%5Etfw
-
Best regards, Vladimir
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-plugin-contacts/pull/118
CB-11033 Appium tests: Increased the timeout for updating the contact
https://issues.apache.org/jira/browse/CB-11033
You can merge this pull request into a Git repository by runni
78 matches
Mail list logo
