[GitHub] cordova-paramedic pull request: Paramedic improvements

Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r59327252 --- Diff: lib/paramedic.js --- @@ -0,0 +1,231 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more contri

[GitHub] cordova-paramedic pull request: Paramedic improvements

Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r59327011 --- Diff: lib/LocalServer.js --- @@ -0,0 +1,162 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more cont

[GitHub] cordova-paramedic pull request: Paramedic improvements

Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r59326850 --- Diff: lib/LocalServer.js --- @@ -0,0 +1,162 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more cont

Re: Inclusion of Evothings Studio on https://cordova.apache.org/

I’ve merged the PR. The change will go live the next time anyone does a website deployment. Kindly, Dmitry > On Apr 11, 2016, at 4:20 PM, Shazron wrote: > > Layout wise, it could get ugly (thus the randomizer). IMO we can accept the > PR, I don't think there is even a task in JIRA (nor consens

[GitHub] cordova-plugin-contacts pull request: CB-9348 Fetch phoneNumbers a...

Github user 17holeinone commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/88#issuecomment-208715996 Not sure this is the right place, but how about a solution to this problem on Android? --- If your project is set up for it, you can reply to this

[GitHub] cordova-docs pull request: CB-10996 Updating docs index page to ma...

Github user devgeeks commented on the pull request: https://github.com/apache/cordova-docs/pull/575#issuecomment-208684628 Looks nice --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] cordova-docs pull request: CB-10996 Updating docs index page to ma...

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/575#issuecomment-208684175 Screenshot:  --- If your project is set up fo

[GitHub] cordova-docs pull request: CB-10996 Updating docs index page to ma...

GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-docs/pull/575 CB-10996 Updating docs index page to match new content. @riknoll @nikhilkh @rakatyal @devgeeks please take a look when you have a moment. You can merge this pull request into a Git repositor

[GitHub] cordova-plugin-camera pull request: Added Sample section to the Ca...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/203#issuecomment-208634228 I made a few comments inline, but nothing major. Also, `README.md` is actually a generated file in this repo (and this repo only). It would be gr

[GitHub] cordova-plugin-camera pull request: Added Sample section to the Ca...

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/203#discussion_r59302091 --- Diff: README.md --- @@ -526,3 +526,207 @@ Tizen only supports a `destinationType` of [web_activities]: https://hacks.mozilla.org/2013

[GitHub] cordova-ios pull request: CB-10962 CB-10945 removes justlaunch fla...

Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/212#issuecomment-208624800 Everyone, try the new ios-deploy version 1.8.6. This PR can be closed. --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] cordova-plugin-camera pull request: Added Sample section to the Ca...

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/203#discussion_r59300947 --- Diff: README.md --- @@ -526,3 +526,207 @@ Tizen only supports a `destinationType` of [web_activities]: https://hacks.mozilla.org/2013

[GitHub] cordova-plugin-camera pull request: Added Sample section to the Ca...

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/203#discussion_r59300666 --- Diff: README.md --- @@ -526,3 +526,207 @@ Tizen only supports a `destinationType` of [web_activities]: https://hacks.mozilla.org/2013

[GitHub] cordova-plugin-file pull request: adding sample section to readme

Github user rakatyal commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/176#issuecomment-208616871 Minor comments. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-camera pull request: Added Sample section to the Ca...

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/203#discussion_r59299069 --- Diff: README.md --- @@ -526,3 +526,207 @@ Tizen only supports a `destinationType` of [web_activities]: https://hacks.mozilla.org/2013

[GitHub] cordova-plugin-file pull request: adding sample section to readme

Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/176#discussion_r59298774 --- Diff: README.md --- @@ -538,3 +540,296 @@ Android also supports a special filesystem named "documents", which represents a * `root`: Th

[GitHub] cordova-plugin-camera pull request: Added Sample section to the Ca...

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/203#discussion_r59298569 --- Diff: README.md --- @@ -526,3 +526,207 @@ Tizen only supports a `destinationType` of [web_activities]: https://hacks.mozilla.org/2013

Re: Inclusion of Evothings Studio on https://cordova.apache.org/

Layout wise, it could get ugly (thus the randomizer). IMO we can accept the PR, I don't think there is even a task in JIRA (nor consensus) that we should even do the randomizer (at least until it becomes a problem). On Mon, Apr 11, 2016 at 3:44 AM, julio cesar sanchez wrote: > So should we accep

[GitHub] cordova-plugin-file pull request: adding sample section to readme

Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/176#discussion_r59298517 --- Diff: README.md --- @@ -36,7 +36,9 @@ Although most of the plugin code was written when an earlier spec was current: It also implements

[GitHub] cordova-plugin-camera pull request: Added Sample section to the Ca...

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/203#discussion_r59298463 --- Diff: README.md --- @@ -526,3 +526,207 @@ Tizen only supports a `destinationType` of [web_activities]: https://hacks.mozilla.org/2013

[GitHub] cordova-plugin-camera pull request: Added Sample section to the Ca...

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/203#discussion_r59298167 --- Diff: README.md --- @@ -526,3 +526,207 @@ Tizen only supports a `destinationType` of [web_activities]: https://hacks.mozilla.org/2013

[GitHub] cordova-plugin-file-transfer pull request: adding sample section t...

Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/136#discussion_r59297886 --- Diff: README.md --- @@ -315,3 +315,231 @@ If you are upgrading to a new (1.0.0 or newer) version of File, and you have pre

[GitHub] cordova-plugin-file-transfer pull request: adding sample section t...

Github user rakatyal commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/136#issuecomment-208605754 Minor comments. Otherwise LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] cordova-plugin-file-transfer pull request: adding sample section t...

Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/136#discussion_r59297187 --- Diff: README.md --- @@ -315,3 +315,231 @@ If you are upgrading to a new (1.0.0 or newer) version of File, and you have pre

[GitHub] cordova-plugin-file-transfer pull request: adding sample section t...

Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/136#discussion_r59297145 --- Diff: README.md --- @@ -315,3 +315,231 @@ If you are upgrading to a new (1.0.0 or newer) version of File, and you have pre

[GitHub] cordova-lib pull request: CB-11022 Improve performance of `cordova...

Github user jasongin commented on the pull request: https://github.com/apache/cordova-lib/pull/423#issuecomment-208603032 OK, I didn't realize config file transformations were also done already in plugin add. And I think I have a better understanding of the code now. My unders

[GitHub] cordova-plugin-file-transfer pull request: adding sample section t...

Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/136#discussion_r59296514 --- Diff: README.md --- @@ -315,3 +315,231 @@ If you are upgrading to a new (1.0.0 or newer) version of File, and you have pre

[GitHub] cordova-plugin-file-transfer pull request: adding sample section t...

Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/136#discussion_r59295798 --- Diff: README.md --- @@ -315,3 +315,231 @@ If you are upgrading to a new (1.0.0 or newer) version of File, and you have pre

[GitHub] cordova-plugin-file-transfer pull request: adding sample section t...

Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/136#discussion_r59295678 --- Diff: README.md --- @@ -315,3 +315,231 @@ If you are upgrading to a new (1.0.0 or newer) version of File, and you have pre

[GitHub] cordova-plugin-camera pull request: Appium tests stability improve...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/202#discussion_r59295343 --- Diff: appium-tests/android/android.spec.js --- @@ -27,52 +28,47 @@ 'use strict'; -var wdHelper = require('../helpers/

[GitHub] cordova-docs pull request: Added Evothings Studio to Cordova Tools...

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/410#issuecomment-208597412 @mikaelkindborg I've merged the PR! Please feel free to close it. Somehow my merging script didn't append the "this closes..." part. --- If your project is set u

[GitHub] cordova-plugin-file pull request: CB-10798, CB-10384: Fixing permi...

Github user silhouettes commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/170#issuecomment-208582527 @Macdonst, should I follow up with this person to get a rough guess on the timeline (in which case I might need his details), or will he respond in this

[GitHub] cordova-cli pull request: CB-10986: Adding note about scoped npm p...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-cli/pull/243#issuecomment-208579473 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cordova-plugin-file pull request: CB-10798, CB-10384: Fixing permi...

Github user macdonst commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/170#issuecomment-208579024 @rakatyal no one really responded with a date and I'm going to hand it over to Steve to get the release out. --- If your project is set up for it, you ca

[GitHub] cordova-lib pull request: CB-10986: Adding support for scoped npm ...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-lib/pull/425#issuecomment-20852 @vladimir-kotikov please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-cli pull request: CB-10986: Adding note about scoped npm p...

GitHub user riknoll opened a pull request: https://github.com/apache/cordova-cli/pull/243 CB-10986: Adding note about scoped npm packages for plugins @nikhilkh please review. This is related to https://github.com/apache/cordova-lib/pull/425 You can merge this pull request into a Gi

[GitHub] cordova-lib pull request: CB-10986: Adding support for scoped npm ...

GitHub user riknoll opened a pull request: https://github.com/apache/cordova-lib/pull/425 CB-10986: Adding support for scoped npm package plugins Apparently pre 6.1.0 versions of the CLI were able to add scoped npm packages, but I don't think we ever supported that feature (if it ev

[GitHub] cordova-plugin-file pull request: CB-10798, CB-10384: Fixing permi...

Github user rakatyal commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/170#issuecomment-208566190 @macdonst: Hey Simon! I know you were planning to do a plugin release. Any update on when it's scheduled? --- If your project is set up for it, you can r

[GitHub] cordova-plugin-file pull request: CB-10798, CB-10384: Fixing permi...

Github user silhouettes commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/170#issuecomment-208564502 @rakatyal, do you happen to know when this will be released, or who I could ask? Just to see if we should wait for it on our own plugin: https://github

[CI] Status for 04/11/16

Hey everyone, Here is the CI status for last week. Build Status (# of test failures): 0 - Android on Windows 0 - Android on OS X ? - iOS (CI failing, see CB-10898) 0 - WP 8.1 0 - Windows JIRAs that need attention: - CB-10475: iOS Contacts Permission Modal causes test failure - CB-10898: Invalid

[GitHub] cordova-lib pull request: CB-10975 Allow plugin path to be relativ...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-lib/pull/421#issuecomment-208522580 LGTM. Is this a regression? Another one to add tests for. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-lib pull request: CB-10770 Remove cache-min when adding pl...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/422 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request: CB-10770 Remove cache-min when adding pl...

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/422#issuecomment-208511405 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] cordova-plugin-file-transfer pull request: adding sample section t...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/136#issuecomment-208437365 @daserge @rakatyal to help review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-lib pull request: CB-10921 Emit warning in case of plugin ...

Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/420#issuecomment-208401173 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cordova-lib pull request: CB-10770 Remove cache-min when adding pl...

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/422#discussion_r59224471 --- Diff: cordova-lib/src/cordova/lazy_load.js --- @@ -147,10 +147,7 @@ function cordova_npm(platform) { // Returns a promise that resolves to direct

[GitHub] cordova-lib pull request: CB-10770 Remove cache-min when adding pl...

Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/422#issuecomment-208400534 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cordova-lib pull request: CB-10921 Emit warning in case of plugin ...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/420#issuecomment-208353356 @omefire, addressed your notes and merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] cordova-lib pull request: CB-10921 Emit warning in case of plugin ...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/420 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-plugin-camera pull request: CB-4078: correctOrientation no...

Github user unbeatableDeepak commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/197#issuecomment-208319501 @swbradshaw if your code is working please share it with me, my app's new release is pending due to this issue. Thanks in advance. --- If

[GitHub] cordova-lib pull request: CB-10921 Emit warning in case of plugin ...

Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/420#discussion_r59195085 --- Diff: cordova-lib/src/cordova/plugin.js --- @@ -157,6 +157,7 @@ module.exports = function plugin(command, targets, opts) {

[GitHub] cordova-lib pull request: CB-11022 Improve performance of `cordova...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/423#issuecomment-208311472 The config file transformations are already handled during both plugin add/rm and prepare. Consider the following code: [Api.js#L233-L237](https://github.c

[GitHub] cordova-plugin-camera pull request: Appium tests stability improve...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/202#discussion_r59190313 --- Diff: appium-tests/ios/ios.spec.js --- @@ -85,204 +84,187 @@ describe('Camera tests iOS.', function () { }

[GitHub] cordova-plugin-camera pull request: Appium tests stability improve...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/202#discussion_r59189798 --- Diff: appium-tests/android/android.spec.js --- @@ -251,141 +200,50 @@ describe('Camera tests Android.', function () {

[GitHub] cordova-plugin-camera pull request: Appium tests stability improve...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/202#discussion_r59189329 --- Diff: appium-tests/android/android.spec.js --- @@ -27,52 +28,47 @@ 'use strict'; -var wdHelper = require('../

Re: Inclusion of Evothings Studio on https://cordova.apache.org/

So should we accept the PR now? or wait until we have the tool randomizing ready? 2016-03-31 23:00 GMT+02:00 Ryan J. Salva : > +1 > > Sent via 📱 > > > > > On Thu, Mar 31, 2016 at 1:52 PM -0700, "Parashuram N" < > panar...@microsoft.com> wrote: > > +1 – let us add th

[GitHub] cordova-docs pull request: Added Evothings Studio to Cordova Tools...

Github user mikaelkindborg commented on the pull request: https://github.com/apache/cordova-docs/pull/410#issuecomment-208270512 @dblotsky @jcesarmobile Hi, did you reach a decision regarding merging this pull request? --- If your project is set up for it, you can reply to this email

[GitHub] cordova-plugin-statusbar pull request: CB-11018 Fix statusbar with...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/54 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] cordova-plugin-contacts pull request: CB-10985 Android sets type t...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/116 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] cordova-lib pull request: [CB-11062] Add --recursive option to git...

GitHub user jfrumar opened a pull request: https://github.com/apache/cordova-lib/pull/424 [CB-11062] Add --recursive option to git clone command Support cordova plugins that make use of git submodules. ref: https://issues.apache.org/jira/browse/CB-11062 You can merge this p

[GitHub] cordova-plugin-file pull request: CB-10960 Uncaught # i...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/177 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] cordova-android pull request: [CB-8250] fix issue with app_name co...

Github user revolunet commented on the pull request: https://github.com/apache/cordova-android/pull/272#issuecomment-208196997 link to JIRA issue : https://issues.apache.org/jira/browse/CB-8250 --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] cordova-android pull request: [CB-10689] fix issue with app_name c...

Github user revolunet commented on the pull request: https://github.com/apache/cordova-android/pull/272#issuecomment-208196549 @jfrumar Hi, tried with amperstand, ex "Black & White" in `config.xml/widget/name` and no issue here. can you explain the issue further please ? --- If your