[GitHub] cordova-android pull request: CB-9519 Fix the engine destruction b...

Github user NoLongerLazyDhl closed the pull request at: https://github.com/apache/cordova-android/pull/207 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-android pull request: CB-9519 Fix the engine destruction b...

Github user NoLongerLazyDhl closed the pull request at: https://github.com/apache/cordova-android/pull/208 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

Re: [DISCUSS] Plugins release

No objections, plugins owners could benefit of the new way to handle the android permissions with common plugin On Thu, Apr 14, 2016 at 8:23 PM Simon MacDonald wrote: > Nope, do it. > On Apr 14, 2016 14:09, "Steven Gill" wrote: > > > I'm going

Re: [DISCUSS] Plugins release

Nope, do it. On Apr 14, 2016 14:09, "Steven Gill" wrote: > I'm going to start this today. Any objections? > On Apr 8, 2016 12:40 PM, "julio cesar sanchez" > wrote: > > > I can wait, and maybe fix some issues this weekend. > > > > > > El viernes,

[GitHub] cordova-ios pull request: Stay attached to LLDB when running app

Github user saghul closed the pull request at: https://github.com/apache/cordova-ios/pull/188 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-inappbrowser pull request: New PR for Geo sample - ...

Github user normesta commented on a diff in the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/161#discussion_r59801914 --- Diff: README.md --- @@ -217,6 +217,79 @@ The object returned from a call to `cordova.InAppBrowser.open`. -

[GitHub] cordova-plugin-geolocation pull request: New PR for sample content...

Github user normesta commented on a diff in the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/75#discussion_r59793647 --- Diff: README.md --- @@ -296,3 +311,436 @@ callback function when an error occurs with navigator.geolocation. - Returned when

[GitHub] cordova-plugin-geolocation pull request: New PR for sample content...

Github user normesta commented on a diff in the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/75#discussion_r59793230 --- Diff: README.md --- @@ -296,3 +311,436 @@ callback function when an error occurs with navigator.geolocation. - Returned when

[GitHub] cordova-paramedic pull request: Code changes for Collecting Device...

Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/4#discussion_r59791877 --- Diff: lib/ParamedicKill.js --- @@ -0,0 +1,95 @@ +#!/usr/bin/env node + +"use strict"; + +var shelljs =

Re: Why does the Dialogs plugin in inject itself into navigator and has no browser support?

Notification pre-dates the use of plugin namespaces, most plugins originally were hung off of navigator when a standard did not exist. The notification plugin used to include things like displaying a loading spinner, or vibrating the device, so it was much more about 'notifying' than strictly

[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-210133865 Thanks @Taewa ! I was just curious. I wonder how often this happens?! Never on windows ... ;) --- If your project is set up for it, you can reply

[GitHub] cordova-paramedic pull request: Code changes for Collecting Device...

Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/4#discussion_r59777381 --- Diff: lib/paramedic.js --- @@ -105,10 +116,23 @@ ParamedicRunner.prototype.checkPlatformRequirements = function() {

[GitHub] cordova-paramedic pull request: Code changes for Collecting Device...

Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/4#discussion_r59776906 --- Diff: main.js --- @@ -25,7 +25,12 @@ var USAGE = "Error missing args. \n" + "--useTunnel : (optional) use tunneling instead of local

[GitHub] cordova-paramedic pull request: Code changes for Collecting Device...

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/4#discussion_r59769584 --- Diff: lib/ParamedicKill.js --- @@ -0,0 +1,95 @@ +#!/usr/bin/env node + +"use strict"; + +var shelljs = require("shelljs");

Re: [DISCUSS] Plugins release

I'm going to start this today. Any objections? On Apr 8, 2016 12:40 PM, "julio cesar sanchez" wrote: > I can wait, and maybe fix some issues this weekend. > > > El viernes, 8 de abril de 2016, Simon MacDonald > > escribió: > > > I'm currently

[GitHub] cordova-paramedic pull request: Code changes for Collecting Device...

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/4#discussion_r59762195 --- Diff: lib/ParamedicKill.js --- @@ -0,0 +1,95 @@ +#!/usr/bin/env node + +"use strict"; + +var shelljs = require("shelljs");

[GitHub] cordova-paramedic pull request: Code changes for Collecting Device...

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/4#discussion_r59762070 --- Diff: lib/ParamedicKill.js --- @@ -0,0 +1,95 @@ +#!/usr/bin/env node + +"use strict"; + +var shelljs = require("shelljs");

[GitHub] cordova-plugin-camera pull request: Added Sample section to the Ca...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/203#issuecomment-210056156 LGTM! I'll merge this later today and regenerate the README --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-paramedic pull request: Code changes for Collecting Device...

Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/4#discussion_r59745115 --- Diff: lib/ParamedicPermissions.js --- @@ -0,0 +1,60 @@ +#!/usr/bin/env node + +/* jshint node: true */ +var path=

[GitHub] cordova-plugin-test-framework pull request: Add spec started/compl...

Github user rakatyal commented on the pull request: https://github.com/apache/cordova-plugin-test-framework/pull/19#issuecomment-210012817 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-plugin-splashscreen pull request: CB-6498 Misleading docum...

Github user rakatyal commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/97#issuecomment-210011883 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-plugin-media pull request: Protect setVolume call in case ...

GitHub user fafaman opened a pull request: https://github.com/apache/cordova-plugin-media/pull/93 Protect setVolume call in case Player object is referenced but not cr… Hi, this is a fix for https://issues.apache.org/jira/browse/CB-11086. thanks. You can merge this pull request

[GitHub] cordova-plugin-media pull request: Cb 11085

GitHub user fafaman opened a pull request: https://github.com/apache/cordova-plugin-media/pull/92 Cb 11085 This is a fix for Cb 11085. Thanks. You can merge this pull request into a Git repository by running: $ git pull https://github.com/fafaman/cordova-plugin-media CB-11085

[GitHub] cordova-docs pull request: CB-11070 Document SplashScreenBackgroun...

Github user omefire commented on the pull request: https://github.com/apache/cordova-docs/pull/578#issuecomment-209993540 ACK! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-medic pull request: CB-11084 CameraUsesGeolocation=true fo...

GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-medic/pull/92 CB-11084 CameraUsesGeolocation=true for iOS https://issues.apache.org/jira/browse/CB-11084 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-docs pull request: CB-11001 Incorrect docs - "FullScreen" ...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/576 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-labs pull request: CB-10974 Cordova file transfer Content-...

GitHub user daserge opened a pull request: https://github.com/apache/cordova-labs/pull/13 CB-10974 Cordova file transfer Content-Length header problem Adds headers echo endpoint [Jira issue](https://issues.apache.org/jira/browse/CB-10974) You can merge this pull request

[GitHub] cordova-plugin-file-transfer pull request: CB-10974 Cordova file t...

Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/141#issuecomment-209963660 This PR required https://github.com/apache/cordova-labs/pull/13 --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-plugin-file-transfer pull request: CB-10974 Cordova file t...

GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/141 CB-10974 Cordova file transfer Content-Length header problem Fixed iOS logic to not to include Content-Length when chunkedMode=true Fixed Android logic preventing

[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...

Github user Taewa commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-209953945 Hello @purplecabbage I actually didn't know why I had to use sudo. As @ghenry22 explained, I had odd permission problem. Some project had to use

[GitHub] cordova-lib pull request: CB-11022 Save modulesMetadata to both ww...

GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/427 CB-11022 Save modulesMetadata to both www and platform_www when necessary This is a port of corresponding platform changes (see https://github.com/apache/cordova-windows/pull/167,

[GitHub] cordova-plugin-dialogs pull request: Secure prompt text fields for...

GitHub user WillAnd31 opened a pull request: https://github.com/apache/cordova-plugin-dialogs/pull/71 Secure prompt text fields for passwords This PR will add the ability to have secure text input fields (for passwords) on prompts. I've only tested this on iPhone and Android

[GitHub] cordova-ios pull request: CB-11022 Duplicate www files on plugin i...

GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-ios/pull/218 CB-11022 Duplicate www files on plugin installation/removal This PR is similar to https://github.com/apache/cordova-windows/pull/167,

[GitHub] cordova-windows pull request: CB-11022 Duplicate www files on plug...

GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-windows/pull/167 CB-11022 Duplicate www files on plugin installtion/removal This PR is similar to apache/cordova-android#289 and is needed to remove requirement for running prepare after every

[GitHub] cordova-android pull request: CB-11022 Duplicate www files to both...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/289 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-lib pull request: CB-11022 Improve performance of `cordova...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/423 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-10975 Allow plugin path to be relativ...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/421 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Why does the Dialogs plugin in inject itself into navigator and has no browser support?

Hello, sometimes I wonder the historical reasons why certain cordova plugins choose to inject themself into "navigator" instead of their own namespace or remain at cordova.plugins.. For things where a native browser spec exists or is proposed like "geolocation" it makes sense. Then you can just