This sounds great!
Personally, I don't think this belongs behind a flag, why would anyone not
want to build faster?
I think we just need to test more to make sure it functions as expected
everywhere, and then it should just make it's way in directly, without the
overhead of addition flag code, or d
GitHub user dblotsky opened a pull request:
https://github.com/apache/cordova-docs/pull/583
ToC Generation Refactor
**Note**: this PR is easier to review one commit at a time, and the commit
messages roughly describe each change.
Changes:
- now `*-src.yml` files are man
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/583#issuecomment-212213980
@riknoll @rakatyal @nikhilkh please review when you have a moment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/178
CB-5 android: Fixing test content provider
Seems like `FileDescriptor.toString()` changed in Android N and it broke
three of our tests. This removes our dependency on the output of
I collected data for 4 projects with varying numbers and sizes of source files
(mostly .js and .png):
Tiny : 17 files, 0.24 MB (A new Cordova project created from the VS
template)
Small : 55 files, 7.7 MB
Medium:242 files, 44 MB
Large : 12,923 files, 134 MB
Follo
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/168#discussion_r60334412
--- Diff: template/cordova/lib/ConfigChanges.js ---
@@ -0,0 +1,85 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (the "License");
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60334146
--- Diff: www/static/css-src/main.scss ---
@@ -194,6 +194,23 @@ code {
color: #00;
}
+/* algolia search formatting */
+.
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/581#issuecomment-212179026
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
GitHub user nikhilkh opened a pull request:
https://github.com/apache/cordova-cli/pull/245
Clarify the docs w.r.t. directory structure
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nikhilkh/cordova-cli patch-1
Alternatively yo
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/168#discussion_r60332098
--- Diff: template/cordova/lib/ConfigChanges.js ---
@@ -0,0 +1,85 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (the "License");
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/140#issuecomment-212176107
@daserge to help review. Looks like we might need some tests for this as
well.
---
If your project is set up for it, you can reply to this emai
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/168#discussion_r60331966
--- Diff: template/cordova/Api.js ---
@@ -29,7 +29,7 @@ var ActionStack = require('cordova-common').ActionStack;
var CordovaError = require('cor
Github user MrARC commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/51#issuecomment-212174489
I tested this feature on Motorola devices and it looks good, but this isn't
the case when testing on Samsung and Sony Xperia devices, the statusbar doesn'
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-docs/pull/582#issuecomment-212171858
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60329788
--- Diff: conf/_config.yml ---
@@ -81,3 +81,5 @@ kramdown:
# exclude these directories from the build
exclude:
- static/css-src
+
Github user sarangan12 commented on the pull request:
https://github.com/apache/cordova-docs/pull/581#issuecomment-212170562
@dblotsky Let me know when you are done... I will merge the commits to one
commit.
---
If your project is set up for it, you can reply to this email and have
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60329745
--- Diff: conf/_config.yml ---
@@ -81,3 +81,5 @@ kramdown:
# exclude these directories from the build
exclude:
- static/css-src
+
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60329718
--- Diff: www/_layouts/base.html ---
@@ -3,12 +3,20 @@
---
-
+{% if page.language %}
+{% assign language = page.langu
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60329685
--- Diff: www/_includes/algolia.html ---
@@ -0,0 +1,14 @@
+{% if page.version %}
+{% assign version = page.version %}
+{% else %}
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60329698
--- Diff: www/_includes/header.html ---
@@ -29,18 +29,24 @@
Get
Started
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60329672
--- Diff: conf/_config.yml ---
@@ -81,3 +81,5 @@ kramdown:
# exclude these directories from the build
exclude:
- static/css-src
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/4#discussion_r60329456
--- Diff: lib/ParamediciOSPermissions.js ---
@@ -0,0 +1,43 @@
+#!/usr/bin/env node
+
+/* jshint node: true */
+var path = require
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60329201
--- Diff: www/_layouts/base.html ---
@@ -3,12 +3,20 @@
---
-
+{% if page.language %}
+{% assign language = page.languag
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60329126
--- Diff: www/_includes/header.html ---
@@ -29,18 +29,24 @@
Get
Started
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60328845
--- Diff: www/_includes/algolia.html ---
@@ -0,0 +1,14 @@
+{% if page.version %}
+{% assign version = page.version %}
+{% else %}
+
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60328800
--- Diff: conf/_config.yml ---
@@ -81,3 +81,5 @@ kramdown:
# exclude these directories from the build
exclude:
- static/css-src
+
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60328734
--- Diff: www/_layouts/base.html ---
@@ -3,12 +3,27 @@
---
-
+{% if page.language %}
+{% assign language = page.langu
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-medic/pull/93#issuecomment-212168418
Very helpful guide! I was able to get the tests running on my machine (for
Android, didn't try iOS). One thing to note is that it seems like the tests are
very dep
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60328488
--- Diff: www/static/css-src/main.scss ---
@@ -194,6 +194,23 @@ code {
color: #00;
}
+/* algolia search formatting */
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60328530
--- Diff: www/_layouts/base.html ---
@@ -3,12 +3,27 @@
---
-
+{% if page.language %}
+{% assign language = page.langu
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60328452
--- Diff: www/_layouts/base.html ---
@@ -3,12 +3,27 @@
---
-
+{% if page.language %}
+{% assign language = page.langu
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60328435
--- Diff: www/_layouts/base.html ---
@@ -3,12 +3,27 @@
---
-
+{% if page.language %}
+{% assign language = page.langu
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60328400
--- Diff: www/_includes/head.html ---
@@ -18,6 +18,9 @@
{% endif %}
+
+https://cdn.jsdelivr.net/docsearch
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/582#issuecomment-21216
It might be helpful to mention that cordova-plugin-compat is replacing the
PermissionHelper.java file that was duplicated in all the plugin repos. There
were a few
Please review the plugins release blog post
https://github.com/apache/cordova-docs/pull/582
On Thu, Apr 14, 2016 at 6:39 PM, Carlos Santana
wrote:
> No objections, plugins owners could benefit of the new way to handle the
> android permissions with common plugin
>
> On Thu, Apr 14, 2016 at 8:23
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-docs/pull/582
CB-11091 added plugins release blog post
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-docs master
Alternatively
Sounds like a worthy cause. Do you have any stats on how much time is saved?
Definitely put it behind the --incremental flag to start.
On Tue, Apr 19, 2016 at 2:43 PM, Jason Ginchereau
wrote:
> We've had a few customers complain that the dev inner loop for Cordova
> apps is slow compared to nat
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/4#discussion_r60320027
--- Diff: main.js ---
@@ -37,6 +39,30 @@ if (pathToParamedicConfig || // --config
ParamedicConfig.parseFromFile(pathToParamedicConfig):
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/4#discussion_r60319977
--- Diff: main.js ---
@@ -37,6 +39,30 @@ if (pathToParamedicConfig || // --config
ParamedicConfig.parseFromFile(pathToParamedicConfig):
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/93#issuecomment-212146985
@fafaman that does sound like a `configChanges` issue as Nikhil mentioned.
To prevent the restart, you need to add the `uiMode` value in the
`configChanges
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/4#discussion_r60319371
--- Diff: lib/ParamediciOSPermissions.js ---
@@ -0,0 +1,43 @@
+#!/usr/bin/env node
+
+/* jshint node: true */
+var path = require
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/4#discussion_r60319212
--- Diff: lib/ParamedicConfig.js ---
@@ -36,8 +36,10 @@ ParamedicConfig.parseFromArguments = function (argv) {
startPort: argv.s
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/4#discussion_r60318605
--- Diff: lib/ParamedicConfig.js ---
@@ -36,8 +36,10 @@ ParamedicConfig.parseFromArguments = function (argv) {
startPort: argv.s
We've had a few customers complain that the dev inner loop for Cordova apps is
slow compared to native app development. So recently I've been looking at ways
to optimize it. The two largest pieces of a Cordova build are "prepare" and
"compile" phases. While there's not much we can realistically
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60314872
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60314159
--- Diff: www/_layouts/base.html ---
@@ -3,12 +3,27 @@
---
-
+{% if page.language %}
+{% assign language = page.languag
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60313932
--- Diff: www/_layouts/base.html ---
@@ -3,12 +3,27 @@
---
-
+{% if page.language %}
+{% assign language = page.languag
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60313371
--- Diff: www/static/css-src/main.scss ---
@@ -194,6 +194,23 @@ code {
color: #00;
}
+/* algolia search formatting */
+.
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60313002
--- Diff: www/_layouts/base.html ---
@@ -3,12 +3,27 @@
---
-
+{% if page.language %}
+{% assign language = page.languag
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60312938
--- Diff: www/_layouts/base.html ---
@@ -3,12 +3,27 @@
---
-
+{% if page.language %}
+{% assign language = page.languag
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60312014
--- Diff: www/_includes/head.html ---
@@ -18,6 +18,9 @@
{% endif %}
+
+https://cdn.jsdelivr.net/docsearch.j
GitHub user jasongin opened a pull request:
https://github.com/apache/cordova-android/pull/295
CB-7: Use FileUpdater to optimize prepare for android platform
This uses the FileUpdater module added in
https://github.com/apache/cordova-lib/pull/429 to optionally skip copying files
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-android/pull/291#issuecomment-212126887
Should the cloning happen in `cordova-lib` instead - to ensure isolation?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/168#issuecomment-212124345
@rakatyal to help review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/93#issuecomment-212122345
@riknoll to recommend on how to handle Android activity restart when
['configchanges'
](http://developer.android.com/guide/topics/resources/runtime-change
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-212121255
I opened CB-7 to track this work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/4#discussion_r60307151
--- Diff: lib/ParamediciOSPermissions.js ---
@@ -0,0 +1,43 @@
+#!/usr/bin/env node
+
+/* jshint node: true */
+var path = require
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/94#discussion_r60300760
--- Diff: lib/medicPermissions.js ---
@@ -0,0 +1,63 @@
+#!/usr/bin/env node
+
+/* jshint node: true */
+var path= require('path');
GitHub user surajpindoria opened a pull request:
https://github.com/apache/cordova-plugin-contacts/pull/122
[CB-8076] Provide error support for browser platform
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/surajpindoria/cordov
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/94#discussion_r60300110
--- Diff: lib/medicPermissions.js ---
@@ -0,0 +1,63 @@
+#!/usr/bin/env node
+
+/* jshint node: true */
+var path= require('path');
Github user omefire commented on the pull request:
https://github.com/apache/cordova-medic/pull/94#issuecomment-212074252
@sarangan12 could you please review ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user omefire commented on the pull request:
https://github.com/apache/cordova-medic/pull/94#issuecomment-212074104
This PR ports part of the following paramedic PR to medic:
https://github.com/apache/cordova-paramedic/pull/4
---
If your project is set up for it, you can rep
GitHub user omefire opened a pull request:
https://github.com/apache/cordova-medic/pull/94
CB-10475 (cordova-plugin-contacts) Grant 'Contacts' permissions whileâ¦
⦠running on iOS simulator
You can merge this pull request into a Git repository by running:
$ git pull https://
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/428#issuecomment-212067153
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/93#discussion_r60287104
--- Diff: APPIUM.md ---
@@ -0,0 +1,64 @@
+Cordova Medic Appium Runner
+===
+
+This document describes a method to
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/580#discussion_r60286817
--- Diff: www/docs/en/dev/cordova/events/events.md ---
@@ -323,6 +323,16 @@ function onBackKeyDown() {
}
```
+### Windows Quirks
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/580#discussion_r60286669
--- Diff: www/docs/en/dev/cordova/events/events.md ---
@@ -323,6 +323,16 @@ function onBackKeyDown() {
}
```
+### Windows Quirks
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/580#discussion_r60286296
--- Diff: www/docs/en/dev/cordova/events/events.md ---
@@ -323,6 +323,16 @@ function onBackKeyDown() {
}
```
+### Windows Quirks
Github user surajpindoria closed the pull request at:
https://github.com/apache/cordova-plugin-contacts/pull/73
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/93#discussion_r60279829
--- Diff: APPIUM.md ---
@@ -0,0 +1,64 @@
+Cordova Medic Appium Runner
+===
+
+This document describes a method to
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-medic/pull/93#issuecomment-212044839
Minor comments. Otherwise LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/93#discussion_r60279661
--- Diff: APPIUM.md ---
@@ -0,0 +1,64 @@
+Cordova Medic Appium Runner
+===
+
+This document describes a method t
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/93#discussion_r60278921
--- Diff: APPIUM.md ---
@@ -0,0 +1,64 @@
+Cordova Medic Appium Runner
+===
+
+This document describes a method t
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-212039256
@nikhilkh @vladimir-kotikov please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
GitHub user jasongin opened a pull request:
https://github.com/apache/cordova-lib/pull/429
Add FileUpdater module to cordova-common
The new FileUpdater module contains a few functions that enable optimized
file copies by comparing timestamps. These functions are primarily
int
The vote has now closed. The results are:
Positive Binding Votes: 3
Steve Gill
Alexander Sorokin
Shazron Abdullah
The vote has passed. I will share the blog post for review, and then
publish and announce the release.
On Mon, Apr 18, 2016 at 3:56 PM, Shazron wrote:
> I vote +1.
>
> * Verified
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/87#discussion_r60276684
--- Diff: medic/medic-downloadlogs.js ---
@@ -0,0 +1,80 @@
+var path = require('path'),
+fs = require('fs'),
+https = require('https
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/87#discussion_r60274259
--- Diff: medic/medic-downloadlogs.js ---
@@ -0,0 +1,80 @@
+var path = require('path'),
+fs = require('fs'),
+https = require('https
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/87#discussion_r60274232
--- Diff: medic/medic-downloadlogs.js ---
@@ -0,0 +1,80 @@
+var path = require('path'),
+fs = require('fs'),
+https = require('https
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/87#discussion_r60274095
--- Diff: medic/medic-downloadlogs.js ---
@@ -0,0 +1,80 @@
+var path = require('path'),
+fs = require('fs'),
+https = require('https
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/87#discussion_r60274167
--- Diff: medic/medic-downloadlogs.js ---
@@ -0,0 +1,80 @@
+var path = require('path'),
+fs = require('fs'),
+https = require('https
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/580#discussion_r60268796
--- Diff: www/docs/en/dev/cordova/events/events.md ---
@@ -323,6 +323,16 @@ function onBackKeyDown() {
}
```
+### Windows Quirks
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/580#discussion_r60268018
--- Diff: www/docs/en/dev/cordova/events/events.md ---
@@ -323,6 +323,16 @@ function onBackKeyDown() {
}
```
+### Windows Quirks
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-medic/pull/93
CB-2 Added Appium documentation
https://issues.apache.org/jira/browse/CB-2
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpen
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/580#discussion_r60264056
--- Diff: www/docs/en/dev/cordova/events/events.md ---
@@ -323,6 +323,16 @@ function onBackKeyDown() {
}
```
+### Windows Quirks
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/580#discussion_r60263398
--- Diff: www/docs/en/dev/cordova/events/events.md ---
@@ -323,6 +323,16 @@ function onBackKeyDown() {
}
```
+### Windows Quirks
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/428#issuecomment-212000688
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/580#discussion_r60262487
--- Diff: www/docs/en/dev/cordova/events/events.md ---
@@ -323,6 +323,16 @@ function onBackKeyDown() {
}
```
+### Windows Quirks
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/580#discussion_r60262428
--- Diff: www/docs/en/dev/cordova/events/events.md ---
@@ -323,6 +323,16 @@ function onBackKeyDown() {
}
```
+### Windows Quirks
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/580#discussion_r60262381
--- Diff: www/docs/en/dev/cordova/events/events.md ---
@@ -323,6 +323,16 @@ function onBackKeyDown() {
}
```
+### Windows Quirks
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/428#discussion_r60261791
--- Diff: cordova-lib/src/cordova/restore-util.js ---
@@ -112,7 +112,10 @@ function installPluginsFromConfigXML(args) {
// assume it is the
GitHub user cfjedimaster opened a pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/72
Simply add Browser to supported platforms
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cfjedimaster/cordova-plugin-dialog
So on plugins.cordova.io, if you filter by Browser, Dialogs *does*
show up. But when you go to the docs, it isn't shown as supported - so
that could be a minor doc bug. I'll do a PR.
On Tue, Apr 19, 2016 at 10:22 AM, Raymond Camden
wrote:
> I'm looking at the dialog plugin, and I swear I see code
I'm looking at the dialog plugin, and I swear I see code for browser
support already in there. Going to test a bit.
On Thu, Apr 14, 2016 at 3:59 PM, Jesse wrote:
> Notification pre-dates the use of plugin namespaces, most plugins
> originally were hung off of navigator when a standard did not exi
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-medic/pull/92
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-medic/pull/92#issuecomment-211959785
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
GitHub user AllenConquest opened a pull request:
https://github.com/apache/cordova-plugin-network-information/pull/41
fixed two potential memory leaks when doing Analyze on iOS 9
When you perform an Analyze using Xcode 7, two places are identified as
potential memory leaks. These sh
Please review and vote on this cordova-common release
by replying to this email (and keep discussion on the DISCUSS thread)
Release issue: https://issues.apache.org/jira/browse/CB-11096
Both tools have been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/CB-11096/
The packa
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/428
CB-10761 Resore plugins saved without spec attribute
This PR updates plugin restore logic to restore plugins that were added to
plugin.xml without `spec` attribute. See
[CB-10761](htt
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/292
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
1 - 100 of 109 matches
Mail list logo
