[GitHub] cordova-plugin-splashscreen pull request: CB-11156 Change default ...

2016-04-26 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/99 CB-11156 Change default FadeSplashScreenDuration value Updated the docs [Jira issue](https://issues.apache.org/jira/browse/CB-11156) You can merge this pull request into

[GitHub] cordova-windows pull request: CB-11156 Change default FadeSplashSc...

2016-04-26 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-windows/pull/170 CB-11156 Change default FadeSplashScreenDuration value [Jira issue](https://issues.apache.org/jira/browse/CB-11156) You can merge this pull request into a Git repository by running: $

[GitHub] cordova-lib pull request: CB-11131 Fix TypeError: message.toUpperC...

2016-04-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/431 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-medic pull request: CB-11152: Removing the android win bui...

2016-04-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-medic/pull/100 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-medic pull request: CB-11152: Removing the android win bui...

2016-04-26 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-medic/pull/100#issuecomment-214899480 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-android pull request: CB-11153 Use Gradle 2.8 correctly fo...

2016-04-26 Thread infil00p
Github user infil00p commented on the pull request: https://github.com/apache/cordova-android/pull/299#issuecomment-214899779 Good call on updating this to Gradle 2.13, I just updated to 2.1.0 beta, and Android Studio just showed me a bunch of complaints about importing the project.

[GitHub] cordova-android pull request: CB-11153 Use Gradle 2.8 correctly fo...

2016-04-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/299 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-android pull request: CB-11153 Use Gradle 2.8 correctly fo...

2016-04-26 Thread infil00p
Github user infil00p commented on the pull request: https://github.com/apache/cordova-android/pull/299#issuecomment-214900265 OK, I merged this in, because I need it for something I'm working on :P --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-medic pull request: CB-11152: Removing the android win bui...

2016-04-26 Thread rakatyal
GitHub user rakatyal opened a pull request: https://github.com/apache/cordova-medic/pull/100 CB-11152: Removing the android win builder @sarangan12 , @riknoll : Please review. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpen

[GitHub] cordova-docs pull request: CB-11104: Integrate Algolia Search to c...

2016-04-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/581 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-plugin-camera pull request: fixed some bad formatting that...

2016-04-26 Thread Mikejo5000
GitHub user Mikejo5000 opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/207 fixed some bad formatting that hid HTML tags You can merge this pull request into a Git repository by running: $ git pull https://github.com/Mikejo5000/cordova-plugin-camera

[GitHub] cordova-docs pull request: Use XML entities in attributes

2016-04-26 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/585#issuecomment-214846992 It's really an issue with some XML parsers that conform to the spec on "well-formed" XML. In particular, .NET XML parsers used by Visual Studio fail if you do not

[GitHub] cordova-plugin-inappbrowser pull request: CB-11136: Fix OAuth by p...

2016-04-26 Thread ephemer
Github user ephemer commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/162#issuecomment-214827853 Thank you, my pleasure. I have thought about this a bit longer.. The main issue is that recent Cordova changes, namely introducing WKWebVie

[GitHub] cordova-lib pull request: CB-11131 Fix TypeError: message.toUpperC...

2016-04-26 Thread codecov-io
Github user codecov-io commented on the pull request: https://github.com/apache/cordova-lib/pull/431#issuecomment-214814135 ## [Current coverage][cc-pull] is **100%** > Merging [#431][cc-pull] into [master][cc-base-branch] will not change coverage ```diff @@

[GitHub] cordova-lib pull request: CB-11117: Add FileUpdater module to cord...

2016-04-26 Thread codecov-io
Github user codecov-io commented on the pull request: https://github.com/apache/cordova-lib/pull/429#issuecomment-214812288 ## [Current coverage][cc-pull] is **100%** > Merging [#429][cc-pull] into [master][cc-base-branch] will increase coverage by **+19.90%** ```diff

[GitHub] cordova-android pull request: CB-11133 Handle android emulator sta...

2016-04-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/297 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-lib pull request: CB-11131 Fix TypeError: message.toUpperC...

2016-04-26 Thread jasongin
Github user jasongin commented on the pull request: https://github.com/apache/cordova-lib/pull/431#issuecomment-214811002 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] cordova-lib pull request: CB-11131 Fix TypeError: message.toUpperC...

2016-04-26 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-lib/pull/431#issuecomment-214810543 Updated, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-android pull request: CB-11133 Handle android emulator sta...

2016-04-26 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-android/pull/297#issuecomment-214810232 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-android pull request: CB-11153 Use Gradle 2.8 correctly fo...

2016-04-26 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-android/pull/299#issuecomment-214809471 I just ended up moving to version 2.13 which is the latest - and the perf is even a bit better than version 2.8. I looked at Android docs and did not find anyt

[GitHub] cordova-windows pull request: CB-11150 CI Error - Windows Platform...

2016-04-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/169 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-windows pull request: CB-11150 CI Error - Windows Platform...

2016-04-26 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-windows/pull/169#issuecomment-214806350 LGTM. Let's get this in - as it will fix our build. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

RE: [DISCUSS] Faster incremental builds

2016-04-26 Thread Jason Ginchereau
I don't understand how adding a file list to the hook parameters will help solve this problem. Any hook that currently fails after an incremental prepare would need to be updated either way. It would be simpler to just update it to correctly handle the case when a file wasn't updated by prepare.

[GitHub] cordova-plugin-inappbrowser pull request: CB-11136: Fix OAuth by p...

2016-04-26 Thread Chun-Yang
Github user Chun-Yang commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/162#issuecomment-214800395 @ephemer Man you are genius! Thank you SO~~ much! --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] cordova-lib pull request: CB-11131 Fix TypeError: message.toUpperC...

2016-04-26 Thread jasongin
Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/431#discussion_r61116509 --- Diff: cordova-common/src/CordovaLogger.js --- @@ -209,7 +209,7 @@ function formatError(error, isVerbose) { message = error; }

[GitHub] cordova-docs pull request: CB-11077 backbutton does not minimize a...

2016-04-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/580 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-lib pull request: CB-11036 'args.slice is not a function' ...

2016-04-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/430 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-android pull request: CB-11132 Fix Error: Cannot read prop...

2016-04-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/296 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-android pull request: CB-11153 Use Gradle 2.8 correctly fo...

2016-04-26 Thread infil00p
Github user infil00p commented on the pull request: https://github.com/apache/cordova-android/pull/299#issuecomment-214762095 Why 2.8? Why not 2.10? Is 2.10 slower than 2.8? Will this break other users somehow? --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-windows pull request: CB-11150 CI Error - Windows Platform...

2016-04-26 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-windows/pull/169 CB-11150 CI Error - Windows Platform - Could not find XHR config file Changes config.xml path to absolute [Jira issue](https://issues.apache.org/jira/browse/CB-11150) You can merge

[GitHub] cordova-medic pull request: CB-11140 Patch CSP tag to allow Appium...

2016-04-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-medic/pull/99 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i