[GitHub] cordova-plugin-camera pull request: [CB-10388] - Added correctOrie...

2016-04-27 Thread swbradshaw
Github user swbradshaw commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/158#issuecomment-215291931 @morioma - Take a look at #197 again. I completely rewrote the implementation. --- If your project is set up for it, you can reply to this email an

[GitHub] cordova-plugin-camera pull request: CB-4078: correctOrientation no...

2016-04-27 Thread swbradshaw
Github user swbradshaw commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/197#issuecomment-215290093 Re-opening with cleaned up fork. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] cordova-plugin-camera pull request: CB-4078: correctOrientation no...

2016-04-27 Thread swbradshaw
GitHub user swbradshaw reopened a pull request: https://github.com/apache/cordova-plugin-camera/pull/197 CB-4078: correctOrientation not working on camera.getPicture for PHOTOLIBRARY This fixes the orientation bug for Android 4.4+ devices when choosing a picture from the photo libr

[GitHub] cordova-plugin-camera pull request: CB-4078: correctOrientation no...

2016-04-27 Thread swbradshaw
Github user swbradshaw closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/197 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-camera pull request: CB-4078: correctOrientation no...

2016-04-27 Thread swbradshaw
Github user swbradshaw commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/197#issuecomment-215287391 @unbeatableDeepak My changes have been committed. I did a rebase from the master since I was weeks behind. Since this is my first PR, I'm not sure if

[GitHub] cordova-docs pull request: Update plugman.md

2016-04-27 Thread darylldawn
GitHub user darylldawn opened a pull request: https://github.com/apache/cordova-docs/pull/587 Update plugman.md In installing plugins using Plugman, command install is required. Without the command install, the plugin install fails and shows About Plugman instead. You can merge

[GitHub] cordova-android pull request: CB-10096: Upgrading to Gradle Plugin...

2016-04-27 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-android/pull/300#issuecomment-215272746 Sure, I'll try it out --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[DISCUSS] CI Builds on PRs submitted for cordova plugins

2016-04-27 Thread Sarangan Rajamanickam
Hi All, I have created a proposal for adding CI builds on PRs submitted for cordova plugins. You could find the details in this PR: https://github.com/cordova/cordova-discuss/pull/42. Please review the proposal and provide your feedback. Thanks in advance. Regards Sarangan Rajamanickam

Re: [DISCUSS] Faster incremental builds

2016-04-27 Thread Carlos Santana
+1 also minor bump - Carlos @csantanapr > On Apr 27, 2016, at 5:24 PM, Jason Ginchereau wrote: > > OK, I think there is a solution that will make everyone happy, while > maintaining compatibility with existing after_prepare hooks: An incremental > prepare can copy both files that are newer AN

[GitHub] cordova-plugin-splashscreen pull request: CB-11156 Change default ...

2016-04-27 Thread RobPosener
Github user RobPosener commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/99#issuecomment-215261001 I played around with this and found 1300 "looked the nicest". Also, you need to update the splashscreen plugin documentation to whatever the n

[GitHub] cordova-lib pull request: CB-11117: Add FileUpdater module to cord...

2016-04-27 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/429#issuecomment-215260110 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] cordova-android pull request: CB-11117: Use FileUpdater to optimiz...

2016-04-27 Thread codecov-io
Github user codecov-io commented on the pull request: https://github.com/apache/cordova-android/pull/295#issuecomment-215259559 ## [Current coverage][cc-pull] is **100%** > Merging [#295][cc-pull] into [master][cc-base-branch] will not change coverage ```diff @@

[GitHub] cordova-android pull request: CB-11117: Use FileUpdater to optimiz...

2016-04-27 Thread jasongin
Github user jasongin commented on the pull request: https://github.com/apache/cordova-android/pull/295#issuecomment-215256784 @vladimir-kotikov @infil00p please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] cordova-coho pull request: Create jenkins-access.md

2016-04-27 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-coho/pull/117 Create jenkins-access.md Added instructions on how to give a committer Jenkins access. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shaz

[GitHub] cordova-lib pull request: CB-11117: Add FileUpdater module to cord...

2016-04-27 Thread jasongin
Github user jasongin commented on the pull request: https://github.com/apache/cordova-lib/pull/429#issuecomment-215255548 @vladimir-kotikov I think this is ready to go after the latest update. Please let me know if you have any further comments. --- If your project is set up for it,

[GitHub] cordova-android pull request: CB-10096: Upgrading to Gradle Plugin...

2016-04-27 Thread codecov-io
Github user codecov-io commented on the pull request: https://github.com/apache/cordova-android/pull/300#issuecomment-215245487 ## [Current coverage][cc-pull] is **100%** > Merging [#300][cc-pull] into [master][cc-base-branch] will not change coverage ```diff @@

[GitHub] cordova-android pull request: CB-10096: Upgrading to Gradle Plugin...

2016-04-27 Thread infil00p
GitHub user infil00p opened a pull request: https://github.com/apache/cordova-android/pull/300 CB-10096: Upgrading to Gradle Plugin 2.1.0 This is a minor change, but I need people running stable to make sure it works. @riknoll Can you take a quick look? You can merge this pull requ

[GitHub] cordova-plugin-inappbrowser pull request: Adding links to the top ...

2016-04-27 Thread normesta
GitHub user normesta opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/163 Adding links to the top of the readme file to point to samples and reference content You can merge this pull request into a Git repository by running: $ git pull https:/

[GitHub] cordova-docs pull request: added CVE announcement blog post

2016-04-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/586 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-plugin-geolocation pull request: Adding links to reference...

2016-04-27 Thread normesta
GitHub user normesta opened a pull request: https://github.com/apache/cordova-plugin-geolocation/pull/76 Adding links to reference content and sample content to the top of th… …e readme file You can merge this pull request into a Git repository by running: $ git pull https:

RE: [DISCUSS] Faster incremental builds

2016-04-27 Thread Jason Ginchereau
OK, I think there is a solution that will make everyone happy, while maintaining compatibility with existing after_prepare hooks: An incremental prepare can copy both files that are newer AND FILES THAT ARE OLDER than the target files in the platform's www directory, while skipping any files whi

[GitHub] cordova-docs pull request: added CVE announcement blog post

2016-04-27 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-docs/pull/586#issuecomment-215230160 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cordova-docs pull request: added CVE announcement blog post

2016-04-27 Thread tony--
GitHub user tony-- opened a pull request: https://github.com/apache/cordova-docs/pull/586 added CVE announcement blog post You can merge this pull request into a Git repository by running: $ git pull https://github.com/tony--/cordova-docs blog-post-27April2016 Alternatively y

[GitHub] cordova-paramedic pull request: Code changes for Collecting Device...

2016-04-27 Thread sarangan12
Github user sarangan12 commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/4#discussion_r61334254 --- Diff: lib/ParamediciOSPermissions.js --- @@ -0,0 +1,43 @@ +#!/usr/bin/env node + +/* jshint node: true */ +var path = requi

[GitHub] cordova-paramedic pull request: Code changes for Collecting Device...

2016-04-27 Thread sarangan12
Github user sarangan12 commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/4#discussion_r61334214 --- Diff: lib/ParamedicConfig.js --- @@ -36,8 +36,10 @@ ParamedicConfig.parseFromArguments = function (argv) { startPort: argv

[GitHub] cordova-paramedic pull request: Code changes for Collecting Device...

2016-04-27 Thread sarangan12
Github user sarangan12 commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/4#discussion_r61334368 --- Diff: lib/utils/utilities.js --- @@ -0,0 +1,123 @@ +#!/usr/bin/env node + +var shelljs = require('shelljs'); +var verbose = und

[GitHub] cordova-paramedic pull request: Code changes for Collecting Device...

2016-04-27 Thread sarangan12
Github user sarangan12 commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/4#discussion_r61334311 --- Diff: lib/utils/utilities.js --- @@ -0,0 +1,123 @@ +#!/usr/bin/env node + +var shelljs = require('shelljs'); +var verbose = und

[GitHub] cordova-paramedic pull request: Code changes for Collecting Device...

2016-04-27 Thread sarangan12
Github user sarangan12 commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/4#discussion_r61334228 --- Diff: lib/ParamedicConfig.js --- @@ -36,8 +36,10 @@ ParamedicConfig.parseFromArguments = function (argv) { startPort: argv

[GitHub] cordova-paramedic pull request: Code changes for Collecting Device...

2016-04-27 Thread sarangan12
Github user sarangan12 commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/4#discussion_r61334170 --- Diff: lib/ParamediciOSPermissions.js --- @@ -0,0 +1,43 @@ +#!/usr/bin/env node + +/* jshint node: true */ +var path = requi

RE: [DISCUSS] Patch release for Cordova Plugin File

2016-04-27 Thread Raghav Katyal
Though it isn't a common scenario, I thought of prioritizing this since it would cause an app crash. Thoughts? -Original Message- From: Joe Bowser [mailto:bows...@gmail.com] Sent: Wednesday, April 27, 2016 11:24 AM To: dev@cordova.apache.org Subject: Re: [DISCUSS] Patch release for Cordo

[GitHub] cordova-plugin-media-capture pull request: CB-10554: Implementing ...

2016-04-27 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-media-capture/pull/60#issuecomment-215216238 @adamduren @nikhilkh @infil00p I'd appreciate some feedback. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-plugin-media-capture pull request: CB-10554: Implementing ...

2016-04-27 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-plugin-media-capture/pull/60 CB-10554: Implementing plugin save/restore API for Android The purpose of this PR is to handle the case where the Webview gets destroyed in the background while a capture activi

[GitHub] cordova-plugin-wkwebview-engine pull request: [CB-10818] Support t...

2016-04-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/4 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-wkwebview-engine pull request: CB-10817 The webView...

2016-04-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/5 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

CVE-2015-5207 - Bypass of Access Restrictions in Apache Cordova iOS

2016-04-27 Thread Tony Homer
CVE-2015-5207 - Bypass of Access Restrictions in Apache Cordova iOS Severity: High Vendor: The Apache Software Foundation Versions Affected: cordova-ios 3.9.1 and below Description: Apache Cordova iOS contains 2 methods to bypass the URL access restrictions provided by the whitelist. An attacke

CVE-2015-5208 - Arbitrary plugin execution issue in Apache Cordova iOS

2016-04-27 Thread Tony Homer
CVE-2015-5208 - Arbitrary plugin execution issue in Apache Cordova iOS Severity: High Vendor: The Apache Software Foundation Versions Affected: cordova-ios 3.9.1 and below Description: An arbitrary plugin can be executed when a user clicks on a link. Upgrade path: Developers who are concerned

CVE-2015-5207 - Bypass of Access Restrictions in Apache Cordova iOS

2016-04-27 Thread Tony Homer
CVE-2015-5207 - Bypass of Access Restrictions in Apache Cordova iOS Severity: High Vendor: The Apache Software Foundation Versions Affected:cordova-ios 3.9.1 and below Description:Apache Cordova iOS contains 2 methods to bypass the URL access restrictions provided by the whitelist. An attacker can

Re: [DISCUSS] Patch release for Cordova Plugin File

2016-04-27 Thread Darryl Pogue
Not a plugin, but I'd appreciate a tools release (or at least a cordova-lib release). On 27 April 2016 at 11:26, Steven Gill wrote: > I'm fine with you doing a plugins release next week. Anyone else have any > plugins that need a release? > > On Wed, Apr 27, 2016 at 11:24 AM, Joe Bowser wrote:

Re: [DISCUSS] Patch release for Cordova Plugin File

2016-04-27 Thread Shazron
I'm integrating two patches for cordova-plugin-wkwebview-engine today, that can go in next week's release. On Wed, Apr 27, 2016 at 11:26 AM, Steven Gill wrote: > I'm fine with you doing a plugins release next week. Anyone else have any > plugins that need a release? > > On Wed, Apr 27, 2016 at 1

[GitHub] cordova-plugin-splashscreen pull request: CB-11156 Change default ...

2016-04-27 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/99#issuecomment-215191026 Defaults for windows is being changed in https://github.com/apache/cordova-windows/pull/170. --- If your project is set up for it, you can reply to

Re: [DISCUSS] Patch release for Cordova Plugin File

2016-04-27 Thread Steven Gill
I'm fine with you doing a plugins release next week. Anyone else have any plugins that need a release? On Wed, Apr 27, 2016 at 11:24 AM, Joe Bowser wrote: > How critical is this? How many devices have removable external storage? > Why can't this wait for a full plugins release? > > On Wed, Apr

Re: [DISCUSS] Patch release for Cordova Plugin File

2016-04-27 Thread Joe Bowser
How critical is this? How many devices have removable external storage? Why can't this wait for a full plugins release? On Wed, Apr 27, 2016, 11:08 AM Raghav Katyal wrote: > Recent release of cordova-plugin-file introduced an app crash scenario > when external storage is not mounted on Android.

[DISCUSS] Patch release for Cordova Plugin File

2016-04-27 Thread Raghav Katyal
Recent release of cordova-plugin-file introduced an app crash scenario when external storage is not mounted on Android. I think we need to do a patch release for it. JIRA: https://issues.apache.org/jira/browse/CB-11142 PR: https://github.com/apache/cordova-plugin-file/pull/179 Are there an

[GitHub] cordova-plugin-splashscreen pull request: CB-11156 Change default ...

2016-04-27 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/99#issuecomment-215144537 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-plugin-splashscreen pull request: CB-11156 Change default ...

2016-04-27 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/99#issuecomment-215144520 I'm assuming the default for Windows is already 500? --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] cordova-plugin-camera pull request: CB-11162 Appium tests: retry s...

2016-04-27 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/208 CB-11162 Appium tests: retry spec on failure https://issues.apache.org/jira/browse/CB-11162 You can merge this pull request into a Git repository by running: $ git pull https:/

[GitHub] cordova-coho pull request: CB-7904 Built nightly releases using co...

2016-04-27 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-coho/pull/116 CB-7904 Built nightly releases using coho Updates code for the current version Fixed the date format [Jira issue](https://issues.apache.org/jira/browse/CB-7904) You can merge this

[GitHub] cordova-plugin-inappbrowser pull request: inAppBrowser custom appl...

2016-04-27 Thread osvso
Github user osvso commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/99#issuecomment-215002415 I've changed the implementation a bit. Currently defining additional property with custom application scheme is not required anymore. --- If your pro

[GitHub] cordova-windows pull request: CB-11156 Change default FadeSplashSc...

2016-04-27 Thread rakatyal
Github user rakatyal commented on the pull request: https://github.com/apache/cordova-windows/pull/170#issuecomment-214996602 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] cordova-plugin-media pull request: iOS: Add support for playing no...

2016-04-27 Thread vintage
Github user vintage commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/39#issuecomment-214994434 That's the one of the features which is needed in my project. Unfortunately I failed to merge current master into this branch. Will try again later, but I