Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/173#discussion_r61665577
--- Diff: template/www/cordova.js ---
@@ -1508,9 +1509,10 @@ module.exports = {
// OR cordova.require('cordova/platform').activation
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/173#discussion_r61665566
--- Diff: cordova-js-src/platform.js ---
@@ -56,9 +57,10 @@ module.exports = {
// OR cordova.require('cordova/platform').activationC
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r61665459
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,499 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+o
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/433#issuecomment-215922979
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user codecov-io commented on the pull request:
https://github.com/apache/cordova-lib/pull/407#issuecomment-215918679
## [Current coverage][cc-pull] is **13.19%**
> Merging [#407][cc-pull] into [master][cc-base-branch] will increase
coverage by **-86.81%**
```diff
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-215915464
@ktop @riknoll yeah, config.xml should be part of this. Anything in
config.xml should trump whatever is specified in the plugin.xml. If we do modes
then default mo
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r61659743
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,499 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+o
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-215911697
@nikhilkh As we discussed, this workaround was the best I could find. The
command script approach has similar performance to just copying files via the
node fs API
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/173#issuecomment-215908246
@purplecabbage who was involved in some of the original code here. @daserge
@vladimir-kotikov to review as well
---
If your project is set up for it, you can
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-windows/pull/173#issuecomment-215905896
Not sure about that. May be it wasn't needed at that time since the
activation events were limited. With UWP there are more activation kinds
introduced.
---
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-windows/pull/173#issuecomment-215905585
Was there a reason we weren't saving all of the detail information before?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user codecov-io commented on the pull request:
https://github.com/apache/cordova-windows/pull/173#issuecomment-215903575
## [Current coverage][cc-pull] is **73.49%**
> Merging [#173][cc-pull] into [master][cc-base-branch] will increase
coverage by **-26.51%**
```dif
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/433#discussion_r61655336
--- Diff: cordova-lib/spec-cordova/platforms/platforms.spec.js ---
@@ -17,19 +17,25 @@
under the License.
*/
+var fs = re
GitHub user rakatyal opened a pull request:
https://github.com/apache/cordova-windows/pull/173
CB-10653 Making the windows activation context complete
The current implementation doesn't capture details for all the activation
options for UWP apps.
You can merge this pull request in
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/433#issuecomment-215898416
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/433#discussion_r61653369
--- Diff: cordova-lib/spec-cordova/platforms/platforms.spec.js ---
@@ -17,19 +17,25 @@
under the License.
*/
+var fs = require('f
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-215892244
I would put the mode flag as out-of-scope for now, we can re-asses later if
need be.
I could not get this to work, can you please post instructions fo
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-windows/pull/171#issuecomment-215891369
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-ios/pull/219#issuecomment-215890484
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
The reason I brought up notifications about critical errors is that that is
NOT happening now. There have been a number of instances recently, where
there has been discussion about regression errors that have not been
announced to the wider community (eg, via the blog) and cordova users have
been
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-215866756
@ktop config-file wasn't in config.xml before, but we wanted to add it
because the number of config.xml attributes that just edit various native xml
files is gettin
Github user ktop commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-215857823
@macdonst
I had Edna test the first time around before I opened the PR and she was
able to get it working, so that is weird that it is adding a new element for
yo
On Fri, Apr 29, 2016 at 11:40 AM, Joe Bowser wrote:
>
>
> On Fri, Apr 29, 2016 at 10:05 AM, Nikhil Khandelwal <
> nikhi...@microsoft.com> wrote:
>
>> I’m hearing two purposes of a user list:
>> - Key announcements
>> - Self-help for users
>>
>> I’m not totally convinced that slack + stack overflo
On Fri, Apr 29, 2016 at 10:05 AM, Nikhil Khandelwal
wrote:
> I’m hearing two purposes of a user list:
> - Key announcements
> - Self-help for users
>
> I’m not totally convinced that slack + stack overflow are not sufficient
> for finding resources & common answers for cordova issues. Creating an
The Buildbot working for ''
has noticed that the buildslave named cordova-windows-slave went away
It last disconnected at Fri Apr 29 18:28:40 2016 (buildmaster-local time)
The admin on record (as reported by BUILDSLAVE:info/admin)
was 'Dmitry Blotsky
'.
Sincerely,
The Buildbot
https://ci.apac
The Buildbot working for ''
has noticed that the buildslave named cordova-osx-slave went away
It last disconnected at Fri Apr 29 18:28:25 2016 (buildmaster-local time)
The admin on record (as reported by BUILDSLAVE:info/admin)
was 'Dmitry Blotsky
'.
Sincerely,
The Buildbot
https://ci.apache.o
I need to move the machines, so be advised that both build machines are going
to go offline again for a bit.
Thanks,
Richard
-Original Message-
From: Richard Knoll [mailto:rikn...@microsoft.com]
Sent: Friday, April 29, 2016 10:06 AM
To: dev@cordova.apache.org
Subject: RE: Buildbot: buil
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/101#discussion_r61622534
--- Diff: README.md ---
@@ -222,6 +222,10 @@ __Note__: `SplashScreen` value should be absolute in
order to work in a sub-page
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/100#issuecomment-215833256
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-windows/pull/172#issuecomment-215833144
Minor comments. Otherwise LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/172#discussion_r61621269
--- Diff: cordova-js-src/exec.js ---
@@ -41,6 +41,20 @@ var execProxy = require('cordova/exec/proxy');
*/
module.exports = function (succe
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/172#discussion_r61619913
--- Diff: cordova-js-src/exec.js ---
@@ -41,6 +41,20 @@ var execProxy = require('cordova/exec/proxy');
*/
module.exports = function (succe
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-215817627
Simultaneously, lets ask libuv to make the fix for this issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Sorry everyone! The build machines were accidentally unplugged this morning,
but they're back up now.
Thanks,
Richard
-Original Message-
From: build...@apache.org [mailto:build...@apache.org]
Sent: Friday, April 29, 2016 8:27 AM
To: dev@cordova.apache.org
Subject: Buildbot: buildslave c
I’m hearing two purposes of a user list:
- Key announcements
- Self-help for users
I’m not totally convinced that slack + stack overflow are not sufficient for
finding resources & common answers for cordova issues. Creating another channel
will just fragment the community.
FWIW, our blog got ab
Github user Alex-Sessler commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/164#issuecomment-215814096
I think i could have time to add this some time this weekend.
---
If your project is set up for it, you can reply to this email and have your
Github user devgeeks commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/164#issuecomment-215812203
+1 for option.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-215811240
@ktop Yeah, I have the `attr="true"` in my plugin.xml and it still gets
added instead of merged.
```
```
I'm not s
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/123#discussion_r61609305
--- Diff: appium-tests/common/common.spec.js ---
@@ -133,7 +136,7 @@ describe('Contacts Android', function () {
function renameConta
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/123#issuecomment-215809141
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Thought I'd throw in my 2¢ worth:
- If a user list is created, I'll gladly participate.
- Having a Cordova-branded user list could be useful from a "branding"
perspective. The Adobe Forums are "PhoneGap" branded, and the Google Group
is named "phonegap" (although the welcome text makes clear that
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/164#issuecomment-215792971
Does it make sense to have this be an iab option? Could a non-secure
activity want to display a secure iab?
Maybe that is step 2. This loo
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-215780851
I need to add a workaround for the nodejs bug in setting file timestamps on
Windows: https://github.com/nodejs/node/issues/2069
---
If your project is set up for
The Buildbot working for ''
has noticed that the buildslave named cordova-osx-slave went away
It last disconnected at Fri Apr 29 15:21:50 2016 (buildmaster-local time)
The admin on record (as reported by BUILDSLAVE:info/admin)
was 'Dmitry Blotsky
'.
Sincerely,
The Buildbot
https://ci.apache.o
Github user bau720123 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/87#issuecomment-215755338
hi @ThillaiganeshChan and @vladimir-kotikov
is there anything update ? or ...
https://issues.apache.org/jira/browse/CB-10882
---
If your project
Can I get someone to review my PR?
https://github.com/apache/cordova-lib/pull/432
Thanks,
Karen Tran
On Thu, Apr 21, 2016 at 11:02 AM, Vladimir Kotikov (Akvelon) <
v-vlk...@microsoft.com> wrote:
> Exactly. Multiple tags is also possible with this syntax.
>
> -
> Best regards, Vladimir
>
> -O
The Buildbot working for ''
has noticed that the buildslave named cordova-windows-slave went away
It last disconnected at Fri Apr 29 15:05:45 2016 (buildmaster-local time)
The admin on record (as reported by BUILDSLAVE:info/admin)
was 'Dmitry Blotsky
'.
Sincerely,
The Buildbot
https://ci.apac
Github user alsorokin commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/123#issuecomment-215745788
@riknoll Addressed your comment.
Also as a minor change, switched to `tapElementByXPath` function for iOS.
---
If your project is set up for it,
That message is relatively new, was included because a lot of people was
expecting adobe support.
I don't think the google group is defunct, last time I checked it still had
more daily messages than the new adobe forums (but less than the old
phonegap build community)
2016-04-29 16:11 GMT+02:00
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/101
CB-11179 Extend the windows-splashscreen docs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-plugin-spl
On Fri, Apr 29, 2016 at 9:09 AM, Raymond Camden wrote:
>
>> The expectation that it's be a peer group with no guarantees of dev
>> involvement is very important, since that was not made clear on the Google
>> group and made a lot of people upset.
The top post on the GG has:
"One last thing: the
The Google Group is defunct?
On Fri, Apr 29, 2016 at 9:08 AM, Joe Bowser wrote:
> On Apr 28, 2016 5:37 PM, "Shazron" wrote:
>>
>> Perhaps it's time for a users mailing list. No dev is expected to answer
>> questions on it.
>>
>
> I like this expectation. With the migration to the PhoneGap Adobe
On Apr 28, 2016 5:37 PM, "Shazron" wrote:
>
> Perhaps it's time for a users mailing list. No dev is expected to answer
> questions on it.
>
I like this expectation. With the migration to the PhoneGap Adobe Forum
from the defunct Google Group, a users list now makes sense.
The expectation that i
+1 to Raymond, if the idea is asking and answering questions, I think there
are enough options right now and for announcements we have the blog
2016-04-29 15:44 GMT+02:00 Raymond Camden :
> If the idea is a list for users to help each other (taking that from
> the httpd list), then why isn't the
If the idea is a list for users to help each other (taking that from
the httpd list), then why isn't the PG Google Group appropriate for
that already?
If the idea is for important announcements (Robert's comment), then we
have a mechanism for that now - the blog.
On Fri, Apr 29, 2016 at 1:42 AM,
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/100
CB-8056 Updated the dependency version, added it to the docs
Related to https://github.com/apache/cordova-windows/pull/172
You can merge this pull request into a Git repository
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-windows/pull/172
CB-11176 Fix windows-splashscreen compatibility with older plugin verâ¦
â¦sions
[Jira issue with details](https://issues.apache.org/jira/browse/CB-11176)
You can merge this pull
Github user ephemer commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/8#issuecomment-215702371
@shazron in that case we'd have to remove the configuration code from
updateWithInfo because we've already established that it doesn't do anything
Github user devgeeks commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/164#issuecomment-215697044
Well, it certainly works as advertised with the PrivacyScreenPlugin, anyway.
---
If your project is set up for it, you can reply to this email and
GitHub user androdel opened a pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/73
Close function (Android only)
Only did it for Android because the problem only occurred here.
You can merge this pull request into a Git repository by running:
$ git pull https:
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/301
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Done. Please see PR [1] and JIRA [2]
This happens due to some caching issues with `getPlatformApi` method which
doesn't respect symlinked paths.
The reason why tests are not failing on Travis and Appveyor is that they run in
environments, where the test directory isn't symlinked. However, on OS
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/433
CB-11174 Resolve symlinked path before getting PlatformApi instance
This PR the issue when `getPlatformApi` method in cordova-lib returns a
different instances for two paths pointing t
GitHub user cjpearson reopened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/94
CB-3360: Set custom inappbrowser user agent for ios
This uses the same OverrideUserAgent and AppendUserAgent properties as the
pull requests for cordova-ios and cordova-andro
Github user devgeeks commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/164#issuecomment-215685335
Nice, I'll try to have a look at this as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
GitHub user Alex-Sessler opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/164
Added FLAG_SECURE support
I'm using this Plugin together with the Privacyscreen Plugin
(https://github.com/devgeeks/PrivacyScreenPlugin), which sets the FLAG_SECURE
on the
Github user androdel commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/94#issuecomment-215651859
But where is the fix for iOS?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
67 matches
Mail list logo