[GitHub] cordova-lib pull request: CB-9858 Cordova Fetch Work

2016-05-04 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/407#issuecomment-217087853 Made the changes. LMK. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-docs pull request: CB-11203: Improving documentation of pl...

2016-05-04 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/595#issuecomment-217050499 @nikhilkh please review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] cordova-docs pull request: CB-11203: Improving documentation of pl...

2016-05-04 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-docs/pull/595 CB-11203: Improving documentation of plugin CLI variables You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-docs CB-11203

[GitHub] cordova-docs pull request: CB-11196: Converting mark elements in d...

2016-05-04 Thread rakatyal
Github user rakatyal commented on the pull request: https://github.com/apache/cordova-docs/pull/593#issuecomment-217042218 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] cordova-docs pull request: CB-11196: Converting mark elements in d...

2016-05-04 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/593#issuecomment-217041794 Wohoo! 💥 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] cordova-docs pull request: CB-11196: Converting mark elements in d...

2016-05-04 Thread jasongin
Github user jasongin commented on the pull request: https://github.com/apache/cordova-docs/pull/593#issuecomment-217040413 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] cordova-docs pull request: CB-11196: Converting mark elements in d...

2016-05-04 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/593#issuecomment-217001592 @jasongin @rakatyal @purplecabbage updated. iOS logo back to normal and new logo for OS X. ![new_logos_xml_2](https://cloud.githubusercontent.com/assets/1

[GitHub] cordova-lib pull request: CB-9858 Cordova Fetch Work

2016-05-04 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/407#discussion_r62104877 --- Diff: cordova-fetch/spec/package.json --- @@ -0,0 +1,11 @@ +{ --- End diff -- Hmm. Maybe just name it differently. My concer

[GitHub] cordova-lib pull request: CB-9858 Cordova Fetch Work

2016-05-04 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/407#discussion_r62101897 --- Diff: cordova-fetch/spec/package.json --- @@ -0,0 +1,11 @@ +{ --- End diff -- I just copy it into temporary tests folder so I can

[GitHub] cordova-lib pull request: CB-9858 Cordova Fetch Work

2016-05-04 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/407#discussion_r62100822 --- Diff: cordova-fetch/index.js --- @@ -0,0 +1,234 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more contribu

[GitHub] cordova-lib pull request: CB-9858 Cordova Fetch Work

2016-05-04 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/407#discussion_r62100600 --- Diff: cordova-fetch/index.js --- @@ -0,0 +1,234 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more contribu

[GitHub] cordova-plugin-wkwebview-engine pull request: Readme update

2016-05-04 Thread laidig
GitHub user laidig opened a pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/9 Readme update I had a lot of trouble understanding why my app would not load. It turns out that the answer was at the bottom of the README. I've the moved required configurati

[GitHub] cordova-cli pull request: Remove unused ansi npm dependency

2016-05-04 Thread nikhilkh
GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-cli/pull/248 Remove unused ansi npm dependency You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-cli removeAnsi Alternatively you can

[GitHub] cordova-ios pull request: CB-11117: Optimize prepare for ios platf...

2016-05-04 Thread codecov-io
Github user codecov-io commented on the pull request: https://github.com/apache/cordova-ios/pull/220#issuecomment-216945466 ## [Current coverage][cc-pull] is **51.81%** > Merging [#220][cc-pull] into [master][cc-base-branch] will decrease coverage by **-2.75%** ```diff

Re: [Android] New Bridge: evaluateJavascript

2016-05-04 Thread Joe Bowser
Hey, I'm bumping this thread up and creating an issue for this. https://issues.apache.org/jira/browse/CB-11202 I'm going to start creating a 6.0.x milestone and I'll be assigning issues to it in JIRA soon. On Fri, Mar 11, 2016 at 5:48 PM, Darryl Pogue wrote: > On 10 March 2016 at 16:29, Joe Bo

[GitHub] cordova-plugin-file-transfer pull request: Fix cordova-plugin-file...

2016-05-04 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/138#issuecomment-216935005 This is not relevant now - we have removed the peer dependencies - please close this PR. --- If your project is set up for it, you can reply to

[GitHub] cordova-lib pull request: CB-11194 Improve cordova load time

2016-05-04 Thread codecov-io
Github user codecov-io commented on the pull request: https://github.com/apache/cordova-lib/pull/434#issuecomment-216933920 ## [Current coverage][cc-pull] is **80.71%** > Merging [#434][cc-pull] into [master][cc-base-branch] will increase coverage by **+1.09%** ```diff

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

2016-05-04 Thread mccob
Github user mccob commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-216922029 how to invoke permission since Android M permissions system for WebRTC getUserMedia ? --- If your project is set up for it, you can reply to this email an

[GitHub] cordova-plugin-camera pull request: Specific camera permissions ad...

2016-05-04 Thread mccob
Github user mccob commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/61#issuecomment-216922074 how to invoke permission since Android M permissions system for WebRTC getUserMedia ? --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-plugin-camera pull request: Camera permissions added

2016-05-04 Thread mccob
Github user mccob commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/98#issuecomment-216921817 how to invoke permission since Android M permissions system for WebRTC getUserMedia ? --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-android pull request: Grant Lollipop permission requests

2016-05-04 Thread dpogue
Github user dpogue commented on the pull request: https://github.com/apache/cordova-android/pull/178#issuecomment-216921401 Maybe we need a plugin that acts as a polyfill for the [W3C Permissions API](https://w3c.github.io/permissions/) `navigator.permission.request()` to programmatic

RE: [DISCUSS] CI Builds on PRs submitted for cordova plugins

2016-05-04 Thread Nikhil Khandelwal
I want to call attention to this proposal. Please help review this and provide feedback. It adds the critical ability to run tests using paramedic on every PR. -Nikhil -Original Message- From: Sarangan Rajamanickam [mailto:saraj...@microsoft.com] Sent: Wednesday, April 27, 2016 5:01 PM

[GitHub] cordova-android pull request: Grant Lollipop permission requests

2016-05-04 Thread mccob
Github user mccob commented on the pull request: https://github.com/apache/cordova-android/pull/178#issuecomment-216920234 How we are supposed to invoke permission request on Android M with cordova ? getUserMedia doesn't produce any permission request and leave errors from accessing m

[GitHub] cordova-lib pull request: CB-11194 Improve cordova load time

2016-05-04 Thread jasongin
Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/434#discussion_r62068625 --- Diff: cordova-lib/cordova-lib.js --- @@ -18,19 +18,35 @@ */ // For now expose plugman and cordova just as they were in the old repos

[GitHub] cordova-plugin-dialogs pull request: [Windows] Separated CSS from ...

2016-05-04 Thread serbanghita
GitHub user serbanghita opened a pull request: https://github.com/apache/cordova-plugin-dialogs/pull/74 [Windows] Separated CSS from JS code. Fixed prompt UI Fixed the prompt dialog CSS to look close to native. Fixed the positioning of the prompt dialog for Windows. **Ho

[GitHub] cordova-plugin-splashscreen pull request: CB-8056 Updated the depe...

2016-05-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/100 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] cordova-windows pull request: CB-11176 Fix windows-splashscreen co...

2016-05-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/172 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-windows pull request: CB-11176 Fix windows-splashscreen co...

2016-05-04 Thread codecov-io
Github user codecov-io commented on the pull request: https://github.com/apache/cordova-windows/pull/172#issuecomment-216891242 ## [Current coverage][cc-pull] is **73.42%** > Merging [#172][cc-pull] into [master][cc-base-branch] will not change coverage ```diff @@

[GitHub] cordova-windows pull request: CB-11176 Fix windows-splashscreen co...

2016-05-04 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/172#discussion_r62049082 --- Diff: cordova-js-src/exec.js --- @@ -41,6 +41,20 @@ var execProxy = require('cordova/exec/proxy'); */ module.exports = function (succes

[GitHub] cordova-windows pull request: CB-11176 Fix windows-splashscreen co...

2016-05-04 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/172#discussion_r62048444 --- Diff: cordova-js-src/exec.js --- @@ -41,6 +41,20 @@ var execProxy = require('cordova/exec/proxy'); */ module.exports = function (succes

[GitHub] cordova-plugin-inappbrowser pull request: Fix for - Stretched tool...

2016-05-04 Thread AnhsirkDasarp
GitHub user AnhsirkDasarp opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/166 Fix for - Stretched tool-bar icons The toolbar height param is already set to 44 , So the toolbar icons are stretched. Looks too weired on small screen devices ( portrait

[GitHub] cordova-docs pull request: Update Win8 plugin.md

2016-05-04 Thread adborbas
GitHub user adborbas opened a pull request: https://github.com/apache/cordova-docs/pull/594 Update Win8 plugin.md Fix Plugin.xml link pointing to wrong location. You can merge this pull request into a Git repository by running: $ git pull https://github.com/adborbas/cordova-doc

[GitHub] cordova-plugin-statusbar pull request: Handle extended status bar ...

2016-05-04 Thread goshakkk
Github user goshakkk commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/55#issuecomment-216800124 I've made the changes to account for hidden status bar. Can we move forward with this now? --- If your project is set up for it, you can reply to thi

[GitHub] cordova-lib pull request: CB-11194 Improve cordova load time

2016-05-04 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/434#discussion_r62007337 --- Diff: cordova-lib/cordova-lib.js --- @@ -18,19 +18,35 @@ */ // For now expose plugman and cordova just as they were in the ol

[GitHub] cordova-android pull request: CB-11198 Skip android target sdk che...

2016-05-04 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/303#discussion_r62002478 --- Diff: bin/templates/cordova/lib/builders/AntBuilder.js --- @@ -107,7 +107,18 @@ AntBuilder.prototype.build = function(opts) { va

[GitHub] cordova-lib pull request: CB-9858 Cordova Fetch Work

2016-05-04 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/407#discussion_r62000656 --- Diff: cordova-fetch/index.js --- @@ -0,0 +1,234 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more co

[GitHub] cordova-lib pull request: CB-9858 Cordova Fetch Work

2016-05-04 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/407#discussion_r62000572 --- Diff: cordova-fetch/index.js --- @@ -0,0 +1,234 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more co

[GitHub] cordova-android pull request: fix crash when calling methods on a ...

2016-05-04 Thread uareurapid
GitHub user uareurapid opened a pull request: https://github.com/apache/cordova-android/pull/304 fix crash when calling methods on a destroyed webview Hi guys. This has happened in some of my apps, not often, but a few times. I also have see some reports on the web. Take a look

[GitHub] cordova-lib pull request: CB-9858 Cordova Fetch Work

2016-05-04 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/407#discussion_r61999817 --- Diff: cordova-fetch/spec/package.json --- @@ -0,0 +1,11 @@ +{ --- End diff -- Do we need a separate `package.json` for specs

[GitHub] cordova-lib pull request: CB-9858 Cordova Fetch Work

2016-05-04 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/407#discussion_r61998473 --- Diff: cordova-fetch/index.js --- @@ -0,0 +1,234 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more co

[GitHub] cordova-lib pull request: CB-9858 Cordova Fetch Work

2016-05-04 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/407#discussion_r61998292 --- Diff: cordova-fetch/index.js --- @@ -0,0 +1,234 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more co

[GitHub] cordova-windows pull request: CB-11139 Use PluginManager from comm...

2016-05-04 Thread vladimir-kotikov
Github user vladimir-kotikov closed the pull request at: https://github.com/apache/cordova-windows/pull/171 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-ios pull request: CB-11161 Reuse PluginManager from common...

2016-05-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/219 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is