Github user alsorokin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/209#discussion_r63320919
--- Diff: appium-tests/helpers/cameraHelper.js ---
@@ -103,11 +109,185 @@ module.exports.getPicture = function (opts, pid) {
}, opts
Github user mirko77 commented on the pull request:
https://github.com/apache/cordova-ios/pull/193#issuecomment-219371740
Great, with ios-deploy 1.8.6 it is working fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user jcesarmobile commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/209#discussion_r63323857
--- Diff: appium-tests/helpers/cameraHelper.js ---
@@ -103,11 +109,185 @@ module.exports.getPicture = function (opts, pid) {
}, o
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-windows/pull/177#issuecomment-219376635
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Yeah, right. I somehow pasted the wrong link, sorry. The correct one is
https://github.com/cordova/cordova-discuss/pull/47
-
Best regards, Vladimir
-Original Message-
From: Shazron [mailto:shaz...@gmail.com]
Sent: Saturday, May 14, 2016 1:53 AM
To: dev@cordova.apache.org
Subject: Re: [
Github user alsorokin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/209#discussion_r63327575
--- Diff: appium-tests/helpers/cameraHelper.js ---
@@ -103,11 +109,185 @@ module.exports.getPicture = function (opts, pid) {
}, opts
Github user MIYankov commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/126#issuecomment-219403560
I encountered the same problem. restouffer's branch fixes the issue. It's
vital that this gets merged soon since usually we don't have power over
Hi Community.
Node.js v6 was released early this month
https://github.com/nodejs/LTS#lts_schedule
When is Cordova going to support it as official runtime? Same thing that
happened when Cordova CLI v5.x.x (don't remember the exact version) claimed
support for Node.js v4.
Cheers!
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-ios/pull/223#issuecomment-219478177
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
The only known issue with Node v6 and Cordova is: CB-11200. The bug breaks
uninstallation of plugins with custom frameworks for iOS platform, such as
Facebook plugin.
This JIRA has been resolved in corodva-ios master. We'll need a release of
cordova-ios and a tools release pinning that version
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/209#discussion_r63387806
--- Diff: appium-tests/helpers/cameraHelper.js ---
@@ -103,11 +109,185 @@ module.exports.getPicture = function (opts, pid) {
}, opts);
Github user cordova-qa commented on the pull request:
https://github.com/apache/cordova-plugin-vibration/pull/45#issuecomment-219489091
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-vibration/pull/45/commits/de7
Github user cordova-qa commented on the pull request:
https://github.com/apache/cordova-plugin-vibration/pull/41#issuecomment-219490409
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-vibration/pull/41/commits/e2f
Github user cordova-qa commented on the pull request:
https://github.com/apache/cordova-plugin-vibration/pull/40#issuecomment-219491765
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-vibration/pull/40/commits/b0a
GitHub user jcesarmobile opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/216
Set android quality default value to 50 on the java code
Default value is set to 80 on the java code, but doc says that default
value is 50.
Iâm changing it just fo
Github user cordova-qa commented on the pull request:
https://github.com/apache/cordova-plugin-vibration/pull/32#issuecomment-219493247
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-vibration/pull/32/commits/234
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-cli/pull/247#issuecomment-219493551
@omefire Can you please take a look into this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/209#discussion_r63394154
--- Diff: appium-tests/helpers/cameraHelper.js ---
@@ -103,11 +109,185 @@ module.exports.getPicture = function (opts, pid) {
}, opts);
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-ios/pull/223#issuecomment-219494395
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user cordova-qa commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/216#issuecomment-219494802
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-camera/pull/216/commits/0115458
Github user omefire commented on the pull request:
https://github.com/apache/cordova-cli/pull/247#issuecomment-219495292
@purplecabbage, I didn't create a JIRA issue to track the telemetry work, I
should have. My bad.
I've tested this on MAC(El Capitan) and Windows10, but couldn't
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/209#discussion_r63394732
--- Diff: appium-tests/helpers/cameraHelper.js ---
@@ -103,11 +109,185 @@ module.exports.getPicture = function (opts, pid) {
}, opts)
Github user cordova-qa commented on the pull request:
https://github.com/apache/cordova-plugin-vibration/pull/31#issuecomment-219496084
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-vibration/pull/31/commits/2d3
GitHub user sarangan12 opened a pull request:
https://github.com/apache/cordova-plugin-vibration/pull/46
Dummy PR to test CI
Dummy PR to test CI
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sarangan12/cordova-plugin-vibration d
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-cli/pull/247#issuecomment-219496280
I am using windows 10, but I typically use the git-bash shell which may be
why we aren't seeing the same things.
@purplecabbage
risingj.co
Github user cordova-qa commented on the pull request:
https://github.com/apache/cordova-plugin-vibration/pull/46#issuecomment-219498365
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-vibration/pull/46/commits/0ef
Github user sarangan12 commented on the pull request:
https://github.com/apache/cordova-plugin-vibration/pull/46#issuecomment-219499826
Let there be tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/602#discussion_r63397530
--- Diff: www/docs/en/dev/guide/platforms/win8/index.md ---
@@ -80,11 +80,10 @@ Install any edition of
[Visual Studio](http://www.visualstudio.com/d
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/602#discussion_r63398880
--- Diff: www/docs/en/dev/guide/platforms/win8/index.md ---
@@ -80,11 +80,10 @@ Install any edition of
[Visual Studio](http://www.visualstudio.com/
Github user cordova-qa commented on the pull request:
https://github.com/apache/cordova-plugin-vibration/pull/46#issuecomment-219502518
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-vibration/pull/46/commits/0ef
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/602#issuecomment-219502716
LGTM! Only other comment is that it looks like you mention UWP but it
doesn't show up in the screenshot
---
If your project is set up for it, you can reply to thi
Github user cordova-qa commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/56#issuecomment-219505607
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-statusbar/pull/56/commits/20a
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/602
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/177
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user cordova-qa commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/55#issuecomment-219507038
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-statusbar/pull/55/commits/73e
Github user cordova-qa commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/52#issuecomment-219508472
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-statusbar/pull/52/commits/6d7
Github user cordova-qa commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/51#issuecomment-219510006
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-statusbar/pull/51/commits/846
Github user daserge commented on the pull request:
https://github.com/apache/cordova-labs/pull/13#issuecomment-219510176
@riknoll, I'm friendly remaining regarding the server update...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
GitHub user sarangan12 opened a pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/57
Dummy PR to test CI
Dummy PR to test CI
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sarangan12/cordova-plugin-statusbar d
Github user cordova-qa commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/37#issuecomment-219511532
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-statusbar/pull/37/commits/5e9
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/216
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user cordova-qa commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/19#issuecomment-219513791
Cordova CI Build has one or more failures.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-statusbar/pull/19/commits/3c7c3
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/177#issuecomment-219514241
LGTM. Thanks, Raghav for doing the refactor!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user cordova-qa commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/57#issuecomment-219515226
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-statusbar/pull/57/commits/745
GitHub user rakatyal opened a pull request:
https://github.com/apache/cordova-docs/pull/603
Snapshotting dev to 6.x
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-docs raghav/snapshot
Alternatively you can re
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-docs/pull/603#issuecomment-219516481
@omefire , @riknoll : Please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user cordova-qa commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/167#issuecomment-219516622
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-camera/pull/167/commits/0115458
Github user cordova-qa commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/147#issuecomment-219517968
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-camera/pull/147/commits/0115458
Github user sarangan12 commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/19#issuecomment-219518320
Let there be tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Hey all,
No status for the Buildbot CI this week!
When cordova-fetch was merged into the cordova-lib repo it required us to
update the buildbot configuration files for the CI to pass. Updating those
files requires some manual intervention from Infra to sync the changes with the
buildbot master
Github user sarangan12 commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/57#issuecomment-219520871
Let there be tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user cordova-qa commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/19#issuecomment-219521439
Cordova CI Build has one or more failures.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-statusbar/pull/19/commits/3c7c3
Github user omefire commented on the pull request:
https://github.com/apache/cordova-cli/pull/247#issuecomment-219521656
@purplecabbage , I can't repro this with git-bash shell on Win10 because
I'm running into another issue: https://github.com/nodejs/node/issues/3006
The gi
Github user cordova-qa commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/57#issuecomment-219523068
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-statusbar/pull/57/commits/745
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/603#discussion_r63410912
--- Diff: www/docs/en/6.x/config_ref/images.md ---
@@ -19,17 +19,17 @@ license: >
title: Customize app icons
--- End diff --
'app
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/603#discussion_r63411414
--- Diff: www/docs/en/6.x/config_ref/images.md ---
@@ -137,15 +140,17 @@ For Windows the recommended approach to define app
icons is to use `target` att
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/603#discussion_r63411548
--- Diff: www/docs/en/6.x/config_ref/images.md ---
@@ -137,15 +140,17 @@ For Windows the recommended approach to define app
icons is to use `target` att
Github user omefire commented on the pull request:
https://github.com/apache/cordova-docs/pull/603#issuecomment-219525124
Changes related to telemetry are definitely part of this snapshot.
Thanks Raghav!
---
If your project is set up for it, you can reply to this email and have yo
Github user omefire commented on the pull request:
https://github.com/apache/cordova-docs/pull/603#issuecomment-219526115
However, I don't see the privacy policy changes:
```www/privacy/index.md```:
https://github.com/apache/cordova-docs/commit/0d5f185c45f11a46e3dc5b720e23d4b38a40779a
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/147
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/167
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user omefire commented on the pull request:
https://github.com/apache/cordova-cli/pull/247#issuecomment-219530078
@purplecabbage , could you please file a JIRA issue for what you've
encountered ?
I just did the same for the issues I just mentioned:
https://issues.apache.org
This is pretty important, and the vulnerability has been out for a week now
but has just been released for Studio. (Upstream IntelliJ had it patched)
Everyone using Studio should update ASAP.
-- Forwarded message --
From: Android Studio Developer Support <
noreply-developer-andro
Github user cordova-qa commented on the pull request:
https://github.com/apache/cordova-plugin-battery-status/pull/34#issuecomment-219536326
Cordova CI Build has one or more failures.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-battery-status/pull/34/com
Github user cordova-qa commented on the pull request:
https://github.com/apache/cordova-plugin-battery-status/pull/31#issuecomment-219537703
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-battery-status/pull/31/c
Github user cordova-qa commented on the pull request:
https://github.com/apache/cordova-plugin-battery-status/pull/28#issuecomment-219539176
Cordova CI Build has one or more failures.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-battery-status/pull/28/com
Github user cordova-qa commented on the pull request:
https://github.com/apache/cordova-plugin-battery-status/pull/27#issuecomment-219539410
Cordova CI Build has one or more failures.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-battery-status/pull/27/com
Updated, thanks!
2016-05-16 22:09 GMT+02:00 Joe Bowser :
> This is pretty important, and the vulnerability has been out for a week now
> but has just been released for Studio. (Upstream IntelliJ had it patched)
> Everyone using Studio should update ASAP.
>
> -- Forwarded message ---
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-docs/pull/603#issuecomment-219547791
@omefire: This is just copying current dev to latest version on the docs
and hence you only see those changes. The privacy policy changes will take
effect when I
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/176#discussion_r63426276
--- Diff: bin/lib/create.js ---
@@ -46,15 +47,15 @@ module.exports.create = function (destinationDir,
config, options) {
var root = path.jo
GitHub user revolunet opened a pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/10
rm outdated info about allowsInlineMediaPlayback
has been fixed the 28/8/2015
You can merge this pull request into a Git repository by running:
$ git pull https://gith
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/603#issuecomment-219550624
LGTM! Checked to make sure all changes were to `.md` files in 6.x and that
seems to be the case.
---
If your project is set up for it, you can reply to this email
Github user omefire commented on the pull request:
https://github.com/apache/cordova-docs/pull/603#issuecomment-219551255
LGTM!
Changes to CLI reference are effectively in this PR.
I'm OK with not making any changes related to my earlier comments as those
were separate PRs.
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/176#discussion_r63428275
--- Diff: bin/lib/create.js ---
@@ -46,15 +47,15 @@ module.exports.create = function (destinationDir,
config, options) {
var root = path.joi
Other than this known defect which could be fixed in the next cordova-ios
and tools release, is there any reason that is keeping the project from
claiming support on Node v6?
This defect seems pretty simple to workaround, remove iOS, remove the
plugin and add iOS support again (ugly? yes, but worka
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-windows/pull/176#issuecomment-219552867
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
I believe there's another Node 6 bug affecting a wide number of CLI
apps (including Cordova), where logging buffers are not guaranteed to
be flushed on process.exit().
This means that sometimes output is truncated or overlaps in the
terminal after an error.
The upstream bug is https://github.com/n
Github user codecov-io commented on the pull request:
https://github.com/apache/cordova-windows/pull/176#issuecomment-219553941
## [Current coverage][cc-pull] is **72.88%**
> Merging [#176][cc-pull] into [master][cc-base-branch] will decrease
coverage by **0.52%**
```diff
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/176
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Bump
On May 13, 2016 8:21 AM, "Steven Gill" wrote:
> Please review and vote on this Tools Release
> by replying to this email (and keep discussion on the DISCUSS thread)
>
> Release issue: https://issues.apache.org/jira/browse/CB-11260
>
> Both tools have been published to
> dist/dev:https://dis
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/603
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/223
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/440#discussion_r63441699
--- Diff: cordova-lib/src/plugman/install.js ---
@@ -134,15 +134,15 @@ function checkEngines(engines) {
var engine = engines[i];
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-labs/pull/13#issuecomment-219579494
@daserge I haven't forgotten! The issue is that some changes were recently
made to the server configuration and the README appears to be out of date. I'm
trying to
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-labs/pull/13#issuecomment-219587750
@daserge issue is resolved and server should be updated! Let me know if it
isn't!
---
If your project is set up for it, you can reply to this email and have your
r
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-android/pull/305#issuecomment-219589249
Sorry @jasongin, I made a few more updates. Mind taking a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/58
CB-11277 Fix browser support
patched missing _ready method, and changed the way the proxy is installed
You can merge this pull request into a Git repository by running:
$
Github user cordova-qa commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/58#issuecomment-219593243
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-statusbar/pull/58/commits/b44
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-statusbar/pull/58
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if th
89 matches
Mail list logo