[GitHub] cordova-ios pull request: CB-11265: Remove Target checking for cor...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/224 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-console pull request: Dummy Entry

Github user sarangan12 closed the pull request at: https://github.com/apache/cordova-plugin-console/pull/18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-device pull request: Dummy Commit to test CI

Github user sarangan12 closed the pull request at: https://github.com/apache/cordova-plugin-device/pull/52 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-device-motion pull request: Dummy Commit to Test CI

Github user sarangan12 closed the pull request at: https://github.com/apache/cordova-plugin-device-motion/pull/44 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-plugin-vibration pull request: Dummy PR to test CI

Github user sarangan12 closed the pull request at: https://github.com/apache/cordova-plugin-vibration/pull/46 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-media-capture pull request: Dummy Commit to test CI

Github user sarangan12 closed the pull request at: https://github.com/apache/cordova-plugin-media-capture/pull/62 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-plugin-network-information pull request: Dummy commit to t...

Github user sarangan12 closed the pull request at: https://github.com/apache/cordova-plugin-network-information/pull/42 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cordova-plugin-device-orientation pull request: Dummy commit to te...

Github user sarangan12 closed the pull request at: https://github.com/apache/cordova-plugin-device-orientation/pull/28 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cordova-plugin-battery-status pull request: Dummy PR to test CI

Github user sarangan12 closed the pull request at: https://github.com/apache/cordova-plugin-battery-status/pull/36 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cordova-plugin-globalization pull request: Dummy PR to test CI

Github user sarangan12 closed the pull request at: https://github.com/apache/cordova-plugin-globalization/pull/48 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-plugin-statusbar pull request: Dummy PR to test CI

Github user sarangan12 closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/57 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-lib pull request: CB-11023 Add attribute through config-fi...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-lib/pull/432#issuecomment-220179183 @ktop I have a couple questions. First, do we have a plan for dealing with plugins that have conflicting attribute edits? For example, if plugin A has this in its

[GitHub] cordova-coho pull request: CB-11279 Support arbitrary repositories...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/122#discussion_r63761902 --- Diff: src/nightly.js --- @@ -60,36 +62,26 @@ module.exports = function*(argv) { } // Clone and update Repos -

[GitHub] cordova-coho pull request: CB-11279 Support arbitrary repositories...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/122#discussion_r63765329 --- Diff: src/nightly.js --- @@ -60,36 +62,26 @@ module.exports = function*(argv) { } // Clone and update Repos -yield

[GitHub] cordova-coho pull request: CB-11279 Support arbitrary repositories...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-coho/pull/122#issuecomment-220131313 One minor comment - LGTM otherwise --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-ios pull request: Removed the check for valid targets

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-ios/pull/224#issuecomment-220128782 LGTM. This code has been ported from bash script without any changes. I guess the purpose was to fail fast if user mispelled the simulator name. --- If

[GitHub] cordova-ios pull request: Removed the check for valid targets

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-ios/pull/224#issuecomment-220124198 + @vladimir-kotikov who originally added this code. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-coho pull request: CB-11279 Support arbitrary repositories...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/122#discussion_r63757350 --- Diff: src/nightly.js --- @@ -60,36 +62,26 @@ module.exports = function*(argv) { } // Clone and update Repos -yield

[GitHub] cordova-plugin-statusbar pull request: CB-10866: Adding engine inf...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/52 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-cli pull request: CB-11262 Add a warning about prerelease ...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/251 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-media pull request: CB-9741 Updated Android AudioPl...

Github user riknoll closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/72 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-cli pull request: CB-11262 Add a warning about prerelease ...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-cli/pull/251#issuecomment-220098758 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-plugin-media pull request: Add seekCompleteCallback to see...

Github user mattgrande commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/37#issuecomment-220071799 lol, love that CI runs 18 months after the fact. I no longer need this, so if someone wants to build a new PR using my code, please feel free. --- If

[GitHub] cordova-plugin-inappbrowser pull request: doc: do not use `with` i...

Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/167#issuecomment-220035333 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-inappbrowser pull request: doc: do not use `with` i...

GitHub user jakub-g opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/167 doc: do not use `with` in JS samples The usage of `with` JS statement is highly discouraged for a number of reasons, see

[GitHub] cordova-cli pull request: CB-11262 Add a warning about prerelease ...

Github user daserge commented on the pull request: https://github.com/apache/cordova-cli/pull/251#issuecomment-220024373 @vladimir-kotikov, addressed your comments, please take a look once more. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-lib pull request: CB-11261 Cut out '-nightly' prerelease t...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/440 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-file-transfer pull request: [Android] Handle redire...

Github user restouffer commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/126#issuecomment-220013558 I'm not familiar with Jenkins, but I'm not convinced those links suggest this patch is the cause of the CI failures. This patch is [Build

[GitHub] cordova-plugin-device-orientation pull request: add Android suppor...

Github user kimras commented on the pull request: https://github.com/apache/cordova-plugin-device-orientation/pull/19#issuecomment-220008722 Sorry for my ignorance. but these links do not take me anywhere. I am very interested in this and would like to offer my testing help if

[GitHub] cordova-coho pull request: CB-7904 Update version format to includ...

GitHub user daserge opened a pull request: https://github.com/apache/cordova-coho/pull/123 CB-7904 Update version format to include SHA and use UTC date Updating as per [discussion](https://github.com/cordova/cordova-discuss/pull/47#discussion_r63589276). Not including

[GitHub] cordova-lib pull request: Fixed issues with travis failing for nod...

GitHub user stevengill opened a pull request: https://github.com/apache/cordova-lib/pull/442 Fixed issues with travis failing for node 6 You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-lib master

[GitHub] cordova-coho pull request: CB-11279 Support arbitrary repositories...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/122#discussion_r63683653 --- Diff: src/nightly.js --- @@ -60,36 +62,26 @@ module.exports = function*(argv) { } // Clone and update Repos -

Buildbot: buildslave cordova-windows-slave was lost

The Buildbot working for '' has noticed that the buildslave named cordova-windows-slave went away It last disconnected at Wed May 18 09:28:28 2016 (buildmaster-local time) The admin on record (as reported by BUILDSLAVE:info/admin) was 'Richard Knoll '. Sincerely, The

[GitHub] cordova-plugin-camera pull request: CB-11183 Appium tests: Added i...

Github user alsorokin closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/209 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-camera pull request: CB-11183 Appium tests: Added i...

Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/209#issuecomment-219966472 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-contacts pull request: Label for custum type phone ...

Github user tobiasmuecksch commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/102#issuecomment-219948361 WIll someone finally merge this please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-plugin-file-transfer pull request: Fix exception thrown by...

Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/124#issuecomment-219935712 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-file-transfer pull request: [Android] Handle redire...

Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/126#issuecomment-219934546 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-file-transfer pull request: Allow to pass an ArrayB...

Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/128#issuecomment-21990 Cordova CI Build has one or more failures. **Commit** -