[GitHub] cordova-plugin-media pull request: Make moveFile() always copy ins...

2016-05-19 Thread piyushkhare11
Github user piyushkhare11 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/96#issuecomment-220246977 I am using the plugin(cordova-plugin-media), use case is application will keep running always and at regular intervals it will play some audio. The a

[DISCUSS] Cordova-Ubuntu Release 4.3.4

2016-05-19 Thread David Barth
Hey, Just a quick note to say I'm going to do another minor release of cordova-ubuntu to fix some bugs. It will still be on the 4.3.x line, ie a bit outdated, but to keep a safe fallback while we get 6.x ready for developers to use. I will use https://issues.apache.org/jira/browse/CB-11294

[GitHub] cordova-lib pull request: CB-11023 Add attribute through config-fi...

2016-05-19 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/432#issuecomment-220254686 I think there is no mechanism for resolving conflicts, as there was no need for it before. One idea on how to deal w/ conflicts is to fail by defau

[GitHub] cordova-coho pull request: CB-11279 Support arbitrary repositories...

2016-05-19 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/122#discussion_r63838519 --- Diff: src/nightly.js --- @@ -60,36 +62,26 @@ module.exports = function*(argv) { } // Clone and update Repos -

[GitHub] cordova-coho pull request: CB-11279 Support arbitrary repositories...

2016-05-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/122 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-coho pull request: CB-7904 Update version format to includ...

2016-05-19 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-coho/pull/123#issuecomment-220262368 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] cordova-coho pull request: CB-7904 Update version format to includ...

2016-05-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/123 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-coho pull request: CB-11280 Pin nightly platforms versions

2016-05-19 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-coho/pull/124 CB-11280 Pin nightly platforms versions This PR updates `coho nightly` command to pin platforms to their nightly versions in `cordova-lib/platfomsConfig.json` in order to use these ni

[GitHub] cordova-android pull request: CB-10710 Respect plugman's www optio...

2016-05-19 Thread vladimir-kotikov
Github user vladimir-kotikov closed the pull request at: https://github.com/apache/cordova-android/pull/267 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-media-capture pull request: CB-9611 Fixes fullpath ...

2016-05-19 Thread vladimir-kotikov
Github user vladimir-kotikov closed the pull request at: https://github.com/apache/cordova-plugin-media-capture/pull/43 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishe

[GitHub] cordova-plugin-contacts pull request: CB-9348 Fetch phoneNumbers a...

2016-05-19 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/88#issuecomment-220301006 @shazron, unfortunately it doesn't seem to be possible to add automated tests for this feature. Testing this requires linked contact to be creat

[GitHub] cordova-plugin-splashscreen pull request: CB-10255 Add options to ...

2016-05-19 Thread thom7kick
Github user thom7kick commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-220321857 can u Add options to change colors of the splashscreen navigation and status bars on Android --- If your project is set up for it, you can reply

[GitHub] cordova-plugin-camera pull request: CB-11296 (Appium) Better eleme...

2016-05-19 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/217 CB-11296 (Appium) Better element clicking and session error handling ### Platforms affected Android, iOS ### What does this PR do? https://issues.apache.or

[GitHub] cordova-plugin-camera pull request: CB-11296 (Appium) Better eleme...

2016-05-19 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/217#issuecomment-220352102 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-camera/pull/217/commits/f5661e0

[GitHub] cordova-plugin-camera pull request: CB-11296 (Appium) Better eleme...

2016-05-19 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/217#issuecomment-220353502 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-camera/pull/217/commits/e0ba49b

[GitHub] cordova-plugin-contacts pull request: CB-11296: Appium: Better ele...

2016-05-19 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/126 CB-11296: Appium: Better element clicking and session error handling ### Platforms affected Android, iOS ### What does this PR do? https://issues.apache.

[GitHub] cordova-plugin-contacts pull request: CB-11296: Appium: Better ele...

2016-05-19 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/126#issuecomment-220356372 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-contacts/pull/126/commits/f76

[GitHub] cordova-plugin-camera pull request: CB-11296 (Appium) Better eleme...

2016-05-19 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/217#issuecomment-220357459 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-camera/pull/217/commits/d6fe353

[GitHub] cordova-plugin-camera pull request: CB-11296 (Appium) Better eleme...

2016-05-19 Thread alsorokin
Github user alsorokin closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/217 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if t

[GitHub] cordova-plugin-contacts pull request: CB-11296: Appium: Better ele...

2016-05-19 Thread alsorokin
Github user alsorokin closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/126 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-lib pull request: CB-11023 Add attribute through config-fi...

2016-05-19 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-lib/pull/432#issuecomment-220386776 @vladimir-kotikov yep, my thought's exactly! We definitely need to handle plugins conflicting with each other because any bugs caused by those conflicts would likel

[GitHub] cordova-lib pull request: CB-11023 Add attribute through config-fi...

2016-05-19 Thread ktop
Github user ktop commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/432#discussion_r63922339 --- Diff: cordova-lib/src/cordova/prepare.js --- @@ -116,6 +117,13 @@ function preparePlatforms (platformList, projectRoot, options) {

[GitHub] cordova-lib pull request: CB-11023 Add attribute through config-fi...

2016-05-19 Thread ktop
Github user ktop commented on the pull request: https://github.com/apache/cordova-lib/pull/432#issuecomment-220440531 @riknoll Vladimir is correct, there is no mechanism for either yet. I think warnings are good, but does that mean the plugins that get installed first get fir

[GitHub] cordova-lib pull request: CB-11023 Add attribute through config-fi...

2016-05-19 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-lib/pull/432#issuecomment-220467601 I think that the issue might be that we need to separate inserting child elements and editing existing ones. Something like this: ```xml

[GitHub] cordova-plugin-media pull request: Make moveFile() always copy ins...

2016-05-19 Thread ghenry22
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/96#issuecomment-220506090 @piyushkhare11 - this is not the right place for your question, I suggest that you log a ticket on the cordova jira or ask in the cordova slack channel.