[GitHub] cordova-plugin-dialogs issue #71: Secure prompt text fields for passwords

2016-06-16 Thread WillAnd31
Github user WillAnd31 commented on the issue: https://github.com/apache/cordova-plugin-dialogs/pull/71 I definitely agree, and that's the ideal way of doing it, and it could even support having the default text be the placeholder in the secure input prompt. I implemented it this way s

[GitHub] cordova-plugin-dialogs issue #71: Secure prompt text fields for passwords

2016-06-16 Thread purplecabbage
Github user purplecabbage commented on the issue: https://github.com/apache/cordova-plugin-dialogs/pull/71 Interesting, and useful. However, you cannot simply shoehorn your api into another value. I suggest you add your new boolean to the end of the args: navigator.notificatio

[GitHub] cordova-plugin-dialogs issue #78: Master

2016-06-16 Thread purplecabbage
Github user purplecabbage commented on the issue: https://github.com/apache/cordova-plugin-dialogs/pull/78 Why would you do this? Please close it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

Re: [DISCUSS] Cordova-windows release

2016-06-16 Thread Jesse
Sorry Vlad. I was away. @purplecabbage risingj.com On Fri, Jun 3, 2016 at 7:33 AM, Vladimir Kotikov (Akvelon) < v-vlk...@microsoft.com> wrote: > The release is done. Please review the blog post here: > https://github.com/apache/cordova-docs/pull/609 > > - > Best regards, Vladimir > > -Origi

Nightly build #43 for cordova has succeeded!

2016-06-16 Thread Apache Jenkins Server
Nightly build #43 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/43/consoleFull - Jenkins for Apache Cordova ---

Re: Proof of Concept: Plugins as Android Modules

2016-06-16 Thread julio cesar sanchez
Hi. I sadly can't contribute to this because I don't think I have enough Android knowledge, but just wanted to answer on this topic as I feel that is very important and I think this one and the previous ones you sent related to this didn't get enough attention. So, even if I can't personally help,

[GitHub] cordova-lib issue #453: Support a display name via config.xml

2016-06-16 Thread macdonst
Github user macdonst commented on the issue: https://github.com/apache/cordova-lib/pull/453 @dpogue yeah, I agree that it is a common use case. One reason I bring it up is you may be able to re-use some code that @ktop is landing into cordova-common. Also, I mis-spoke as Karen's chang

[GitHub] cordova-lib issue #453: Support a display name via config.xml

2016-06-16 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-lib/pull/453 @macdonst I would agree if this were platform-specific, or outside the scope of the W3C Widgets spec, but this is a fairly common request in JIRA and the spec supports it reasonably gracefully. I

[GitHub] cordova-lib issue #449: CB-11023 Add edit-config functionality

2016-06-16 Thread ktop
Github user ktop commented on the issue: https://github.com/apache/cordova-lib/pull/449 Cool, let me rebase --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-lib issue #453: Support a display name via config.xml

2016-06-16 Thread macdonst
Github user macdonst commented on the issue: https://github.com/apache/cordova-lib/pull/453 @dpogue take a look at this PR https://github.com/apache/cordova-lib/pull/449. It should allow for the editing of anything in AndroidManifest.xml. Currently it works for plugin.xml but the pla

[GitHub] cordova-lib issue #449: CB-11023 Add edit-config functionality

2016-06-16 Thread macdonst
Github user macdonst commented on the issue: https://github.com/apache/cordova-lib/pull/449 LGTM! Sorry for taking so long. My workspace is in a bad way and I think I need to kill it with fire and setup the whole thing from scratch. Once this gets into a release I have about 4

[GitHub] cordova-windows pull request #178: CB-11443 Splashscreen is created the seco...

2016-06-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/178 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-windows issue #178: CB-11443 Splashscreen is created the second time...

2016-06-16 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-windows/pull/178 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so