Nightly build #55 for cordova has succeeded!

2016-06-28 Thread Apache Jenkins Server
Nightly build #55 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/55/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-cli pull request #257: CB-11412 removed link-to, aliased copy-from t...

2016-06-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/257 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #458: CB-11412 template support for www folders

2016-06-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/458 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-media issue #95: CB-11148 - BB10 Media getDuration does not w...

2016-06-28 Thread dpeacock
Github user dpeacock commented on the issue: https://github.com/apache/cordova-plugin-media/pull/95 The test that failed is an iOS test... this commit is only for 'src/blackberry10/index.js' not sure how the two could be related... thoughts? --- If your project is set up for it, you

[GitHub] cordova-plugin-media issue #94: CB-11146 - getDuration only available after ...

2016-06-28 Thread emirdeliz
Github user emirdeliz commented on the issue: https://github.com/apache/cordova-plugin-media/pull/94 Some resolution for this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-plugin-media issue #95: CB-11148 - BB10 Media getDuration does not w...

2016-06-28 Thread emirdeliz
Github user emirdeliz commented on the issue: https://github.com/apache/cordova-plugin-media/pull/95 Some resolution for this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-android pull request #313: Support project template with aar for bui...

2016-06-28 Thread HenryPing
Github user HenryPing closed the pull request at: https://github.com/apache/cordova-android/pull/313 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-android pull request #313: Support project template with aar for bui...

2016-06-28 Thread HenryPing
GitHub user HenryPing opened a pull request: https://github.com/apache/cordova-android/pull/313 Support project template with aar for building app with custom plugins You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-plugin-wkwebview-engine issue #7: Fixes CB-11074: WKWebView configur...

2016-06-28 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/7 I'm creating failing unit tests for this first, I think we have passed the point where we can argue about the implementation, but we need objective verification:

[GitHub] cordova-android pull request #178: Grant Lollipop permission requests

2016-06-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/178 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-wkwebview-engine issue #8: CB-11074: Ensure settings from con...

2016-06-28 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/8 I'm creating failing unit tests for this first, I think we have passed the point where we can argue about the implementation, but we need objective verification:

[GitHub] cordova-android issue #178: Grant Lollipop permission requests

2016-06-28 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/178 BTW: I'm going to close this and recommend that the approach dpogue is mentioning be taken. We can't guarantee behaviour across multiple webviews. --- If your project is set up for it,

[GitHub] cordova-plugin-inappbrowser issue #116: Added support for file:/// access

2016-06-28 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/116 Thanks for this PR. There's 3 issues with this PR: 1. It doesn't merge cleanly anymore - the commits should be rebased 2. An issue should be created for this in

[GitHub] cordova-plugin-inappbrowser issue #116: Added support for file:/// access

2016-06-28 Thread mani95lisa
Github user mani95lisa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/116 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

Re: Why doesn't `cordova.requestPermission` have an `callbackContext` arg?

2016-06-28 Thread Philipp Kursawe
I see. Cordova already uses a `permissionResultCallbacks` that holds the user provided `requestCode`. It could additionally hold the `callbackContext`. And when android calls `CordovaInterfaceImpl.onRequestPermissionResult` it could call a new plugin function with a new signature that contains the

Re: Why doesn't `cordova.requestPermission` have an `callbackContext` arg?

2016-06-28 Thread julio cesar sanchez
onRequestPermissionResult is an Android method we have to override, so we can't choose which params to pass. https://developer.android.com/reference/android/support/v4/app/ActivityCompat.OnRequestPermissionsResultCallback.html 2016-06-28 10:29 GMT+02:00 Philipp Kursawe :

Why doesn't `cordova.requestPermission` have an `callbackContext` arg?

2016-06-28 Thread Philipp Kursawe
I wonder about this API design decision. The current API forces us to save the callback context in some state variable to have access to it in the plugins `onRequestPermissionResult` like this: private void requestPermissionAction(CallbackContext callbackContext, JSONArray permission) {