GitHub user philbenoit opened a pull request:
https://github.com/apache/cordova-plugin-contacts/pull/130
CB-11532: (ios) Fix bug with bad characters in contact name
### Platforms affected
iOS
### What does this PR do?
Fixes https://issues.apache.org/jira/br
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/460#discussion_r69436760
--- Diff: cordova-lib/spec-cordova/run.spec.js ---
@@ -79,7 +82,7 @@ describe('run command', function() {
it('should pass down param
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/460#discussion_r69436735
--- Diff: cordova-lib/spec-cordova/emulate.spec.js ---
@@ -82,7 +85,7 @@ describe('emulate command', function() {
cordova.raw.em
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-lib/pull/460
Some minor comments, LGTM otherwise
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
GitHub user dankito opened a pull request:
https://github.com/apache/cordova-plugin-network-information/pull/44
Detection of Ethernet Network Type on Android
On an Android device with Ethernet interface we have to support
NetworkInfo's typeName equals 'eth', therefore NetworkManager
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-network-information/pull/44
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/11#discussion_r69461594
--- Diff: lib/paramedic.js ---
@@ -190,48 +192,160 @@ ParamedicRunner.prototype.writeMedicConnectionUrl =
function(url) {
fs.write
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/11#discussion_r69461580
--- Diff: lib/paramedic.js ---
@@ -94,8 +96,8 @@ ParamedicRunner.prototype.run = function () {
self.killEmulatorProcess();
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/11#discussion_r69461701
--- Diff: lib/paramedic.js ---
@@ -190,48 +192,160 @@ ParamedicRunner.prototype.writeMedicConnectionUrl =
function(url) {
fs.write
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/11#discussion_r69461790
--- Diff: lib/paramedic.js ---
@@ -190,48 +192,160 @@ ParamedicRunner.prototype.writeMedicConnectionUrl =
function(url) {
fs.write
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/11#discussion_r69461819
--- Diff: lib/paramedic.js ---
@@ -190,48 +192,160 @@ ParamedicRunner.prototype.writeMedicConnectionUrl =
function(url) {
fs.write
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/11#discussion_r69461861
--- Diff: lib/paramedic.js ---
@@ -190,48 +192,160 @@ ParamedicRunner.prototype.writeMedicConnectionUrl =
function(url) {
fs.write
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/11#discussion_r69461844
--- Diff: lib/paramedic.js ---
@@ -190,48 +192,160 @@ ParamedicRunner.prototype.writeMedicConnectionUrl =
function(url) {
fs.write
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/11#discussion_r69461950
--- Diff: lib/paramedic.js ---
@@ -190,48 +192,160 @@ ParamedicRunner.prototype.writeMedicConnectionUrl =
function(url) {
fs.write
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/11#discussion_r69462066
--- Diff: lib/appium/AppiumRunner.js ---
@@ -0,0 +1,483 @@
+#!/usr/bin/env node
+
+/*
+ * Licensed to the Apache Software Fo
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/11#discussion_r69462115
--- Diff: lib/appium/AppiumRunner.js ---
@@ -0,0 +1,483 @@
+#!/usr/bin/env node
+
+/*
+ * Licensed to the Apache Software Fo
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/11#discussion_r69462091
--- Diff: lib/appium/AppiumRunner.js ---
@@ -0,0 +1,483 @@
+#!/usr/bin/env node
+
+/*
+ * Licensed to the Apache Software Fo
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/11#discussion_r69462157
--- Diff: lib/appium/AppiumRunner.js ---
@@ -0,0 +1,483 @@
+#!/usr/bin/env node
+
+/*
+ * Licensed to the Apache Software Fo
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/11#discussion_r69462195
--- Diff: lib/appium/AppiumRunner.js ---
@@ -0,0 +1,483 @@
+#!/usr/bin/env node
+
+/*
+ * Licensed to the Apache Software Fo
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/11#discussion_r69462247
--- Diff: lib/appium/AppiumRunner.js ---
@@ -0,0 +1,483 @@
+#!/usr/bin/env node
+
+/*
+ * Licensed to the Apache Software Fo
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/11#discussion_r69462316
--- Diff: lib/appium/AppiumRunner.js ---
@@ -0,0 +1,483 @@
+#!/usr/bin/env node
+
+/*
+ * Licensed to the Apache Software Fo
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/11#discussion_r69462391
--- Diff: lib/appium/helpers/util.js ---
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/11#discussion_r69462408
--- Diff: lib/utils/utilities.js ---
@@ -136,6 +136,9 @@ module.exports = {
PARAMEDIC_DEFAULT_APP_NAME: 'io.cordova.hellocordova',
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/11#discussion_r69462322
--- Diff: lib/appium/AppiumRunner.js ---
@@ -0,0 +1,483 @@
+#!/usr/bin/env node
+
+/*
+ * Licensed to the Apache Software Fo
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/11#discussion_r69462368
--- Diff: lib/appium/AppiumRunner.js ---
@@ -0,0 +1,483 @@
+#!/usr/bin/env node
+
+/*
+ * Licensed to the Apache Software Fo
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-windows/pull/179
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/179
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Hello guys,
I wanted to draw your attention to the PR introducing new before_deploy hook
[1].
Implementation divides run/emulate command into 2: build + run(nobuild) and
fires the hook event in between.
I would appreciate your feedback.
[1]: https://github.com/apache/cordova-lib/pull/460
Plea
GitHub user homen opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/150
CB-11534 This plugin should support Android Marshmallow runtime permission
### Platforms affected
Android
### What does this PR do?
It will support Andr
GitHub user jcesarmobile opened a pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/60
CB-11485: (ios) fix resize on rotation with popover
This PR fix the webview resize problem when a popover is present
### Platforms affected
iOS
### What do
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-statusbar/pull/60
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if th
Github user daserge commented on the issue:
https://github.com/apache/cordova-windows/pull/173
@rakatyal, @afourney, do you happen to have some examples with details
disappearing?
I tried and it did not reproduce for me on Windows Phone 8.1 project
running on Windows 10 Mobile.
Github user daserge commented on the issue:
https://github.com/apache/cordova-windows/pull/173
@rakatyal, you also noted that it was happening for some other activation
kinds - could you please share which ones I should also test?
What do you think on a solution to have the raw arg
GitHub user jcesarmobile opened a pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/61
CB-11287: (ios) - fix webview resize after modal on iPhones
### Platforms affected
iOS
### What does this PR do?
Fixes CB-11287
### What testing h
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-statusbar/pull/61
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if th
Nightly build #61 for cordova has succeeded!
The latest nightly has been published and you can try it out with 'npm i -g
cordova@nightly'
For details check build console at
https://builds.apache.org/job/cordova-nightly/61/consoleFull
-
Jenkins for Apache Cordova
---
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/234#discussion_r69504477
--- Diff: bin/templates/scripts/cordova/Api.js ---
@@ -217,6 +214,90 @@ Api.prototype.addPlugin = function (plugin,
installOptions) {
retu
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/234#discussion_r69504527
--- Diff: bin/templates/scripts/cordova/Api.js ---
@@ -217,6 +214,90 @@ Api.prototype.addPlugin = function (plugin,
installOptions) {
retu
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/234#discussion_r69504555
--- Diff: bin/templates/scripts/cordova/Api.js ---
@@ -217,6 +214,90 @@ Api.prototype.addPlugin = function (plugin,
installOptions) {
retu
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/234#discussion_r69504623
--- Diff: bin/templates/scripts/cordova/Api.js ---
@@ -236,10 +317,50 @@ Api.prototype.addPlugin = function (plugin,
installOptions) {
* CordovaE
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/234#discussion_r69504742
--- Diff: bin/templates/scripts/cordova/lib/plugman/pluginHandlers.js ---
@@ -66,17 +66,19 @@ var handlers = {
install:function(obj, plugin,
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/234#discussion_r69504824
--- Diff: bin/templates/scripts/cordova/lib/plugman/pluginHandlers.js ---
@@ -91,18 +93,29 @@ var handlers = {
}
},
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/234#discussion_r69504867
--- Diff: bin/templates/scripts/cordova/lib/podMod.js ---
@@ -0,0 +1,162 @@
+var fs = require('fs');
+var util = require('util');
+var events
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/234#discussion_r69504887
--- Diff: bin/templates/scripts/cordova/lib/podMod.js ---
@@ -0,0 +1,162 @@
+var fs = require('fs');
+var util = require('util');
+var events
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/234#discussion_r69505064
--- Diff: bin/templates/scripts/cordova/lib/podMod.js ---
@@ -0,0 +1,162 @@
+var fs = require('fs');
+var util = require('util');
+var events
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/234#discussion_r69505374
--- Diff: bin/templates/scripts/cordova/lib/plugman/pluginHandlers.js ---
@@ -91,18 +93,29 @@ var handlers = {
}
},
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/234#discussion_r69505429
--- Diff: bin/templates/scripts/cordova/Api.js ---
@@ -236,10 +317,50 @@ Api.prototype.addPlugin = function (plugin,
installOptions) {
* CordovaE
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/234#discussion_r69505602
--- Diff: bin/templates/scripts/cordova/lib/podMod.js ---
@@ -0,0 +1,162 @@
+var fs = require('fs');
+var util = require('util');
+var events
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/234
No tests for this feature were available. Tests will need to be added
before this can land.
The existing tests pass now.
---
If your project is set up for it, you can reply to this email an
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/234#discussion_r69511105
--- Diff: bin/templates/scripts/cordova/lib/plugman/pluginHandlers.js ---
@@ -91,18 +93,29 @@ var handlers = {
}
},
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-lib/pull/460
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
51 matches
Mail list logo
