Github user jcesarmobile commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/170
Thanks. I forgot one thing, before we can merge it though, you need to sign
Apache's Contributor License Agreement (can be done online):
http://www.apache.org/licenses/#clas
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/170
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/170/commits/e98085c17d02f252273fada13f2
Github user DrMoriarty commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/170
@jcesarmobile done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Nightly build #76 for cordova has succeeded!
The latest nightly has been published and you can try it out with 'npm i -g
cordova@nightly'
For details check build console at
https://builds.apache.org/job/cordova-nightly/76/consoleFull
-
Jenkins for Apache Cordova
---
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/109
@daserge, could you please review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user jcesarmobile commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/170#discussion_r71408945
--- Diff: src/android/InAppBrowser.java ---
@@ -579,11 +579,13 @@ public void run() {
Resources activityRes =
Github user scyclops commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/170#discussion_r71406416
--- Diff: src/android/InAppBrowser.java ---
@@ -579,11 +579,13 @@ public void run() {
Resources activityRes =
cord
Github user jcesarmobile commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/167
Thanks for the PR. It looks good.
Can you create an issue on issues.apache.org/jira/browse/CB and use the ID
as title on the PR?
Thanks
---
If your project is
Github user jcesarmobile commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/170
Thanks for the PR, looks good, but I've added a few comments.
Can you add the modifications and change the title to start with CB-11578
so it's linked with the JIRA issu
Github user jcesarmobile commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/170#discussion_r71403914
--- Diff: src/android/InAppBrowser.java ---
@@ -644,11 +648,13 @@ public boolean onKey(View v, int keyCode, KeyEvent
event) {
Github user jcesarmobile commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/170#discussion_r71403773
--- Diff: src/android/InAppBrowser.java ---
@@ -579,11 +579,13 @@ public void run() {
Resources activityRes =
Github user jcesarmobile commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/170#discussion_r71403717
--- Diff: src/android/InAppBrowser.java ---
@@ -600,11 +602,13 @@ public void onClick(View v) {
forward.setId(I
Github user jcesarmobile commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/170#discussion_r71403520
--- Diff: src/android/InAppBrowser.java ---
@@ -579,11 +579,13 @@ public void run() {
Resources activityRes =
Github user bhariharan commented on the issue:
https://github.com/apache/cordova-ios/pull/236
Thanks @dpogue! I'll close this then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user bhariharan closed the pull request at:
https://github.com/apache/cordova-ios/pull/236
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/109
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-splashscreen/pull/109/commits/a0836cbccf5842510c3e433c03b
GitHub user nbabanov opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/109
CB-11602: (android) Fix bug AutoHideSplashScreen false - not working
### Platforms affected
Android
### What does this PR do?
Fixes https://issues.apache.org/ji
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-windows/pull/187
## [Current coverage][cc-pull] is **72.57%**
> Merging [#187][cc-pull] into [master][cc-base-branch] will decrease
coverage by **0.08%**
```diff
@@ master
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-windows/pull/187
CB-11241 Return adding BOM to www back to prepare
This PR reverts changes, made in #134
The reason of reverting is that original change causes the problems with
submitting
19 matches
Mail list logo
