[DOCS] Contribution ideas

2016-08-17 Thread Shazron
I kinda like how the WebKit nightly looks: https://webkit.org/nightly/start/trunk/204581/ Some good ideas there for our contrib docs, which currently look like this: http://cordova.apache.org/contribute/ Screenshot: ​ webkit-nightly-contrib.png

[GitHub] cordova-ios issue #241: CB-11705 - Adding CordovaDefaultWebViewEngine config...

2016-08-17 Thread hnilsen
Github user hnilsen commented on the issue: https://github.com/apache/cordova-ios/pull/241 Yes, the current situation is that I can supply a plugin for my own WKWebView, but not for the UIWebView, which is a private plugin. I'd like to be able to control them both. My PR is a

[GitHub] cordova-plugin-media-capture issue #67: add orientation support

2016-08-17 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media-capture/pull/67 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-media-capture/pull/67/commits/568ff4456e1c33366bec6ef3fe5

[GitHub] cordova-plugin-media-capture pull request #67: add orientation support

2016-08-17 Thread SandLZ
Github user SandLZ closed the pull request at: https://github.com/apache/cordova-plugin-media-capture/pull/67 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

Nightly build #104 for cordova has succeeded!

2016-08-17 Thread Apache Jenkins Server
Nightly build #104 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/104/consoleFull - Jenkins for Apache Cordova -

[GitHub] cordova-plugin-media-capture pull request #67: add orientation support

2016-08-17 Thread SandLZ
GitHub user SandLZ opened a pull request: https://github.com/apache/cordova-plugin-media-capture/pull/67 add orientation support You can merge this pull request into a Git repository by running: $ git pull https://github.com/SandLZ/cordova-plugin-media-capture master Alternat

[GitHub] cordova-ios issue #241: CB-11705 - Adding CordovaDefaultWebViewEngine config...

2016-08-17 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/241 I get what you are saying now, you want the "fallback" webview-engine to be your plugin. I'll review this PR soon with that in mind. --- If your project is set up for it, you can reply to this

[GitHub] cordova-coho pull request #130: CB-11646 version arg optional, will grab fro...

2016-08-17 Thread shazron
Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/130#discussion_r75238878 --- Diff: src/platform-release.js --- @@ -131,6 +140,7 @@ exports.prepareReleaseBranchCommand = function*() { var repos = flagutil.computeReposF

[GitHub] cordova-coho pull request #129: CB-11642 Update CDVAvailability.h

2016-08-17 Thread shazron
Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/129#discussion_r75238702 --- Diff: src/platform-release.js --- @@ -162,6 +164,30 @@ exports.prepareReleaseBranchCommand = function*() { yield versionutil.updateR

Re: Carlos MIA

2016-08-17 Thread Shazron
Hey Carlos, Appreciate your contributions to the community! Sorry to see you going away... I'm sure you'll be back, a commit here and there, a PMC vote maybe. However, when you're in Cordova, you are in for life, sorry! :P (the commit bit will always be there, I don't think we have ever removed an

Carlos MIA

2016-08-17 Thread Carlos Santana
Man this sucks but I have to admit that I have being missing in action and have to realize I can't dedicate the time I would like to Apache Cordova. This burns me because Cordova have become a second family to me :-( I recently got re-assigned out from IBM MobileFirst (aka Worklight) in to IBM Bl

[COHO] check-license helper

2016-08-17 Thread Shazron
Right now when you run `coho check-license` you might get a list of potentially incompatible packages (make sure you run it on a repo with just bundled dependencies, not dev dependencies -- we don't need to check the license on devDeps). Previously you would have to manually verify the license on

[GitHub] cordova-coho pull request #132: CB-11718 - check-license -- create a knownIs...

2016-08-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/132 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-coho pull request #132: CB-11718 - check-license -- create a knownIs...

2016-08-17 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-coho/pull/132 CB-11718 - check-license -- create a knownIssues.json for packages that have licenses that have been manually verified Helper when you get a report for packages with unknown licenses, that you

[GitHub] cordova-plugin-splashscreen issue #111: fixing problem when trying to remove...

2016-08-17 Thread metrologma
Github user metrologma commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/111 I have this problem, too --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] cordova-docs pull request #627: Add docs for defaultlocale to config.xml

2016-08-17 Thread dpogue
GitHub user dpogue opened a pull request: https://github.com/apache/cordova-docs/pull/627 Add docs for defaultlocale to config.xml This allows customizing the default language of the application on iOS. Ref CB-9789 See also https://github.com/apache/cordova-ios/pull/237

[GitHub] cordova-ios issue #237: CB-9789: Support setting the default app locale

2016-08-17 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/237 @dpogue Please send a PR for a docs update as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-ios pull request #237: CB-9789: Support setting the default app loca...

2016-08-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/237 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-coho pull request #131: CB-11717 - Include Unlicense as a valid lice...

2016-08-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/131 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-coho pull request #128: CB-11484 Fix library vulnerability in nlf

2016-08-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/128 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-coho pull request #131: CB-11717 - Include Unlicense as a valid lice...

2016-08-17 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-coho/pull/131 CB-11717 - Include Unlicense as a valid license in validLicenses.json Rationale: https://issues.apache.org/jira/browse/CB-11717 You can merge this pull request into a Git repository by running

[GitHub] cordova-docs pull request #626: Added AppStudio to the Cordova Tools listing

2016-08-17 Thread artlogic
GitHub user artlogic opened a pull request: https://github.com/apache/cordova-docs/pull/626 Added AppStudio to the Cordova Tools listing Request to add info about AppStudio to the Cordova Tools section of the Cordova home page. You can merge this pull request into a Git repository

[GitHub] cordova-ios issue #237: CB-9789: Support setting the default app locale

2016-08-17 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/237 @shazron Thanks, I've rebased on master and updated the tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

Re: [VOTE] cordova-ios@4.2.1 release (attempt 2)

2016-08-17 Thread Shazron
I vote +1 - verified archives using coho verify-archive - ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses, manually verified licenses when applicable - ran coho audit-license-headers over the relevant repos - ran npm test, all green - created a

Introduction

2016-08-17 Thread Dao, Thomas
Hello! This is Thomas, I have been subscribed to the DL for a while and would like to see where I can help :) I have experience in release/build engineering and also devops and some Android development. Thomas

[GitHub] cordova-plugin-wkwebview-engine issue #15: Ionic changes to WKWebView (For C...

2016-08-17 Thread manucorporat
Github user manucorporat commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15 Hi @shazron sure thing! I take care of this :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

Re: [VOTE] cordova-android@5.2.2 release (Attempt 2)

2016-08-17 Thread Joe Bowser
I vote +1 * Ran coho audit-license-headers over the relevant repos * Ran Mobile Spec Auto Tests * Created Hello World application using tag * Created Hello World application using CLI On Wed, Aug 17, 2016 at 10:45 AM, Steven Gill wrote: > Please review and vote on this 5.2.2 Android Release > b

[VOTE] cordova-android@5.2.2 release (Attempt 2)

2016-08-17 Thread Steven Gill
Please review and vote on this 5.2.2 Android Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-11626 The archive has been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-11626 The package

[VOTE] cordova-ios@4.2.1 release (attempt 2)

2016-08-17 Thread Steven Gill
Please review and vote on this 4.2.1 iOS Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-11627 The archive has been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-11627 The package was

[GitHub] cordova-ios pull request #242: CB-11703 - travis ci setup is still using 0.1...

2016-08-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/242 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-plugin-inappbrowser issue #178: CB-10467 Hardware back button, while...

2016-08-17 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/178 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/178/commits/2776b14db6e949c87850d3874ad

[GitHub] cordova-plugin-file-transfer pull request #149: CB-11316 windows: Added cont...

2016-08-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/149 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-file-transfer issue #149: CB-11316 windows: Added content-typ...

2016-08-17 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/149 Hey. I'm sorry that it took us so long to accept your PR. Merging it now. --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] cordova-plugin-camera pull request #231: CB-11709 Tests should use resolveLo...

2016-08-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/231 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-camera issue #231: CB-11709 Tests should use resolveLocalFile...

2016-08-17 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/231 :ship: it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[GitHub] cordova-plugin-inappbrowser pull request #178: CB-10467 Hardware back button...

2016-08-17 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/178#discussion_r75116093 --- Diff: src/windows/InAppBrowserProxy.js --- @@ -176,6 +179,38 @@ var IAB = { browserWrap.appendChi

[GitHub] cordova-plugin-inappbrowser issue #178: CB-10467 Hardware back button, while...

2016-08-17 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/178 Two minor comments, otherwise LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] cordova-plugin-inappbrowser pull request #178: CB-10467 Hardware back button...

2016-08-17 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/178#discussion_r75115204 --- Diff: src/windows/InAppBrowserProxy.js --- @@ -176,6 +179,38 @@ var IAB = { browserWrap.appendChi

[GitHub] cordova-plugin-inappbrowser pull request #178: CB-10467 Hardware back button...

2016-08-17 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/178#discussion_r75115134 --- Diff: src/windows/InAppBrowserProxy.js --- @@ -176,6 +179,38 @@ var IAB = { browserWrap.appendChi

[GitHub] cordova-plugin-file issue #191: CB-11699 Read files as Data URLs properly

2016-08-17 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-plugin-file/pull/191 @daserge, @sgrebnov, please take a look /cc @jasongin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-lib issue #479: CB-11698 Fix plugin installation when restoring plat...

2016-08-17 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-lib/pull/479 > Honestly, this is just further convincing me that restore and prepare should be two separate commands. I tend to agree, but we can't change this as I believe this is a part o

[GitHub] cordova-ios issue #241: CB-11705 - Adding CordovaDefaultWebViewEngine config...

2016-08-17 Thread hnilsen
Github user hnilsen commented on the issue: https://github.com/apache/cordova-ios/pull/241 That doesn't swap out the private CDVUIWebViewEngine used by iOS8, does it? That's why I'm adding the option to extract and use my own version of CDVUIWebViewEngine. This is what I'm able to do